europe 0.0.20 → 0.0.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 55a8a248cfae6ade9980da4ea2e6b47938c5aa75c8936c8f010e35a50b6f2b86
-  data.tar.gz: 23920666bd00770ab722cfb8d6edc5e17b416f9d6d81c8ecb1ebfc9112d65338
+  metadata.gz: a1265263ae93ea1408b778a1bff21d44a913d54f10e034d2eb4f2536ed3e87ce
+  data.tar.gz: '079be0aeba6bf84a543b9df49e25d1571b3a8527b3770c176ae3014b3260d809'
 SHA512:
-  metadata.gz: cd703d1d1d8e534dc8ad46bb1051aa2cfe871e807215c0a417286bac7d23814bf7aba5d0f8f4bdb49fb88f1ed49992f5b6e24a30416c0f769f06d051970b9c78
-  data.tar.gz: ce9d7fd212fb5905a71598ab7545eb3ad80823a095e97af46101426c214ec592e3d4eacaf429bfaa21a7f2417072a5154c2e97a2b024f642d4fe9a346322f967
+  metadata.gz: fb51a61ff49138ce79b0e3919427967a62b79ece0f8285c3b2074cbb4cb2a960f02d611970991e43784dcb750e09d8708c822840b338cbd41cd3aa1c5df53666
+  data.tar.gz: 8c4eda6745c2a60a39e9c38dbb2770a23cf0597764bfab1e57deeac3c2bdbcbf5fe0659c0a96cf023176219808ccab0c91966d4e8454a1f0632f9c91eda61f02

data/.rubocop.yml

@@ -1,6 +1,6 @@
 AllCops:
   NewCops: enable
-  TargetRubyVersion: 3.1
+  TargetRubyVersion: 3.2
   SuggestExtensions: false
   Exclude:
     - 'europe.gemspec'

data/CHANGELOG.md

@@ -1,6 +1,9 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
+## 0.0.21
+  - Added check to fail short VAT numbers under 5 characters
+  - [Full Changelog](https://github.com/gem-shards/europe.rb/compare/v0.0.20...v0.0.21)
 ## 0.0.20
   - Added fallback VAT rates in case the EU website is down or unresponsive
   - [Full Changelog](https://github.com/gem-shards/europe.rb/compare/v0.0.19...v0.0.20)

data/lib/europe/vat/vat.rb

@@ -33,6 +33,8 @@ module Europe
     XML
 
     def self.validate(number)
+      return :failed if number.size < 4
+
       response = send_request(number[0..1], number[2..-1])
       return :failed unless response.is_a? Net::HTTPSuccess
       return :failed if response.body.include?('soap:Fault')

data/lib/europe/version.rb

@@ -2,5 +2,5 @@
 
 # Europe version
 module Europe
-  VERSION = '0.0.20'
+  VERSION = '0.0.21'
 end

data/test/europe/vat/format_test.rb

@@ -62,15 +62,15 @@ module Europe
       def check_character_and_digit(number)
         assert_equal true, Europe::Vat::Format.validate(
           number[0..1] +
-          number[2..-1].gsub(/X/, [*('A'..'Z'), *('0'..'9')].sample)
+          number[2..-1].gsub('X', [*('A'..'Z'), *('0'..'9')].sample)
         )
       end
 
       def check_integer(number)
         {
-          number[0..1] + number[2..-1].gsub(/9/, [*('0'..'9')].sample) => true,
-          number.gsub(/9/, rand(10).to_s) => true,
-          number.gsub(/9/, [*('A'..'Z')].sample(1).join) => false
+          number[0..1] + number[2..-1].gsub('9', [*('0'..'9')].sample) => true,
+          number.gsub('9', rand(10).to_s) => true,
+          number.gsub('9', [*('A'..'Z')].sample(1).join) => false
         }.each do |key, value|
           assert_equal value, Europe::Vat::Format.validate(key)
         end
@@ -78,10 +78,10 @@ module Europe
 
       def check_alphanumeric(number)
         assert_equal true, Europe::Vat::Format.validate(
-          number[0..1] + number[2..-1].gsub(/L/, [*('A'..'Z')].sample)
+          number[0..1] + number[2..-1].gsub('L', [*('A'..'Z')].sample)
         )
         assert_equal false, Europe::Vat::Format.validate(
-          number[0..1] + number[2..-1].gsub(/L/, [*('0'..'9')].sample)
+          number[0..1] + number[2..-1].gsub('L', [*('0'..'9')].sample)
         )
       end
 

data/test/europe/vat/validation_test.rb

@@ -12,6 +12,10 @@ module Europe
         WebMock.disable!
       end
 
+      def test_validation_of_short_vat_number
+        assert_equal :failed, Europe::Vat.validate('6')
+      end
+
       def test_validation_of_false_vat_number
         validate_false_vat = Europe::Vat.validate('NL123456789B01')
         assert_equal false, validate_false_vat[:valid]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: europe
 version: !ruby/object:Gem::Version
-  version: 0.0.20
+  version: 0.0.21
 platform: ruby
 authors:
 - Gem shards
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-03 00:00:00.000000000 Z
+date: 2024-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug