estore 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 78dbb09be7de8d003f5e6c5241a96df71b47c2db
-  data.tar.gz: 2e5cc0c9440c44154542855e92c014fe11fa7e83
+  metadata.gz: bdd806cd7c12b665577e8f686f9a14225fd102ce
+  data.tar.gz: 519601368cfc6e8d30912510fadbd2b866eff7e8
 SHA512:
-  metadata.gz: 852983cf3c549846b0638e2405531b4455e8fc8ef4961b0f65f3de1a4f4dd3e676446b3c7acd5b6aeb320ad91fe9cf5b2dc10c1931cb96244f27ee204c6113e3
-  data.tar.gz: 75bea923d74418ea433f5e03952cf76ba302daa82ec7d8704dde450154c86807049562f60038905f1e0c1de7d34d9abb54b183cd86f4c9b7f7097ebb17c5bcdc
+  metadata.gz: 5e554e45930e79aeb9c1eca4cdc5437bc8a26f3228c02b71d63c4c5e1c573cac7268e83d51bcd96bf619c7b430d1ca22eaaffbe224c44b139f6e4e031b1306dd
+  data.tar.gz: 1ef5c432b902a710b61886b4e0ba5eee9448c021978add9d93b033b9b747dd5a693e019c960b855ea005cc350f781b9bdea73351f85905b958c7d5e0a348a29b

data/.simplecov

@@ -0,0 +1,14 @@
+SimpleCov.start do
+  project_name 'estore'
+
+  # Filter out the following files
+  add_filter '/spec/'
+  add_filter '/gems/'
+  add_filter '/config/'
+
+  require 'coveralls'
+  SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+    Coveralls::SimpleCov::Formatter,
+    SimpleCov::Formatter::HTMLFormatter
+  ]
+end

data/.travis.yml

@@ -5,7 +5,7 @@ bundler_args: --without yard guard benchmarks tools
 env:
   global:
     - JRUBY_OPTS='--dev -J-Xmx1024M'
-    - CODECLIMATE_REPO_TOKEN=86bb9d558da8217d85126a02c4a264dc8789bb4cc8d3949e8fcbabca0440f2fa
+    - CODECLIMATE_REPO_TOKEN=c571107e67aa90424c4d4256a3ad20127d1c64104b83d43f3ec23630c7aa19da
 install:
   - "wget -nc http://download.geteventstore.com/binaries/EventStore-OSS-Linux-v3.0.3.tar.gz"
   - "tar -xvzf EventStore-OSS-Linux-v3.0.3.tar.gz"

data/CHANGELOG.md

@@ -0,0 +1,28 @@
+## v0.1.2 - 2015-04-05
+### Added
+* Errors during commands reject promises too
+* Unit testing started
+
+[Compare v0.1.1...v0.1.2](https://github.com/rom-rb/rom-event_store/compare/v0.1.1...v0.1.2)
+
+## v0.1.1 - 2015-04-05
+### Added
+* General errors during connection reject command promises
+
+[Compare v0.1.0...v0.1.1](https://github.com/rom-rb/rom-event_store/compare/v0.1.0...v0.1.1)
+
+## v0.1.0 - 2015-04-03
+### Added
+* General refactoring using the concept of `Command`
+
+[Compare v0.0.2...v0.1.0](https://github.com/rom-rb/rom-event_store/compare/v0.0.2...v0.1.0)
+
+## v0.0.2 - 2015-04-01
+### Added
+* Gem name changed to `estore`
+* Minor refactoring
+
+[Compare v0.0.1...v0.0.2](https://github.com/rom-rb/rom-event_store/compare/v0.0.1...v0.0.2)
+
+## v0.0.1 - 2015-03-31
+Forked from [eventstore-ruby](https://github.com/mathieuravaux/eventstore-ruby)

data/Gemfile

@@ -4,14 +4,5 @@ source 'https://rubygems.org'
 gemspec
 
 group :test do
-  gem 'rspec', '~> 3.1'
-  gem 'codeclimate-test-reporter', require: false
-end
-
-group :tools do
-  gem 'rubocop'
-
-  gem 'guard'
-  gem 'guard-rspec'
-  gem 'guard-rubocop'
+  gem 'coveralls', require: false
 end

data/README.md

@@ -1,19 +1,20 @@
 [gem]: https://rubygems.org/gems/estore
-[travis]: https://travis-ci.org/rom-eventstore/estore
-[gemnasium]: https://gemnasium.com/rom-eventstore/estore
-[codeclimate]: https://codeclimate.com/github/rom-eventstore/estore
-[inchpages]: http://inch-ci.org/github/rom-eventstore/estore
-[gitter]: https://gitter.im/rom-eventstore/estore?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge
+[travis]: https://travis-ci.org/eventstore-rb/estore
+[gemnasium]: https://gemnasium.com/eventstore-rb/estore
+[codeclimate]: https://codeclimate.com/github/eventstore-rb/estore
+[coveralls]: https://coveralls.io/r/eventstore-rb/estore
+[inchpages]: http://inch-ci.org/github/eventstore-rb/estore
+[gitter]: https://gitter.im/eventstore-rb/estore?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge
 
 # Estore
 
 [![Gem Version](https://badge.fury.io/rb/estore.svg)][gem]
-[![Build Status](https://travis-ci.org/rom-eventstore/estore.svg?branch=master)][travis]
-[![Dependency Status](https://gemnasium.com/rom-eventstore/estore.png)][gemnasium]
-[![Code Climate](https://codeclimate.com/github/rom-eventstore/estore/badges/gpa.svg)][codeclimate]
-[![Test Coverage](https://codeclimate.com/github/rom-eventstore/estore/badges/coverage.svg)][codeclimate]
-[![Inline docs](http://inch-ci.org/github/rom-eventstore/estore.svg?branch=master)][inchpages]
-[![Join the chat at https://gitter.im/rom-eventstore/estore](https://badges.gitter.im/Join%20Chat.svg)][gitter]
+[![Build Status](https://travis-ci.org/eventstore-rb/estore.svg?branch=master)][travis]
+[![Dependency Status](https://gemnasium.com/eventstore-rb/estore.png)][gemnasium]
+[![Code Climate](https://codeclimate.com/github/eventstore-rb/estore/badges/gpa.svg)][codeclimate]
+[![Coverage Status](https://coveralls.io/repos/eventstore-rb/estore/badge.svg)][coveralls]
+[![Inline docs](http://inch-ci.org/github/eventstore-rb/estore.svg?branch=master)][inchpages]
+[![Join the chat at https://gitter.im/eventstore-rb/estore](https://badges.gitter.im/Join%20Chat.svg)][gitter]
 
 An [Event Store](http://geteventstore.com/) driver for Ruby
 

data/estore.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ['mathieu.ravaux@gmail.com', 'hector0193@gmail.com']
   spec.summary       = 'An Event Store driver for Ruby'
   spec.description   = 'TCP driver to read and write events to Event Store'
-  spec.homepage      = 'https://github.com/rom-eventstore/estore'
+  spec.homepage      = 'https://github.com/eventstore-rb/estore'
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
@@ -24,4 +24,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rubocop', '~> 0.28.0'
+  spec.add_development_dependency 'rspec', '~> 3.1'
 end

data/lib/estore/commands.rb

@@ -2,7 +2,9 @@ require 'estore/commands/promise'
 require 'estore/commands/base'
 require 'estore/commands/append'
 require 'estore/commands/ping'
-require 'estore/commands/read_batch'
-require 'estore/commands/read_forward'
+require 'estore/commands/read'
+require 'estore/commands/reads/batch'
+require 'estore/commands/reads/forward'
 require 'estore/commands/subscription'
-require 'estore/commands/catch_up_subscription'
+require 'estore/commands/subscriptions/live'
+require 'estore/commands/subscriptions/catch_up'

data/lib/estore/commands/append.rb

@@ -3,9 +3,7 @@ module Estore
     class Append
       include Command
 
-      CONTENT_TYPES = {
-        json: 1
-      }
+      handle WriteEventsCompleted => :completed
 
       def initialize(connection, stream, events, options = {})
         super(connection)
@@ -13,23 +11,22 @@ module Estore
       end
 
       def call
+        register!
+
         msg = WriteEvents.new(
           event_stream_id: @stream,
           expected_version: @options[:expected_version] || -2,
           events: Array(@events).map { |event| new_event(event) },
           require_master: true
         )
-
-        register!
         write('WriteEvents', msg)
+
         promise
       end
 
-      def handle(message, *)
+      def completed(response)
         remove!
 
-        response = decode(WriteEventsCompleted, message)
-
         if response.result == OperationResult::Success
           promise.fulfill(response)
         else
@@ -39,6 +36,10 @@ module Estore
 
       private
 
+      CONTENT_TYPES = {
+        json: 1
+      }
+
       def new_event(event)
         uuid = event[:id] || SecureRandom.uuid
         content_type = event.fetch(:content_type, :json)

data/lib/estore/commands/base.rb

@@ -3,6 +3,12 @@ module Estore
     module Command
       attr_reader :uuid
 
+      def self.included(base)
+        base.extend ClassMethods
+        base.singleton_class.class_eval { attr_accessor :handlers }
+        base.handlers = {}
+      end
+
       def initialize(connection)
         @connection = connection
         @uuid = SecureRandom.uuid
@@ -28,26 +34,20 @@ module Estore
         @promise ||= Promise.new(@uuid)
       end
 
-      def decode(type, message)
-        type.decode(message)
-      rescue => error
-        puts "Protobuf decoding error on connection #{object_id}"
-        puts type: type, message: message
-        puts error.backtrace
-        raise error
-      end
+      def handle(message)
+        handler = self.class.handlers[message.class]
 
-      module ReadStreamForward
-        def read(stream, from, limit)
-          msg = ReadStreamEvents.new(
-            event_stream_id: stream,
-            from_event_number: from,
-            max_count: limit,
-            resolve_link_tos: true,
-            require_master: false
-          )
+        if handler
+          send(handler, message) unless handler == :ignore
+        else
+          $stderr.puts "#{message.class} arrived but not handled by "\
+            "command #{self.class}"
+        end
+      end
 
-          write('ReadStreamEventsForward', msg)
+      module ClassMethods
+        def handle(hash)
+          handlers.update(hash)
         end
       end
     end

data/lib/estore/commands/read.rb

@@ -0,0 +1,28 @@
+module Estore
+  module Commands
+    module ReadStreamForward
+      def read(stream, from, limit)
+        msg = ReadStreamEvents.new(
+          event_stream_id: stream,
+          from_event_number: from,
+          max_count: limit,
+          resolve_link_tos: true,
+          require_master: false
+        )
+
+        write('ReadStreamEventsForward', msg)
+      end
+
+      def error(response)
+        case response.result
+        when ReadStreamEventsCompleted::ReadStreamResult::AccessDenied
+          :access_denied
+        when ReadStreamEventsCompleted::ReadStreamResult::Error
+          response.error ? response.error : 'No message given'
+        else
+          false
+        end
+      end
+    end
+  end
+end

data/lib/estore/commands/{read_batch.rb → reads/batch.rb}

@@ -2,7 +2,9 @@ module Estore
   module Commands
     class ReadBatch
       include Command
-      include Command::ReadStreamForward
+      include ReadStreamForward
+
+      handle ReadStreamEventsForwardCompleted => :completed
 
       def initialize(connection, stream, from, limit)
         super(connection)
@@ -15,10 +17,15 @@ module Estore
         promise
       end
 
-      def handle(message, *)
+      def completed(response)
         remove!
-        response = decode(ReadStreamEventsCompleted, message)
-        promise.fulfill(Array(response.events))
+        error = error(response)
+
+        if error
+          promise.reject error
+        else
+          promise.fulfill(Array(response.events))
+        end
       end
     end
   end

data/lib/estore/commands/{read_forward.rb → reads/forward.rb}

@@ -2,7 +2,9 @@ module Estore
   module Commands
     class ReadForward
       include Command
-      include Command::ReadStreamForward
+      include ReadStreamForward
+
+      handle ReadStreamEventsCompleted => :batch_completed
 
       def initialize(connection, stream, from, batch_size = nil, &block)
         super(connection)
@@ -20,8 +22,7 @@ module Estore
         promise
       end
 
-      def handle(message, *)
-        response = decode(ReadStreamEventsCompleted, message)
+      def keep_reading(response)
         events = Array(response.events)
 
         @from += events.size
@@ -34,6 +35,17 @@ module Estore
           promise.fulfill(@block ? nil : @events)
         end
       end
+
+      def batch_completed(response)
+        error = error(response)
+
+        if error
+          remove!
+          promise.reject error
+        else
+          keep_reading(response)
+        end
+      end
     end
   end
 end

data/lib/estore/commands/subscription.rb

@@ -1,8 +1,6 @@
 module Estore
   module Commands
-    class Subscription
-      include Command
-
+    module Subscription
       def initialize(connection, stream, options = {})
         super(connection)
         @has_finished = false
@@ -10,10 +8,6 @@ module Estore
         @resolve_link_tos = options.fetch(:resolve_link_tos, true)
       end
 
-      def finished?
-        @has_finished
-      end
-
       def call
         start
       end
@@ -39,11 +33,6 @@ module Estore
         @handler = block
       end
 
-      def handle(message, type)
-        dispatch(decode(StreamEventAppeared, message).event) if
-          type == 'StreamEventAppeared'
-      end
-
       def dispatch(event)
         @position = event.original_event_number
         @handler.call(event)

data/lib/estore/commands/{catch_up_subscription.rb → subscriptions/catch_up.rb}

@@ -1,11 +1,14 @@
 module Estore
   module Commands
-    class CatchUpSubscription < Subscription
+    class CatchUpSubscription
       include Command
+      include Subscription
+
+      handle StreamEventAppeared => :event_appeared,
+             SubscriptionConfirmation => :ignore
 
       def initialize(connection, stream, from, options = {})
-        super(connection, options)
-        @stream = stream
+        super(connection, stream, options)
         @from = from
         @batch = options[:batch_size]
         @mutex = Mutex.new
@@ -42,18 +45,14 @@ module Estore
         @queue.find_all { |event| event.original_event_number > @position }
       end
 
-      def handle(message, type)
-        if type == 'StreamEventAppeared'
-          event = decode(StreamEventAppeared, message).event
-
-          unless @caught_up
-            @mutex.synchronize do
-              @queue << event unless @caught_up
-            end
+      def event_appeared(response)
+        unless @caught_up
+          @mutex.synchronize do
+            @queue << response.event unless @caught_up
           end
-
-          dispatch(event) if @caught_up
         end
+
+        dispatch(response.event) if @caught_up
       end
     end
   end

data/lib/estore/commands/subscriptions/live.rb

@@ -0,0 +1,15 @@
+module Estore
+  module Commands
+    class LiveSubscription
+      include Command
+      include Commands::Subscription
+
+      handle StreamEventAppeared => :event_appeared,
+             SubscriptionConfirmation => :ignore
+
+      def event_appeared(response)
+        dispatch(response.event)
+      end
+    end
+  end
+end

data/lib/estore/connection.rb

@@ -34,11 +34,11 @@ module Estore
 
     private
 
-    def on_received_package(message, type, uuid, _flags)
+    def on_received_package(type, package, uuid, _flags)
       if type == 'HeartbeatRequestCommand'
         write(SecureRandom.uuid, 'HeartbeatResponseCommand')
       else
-        @context.dispatch(uuid, message, type)
+        @context.dispatch(uuid, Package.decode(type, package))
       end
     end
 

data/lib/estore/connection/buffer.rb

@@ -42,9 +42,9 @@ module Estore
       end
 
       def handle(pkg)
-        code, flags, uuid_bytes, message = parse(pkg)
+        code, flags, uuid_bytes, package = parse(pkg)
         command = Estore::Connection.command_name(code)
-        @handler.call(message, command, Package.parse_uuid(uuid_bytes), flags)
+        @handler.call(command, package, Package.parse_uuid(uuid_bytes), flags)
       end
 
       def parse(pkg)

data/lib/estore/connection_context.rb

@@ -20,15 +20,23 @@ module Estore
       end
     end
 
-    def dispatch(uuid, message, type)
+    def dispatch(uuid, message)
       command = @commands[uuid]
-      command.handle(message, type) if command
+      command.handle(message) if command
+    rescue => error
+      command.reject! error
+      remove(command)
+    end
+
+    def empty?
+      @commands.empty?
     end
 
     def on_error(error)
       # TODO: Error handling
       @mutex.synchronize do
         @commands.each { |_uuid, command| command.reject! error }
+        @commands = {}
       end
     end
   end

data/lib/estore/message_extensions.rb

@@ -13,7 +13,9 @@ module Estore
       original_event.event_number
     end
   end
-end
 
-Estore::ResolvedEvent.send(:include, Estore::OriginalEventMixin)
-Estore::ResolvedIndexedEvent.send(:include, Estore::OriginalEventMixin)
+  ResolvedEvent.send(:include, OriginalEventMixin)
+  ResolvedIndexedEvent.send(:include, OriginalEventMixin)
+
+  ReadStreamEventsForwardCompleted = ReadStreamEventsCompleted
+end

data/lib/estore/package.rb

@@ -23,6 +23,14 @@ module Estore
       uuid.scan(/[0-9a-f]{4}/).map { |x| x.to_i(16) }.pack('n*')
     end
 
+    def self.decode(type, message)
+      message.empty? ? nil : Estore.const_get(type).decode(message)
+    rescue => error
+      puts 'Decoding error:'
+      puts type: type, message: message
+      raise error
+    end
+
     def self.parse_uuid(bytes)
       a, b, c, d, e, f, g, h =
         *bytes.unpack('n*').map { |n| n.to_s(16) }.map { |n| n.rjust(4, '0') }

data/lib/estore/session.rb

@@ -26,7 +26,7 @@ module Estore
     end
 
     def ping
-      command(Commands::Ping)
+      command(Commands::Ping).call
     end
 
     def read(stream, options = {})
@@ -56,7 +56,7 @@ module Estore
       if options[:from]
         command(Commands::CatchUpSubscription, stream, options[:from], options)
       else
-        command(Commands::Subscription, stream, options)
+        command(Commands::LiveSubscription, stream, options)
       end
     end
 

data/lib/estore/version.rb

@@ -1,3 +1,3 @@
 module Estore
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/spec/integration/session_spec.rb

@@ -39,6 +39,10 @@ describe Estore::Session do
     stream
   end
 
+  it 'pings the Event Store' do
+    Timeout.timeout(5) { session.ping.sync }
+  end
+
   it 'reads all the events from a stream' do
     stream = session.read(stream_with(200)).sync
 
@@ -57,6 +61,12 @@ describe Estore::Session do
     expect(stream).to have(15).events.starting_at(10)
   end
 
+  it 'reads no events if the stream does not exist' do
+    stream = session.read('doesnotexist').sync
+
+    expect(stream).to have(0).events
+  end
+
   it 'allows to make a live subscription' do
     stream = random_stream
     received = []
@@ -79,18 +89,23 @@ describe Estore::Session do
     stream_with(2100, stream)
 
     sub = session.subscription(stream, from: 30)
+
     sub.on_event do |event|
+      # Events received during processing should be
+      # received later too
+      sleep 1 if received.size < 1
       received << event
       puts "Receiving... #{received.size}"
     end
-    sub.start
 
     Thread.new do
-      50.times do
+      30.times do
         stream_with(2, stream)
       end
     end
 
-    expect(received).to have(2170).events.starting_at(30).before(20.seconds)
+    sub.start
+
+    expect(received).to have(2130).events.starting_at(30).before(20.seconds)
   end
 end

data/spec/spec_helper.rb

@@ -1,9 +1,5 @@
 # encoding: utf-8
-if RUBY_ENGINE == 'rbx'
-  require 'codeclimate-test-reporter'
-  CodeClimate::TestReporter.start
-end
-
+require 'simplecov'
 require 'estore'
 
 trap 'TTIN' do
@@ -39,6 +35,8 @@ RSpec::Matchers.define :have do |expectation|
         expect(wrapper.event.event_number).to be(index + @start)
       end
     end
+
+    true
   end
 
   chain(:events) {}

data/spec/unit/estore/commands/append_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+require 'unit/estore/connection_mock'
+
+describe Estore::Commands::Append do
+  subject(:append) do
+    Estore::Commands::Append.new(connection, 'test-stream', events)
+  end
+
+  let(:events) do
+    [{ type: 'something', data: 'something else' }, { type: 'stuff' }]
+  end
+
+  let(:connection) { Estore::ConnectionMock.new }
+  let(:promise) { append.call }
+
+  before do
+    promise
+  end
+
+  it 'writes a message with the events to the connection buffer' do
+    _uuid, _type, msg = connection.buffer.first
+
+    expect(msg.events.size).to be(events.size)
+  end
+
+  it 'rejects the promise on errors' do
+    append.handle(
+      Estore::WriteEventsCompleted.new(
+        result: Estore::OperationResult::AccessDenied
+      )
+    )
+
+    expect { promise.sync }.to raise_exception
+  end
+end

data/spec/unit/estore/commands/reads/batch_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+require 'unit/estore/connection_mock'
+
+describe Estore::Commands::ReadBatch do
+  subject(:read) do
+    Estore::Commands::ReadBatch.new(connection, 'test-stream', 5, 10)
+  end
+
+  let(:message) { Estore::ReadStreamEventsCompleted }
+  let(:connection) { Estore::ConnectionMock.new }
+  let(:promise) { read.call }
+
+  def result(type)
+    message.new(
+      result: message::ReadStreamResult.const_get(type)
+    )
+  end
+
+  before do
+    promise
+  end
+
+  it 'rejects the promise on errors' do
+    read.handle(result(:Error))
+
+    expect { promise.sync }.to raise_exception
+  end
+
+  it 'rejects the promise when access is denied' do
+    read.handle(result(:AccessDenied))
+
+    expect { promise.sync }.to raise_exception
+  end
+end

data/spec/unit/estore/commands/reads/forward_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+require 'unit/estore/connection_mock'
+
+describe Estore::Commands::ReadForward do
+  subject(:read) do
+    Estore::Commands::ReadForward.new(connection, 'test-stream', 5, 10)
+  end
+
+  let(:message) { Estore::ReadStreamEventsCompleted }
+  let(:connection) { Estore::ConnectionMock.new }
+  let(:promise) { read.call }
+
+  def result(type)
+    message.new(
+      result: message::ReadStreamResult.const_get(type)
+    )
+  end
+
+  before do
+    promise
+  end
+
+  it 'rejects the promise on errors' do
+    read.handle(result(:Error))
+
+    expect { promise.sync }.to raise_exception
+  end
+
+  it 'rejects the promise when access is denied' do
+    read.handle(result(:AccessDenied))
+
+    expect { promise.sync }.to raise_exception
+  end
+end

data/spec/unit/estore/connection_context_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe Estore::ConnectionContext do
+  subject(:context) { Estore::ConnectionContext.new }
+
+  let(:bad_command) do
+    BadCommand = Class.new do
+      attr_reader :error
+
+      def uuid
+        'test'
+      end
+
+      def reject!(error)
+        @error = error
+      end
+
+      def handle(_msg)
+        boom
+      end
+    end
+
+    BadCommand.new
+  end
+
+  before do
+    context.register(bad_command)
+  end
+
+  it 'rejects a command when exceptions happen inside the command' do
+    context.dispatch('test', 'something')
+
+    expect(bad_command.error).to be_instance_of(NameError)
+  end
+
+  it 'removes all commands when exceptions happen inside the command' do
+    context.dispatch('test', 'something')
+
+    expect(context.empty?).to be_truthy
+  end
+
+  it 'rejects a command when exceptions happen in the connection' do
+    context.on_error(StandardError.new('this is an error'))
+
+    expect(bad_command.error).to be_instance_of(StandardError)
+  end
+
+  it 'removes all commands when exceptions happen in the connection' do
+    context.on_error('this is an error')
+
+    expect(context.empty?).to be_truthy
+  end
+end

data/spec/unit/estore/connection_mock.rb

@@ -0,0 +1,22 @@
+module Estore
+  class ConnectionMock
+    attr_reader :buffer, :registry
+
+    def initialize
+      @buffer = []
+      @registry = {}
+    end
+
+    def write(uuid, type, msg)
+      @buffer << [uuid, type, msg]
+    end
+
+    def register(command)
+      @registry[command.uuid] = command
+    end
+
+    def remove(command)
+      @registry.delete(command.uuid)
+    end
+  end
+end

data/spec/unit/estore/package_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+
+describe Estore::Package do
+  subject(:package) { Estore::Package }
+
+  it 'rejects the promise on errors' do
+    expect { package.decode('boom', 'boom') }.to raise_exception
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: estore
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Mathieu Ravaux
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-05 00:00:00.000000000 Z
+date: 2015-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: beefcake
@@ -81,6 +81,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.28.0
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.1'
 description: TCP driver to read and write events to Event Store
 email:
 - mathieu.ravaux@gmail.com
@@ -91,6 +105,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rubocop.yml"
+- ".simplecov"
 - ".travis.yml"
 - ".yardopts"
 - CHANGELOG.md
@@ -103,12 +118,14 @@ files:
 - lib/estore/commands.rb
 - lib/estore/commands/append.rb
 - lib/estore/commands/base.rb
-- lib/estore/commands/catch_up_subscription.rb
 - lib/estore/commands/ping.rb
 - lib/estore/commands/promise.rb
-- lib/estore/commands/read_batch.rb
-- lib/estore/commands/read_forward.rb
+- lib/estore/commands/read.rb
+- lib/estore/commands/reads/batch.rb
+- lib/estore/commands/reads/forward.rb
 - lib/estore/commands/subscription.rb
+- lib/estore/commands/subscriptions/catch_up.rb
+- lib/estore/commands/subscriptions/live.rb
 - lib/estore/connection.rb
 - lib/estore/connection/buffer.rb
 - lib/estore/connection/protocol.rb
@@ -121,8 +138,14 @@ files:
 - lib/estore/version.rb
 - spec/integration/session_spec.rb
 - spec/spec_helper.rb
+- spec/unit/estore/commands/append_spec.rb
+- spec/unit/estore/commands/reads/batch_spec.rb
+- spec/unit/estore/commands/reads/forward_spec.rb
+- spec/unit/estore/connection_context_spec.rb
+- spec/unit/estore/connection_mock.rb
+- spec/unit/estore/package_spec.rb
 - vendor/proto/ClientMessageDtos.proto
-homepage: https://github.com/rom-eventstore/estore
+homepage: https://github.com/eventstore-rb/estore
 licenses:
 - MIT
 metadata: {}
@@ -149,3 +172,9 @@ summary: An Event Store driver for Ruby
 test_files:
 - spec/integration/session_spec.rb
 - spec/spec_helper.rb
+- spec/unit/estore/commands/append_spec.rb
+- spec/unit/estore/commands/reads/batch_spec.rb
+- spec/unit/estore/commands/reads/forward_spec.rb
+- spec/unit/estore/connection_context_spec.rb
+- spec/unit/estore/connection_mock.rb
+- spec/unit/estore/package_spec.rb