establish 0.0.26 → 0.0.27

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a1565c65a2866c66db980533a1fd6e1487f53a6407aff769130f72c724997dc0
-  data.tar.gz: 3375023d4ec987c1d2ee6c87cbd39191674a5b2fcfb390d3cd7c0a6dc9b67d7c
+  metadata.gz: a903044842b73b828911ed1f4834f63ad4e58b7cc2c32a0610380c44244503c6
+  data.tar.gz: 300bba595145f9e55748b0fb9eb306ecea46d44998bd1ea6b903181a7bf82ac9
 SHA512:
-  metadata.gz: bf04845085479a3aae363a1be6b6b32106d9a3ebf18dd373df2db3e802eb8efeff983a0e35848ce934eabba8b21998e2653298590ff713ea22a4a35468070c5d
-  data.tar.gz: f24bd4dc68af13149226ead11f61bacc7c1af43b2aff1f5bf5093c198d75815583993877b7c03ea586c27e47763a619f216ba6166fd86b11f7dd12f156569aac
+  metadata.gz: a9f186e0b65aa020ed0c2e5c8aff7e4af66898ebaa96eb004e26c887367219caa53cf27a7c095c5269c80098a4db013f0fc6532c1c018e4ac1c04cefd59e8a7c
+  data.tar.gz: 285ea4a771adc5fdbeade8f2eaa154a2321ae8fa806da8dd30108ee5b9cee8f3cd0698bf31abd8f3f6dd6944987ab741787b77fe3a49502274e0da478b0ffe44

data/lib/establish/app_metadata.rb

@@ -1,8 +1,12 @@
 require 'nokogiri'
 
 module Establish
+  class AppMetadataError < StandardError
+
+  end
+
   class AppMetadata
-    APPLE_ITUNES_NAMESPACE = "http://apple.com/itunes/importer"
+    ITUNES_NAMESPACE = "http://apple.com/itunes/importer"
 
     attr_accessor :metadata_dir
 
@@ -28,9 +32,7 @@ module Establish
 
     # Update the app description which is shown in the AppStore
     def update_description(hash)
-      raise "Please pass a hash of languages to this method" unless hash.kind_of?Hash
-
-      # TODO: Implement
+      update_localized_value('description', hash)
     end
 
 
@@ -44,14 +46,60 @@ module Establish
     end
 
     private
-      def modify_value(xpath, new_value)
-        binding.pry
 
-        @data.xpath("//x:#{xpath}", "x" => APPLE_ITUNES_NAMESPACE)
+    # Usage: '//x:keyword'
+    def fetch_value(xpath)
+      @data.xpath(xpath, "x" => ITUNES_NAMESPACE)
+    end
+
+    def update_localized_value(xpath_name, new_value)
+      raise "Please pass a hash of languages to this method" unless new_value.kind_of?Hash
+
+      fetch_value("//x:locale").each do |locale|
+        key = locale['name']
+        if new_value[key]
+          description_field = locale.search(xpath_name).first
+          if description_field.content != new_value[key]
+            description_field.content = new_value[key]
+            Helper.log.debug "Updated #{xpath_name} for locale #{locale}"
+          end
+        else
+          Helper.log.error "Could not find '#{xpath_name}' for #{key}. It was provided before. Not updating this value"
+        end
       end
+    end
 
+    # Parses the metadata using nokogiri
     def parse_package(path)
-      @data ||= Nokogiri::XML(File.read("#{self.metadata_dir}/#{@app.apple_id}.itmsp/metadata.xml"))
+      @data ||= Nokogiri::XML(File.read("#{path}/#{@app.apple_id}.itmsp/metadata.xml"))
+      verify_package
+      clean_package
+    end
+
+    # Checks if there is a non live version available
+    # (a new version, or a new app)
+    def verify_package
+      versions = fetch_value("//x:version")
+
+      # TODO: This does not work for new apps
+      raise AppMetadataError.new("You have to create a new version before modifying the app metadata") if versions.count == 1
+
+      raise AppMetadataError.new("metadata_token is missing") if fetch_value("//x:metadata_token").count != 1
+    end
+
+    # Cleans up the package of stuff we do not want to modify/upload
+    def clean_package
+
+
+      # Remove the live version (if it exists)
+      versions = fetch_value("//x:version")
+      while versions.count > 1
+        versions.last.remove
+        versions = fetch_value("//x:version")
+      end
+      Helper.log.info "Modifying version '#{versions.first.attr('string')}' of app #{@app.app_identifier}"
+
+
     end
   end
-end
+end

data/lib/establish/version.rb

@@ -1,3 +1,3 @@
 module Establish
-  VERSION = "0.0.26"
+  VERSION = "0.0.27"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: establish
 version: !ruby/object:Gem::Version
-  version: 0.0.26
+  version: 0.0.27
 platform: ruby
 authors:
 - Vincenzo Fehring