establish 0.0.25 → 0.0.26

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a2c04e19736379dfc5530b8fd95ece5357805557b60c9098d4b9a4acc3a5b256
-  data.tar.gz: e362d85bf559fd63305e9eca38b364e5de69377b0de9748e0611176b39c98619
+  metadata.gz: a1565c65a2866c66db980533a1fd6e1487f53a6407aff769130f72c724997dc0
+  data.tar.gz: 3375023d4ec987c1d2ee6c87cbd39191674a5b2fcfb390d3cd7c0a6dc9b67d7c
 SHA512:
-  metadata.gz: dfc50e5a1e958d5de10cb4111998c340e7cc11dc9f9354ad2dfd928bc10520a611aa9387a375a3d10dbf4916c797a8a8da26a54b6aa29b83b1591064a2037eae
-  data.tar.gz: 7cc66d8611c7ce7d1de5ae204cc651c7e75bb852e0ca4f55f971ee1f9b0b09dd8d6cda6e58e43577e22579a41e03e685e4eb53ebc35f365d8d60c9cd2375cf0a
+  metadata.gz: bf04845085479a3aae363a1be6b6b32106d9a3ebf18dd373df2db3e802eb8efeff983a0e35848ce934eabba8b21998e2653298590ff713ea22a4a35468070c5d
+  data.tar.gz: f24bd4dc68af13149226ead11f61bacc7c1af43b2aff1f5bf5093c198d75815583993877b7c03ea586c27e47763a619f216ba6166fd86b11f7dd12f156569aac

data/lib/establish/app.rb

@@ -1,6 +1,8 @@
 module Establish
   class App
-    attr_accessor :apple_id, :app_identifier
+    attr_accessor :apple_id, :app_identifier, :metadata, :metadata_dir
+
+
 
     module AppStatus
       # As specified by Apple: https://developer.apple.com/library/ios/documentation/LanguagesUtilities/Conceptual/iTunesConnect_Guide/Chapters/ChanginAppStatus.html
@@ -28,6 +30,7 @@ module Establish
       self.app_identifier = app_identifier
 
       if apple_id and not app_identifier
+        # Fetch the app identifier based on the given Apple ID
         self.app_identifier = Establish::ItunesSearchApi.fetch_bundle_identifier(apple_id)
         Helper.log.debug "Created app with ID #{apple_id} and app_identifier #{self.app_identifier}"
       end
@@ -49,10 +52,37 @@ module Establish
       "#{apple_id} - #{app_identifier}"
     end
 
-    # Destructive/Constructive meethods
+    # Use this method to change the default download location for the metadata packages
+    def set_metadata_directory(dir)
+      raise "Can not change metadata directory after accessing metdata of an app" if @metadata
+      self.metadata_dir = dir
+    end
+
+    def get_metadata_directory
+      metdata_dir || './'
+    end
+
+    def metadata
+      @metadata ||= Establish::AppMetadata.new(self, get_metadata_directory)
+    end
+
+
+    #####################################################
+    # Destructive/Constructive methods
+    #####################################################
 
     def create_new_version!(version_number)
       itc.create_new_version!(self, version_number)
     end
+
+    # This method has to be called, after modifying the values of .metadata
+    # It will take care of uploading all changes to Apple
+    def upload_metadata!
+      raise "You first have to modify the metadata using app.metadata.setDescription" unless @metadata
+
+      self.metadata.upload!
+    end
+
+
   end
 end

data/lib/establish/app_metadata.rb

@@ -0,0 +1,57 @@
+require 'nokogiri'
+
+module Establish
+  class AppMetadata
+    APPLE_ITUNES_NAMESPACE = "http://apple.com/itunes/importer"
+
+    attr_accessor :metadata_dir
+
+    def transporter
+      @transporter ||= ItunesTransporter.new
+    end
+
+    def initialize(app, dir)
+      self.metadata_dir = dir
+      @app = app
+
+      # we want to update the metadata, so first we have to download the existing one
+      transporter.download(app, dir)
+
+      # Parse the downloaded package
+      parse_package(dir)
+    end
+
+
+    #####################################################
+    # Updating metadata information
+    #####################################################
+
+    # Update the app description which is shown in the AppStore
+    def update_description(hash)
+      raise "Please pass a hash of languages to this method" unless hash.kind_of?Hash
+
+      # TODO: Implement
+    end
+
+
+    #####################################################
+    # Uploading the updated metadata
+    #####################################################
+
+    # Actually upload the updated metadata to Apple
+    def upload!
+      transporter.upload(@app, @app.get_metadata_directory)
+    end
+
+    private
+      def modify_value(xpath, new_value)
+        binding.pry
+
+        @data.xpath("//x:#{xpath}", "x" => APPLE_ITUNES_NAMESPACE)
+      end
+
+    def parse_package(path)
+      @data ||= Nokogiri::XML(File.read("#{self.metadata_dir}/#{@app.apple_id}.itmsp/metadata.xml"))
+    end
+  end
+end

data/lib/establish/itunes_transporter.rb

@@ -14,11 +14,22 @@ module Establish
       @password = (password || PasswordManager.new.password)
     end
 
-    def download(app)
+    def download(app, dir = nil)
       raise "No valid Establish::App given" unless app.kind_of?Establish::App
 
-      command = build_download_command(@user, @password, app.apple_id)
-      Helper.log.debug command
+      dir ||= app.get_metadata_directory
+      command = build_download_command(@user, @password, app.apple_id, dir)
+
+      self.execute_transporter(command)
+    end
+
+    def upload(app, dir)
+      raise "No valid Establish::App given" unless app.kind_of?Establish::App
+
+      dir ||= app.get_metadata_directory
+      dir += "/#{app.apple_id}.itmsp"
+
+      command = build_upload_command(@user, @password, app.apple_id, dir)
 
       self.execute_transporter(command)
     end
@@ -49,7 +60,11 @@ module Establish
         errors << ex.to_s
       end
 
-      raise errors.join("\n") if errors.count > 0
+      if errors.count > 0
+        Helper.log.debug(caller)
+        raise errors.join("\n")
+      end
+
       true
     end
 
@@ -59,11 +74,25 @@ module Establish
             Helper.transporter_path,
             "-m lookupMetadata",
             "-u \"#{useername}\"",
-            "-p '#{password.gsub('$', '\\$')}'",
+            "-p '#{escaped_password(password)}'",
             "-apple_id #{apple_id}",
             "-destination '#{destination}'"
         ].join(' ')
       end
 
+    def build_upload_command(username, password, apple_id, source = "/tmp")
+      [
+          Helper.transporter_path,
+          "-m upload",
+          "-u \"#{username}\"",
+          "-p '#{escaped_password(password)}'",
+          "-f '#{source}'"
+      ].join(' ')
+    end
+
+    def escaped_password(password)
+      password.gsub('$', '\\$')
+    end
+
   end
 end

data/lib/establish/version.rb

@@ -1,3 +1,3 @@
 module Establish
-  VERSION = "0.0.25"
+  VERSION = "0.0.26"
 end

data/lib/establish.rb

@@ -1,6 +1,7 @@
 require 'establish/version'
 require 'establish/helper'
 require 'establish/app'
+require 'establish/app_metadata'
 require 'establish/itunes_connect'
 require 'establish/itunes_search_api'
 require 'establish/itunes_transporter'

data/spec/app_metadata_spec.rb

@@ -0,0 +1,26 @@
+describe Establish do
+  describe Establish::AppMetadata do
+    let (:apple_id) { 794902327 }
+    let (:app_identifier) { 'net.sunapps.1' }
+
+    describe "#update_description" do
+      before do
+        @app = Establish::App.new(apple_id, app_identifier)
+      end
+
+      it "throws an exception when a string is given instead of a string" do
+        except {
+          @app.metadata.update_description("something")
+        }.to raise_error("Please pass a hash of languages to this method")
+      end
+
+      it "updates the description when a hash is given", now: true do
+        @app.metadata.update_description({
+            'de' => "new"
+        })
+        # TODO
+        # @app.upload_metadata!
+      end
+    end
+  end
+end

data/spec/app_spec.rb

@@ -2,6 +2,7 @@ describe Establish do
   describe Establish::App do
     let (:apple_id) { 284882215 }
     let (:app_identifier) { 'com.facebook.Facebook' }
+
     describe "#initialize" do
       it "automatically fetches the app identifier, if only Apple ID is given" do
         app = Establish::App.new(apple_id)
@@ -11,7 +12,7 @@ describe Establish do
       end
 
       it "lets me create an app using an Apple ID and app identifier" do
-        app = Establish::App.new(apple_id, "com.facebook.Facebook")
+        app = Establish::App.new(apple_id, app_identifier)
 
         app.app_identifier.should eq(app_identifier)
         app.apple_id.should eq(apple_id)
@@ -21,5 +22,40 @@ describe Establish do
         Establish::App.new.app_identifier.should eq(nil)
       end
     end
+
+
+    describe "Accessing App Metadata", felix: true do
+      before do
+        @app = Establish::App.new(794902327, 'net.sunapps.1')
+      end
+
+      describe "#set_metadata_directory" do
+
+        it "throws an exception when updating the location after accessing metadata" do
+          @app.metadata
+          except {
+            @app.set_metadata_directory("something")
+          }.to raise_error("Can not change metadata directory after accessing metadata of an app")
+        end
+
+        it "let's the user modify the download directory" do
+          @app.get_metadata_directory.should eq('./')
+
+          alternative = '/tmp/something'
+          @app.set_metadata_directory(alternative)
+
+          @app.get_metadata_directory.should eq(alternative)
+        end
+
+      end
+
+      describe "#upload_metadata!" do
+        it "throws an exception when metadata was not yet downloaded" do
+          except {
+            @app.upload_metadata!
+          }.to raise_error("You first have to modify the metadata using app.metadata.setDescription")
+        end
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: establish
 version: !ruby/object:Gem::Version
-  version: 0.0.25
+  version: 0.0.26
 platform: ruby
 authors:
 - Vincenzo Fehring
@@ -154,12 +154,14 @@ files:
 - establish.gemspec
 - lib/establish.rb
 - lib/establish/app.rb
+- lib/establish/app_metadata.rb
 - lib/establish/helper.rb
 - lib/establish/itunes_connect.rb
 - lib/establish/itunes_search_api.rb
 - lib/establish/itunes_transporter.rb
 - lib/establish/password_manager.rb
 - lib/establish/version.rb
+- spec/app_metadata_spec.rb
 - spec/app_spec.rb
 - spec/helper_spec.rb
 - spec/itunes_connect_spec.rb
@@ -192,6 +194,7 @@ signing_key:
 specification_version: 4
 summary: Updating your iOS app should not be painful and time consuming.
 test_files:
+- spec/app_metadata_spec.rb
 - spec/app_spec.rb
 - spec/helper_spec.rb
 - spec/itunes_connect_spec.rb