errornot_notifier 1.0.0 → 1.0.1

data/CHANGELOG

@@ -1,4 +1,12 @@
-Version 1.0.0 - XXX
+Version 1.0.1 -
+===============================================================================
+
+Jason Morrison (3):
+      LH-629 Ensure notifier is not considered a framework gem ( update to ErrorNot by Cyril Mougel)
+      Removing things-the-generator-must-do file
+      Add rake cucumber:wip:rails* tasks for work-in-progress features+
+
+Version 1.0.0 - 2010/03/08
 ===============================================================================
 
 Extract from HopToad notifier code base

data/README.rdoc

@@ -198,6 +198,15 @@ Errornot merges the hash you pass with these default options:
 
 You can override any of those parameters.
 
+=== Sending shell environment variables when "Going beyond exceptions"
+
+One common request we see is to send shell environment variables along with
+manual exception notification.  We recommend sending them along with CGI data
+or Rack environment (:cgi_data or :rack_env keys, respectively.)
+
+See ErrornotNotifier::Notice#initialize in lib/errornot_notifier/notice.rb for
+more details.
+
 == Filtering
 
 You can specify a whitelist of errors, that Errornot will not report on.  Use

data/Rakefile

@@ -191,14 +191,14 @@ end
 
 task :cucumber => [:gemspec, :vendor_test_gems]
 
-namespace :cucumber do
+def define_rails_cucumber_tasks(additional_cucumber_args = '')
   namespace :rails do
     RAILS_VERSIONS.each do |version|
       desc "Test integration of the gem with Rails #{version}"
       task version do
         puts "Testing Rails #{version}"
         ENV['RAILS_VERSION'] = version
-        system("cucumber --format progress features/rails.feature")
+        system("cucumber --format progress #{additional_cucumber_args} features/rails.feature")
       end
     end
 
@@ -206,3 +206,12 @@ namespace :cucumber do
     task :all => RAILS_VERSIONS
   end
 end
+
+namespace :cucumber do
+  namespace :wip do
+    define_rails_cucumber_tasks('--tags @wip')
+  end
+
+  define_rails_cucumber_tasks
+end
+

data/generators/errornot/templates/errornot_notifier_tasks.rake

@@ -1,5 +1,10 @@
-Dir[File.join(RAILS_ROOT, 'vendor', 'gems', 'errornot_notifier-*')].each do |vendored_notifier|
-  $: << File.join(vendored_notifier, 'lib')
-end
+# Don't load anything when running the gems:* tasks.
+# Otherwise, hoptoad_notifier will be considered a framework gem.
+# https://thoughtbot.lighthouseapp.com/projects/14221/tickets/629
+unless ARGV.any? {|a| a =~ /^gems/}
+  Dir[File.join(RAILS_ROOT, 'vendor', 'gems', 'errornot_notifier-*')].each do |vendored_notifier|
+    $: << File.join(vendored_notifier, 'lib')
+  end
 
-require 'errornot_notifier/tasks'
+  require 'errornot_notifier/tasks'
+end

data/lib/errornot_notifier/rails/controller_methods.rb

@@ -23,8 +23,7 @@ module ErrornotNotifier
           :controller       => params[:controller],
           :action           => params[:action],
           :url              => errornot_request_url,
-          :cgi_data         => errornot_filter_if_filtering(request.env),
-          :environment_vars => errornot_filter_if_filtering(ENV) }
+          :cgi_data         => errornot_filter_if_filtering(request.env) }
       end
 
       def errornot_filter_if_filtering(hash)

data/lib/errornot_notifier/version.rb

@@ -1,3 +1,3 @@
 module ErrornotNotifier
-  VERSION = "1.0.0".freeze
+  VERSION = "1.0.1".freeze
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 1
   - 0
-  - 0
-  version: 1.0.0
+  - 1
+  version: 1.0.1
 platform: ruby
 authors: 
 - thoughtbot, inc, Cyril Mougel
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-08 00:00:00 +01:00
+date: 2010-03-11 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency