errorinbox 0.0.5a → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 89adea7fd26b7749808bc4642f3948cfb058b964
-  data.tar.gz: df27ea8e1939e6a37a8d25b54e7bcefe69ec16c6
+  metadata.gz: f08056c5e1cf6d6a2e44c6975ebc3b2bf0c18ae3
+  data.tar.gz: e0eb73759a28cc103b4c0caa0c8f6c5e0ca00701
 SHA512:
-  metadata.gz: caa210c6b4980f19827cd5734ccdc14354909a1612f402a5d2408d69d55a4fc80a2389153cbe26b4caf675d5ca46597f167e6fef45f537038d9585b68b84a3e2
-  data.tar.gz: 88d6f364deaa6b7e15636d2ac65ae83853fa31f616c82b32a3298aacabf8a4db5c13059a39b71e7ac72f48c81d384360ecd0a46f4e574045d489d310ba1684c5
+  metadata.gz: f90fd70d5100bf8603ce1e1b3755fc348cc2819263c2527f8f465f607e7638680cee551e2946adca031a76bb949036ffe546cca177b4a161225b3e0694f1110d
+  data.tar.gz: 53f0bb3ae6fa6db265f8343a0b773ebdd509f409cbe0d68794050ae1c9cbcd0ed34ef8bc924ce4dc5fce777a4a48cec9d202e0489176fc87e7308f5471948740

data/lib/error_inbox/configuration.rb

@@ -3,6 +3,14 @@ module ErrorInbox
     attr_accessor :username, :password
     attr_writer :logger
 
+    def ignore_if(&block)
+      ignores << block
+    end
+
+    def ignores
+      @ignores ||= []
+    end
+
     def logger
       @logger ||= begin
         require "logger"

data/lib/error_inbox/notifier.rb

@@ -20,11 +20,16 @@ module ErrorInbox
     end
 
     def save(ex)
-      if ErrorInbox.configuration.username && ErrorInbox.configuration.password
+      if configuration.username && configuration.password
+        if ignored?(ex)
+          configuration.logger.info("#{ex.class.name}: ignored")
+          return {}
+        end
+
         response = begin
           http_request(prepare_body(ex))
         rescue *HTTP_ERRORS => ex
-          ErrorInbox.configuration.logger.error("#{ex.class.name}: #{ex.message}")
+          configuration.logger.error("#{ex.class.name}: #{ex.message}")
           nil
         end
 
@@ -32,17 +37,21 @@ module ErrorInbox
         when Net::HTTPCreated
           JSON.load(response.body)["id"]
         else
-          ErrorInbox.configuration.logger.error(response.class.name)
+          configuration.logger.error(response.class.name)
           {}
         end
       else
-        ErrorInbox.configuration.logger.error("Missing credentials configuration")
+        configuration.logger.error("Missing credentials configuration")
         {}
       end
     end
 
     protected
 
+    def ignored?(ex)
+      !!configuration.ignores.find { |blk| blk.call(ex, @options) }
+    end
+
     def prepare_body(ex)
       body = {
         :type => ex.class.name,
@@ -86,8 +95,12 @@ module ErrorInbox
       request = Net::HTTP::Post.new(uri.request_uri)
       request["Content-Type"] = "application/json"
       request.body = body
-      request.basic_auth(ErrorInbox.configuration.username, ErrorInbox.configuration.password)
+      request.basic_auth(configuration.username, configuration.password)
       http.request(request)
     end
+
+    def configuration
+      ErrorInbox.configuration
+    end
   end
 end

data/lib/error_inbox/version.rb

@@ -1,3 +1,3 @@
 module ErrorInbox
-  VERSION = "0.0.5a"
+  VERSION = "0.0.6"
 end

data/spec/error_inbox/configuration_spec.rb

@@ -0,0 +1,7 @@
+require "spec_helper"
+
+describe ErrorInbox::Configuration do
+  it "appends the block in the ignores attribute" do
+    expect { subject.ignore_if { true } }.to change{ subject.ignores.size }.from(0).to(1)
+  end
+end

data/spec/error_inbox/notifier_spec.rb

@@ -2,6 +2,8 @@ require "spec_helper"
 
 describe ErrorInbox::Notifier do
   let(:ex) { double("exception", :message => "some message", :backtrace => ["a.rb:10", "b.rb:11"]) }
+  let(:configuration) { double("configuration", :username => nil, :password => nil, :ignores => []) }
+  let(:logger) { double("logger") }
 
   around do |example|
     Timecop.travel(2013, 8, 21, 11, 57, 0) do
@@ -10,7 +12,8 @@ describe ErrorInbox::Notifier do
   end
 
   it "raises an error if credentials are missing" do
-    ErrorInbox.stub(:configuration => double("configuration", :username => nil, :password => nil, :logger => logger = double("logger")))
+    ErrorInbox.stub(:configuration => configuration)
+    configuration.stub(:logger => logger)
     logger.
       should_receive(:error).
       with("Missing credentials configuration")
@@ -20,7 +23,8 @@ describe ErrorInbox::Notifier do
   end
 
   it "raises an error if credentials are invalid" do
-    ErrorInbox.stub(:configuration => double("configuration", :username => "foo", :password => "bar", :logger => logger = double("logger")))
+    ErrorInbox.stub(:configuration => configuration)
+    configuration.stub(:username => "foo", :password => "bar", :logger => logger)
     logger.
       should_receive(:error).
       with("Net::HTTPForbidden")
@@ -31,22 +35,36 @@ describe ErrorInbox::Notifier do
     expect(notifier.save(ex)).to eq({})
   end
 
-  it "sends rack exception" do
-    ErrorInbox.stub(:configuration => double("configuration", :username => "foo", :password => "bar"))
+  context "with valid credentials" do
+    before do
+      configuration.stub(:username => "foo", :password => "bar")
 
-    stub_created_request_for_rack_exception
+      ErrorInbox.stub(:configuration => configuration)
+    end
 
-    notifier = described_class.new(:rack_env => { :foo => "bar" })
-    expect(notifier.save(ex)).to eq(1)
-  end
+    it "sends rack exception" do
+      stub_created_request_for_rack_exception
+
+      notifier = described_class.new(:rack_env => { :foo => "bar" })
+      expect(notifier.save(ex)).to eq(1)
+    end
+
+    it "sends any other exception" do
+      stub_created_request_for_any_exception
 
-  it "sends any exception" do
-    ErrorInbox.stub(:configuration => double("configuration", :username => "foo", :password => "bar"))
+      notifier = described_class.new(:sidekiq => { :queue => "default" })
+      expect(notifier.save(ex)).to eq(1)
+    end
 
-    stub_created_request_for_any_exception
+    it "does not send ignored exceptions" do
+      configuration.stub(:ignores => [proc{ |ex, o| true }], :logger => logger)
+      logger.
+        should_receive(:info).
+        with("RSpec::Mocks::Mock: ignored")
 
-    notifier = described_class.new(:sidekiq => { :queue => "default" })
-    expect(notifier.save(ex)).to eq(1)
+      notifier = described_class.new(:rack_env => { :foo => "bar" })
+      expect(notifier.save(ex)).to eq({})
+    end
   end
 
   def stub_created_request_for_rack_exception

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: errorinbox
 version: !ruby/object:Gem::Version
-  version: 0.0.5a
+  version: 0.0.6
 platform: ruby
 authors:
 - Rafael Souza
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-26 00:00:00.000000000 Z
+date: 2013-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -58,6 +58,7 @@ files:
 - lib/error_inbox/rack.rb
 - lib/error_inbox/version.rb
 - lib/errorinbox.rb
+- spec/error_inbox/configuration_spec.rb
 - spec/error_inbox/notifier_spec.rb
 - spec/error_inbox/rack_spec.rb
 - spec/error_inbox_spec.rb
@@ -77,9 +78,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>'
+  - - '>='
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.0.3
@@ -87,6 +88,7 @@ signing_key:
 specification_version: 4
 summary: Capture and send all exceptions raised by your app to errorinbox.com
 test_files:
+- spec/error_inbox/configuration_spec.rb
 - spec/error_inbox/notifier_spec.rb
 - spec/error_inbox/rack_spec.rb
 - spec/error_inbox_spec.rb