errorinbox 0.0.3a → 0.0.4a

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 3f69ae40c69fab22284b253a8dd5f20b45af1c21
+  data.tar.gz: e81ac62d271b789b435a6b8ebea43ffdb0a5eca1
+SHA512:
+  metadata.gz: 49795aee9597820e55d40273a7386d8aecf62ec7da7636154afabc1ff398a74833854db419339a7552c69d58d8b50189d1f390c3a539da983fb82e13773cd3f5
+  data.tar.gz: fcd27aad1a2abb051626c66ad5f65044769c0625a29ecdd42691ec1209aead9252ccc753aa7a3c2e29b68a6b71d27dd41b52117ac1a5076a66453428610eab27

data/lib/error_inbox/configuration.rb

@@ -1,5 +1,13 @@
 module ErrorInbox
   class Configuration
     attr_accessor :username, :password
+    attr_writer :logger
+
+    def logger
+      @logger ||= begin
+        require "logger"
+        Logger.new(STDOUT)
+      end
+    end
   end
 end

data/lib/error_inbox/notifier.rb

@@ -3,31 +3,41 @@ require "json"
 
 module ErrorInbox
   class Notifier
+    HTTP_ERRORS = [
+      Timeout::Error,
+      Errno::EINVAL,
+      Errno::ECONNRESET,
+      EOFError,
+      Net::HTTPBadResponse,
+      Net::HTTPHeaderSyntaxError,
+      Net::ProtocolError,
+      Errno::ECONNREFUSED,
+      OpenSSL::SSL::SSLError
+    ].freeze
+
     def initialize(options)
       @options = options.dup
     end
 
     def save(ex)
-      unless ErrorInbox.configuration.username && ErrorInbox.configuration.password
-        raise MissingCredentialsError
-      end
-
-      uri = URI("http://oops.errorinbox.com/")
-      req = Net::HTTP::Post.new(uri.path)
-      req.basic_auth(ErrorInbox.configuration.username, ErrorInbox.configuration.password)
-      req["Content-Type"] = "application/json"
-      req.body = prepare_body(ex)
-      res = Net::HTTP.start(uri.host, uri.port) do |http|
-        http.request(req)
-      end
+      if ErrorInbox.configuration.username && ErrorInbox.configuration.password
+        response = begin
+          http_request(prepare_body(ex))
+        rescue *HTTP_ERRORS => ex
+          ErrorInbox.configuration.logger.error("#{ex.class.name}: #{ex.message}")
+          nil
+        end
 
-      case res
-      when Net::HTTPCreated
-        JSON.load(res.body)["id"]
-      when Net::HTTPForbidden
-        raise InvalidCredentialsError
+        case response
+        when Net::HTTPCreated
+          JSON.load(response.body)["id"]
+        else
+          ErrorInbox.configuration.logger.error(response.class.name)
+          {}
+        end
       else
-        raise "Unknow error: #{res}"
+        ErrorInbox.configuration.logger.error("Missing credentials configuration")
+        {}
       end
     end
 
@@ -66,5 +76,18 @@ module ErrorInbox
 
       JSON.dump(body)
     end
+
+    def http_request(body)
+      uri = URI("http://oops.errorinbox.com/")
+      http = Net::HTTP.new(uri.host, uri.port)
+      http.read_timeout = 5
+      http.open_timeout = 2
+
+      request = Net::HTTP::Post.new(uri.request_uri)
+      request["Content-Type"] = "application/json"
+      request.body = body
+      request.basic_auth(ErrorInbox.configuration.username, ErrorInbox.configuration.password)
+      http.request(request)
+    end
   end
 end

data/lib/error_inbox/version.rb

@@ -1,3 +1,3 @@
 module ErrorInbox
-  VERSION = "0.0.3a"
+  VERSION = "0.0.4a"
 end

data/spec/error_inbox/notifier_spec.rb

@@ -10,19 +10,25 @@ describe ErrorInbox::Notifier do
   end
 
   it "raises an error if credentials are missing" do
-    ErrorInbox.stub(:configuration => double("configuration", :username => nil, :password => nil))
+    ErrorInbox.stub(:configuration => double("configuration", :username => nil, :password => nil, :logger => logger = double("logger")))
+    logger.
+      should_receive(:error).
+      with("Missing credentials configuration")
 
     notifier = described_class.new(:rack_env => { :foo => "bar" })
-    expect { notifier.save(ex) }.to raise_error(ErrorInbox::MissingCredentialsError)
+    expect(notifier.save(ex)).to eq({})
   end
 
   it "raises an error if credentials are invalid" do
-    ErrorInbox.stub(:configuration => double("configuration", :username => "foo", :password => "bar"))
+    ErrorInbox.stub(:configuration => double("configuration", :username => "foo", :password => "bar", :logger => logger = double("logger")))
+    logger.
+      should_receive(:error).
+      with("Net::HTTPForbidden")
 
     stub_forbidden_request
 
     notifier = described_class.new(:rack_env => { :foo => "bar" })
-    expect { notifier.save(ex) }.to raise_error(ErrorInbox::InvalidCredentialsError)
+    expect(notifier.save(ex)).to eq({})
   end
 
   it "sends rack exception" do

metadata

@@ -1,20 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: errorinbox
 version: !ruby/object:Gem::Version
-  version: 0.0.3a
-  prerelease: 5
+  version: 0.0.4a
 platform: ruby
 authors:
 - Rafael Souza
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-23 00:00:00.000000000 Z
+date: 2013-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -30,17 +27,15 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Send exceptions to errorinbox.com
@@ -70,30 +65,26 @@ files:
 homepage: http://github.com/rafaelss/errorinbox
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -1856483604331423650
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>'
+  - - '>'
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Capture and send all exceptions raised by your app to errorinbox.com
 test_files:
 - spec/error_inbox/notifier_spec.rb