error_page_assets 0.1 → 0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 16bbd1059b6b3587f6f2a9255a4b5b99b2c92303
-  data.tar.gz: 6518f7a7f144ae70e68d0b00070dadf45195ec62
+  metadata.gz: c94f48a67e85f4d220fc08f05f865f51acde686c
+  data.tar.gz: 0e48288914c588abadc2a62f6060a021e3635724
 SHA512:
-  metadata.gz: a1eeab19d61714b3f5c6205cadeec29aea56c6014a0929679cda84d92295173fb0815edc0077c1adc927b143dea9338066e77d1b043d71c051d68ec6e6cd6e12
-  data.tar.gz: a4eb0112a9f0dc5751572f45e1908db88fc2fa1fa1357333e21aed505ad1eb2cbfce8a01fd8871b3a3e0db2f6564274b5cc341a459dc3304bd9f506609ddaaf5
+  metadata.gz: 9bf39fb7184d1c9eebbc15cbf965439a0088a05f064cb0b1a00e51570ae65a008b771048f7a30b8a4f8d3928bc83a616e6ce02e7867171045bb729bb8daaea46
+  data.tar.gz: b953fe9850e031dace399c59129b40ab4bab79fc17ea801e53ff34f50ff0a211bad268077f173c432fe9e768f941319e1f0b01ee5d7bfb470ea7c85b6096558a

data/README.md

@@ -38,12 +38,12 @@ config.assets.precompile += %w[404.html 422.html 500.html]
 ## Usage
 
 Whenever assets are precompiled (i.e. during each deploy),
-your error pages will be generated and dropped into `/public`.
+your error pages will be generated and saved in `/public`.
 
 ```sh
-# public/404.html doesn't exist
+# (public/404.html doesn't exist)
 rails assets:precompile
-# public/404.html exists and includes your most recent code
+# (public/404.html is your newest code)
 ```
 
 Your error pages are automatically generated along with the

data/lib/error_page_assets/version.rb

@@ -1,3 +1,3 @@
 module ErrorPageAssets
-  VERSION = "0.1"
+  VERSION = "0.2"
 end

data/lib/tasks/error_page_assets.rake

@@ -8,27 +8,43 @@ Rake::Task['assets:precompile'].enhance do
   Rake::Task['assets:precompile:error_pages'].invoke
 end
 
+Rake::Task['assets:clobber'].enhance ['assets:clobber:error_pages']
+
+
 namespace :assets do
-  namespace :precompile do
-    def log msg
-      # try to log like Sprockets even though their stuff is all private
-      STDERR.puts msg
-      Rails.logger.info(msg) if Rails.respond_to?(:logger)
+  def log msg
+    # try to log like Sprockets even though their stuff is all private
+    STDERR.puts msg
+    Rails.logger.info(msg) if Rails.respond_to?(:logger) && Rails.logger
+  end
+
+  def process_error_files
+    pattern = Rails.root.join('public', 'assets', "[0-9][0-9][0-9]*.html")
+    groups = Dir[pattern].group_by { |s| File.basename(s)[0..2] }
+    groups.sort_by { |base,_| base }.each do |base, group|
+      src = group.sort_by { |f| File.mtime(f) }.last
+      dst = Rails.root.join('public', "#{base}.html")
+      yield src, dst
     end
+  end
 
-    def copy_error_files
-      pattern = Rails.root.join('public', 'assets', "[0-9][0-9][0-9]*.html")
-      groups = Dir[pattern].group_by { |s| File.basename(s)[0..2] }
-      groups.sort_by { |base,_| base }.each do |base, group|
-        latest = group.sort_by { |f| File.mtime(f) }.last
-        log "copy #{latest} to public/#{base}.html"
-        FileUtils.cp latest, Rails.root.join('public', "#{base}.html")
+  namespace :precompile do
+    desc 'Copy the newest error page assets into /public'
+    task :error_pages do
+      process_error_files do |src,dst|
+        log "copy #{src} to #{dst}"
+        FileUtils.cp src, dst
       end
     end
+  end
 
-    desc 'Copies the newest error pages into /public'
+  namespace :clobber do
+    desc 'Remove the error page assets in /public'
     task :error_pages do
-      copy_error_files
+      process_error_files do |src,dst|
+        log "clobber #{dst}"
+        FileUtils.rm_f dst
+      end
     end
   end
 end

data/spec/error_page_assets_spec.rb

@@ -1,30 +1,35 @@
 require 'rake'
 
 describe 'assets:precompile:error_pages' do
-  before do
-    # load rake task
+  before(:all) do
     Rake.application = Rake::Application.new
     Rake.application.rake_require('stub_assets_precompile', ['spec'])
     Rake.application.rake_require('error_page_assets', ['lib/tasks'])
+  end
 
+  before do
     # allow rake task to call Rails.root.join
     stub_const('Rails', Class.new)
     allow(Rails).to receive_message_chain(:root, :join) { |*args| File.join('spec', *args) }
-  end
 
-  it "copies the error pages" do
     # ensure the rake task uses the most recent asset file
     expect(File).to receive(:mtime).with('spec/public/assets/404-digestnew.html').and_return(Time.now)
     expect(File).to receive(:mtime).with('spec/public/assets/404-digestold.html').and_return(Time.now - 3600)
     expect(File).to receive(:mtime).with('spec/public/assets/500.html').and_return(Time.now)
 
-    # ensure the rake task doesn't actually perform the copies
-    expect(FileUtils).to receive(:cp).with('spec/public/assets/404-digestnew.html', 'spec/public/404.html')
-    expect(FileUtils).to receive(:cp).with('spec/public/assets/500.html', 'spec/public/500.html')
-
     # suppress our logging while testing
     expect(STDERR).to receive(:puts).twice
+  end
+
+  it "copies the error pages" do
+    expect(FileUtils).to receive(:cp).with('spec/public/assets/404-digestnew.html', 'spec/public/404.html')
+    expect(FileUtils).to receive(:cp).with('spec/public/assets/500.html', 'spec/public/500.html')
+    Rake.application['assets:precompile'].invoke
+  end
 
-    Rake.application['assets:precompile:error_pages'].invoke
+  it "clobbers the error pages" do
+    expect(FileUtils).to receive(:rm_f).with('spec/public/404.html')
+    expect(FileUtils).to receive(:rm_f).with('spec/public/500.html')
+    Rake.application['assets:clobber'].invoke
   end
 end

data/spec/stub_assets_precompile.rake

@@ -1,6 +1,9 @@
 namespace :assets do
   desc 'stubs assets:precompile for testing'
   task :precompile do
-    puts 'precompiling'
+  end
+
+  desc 'stubs assets:clobber for testing'
+  task :clobber do
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: error_page_assets
 version: !ruby/object:Gem::Version
-  version: '0.1'
+  version: '0.2'
 platform: ruby
 authors:
 - Scott Bronson