error_log 0.0.2 → 0.0.5

data/Changelog.txt

@@ -0,0 +1,15 @@
+0.0.5 
+	 * haml dependency added (sorry folks, I could not stand rhtml
+	 * viewing archive
+	 * selecting sort order 
+	 * proper group by
+
+0.0.4
+   * marking single errros as read
+
+0.0.3
+   * very unmatura error params introduced
+
+0.0.2
+   Basic skeleton
+   * errors can be browsed already, grouped by error string and category

data/README.txt

@@ -8,7 +8,7 @@ Easy way to track exceptions and warnings in your rails app
 It's still just a skeleton.
 More description and documentation will come.. one day.. I guess.
 
-THIS IS DEVELOPMENT VERSION, DO NOT EVEN TOUCH PRODUCTION SERVER WITH IT.
+THIS IS AN EARLY DEVELOPMENT VERSION, DO NOT EVEN TOUCH PRODUCTION SERVER WITH IT.
 Actually, it is so unmature that even playing with it can make you sad.
 And no one likes to be sad.
 
@@ -53,14 +53,15 @@ To be continued.
 
 == TODOS
 
+* git (and other VCS) awareness
+* better params viewing (currently only example params)
 * setting error level threshold while browsing
-* nicer browsing (themes would be good, but I really do not like css so help needed)
+* better look (themes would be good, but I really do not like css, so help needed)
 * adding errors to ignore list
-* alternative errors storage (for database failures, maybe just some sqlite?)
+* pagination could by nice ;) (it ain't actually so bad without it thanks to grouping)
+* alternative errors storage (for database failures, probably sqlite will do)
 * clickable backtraces? we could show some code
 * rails 2.x compatibility
-* marking single errors as read, browsing archive
-* bugfixes, lots of
 
 == STUFF
 

data/lib/error_log/controller.rb

@@ -1,57 +1,125 @@
 
+
+require 'haml'
+
 module ErrorLog
-   module Controller# < ActionController::Base
-
-      def index
-
-         # Rails 2.x compatible finder
-         scope = ErrorLog::Model
-
-         unless params[:errors_category].to_s.empty?
-            @errors_category = params[:errors_category]
-            scope = scope.where(:category => @errors_category)
-         end
-         
-         @error_logs = scope.all(
-            :order => 'created_at DESC', 
-            :conditions => {
-               :viewed => false
-            }
-         ).group_by(&:error_hash)
-
-         @category_counts = ErrorLog::Model.count(
-            :conditions => {:viewed => false},
-            :group => :category 
-         )
-
-         render :template => '/index'
+  module Controller
+
+    def index
+
+      prepare_opts
+
+      scope = ErrorLog::Model
+
+      scope = scope.where(:category => @errors_category) unless @errors_category.to_s.empty? 
+
+      @error_logs = scope.all(
+        :select => 'count(*) as count_all,
+           min(created_at) as created_at_first, 
+           max(created_at) as created_at_last,
+           min(backtrace) as backtrace,
+           min(error) as error,
+           min(category) as category,
+           min(params) as params,
+           max(level_id) as level_id,
+           error_hash',
+        :order => @opts[:sort_by],
+        :group => 'error_hash',
+        :conditions => {
+        :viewed => viewing_archive? 
+      })
+
+
+      @category_counts = ErrorLog::Model.count(
+        :conditions => {:viewed => viewing_archive?},
+        :group => :category 
+      )
+
+      render :template => '/index'
+    end
+
+    def set_all_viewed
+      ErrorLog::Model.update_all(:viewed => true)
+      redirect_to :back
+    end
+
+    def delete_all_archived
+      ErrorLog::Model.where(:viewed => true).destroy_all
+      redirect_to :back
+    end
+
+    # set all logs with given error hash viewed
+    def set_viewed
+      logs = ErrorLog::Model.where(:viewed => false, :error_hash => params[:error_hash])
+      logs.update_all(:viewed => true)
+      render :update do |page|
+        page[params[:row_div_id]].hide
       end
+    end
 
-      def set_all_viewed
-         ErrorLog::Model.update_all(:viewed => true)
-         redirect_to :back
+    # destroy all archived logs with given error hash
+    def delete
+      logs = ErrorLog::Model.where(:viewed => true, :error_hash => params[:error_hash])
+      logs.destroy_all
+      render :update do |page|
+        page[params[:row_div_id]].hide
       end
+    end
+
+    protected
+
+    def viewing_archive?
+      @opts[:archive] == '1'
+    end
+
+    def self.included(klass)
+      klass.send(:helper_method,:viewing_archive?)
+    end
 
-   end
+    def prepare_opts
+      sorts = {
+        'last' => 'created_at_last DESC',
+        'first' => 'created_at_first DESC',
+        'count' => 'count_all DESC',
+        'level' => 'level_id DESC',
+        'level_count' => 'level DESC, count_all DESC'
+      }
+
+      @opts = {
+        :archive => '0',
+        :sort_by => sorts['last'],
+        :category => nil
+      }
+
+      session[:erlgs_archive] = params[:archive] if params[:archive] 
+      @opts[:archive] = session[:erlgs_archive]
+
+      session[:erlgs_sort_by] = params[:sort_by] if params[:sort_by]
+      @opts[:sort_by] = sorts[session[:erlgs_sort_by]]
+
+      session[:erlgs_category] = params[:category] if params[:category]
+      @opts[:category] = @errors_category = session[:erlgs_category]
+    end
+  end
 end
 
 class ActionController::Base
 
-   rescue_from Exception, :with => :error_log_rescue
+  rescue_from Exception, :with => :error_log_rescue
 
-   def self.error_logs
-      append_view_path File.join(ErrorLog.path,'views')
-      self.send(:include,ErrorLog::Controller) 
-   end
+  def self.error_logs
+    append_view_path File.join(ErrorLog.path,'views')
+    self.send(:include,ErrorLog::Controller) 
+  end
 
-   def error_log_rescue(e)
-      err = ErrorLog::Model.new(
-        :error => e.to_str,
-        :backtrace => e.backtrace,
-        :category => 'rails'
-      )
-      err.save
-      raise e 
-   end
+  def error_log_rescue(e)
+    err = ErrorLog::Model.new(
+      :error => e.to_str,
+      :backtrace => e.backtrace,
+      :category => 'rails'
+    )
+    err.save
+    raise e 
+  end
 
 end

data/lib/error_log/core_ext.rb

@@ -8,12 +8,10 @@ class Object
          yield
          return false
       rescue Exception => e
-         ErrorLog::Model.create(
-           :error => e.to_str,
-           :backtrace => e.backtrace,
-           :level => (options[:level] || :error),
-           :category => category
-         )
+         ErrorLog.log(options[:level] || :error, e.to_str,
+            :backtrace => e.backtrace,
+            :params => options[:params],
+            :category => category)
       end
    end
 

data/lib/error_log/migrations.rb

@@ -0,0 +1,26 @@
+module ErrorLog
+
+  class Migration < ActiveRecord::Migration
+    def self.up
+      create_table :error_logs do |t|
+        t.text :error
+        t.text :backtrace
+        t.string :category
+        # note to future me: "hash" is a really bad name for the column
+        t.string :error_hash
+        t.integer :level_id
+        t.timestamp :created_at
+        t.boolean :viewed, :default => false
+      end
+
+      add_index :error_hash, :category
+    end
+  end 
+
+  class UpgradeMigration1 < ActiveRecord::Migration
+    def self.up
+      add_column :error_logs, :params, :text
+    end
+  end
+
+end

data/lib/error_log/model.rb

@@ -3,24 +3,18 @@ require 'digest/md5'
 module ErrorLog
    class Model < ActiveRecord::Base
 
-      class Migration < ActiveRecord::Migration
-         def self.up
-            create_table :error_logs do |t|
-               t.text :error
-               t.text :backtrace
-               t.string :category
-               # note to future me: "hash" is a really bad name for the column
-               t.string :error_hash
-               t.integer :level_id
-               t.timestamp :created_at
-               t.boolean :viewed, :default => false
-            end
-         end
-      end 
-
       self.table_name = 'error_logs'
+
+      # Migrate database if needed
       unless self.table_exists? 
          Migration.up
+         reset_column_information
+      end
+
+      # Upgrade if needed
+      unless column_names.include?('params')
+         UpgradeMigration1.up
+         reset_column_information
       end
 
       LEVELS = {
@@ -33,6 +27,9 @@ module ErrorLog
          :wtf   => 5
       }
 
+      serialize :params, Hash
+      attr_accessor :count # used in grouping 
+
       def level
          LEVELS.invert[self.level_id]
       end

data/lib/error_log/version.rb

@@ -1,3 +1,3 @@
 module ErrorLog
-   VERSION = "0.0.2" unless defined?(::ErrorLog::VERSION)
+   VERSION = "0.0.5" unless defined?(::ErrorLog::VERSION)
 end

data/lib/error_log.rb

@@ -1,3 +1,4 @@
+require 'pp'
 
 module ErrorLog
 
@@ -59,6 +60,34 @@ module ErrorLog
     Dir.glob(search_me).sort.each {|rb| require rb}
   end
 
+
+  def self.log(level,error,options={})
+    backtrace = options[:backtrace]
+    unless backtrace
+       # get current backtrace, I'm happy to learn any more clever way
+       begin
+         raise "wat?!"
+       rescue Exception => e
+         backtrace = e.backtrace[1..-1]
+       end
+    end
+
+    #TODO: silent rescues may not be optimal, for now they seem better than creating more mess
+    logger.error "\n\n\n#{Time.now}\n= #{error}\n#{backtrace.join("\n")}\n#{options[:params]}" rescue nil
+
+    ErrorLog::Model.create(
+      :error => error,
+      :backtrace => backtrace,
+      :level => level,
+      :params => options[:params],
+      :category => options[:category] || 'error_log'
+    ) rescue nil 
+  end
+
+  def self.logger
+     @logger = Logger.new(File.join(Rails.root,'log','error.log'))
+  end
+
 end  # module ErrorLog
 
 

data/views/_error_log.html.haml

@@ -0,0 +1,51 @@
+- row_div_id = "error_log_row_#{error_log.error_hash}" 
+
+%tr{:class => cycle('odd','even'), :id => row_div_id}
+  %td 
+    %div{:class => "level_box level_#{error_log.level}"}
+      = error_log.level
+    %span.time
+      -# when using select, activerecord returns strings only
+      = Time.parse(error_log.created_at_last).strftime('%Y-%m-%d %H:%M')
+      %span{:style => 'color: #7a7'}
+        (#{distance_of_time_in_words error_log.created_at_last,Time.now} ago) 
+    %br 
+    %br
+    [#{error_log.category}]
+    %b= error_log.error
+    %br 
+    %br
+
+    -# Repeated N times
+    - if error_log.count_all.to_i > 1
+      %div{:style => "text-align: center; clear: both"}
+        Repeated 
+        %b
+          %span{:style => "font-size: #{[12 + error_log.count_all.to_i,100].min}px;"}
+            = error_log.count_all
+        times.
+        %br
+        %span.time_first{:style => 'color: #aaa'}
+          %i in the last #{distance_of_time_in_words error_log.created_at_first,Time.now}
+
+    -# error params if logged     
+    - if error_log.params && !error_log.params.empty? 
+      %br
+      example params:
+      %pre
+        = error_log.params.pretty_inspect 
+
+    -# backtrace
+    - bt = error_log.backtrace.split("\n") 
+    %div.backtrace 
+      = raw bt[0...3].join(" <br />") 
+      - if bt.size > 4 
+        - bid = "error_log_bt_#{error_log.id}" 
+        = link_to_function '...', "$('#{bid}').show();" 
+        %span{:style => "display: none", :id => bid}
+          = raw bt[4...-1].join(" <br />")                  
+    %span.actions
+      - if viewing_archive? 
+        = link_to('delete premamently', { :action => :delete, :error_hash => error_log.error_hash, :row_div_id => row_div_id }, :remote => true, :onclick => "this.innerHTML = 'wait for it...';")
+      - else
+        = link_to('mark as read', { :action => :set_viewed, :error_hash => error_log.error_hash, :row_div_id => row_div_id }, :remote => true, :onclick => "this.innerHTML = 'wait for it...';")

data/views/_styles.html.erb

@@ -0,0 +1,69 @@
+
+<style type="text/css">
+
+   #error_logs_wrap td {
+      padding: 15px;
+   }
+
+   #error_logs tr.odd {
+      background-color: #fefefe;
+   }
+
+   #error_logs tr.even {
+      background-color: #f5f5f5;
+   }
+
+   table#error_logs {
+      border: 1px solid #333;
+      width: 100%;
+      border-collapse: collapse;
+   }
+
+   table#error_logs td {
+      border: 1px solid #999;
+      padding: 10px;
+      font-family: Verdana;
+   }
+
+   table#error_logs .level_error {
+      background-color: #ffa;
+   }
+
+   table#error_logs .level_fatal {
+      background-color: #f99;
+   }
+
+   table#error_logs .level_warn {
+      background-color: #9c9;
+   }
+   
+   table#error_logs .level_box {
+      border: 1px solid #333;
+      padding: 10px;
+      font-weight: bold;
+      float: right;
+      margin: 20px;
+   }
+
+   table#error_logs .backtrace {
+      overflow: hidden;
+      width: 100%;
+      font-family: Monospace;
+      font-size: 0.9em;
+      color: #855;
+   }
+
+   table#error_logs .time {
+      font-size: 0.7em;
+      font-style: italic;
+   }
+
+   table#error_logs .actions {
+      font-size: 0.7em;
+   }
+
+   table#error_logs .time_first {
+     font-size: 0.7em;
+   }
+
+</style>

data/views/index.html.haml

@@ -0,0 +1,42 @@
+= render :partial => '/styles'
+%h1 Error logs #{viewing_archive? ? '[archive]' : ''}
+
+- form_tag({},:method => :get) do
+  sort by: 
+  = select_tag(:sort_by, options_for_select([['last error','last'],
+    ['first error','first'],
+    ['errors count','count'],
+    ['level','level'],
+    ['level then count','level_count']],
+    session[:erlgs_sort_by]), :onchange => 'this.form.submit();' )
+
+%div{:style => 'text-align: right'}
+  - if viewing_archive?  
+    = button_to "Delete all archived", :action => 'delete_all_archived' 
+  - else
+    = button_to "Mark all as read", :action => 'set_all_viewed' 
+%br
+
+-# Hell I love table layouts 
+%table#error_logs_wrap
+  %tr
+    %td{:valign=>"top"}
+      %b Categories:
+      %ul
+        %li
+          = link_to_if @errors_category, 'all', :action => :index 
+          (#{@category_counts.values.sum})
+        - @category_counts.each_pair do |category,count| 
+          %li
+            #{link_to_if (@errors_category != category), category, :action => :index, :category => category} (#{count})
+      %br 
+      %br 
+      %br 
+      - if viewing_archive? 
+        = link_to 'view current', :archive => '0'
+      - else
+        = link_to 'view archive', :archive => '1'
+    %td 
+      %table#error_logs
+        - @error_logs.each do |error_log| 
+          = render :partial => '/error_log', :locals => {:error_log => error_log} 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: error_log
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 21
   prerelease: false
   segments: 
   - 0
   - 0
-  - 2
-  version: 0.0.2
+  - 5
+  version: 0.0.5
 platform: ruby
 authors: 
 - Kacper Ciesla
@@ -15,10 +15,23 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-08-07 00:00:00 +02:00
+date: 2010-11-17 00:00:00 +01:00
 default_executable: 
-dependencies: []
-
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: haml
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :runtime
+  version_requirements: *id001
 description: Who cares about description, nobody reads it anyway.
 email: 
 - kacper.ciesla@gmail.com
@@ -34,8 +47,12 @@ files:
 - lib/error_log/model.rb
 - lib/error_log/controller.rb
 - lib/error_log/core_ext.rb
-- views/index.html.erb
+- lib/error_log/migrations.rb
+- views/index.html.haml
+- views/_styles.html.erb
+- views/_error_log.html.haml
 - README.txt
+- Changelog.txt
 has_rdoc: true
 homepage: 
 licenses: []

data/views/index.html.erb

@@ -1,119 +0,0 @@
-
-<%# I'm sorry but view ain't beautiful quite yet. It will probably be totally rewritten %>
-
-<style type="text/css">
-   #error_logs tr.odd {
-      background-color: #fefefe;
-   }
-
-   #error_logs tr.even {
-      background-color: #f5f5f5;
-   }
-
-   table#error_logs {
-      border: 1px solid #333;
-      width: 100%;
-      border-collapse: collapse;
-   }
-
-   table#error_logs td {
-      border: 1px solid #999;
-      padding: 10px;
-      font-family: Verdana;
-   }
-
-   table#error_logs .level_error {
-      background-color: #ffa;
-   }
-
-   table#error_logs .level_fatal {
-      background-color: #f99;
-   }
-
-   table#error_logs .level_warn {
-      background-color: #9c9;
-   }
-   
-   table#error_logs .level_box {
-      border: 1px solid #333;
-      padding: 10px;
-      font-weight: bold;
-      float: right;
-      margin: 20px;
-   }
-
-   table#error_logs .backtrace {
-      overflow: auto;
-      font-family: Monospace;
-      font-size: 0.9em;
-      color: #999;
-   }
-
-   table#error_logs .time {
-      font-size: 0.7em;
-      font-style: italic;
-   }
-
-
-</style>
-
-<h1>Error logs</h1>
-
-<div align="right">
-   <%= button_to "Mark all as read", :action => 'set_all_viewed' %>
-</div>
-<br />
-
-<!-- Hell I love table layouts -->
-<table style="width: 100%" cellpadding="10">
-   <tr><td valign="top">
-     <ul>
-           <li>
-             <%= link_to_if @errors_category, 'all', :action => :index %> (<%= @category_counts.values.sum %>)
-           </li>
-        <% @category_counts.each_pair do |category,count| %>
-           <li>
-             <%= link_to_if (@errors_category != category), category, :action => :index, :errors_category => category %>&nbsp;(<%= count %>)
-           </li>
-        <% end %>
-     </ul>
-   </td><td>
-
-<table id="error_logs">
-   <% @error_logs.each_pair do |hash,logs| %>
-      <% error_log = logs.first %>
-      <tr class="<%= cycle('odd','even') %>">
-         <td>
-            <div class="level_box level_<%= error_log.level %>">
-               <%= error_log.level %>
-            </div>
-
-            <span class="time"><%= error_log.created_at %></span>
-            <br />
-            [<%= error_log.category %>]
-            <b><%= error_log.error %></b> 
-            <br />
-
-            <% if logs.count > 1 %>
-               <div style="text-align: center">
-                  Repeated <b><span style="font-size: <%= [12 + logs.count,100].min %>px;"><%= logs.count %></span></b> times.<br />
-               </div>
-            <% end %>
-            
-            <br />
-            <% bt = error_log.backtrace.split("\n") %>
-            <div class="backtrace">
-                  <%= bt[0...3].join("\n") %>                  
-                  <% bid = "error_log_bt_#{error_log.id}" %>
-                  <%= link_to_function '...', "$('#{bid}').show();" %>
-                  <span style="display: none" id="<%= bid %>">
-                     <%= bt[4...-1].join("\n") %>                  
-                  </span>
-            </div>
-         </tr>
-      </tr>
-   <% end %>
-</table>
-
-</td></tr>
-</table>