errbit_plugin 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e4044ee01410119ca8ab10ffe1f89415708d2ed9
-  data.tar.gz: faf743c3c52f8e137b9c942dca93abd848e822b8
+  metadata.gz: 4d05454acc287bd01a03cc51cc416ecacecd7abd
+  data.tar.gz: 10b79b6950d22e639c8a08cc69c4bcee94fde6af
 SHA512:
-  metadata.gz: 985d669a9c92db0ac0aea134d4baa62a1147297eae05e15731887f6a40e0e93fade1f139ace6ed8f40bdc901d5d46530ddcc9a7430ec8decb5b9af414c7e4f04
-  data.tar.gz: 3a87f4b41d2ba9135a8200dd639e754d4e9a0f53dd7647e8f3272530982f932e075e89e0289696910310f763470ad2b42d3fd43a8a07929100423791dc52e083
+  metadata.gz: 1f4ef882ae3e1ffc5f3ecde93339d7f032c52a19d58d5e0ee29dee621a2ef4c48a245ed8993b5b7e758bbc865bd4390e00140830db351335ff1860eb9583a8dc
+  data.tar.gz: 0da44f3a335b6fa3b1e44e1e5ff47b2daf5a88b7085e0cbc38d8ef9159cfe30f11be229ca739dad982fc4fa324e2e075893bcaa97836627c0d22426cfbd5c0d1

data/lib/errbit_plugin.rb

@@ -1,5 +1,5 @@
 require "errbit_plugin/version"
-require "errbit_plugin/register_plugin"
+require "errbit_plugin/registry"
 require "errbit_plugin/issue_tracker"
 require "errbit_plugin/validate_issue_tracker"
 require "errbit_plugin/issue_trackers/none"

data/lib/errbit_plugin/{register_plugin.rb → registry.rb}

@@ -22,6 +22,10 @@ module ErrbitPlugin
       end
     end
 
+    def self.clear_issue_trackers
+      @issue_trackers = {}
+    end
+
     def self.issue_trackers
       @issue_trackers
     end

data/lib/errbit_plugin/version.rb

@@ -1,3 +1,3 @@
 module ErrbitPlugin
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/errbit_plugin/{register_plugin_spec.rb → registry_spec.rb}

@@ -1,30 +1,39 @@
 require 'spec_helper'
 
-describe ErrbitPlugin::Register do
+describe ErrbitPlugin::Registry do
   before do
-    ErrbitPlugin::Register.clear
+    ErrbitPlugin::Registry.clear_issue_trackers
   end
 
+  let(:tracker) {
+    tracker = Class.new(ErrbitPlugin::IssueTracker) do
+      def self.label
+        'something'
+      end
+    end
+    tracker
+  }
+
   describe ".add_issue_tracker" do
     context "with issue_tracker class valid" do
       before do
         allow(ErrbitPlugin::ValidateIssueTracker)
           .to receive(:new)
-          .with(ErrbitPlugin::IssueTracker)
+          .with(tracker)
           .and_return(double(:valid? => true, :message => ''))
       end
       it 'add new issue_tracker plugin' do
-        ErrbitPlugin::Register.add_issue_tracker('foo', ErrbitPlugin::IssueTracker)
-        expect(ErrbitPlugin::Register.issue_trackers).to eq({
-          'foo' => ErrbitPlugin::IssueTracker
+        ErrbitPlugin::Registry.add_issue_tracker(tracker)
+        expect(ErrbitPlugin::Registry.issue_trackers).to eq({
+          'something' => tracker
         })
       end
       context "with already issue_tracker with this key" do
-        it 'raise ErrbitPlugin::IncompatibilityError' do
-          ErrbitPlugin::Register.add_issue_tracker('foo', ErrbitPlugin::IssueTracker)
+        it 'raise ErrbitPlugin::AlreadyRegisteredError' do
+          ErrbitPlugin::Registry.add_issue_tracker(tracker)
           expect {
-            ErrbitPlugin::Register.add_issue_tracker('foo', ErrbitPlugin::IssueTracker)
-          }.to raise_error(ErrbitPlugin::IncompatibilityError)
+            ErrbitPlugin::Registry.add_issue_tracker(tracker)
+          }.to raise_error(ErrbitPlugin::AlreadyRegisteredError)
         end
       end
     end
@@ -33,21 +42,21 @@ describe ErrbitPlugin::Register do
       it 'raise an IncompatibilityError' do
         allow(ErrbitPlugin::ValidateIssueTracker)
           .to receive(:new)
-          .with(ErrbitPlugin::IssueTracker)
+          .with(tracker)
           .and_return(double(:valid? => false, :message => 'foo', :errors => []))
         expect {
-          ErrbitPlugin::Register.add_issue_tracker('foo', ErrbitPlugin::IssueTracker)
+          ErrbitPlugin::Registry.add_issue_tracker(tracker)
         }.to raise_error(ErrbitPlugin::IncompatibilityError)
       end
 
       it 'puts the errors in the exception message' do
         allow(ErrbitPlugin::ValidateIssueTracker)
           .to receive(:new)
-          .with(ErrbitPlugin::IssueTracker)
+          .with(tracker)
           .and_return(double(:valid? => false, :message => 'foo', :errors => ['one', 'two']))
 
         begin
-          ErrbitPlugin::Register.add_issue_tracker('foo', ErrbitPlugin::IssueTracker)
+          ErrbitPlugin::Registry.add_issue_tracker(tracker)
         rescue ErrbitPlugin::IncompatibilityError => e
           expect(e.message).to eq('one; two')
         end

data/spec/errbit_plugin/validate_issue_tracker_spec.rb

@@ -9,7 +9,7 @@ describe ErrbitPlugin::ValidateIssueTracker do
         def self.note; 'foo'; end
         def self.fields; ['foo']; end
         def configured?; true; end
-        def check_params; true; end
+        def errors; true; end
         def create_issue; 'http'; end
         def url; 'http'; end
         def comments_allowed?; false; end
@@ -27,7 +27,7 @@ describe ErrbitPlugin::ValidateIssueTracker do
         def self.note; 'foo'; end
         def self.fields; ['foo']; end
         def configured?; true; end
-        def check_params; true; end
+        def errors; true; end
         def create_issue; 'http'; end
         def url; 'http'; end
         def comments_allowed?; false; end
@@ -49,7 +49,7 @@ describe ErrbitPlugin::ValidateIssueTracker do
         def note; 'foo'; end
         def fields; ['foo']; end
         def configured?; true; end
-        def check_params; true; end
+        def errors; true; end
         def create_issue; 'http'; end
         def url; 'http'; end
         def comments_allowed?; false; end
@@ -71,7 +71,7 @@ describe ErrbitPlugin::ValidateIssueTracker do
         def self.label; 'foo'; end
         def note; 'foo'; end
         def configured?; true; end
-        def check_params; true; end
+        def errors; true; end
         def create_issue; 'http'; end
         def url; 'http'; end
         def comments_allowed?; false; end
@@ -93,7 +93,7 @@ describe ErrbitPlugin::ValidateIssueTracker do
         def label; 'foo'; end
         def note; 'foo'; end
         def fields; ['foo']; end
-        def check_params; true; end
+        def errors; true; end
         def create_issue; 'http'; end
         def url; 'http'; end
         def comments_allowed?; false; end
@@ -110,7 +110,7 @@ describe ErrbitPlugin::ValidateIssueTracker do
       end
     end
 
-    context "without check_params method" do
+    context "without errors method" do
       class BazCheckParams < ErrbitPlugin::IssueTracker
         def label; 'foo'; end
         def note; 'foo'; end
@@ -125,10 +125,10 @@ describe ErrbitPlugin::ValidateIssueTracker do
         expect(ErrbitPlugin::ValidateIssueTracker.new(BazCheckParams).valid?).to be false
       end
 
-      it 'say not implement check_params' do
+      it 'say not implement errors' do
         is = ErrbitPlugin::ValidateIssueTracker.new(BazCheckParams)
         is.valid?
-        expect(is.errors).to eql [[:instance_method_missing, :check_params]]
+        expect(is.errors).to eql [[:instance_method_missing, :errors]]
       end
     end
 
@@ -138,7 +138,7 @@ describe ErrbitPlugin::ValidateIssueTracker do
         def note; 'foo'; end
         def fields; ['foo']; end
         def configured?; true; end
-        def check_params; true; end
+        def errors; true; end
         def url; 'http'; end
         def comments_allowed?; false; end
       end
@@ -159,7 +159,7 @@ describe ErrbitPlugin::ValidateIssueTracker do
         def note; 'foo'; end
         def fields; ['foo']; end
         def configured?; true; end
-        def check_params; true; end
+        def errors; true; end
         def create_issue; 'http'; end
         def comments_allowed?; false; end
       end
@@ -181,7 +181,7 @@ describe ErrbitPlugin::ValidateIssueTracker do
         def note; 'foo'; end
         def fields; ['foo']; end
         def configured?; true; end
-        def check_params; true; end
+        def errors; true; end
         def create_issue; 'http'; end
         def url; 'foo'; end
       end
@@ -202,7 +202,7 @@ describe ErrbitPlugin::ValidateIssueTracker do
         def self.label; 'foo'; end
         def self.fields; ['foo']; end
         def configured?; true; end
-        def check_params; true; end
+        def errors; true; end
         def create_issue; 'http'; end
         def url; 'foo'; end
         def comments_allowed?; false; end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: errbit_plugin
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Stephen Crosby
@@ -60,10 +60,10 @@ files:
 - lib/errbit_plugin/issue_trackers/fake.rb
 - lib/errbit_plugin/issue_trackers/none.rb
 - lib/errbit_plugin/rails.rb
-- lib/errbit_plugin/register_plugin.rb
+- lib/errbit_plugin/registry.rb
 - lib/errbit_plugin/validate_issue_tracker.rb
 - lib/errbit_plugin/version.rb
-- spec/errbit_plugin/register_plugin_spec.rb
+- spec/errbit_plugin/registry_spec.rb
 - spec/errbit_plugin/validate_issue_tracker_spec.rb
 - spec/spec_helper.rb
 - vendor/assets/images/fake_create.png
@@ -95,7 +95,7 @@ signing_key:
 specification_version: 4
 summary: Base to create an errbit plugin
 test_files:
-- spec/errbit_plugin/register_plugin_spec.rb
+- spec/errbit_plugin/registry_spec.rb
 - spec/errbit_plugin/validate_issue_tracker_spec.rb
 - spec/spec_helper.rb
 has_rdoc: