errbit_plugin 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9e2cd7db132aa98db005fcd6110d4c7229522a9e
-  data.tar.gz: 3764d2ebacc1341c2f0ad09631fbd16d74ca2a51
+  metadata.gz: e4044ee01410119ca8ab10ffe1f89415708d2ed9
+  data.tar.gz: faf743c3c52f8e137b9c942dca93abd848e822b8
 SHA512:
-  metadata.gz: 57ae4835d1c758f6a7f124963ead230512e2fe78909bdf89843d49ff60bf8d429f726d373982b26a42ac8fbee79c486ff8e33b5ee81450103b5a8964351ae416
-  data.tar.gz: da3dd64c99018bc73d7fedbc312be9b10cb1d8ecd89de7116b8f28baec724a709431e1bd57223792d70b518a8ce6d850a4665aca653c61959801b5747c410831
+  metadata.gz: 985d669a9c92db0ac0aea134d4baa62a1147297eae05e15731887f6a40e0e93fade1f139ace6ed8f40bdc901d5d46530ddcc9a7430ec8decb5b9af414c7e4f04
+  data.tar.gz: 3a87f4b41d2ba9135a8200dd639e754d4e9a0f53dd7647e8f3272530982f932e075e89e0289696910310f763470ad2b42d3fd43a8a07929100423791dc52e083

data/lib/errbit_plugin/issue_tracker.rb

@@ -1,19 +1,10 @@
 module ErrbitPlugin
   class IssueTracker
+    attr_reader :app, :params
+
     def initialize(app, params)
       @app = app
       @params = params
     end
-    attr_reader :app, :params
-
-    def add_error(key, msg)
-      @errors ||= {}
-      @errors[key] ||= []
-      @errors[key] << msg
-    end
-
-    def issue_title(problem)
-      "[#{ problem.environment }][#{ problem.where }] #{problem.message.to_s.truncate(100)}"
-    end
   end
 end

data/lib/errbit_plugin/issue_trackers/fake.rb

@@ -1,27 +1,38 @@
 module ErrbitPlugin
   class FakeIssueTracker < IssueTracker
-    def self.label; 'fake'; end
-    def self.note; 'A fake issue tracker to help in testing purpose'; end
+    def self.label
+      'fake'
+    end
+
+    def self.note
+      'A fake issue tracker to help in testing purpose'
+    end
+
     def self.fields
       {
         :foo => {:label => 'foo'},
         :bar => {:label => 'bar'}
       }
     end
-    ##
-    # The NoneIssueTracker is mark like configured? false because it not valid
-    # like a real IssueTracker
-    def configured?; check_params; end
-    def check_params
-      params[:foo] && params[:bar]
+
+    def configured?
+      errors.any?
     end
+
+    def errors
+      errors = {}
+      errors[:foo] = 'foo is required' unless params[:foo]
+      errors[:bar] = 'bar is required' unless params[:bar]
+
+      errors
+    end
+
     def create_issue; true; end
+
     def url; ''; end
+
     def comments_allowed?; false; end
   end
 end
 
-ErrbitPlugin::Register.add_issue_tracker(
-  'fake',
-  ErrbitPlugin::FakeIssueTracker
-)
+ErrbitPlugin::Registry.add_issue_tracker(ErrbitPlugin::FakeIssueTracker)

data/lib/errbit_plugin/issue_trackers/none.rb

@@ -10,14 +10,11 @@ module ErrbitPlugin
     # The NoneIssueTracker is mark like configured? false because it not valid
     # like a real IssueTracker
     def configured?; false; end
-    def check_params; true; end
+    def errors; {}; end
     def create_issue; true; end
     def url; ''; end
     def comments_allowed?; true; end
   end
 end
 
-ErrbitPlugin::Register.add_issue_tracker(
-  'IssueTracker::None',
-  ErrbitPlugin::NoneIssueTracker
-)
+ErrbitPlugin::Registry.add_issue_tracker(ErrbitPlugin::NoneIssueTracker)

data/lib/errbit_plugin/register_plugin.rb

@@ -1,10 +1,18 @@
 module ErrbitPlugin
-  class IncompatibilityError < Exception; end
+  class IncompatibilityError < StandardError; end
+  class AlreadyRegisteredError < StandardError; end
+
+  module Registry
+    @issue_trackers = {}
+
+    def self.add_issue_tracker(klass)
+      key = klass.label
+
+      if issue_trackers.has_key?(key)
+        raise AlreadyRegisteredError,
+          "issue_tracker '#{key}' already registered"
+      end
 
-  module Register
-    def self.add_issue_tracker(key, klass)
-      @issue_trackers ||= {}
-      raise IncompatibilityError.new('issue_tracker already registered') if @issue_trackers.key?(key)
       validate = ValidateIssueTracker.new(klass)
 
       if validate.valid?
@@ -17,13 +25,5 @@ module ErrbitPlugin
     def self.issue_trackers
       @issue_trackers
     end
-
-    def self.issue_tracker(key)
-      @issue_trackers[key]
-    end
-
-    def self.clear
-      @issue_trackers = {}
-    end
   end
 end

data/lib/errbit_plugin/validate_issue_tracker.rb

@@ -24,7 +24,7 @@ module ErrbitPlugin
     end
 
     def implements_instance_methods?
-      [:comments_allowed?, :configured?, :check_params, :create_issue, :url].all? do |method|
+      [:comments_allowed?, :configured?, :errors, :create_issue, :url].all? do |method|
         if instance.respond_to?(method)
           true
         else

data/lib/errbit_plugin/version.rb

@@ -1,3 +1,3 @@
 module ErrbitPlugin
-  VERSION = "0.0.1"
+  VERSION = "0.1.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: errbit_plugin
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Stephen Crosby
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-25 00:00:00.000000000 Z
+date: 2014-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler