errata 0.2.0 → 0.2.1

data/Rakefile

@@ -11,7 +11,7 @@ begin
     gem.homepage = "http://github.com/seamusabshere/errata"
     gem.authors = ["Seamus Abshere", "Andy Rossmeissl"]
     gem.add_dependency 'activesupport', '>=2.3.4'
-    gem.add_development_dependency 'remote_table', '>=0.2.19'
+    gem.add_dependency 'remote_table', '>=0.2.20'
     gem.require_path = "lib"
     gem.files.include %w(lib/erratum) unless gem.files.empty? # seems to fail once it's in the wild
     gem.rdoc_options << '--line-numbers' << '--inline-source'

data/VERSION

@@ -1 +1 @@
-0.2.0
+0.2.1

data/errata.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{errata}
-  s.version = "0.2.0"
+  s.version = "0.2.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Seamus Abshere", "Andy Rossmeissl"]
-  s.date = %q{2010-05-05}
+  s.date = %q{2010-05-06}
   s.description = %q{Correct strings based on remote errata files}
   s.email = %q{seamus@abshere.net}
   s.extra_rdoc_files = [
@@ -52,14 +52,14 @@ Gem::Specification.new do |s|
 
     if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
       s.add_runtime_dependency(%q<activesupport>, [">= 2.3.4"])
-      s.add_development_dependency(%q<remote_table>, [">= 0.2.19"])
+      s.add_runtime_dependency(%q<remote_table>, [">= 0.2.20"])
     else
       s.add_dependency(%q<activesupport>, [">= 2.3.4"])
-      s.add_dependency(%q<remote_table>, [">= 0.2.19"])
+      s.add_dependency(%q<remote_table>, [">= 0.2.20"])
     end
   else
     s.add_dependency(%q<activesupport>, [">= 2.3.4"])
-    s.add_dependency(%q<remote_table>, [">= 0.2.19"])
+    s.add_dependency(%q<remote_table>, [">= 0.2.20"])
   end
 end
 

data/lib/errata.rb

@@ -7,6 +7,7 @@ require 'active_support/version'
 }.each do |active_support_3_requirement|
   require active_support_3_requirement
 end if ActiveSupport::VERSION::MAJOR == 3
+require 'remote_table'
 require 'erratum'
 require 'erratum/delete'
 require 'erratum/reject'
@@ -18,12 +19,27 @@ require 'erratum/truncate'
 class Errata
   ERRATUM_TYPES = %w{delete replace simplify transform truncate}
 
-  attr_reader :responder
-  attr_reader :table
+  attr_reader :options
   
+  # Arguments
+  # * <tt>:responder</tt> (required) - normally you pass this something like Guru.new, which should respond to questions like #is_a_bentley?. If you pass a string, it will be lazily constantized and a new object initialized from it; for example, 'Guru' will lead to 'Guru'.constantize.new.
+  # * <tt>:table</tt> - takes something that acts like a RemoteTable
+  # If and only if you don't pass <tt>:table</tt>, all other options will be passed to a new RemoteTable (for example, <tt>:url</tt>, etc.)
   def initialize(options = {})
-    @responder = options[:responder]
-    @table = options[:table]
+    options.symbolize_keys!
+    @options = options
+  end
+  
+  def table
+    @_table ||= if options[:table].present?
+      options[:table]
+    else
+      RemoteTable.new options.except(:responder)
+    end
+  end
+  
+  def responder
+    @_responder ||= (options[:responder].is_a?(String) ? options[:responder].constantize.new : options[:responder])
   end
   
   def rejects?(row)

data/test/errata_test.rb

@@ -73,4 +73,20 @@ class ErrataTest < Test::Unit::TestCase
   should "reject rows" do
     assert @e.rejects?('carline_mfr_name' => 'AURORA CARS')
   end
+  
+  should "lazily constantize and initialize responder" do
+    e = Errata.new :table => RemoteTable.new(:url => 'http://spreadsheets.google.com/pub?key=t9WkYT39zjrStx7ruCFrZJg'),
+                   :responder => 'AutomobileVariantGuru'
+    alfa = { "carline_mfr_name"=>"ALFA ROMEO" }
+    e.correct!(alfa)
+    assert_equal 'Alfa Romeo', alfa['carline_mfr_name']
+  end
+  
+  should "pass options to RemoteTable if no :table is specified" do
+    e = Errata.new :url => 'http://spreadsheets.google.com/pub?key=t9WkYT39zjrStx7ruCFrZJg',
+                   :responder => AutomobileVariantGuru.new
+    alfa = { "carline_mfr_name"=>"ALFA ROMEO" }
+    e.correct!(alfa)
+    assert_equal 'Alfa Romeo', alfa['carline_mfr_name']
+  end
 end

data/test/test_helper.rb

@@ -1,7 +1,6 @@
 require 'rubygems'
 require 'test/unit'
 require 'shoulda'
-require 'remote_table'
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 2
-  - 0
-  version: 0.2.0
+  - 1
+  version: 0.2.1
 platform: ruby
 authors: 
 - Seamus Abshere
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-05-05 00:00:00 -04:00
+date: 2010-05-06 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -42,9 +42,9 @@ dependencies:
         segments: 
         - 0
         - 2
-        - 19
-        version: 0.2.19
-  type: :development
+        - 20
+        version: 0.2.20
+  type: :runtime
   version_requirements: *id002
 description: Correct strings based on remote errata files
 email: seamus@abshere.net