errata 0.1.4 → 0.1.5

data/Rakefile

@@ -10,7 +10,8 @@ begin
     gem.email = "seamus@abshere.net"
     gem.homepage = "http://github.com/seamusabshere/errata"
     gem.authors = ["Seamus Abshere", "Andy Rossmeissl"]
-    %w{ activesupport remote_table }.each { |name| gem.add_dependency name }
+    gem.add_dependency 'activesupport', '~>2.3.4'
+    gem.add_dependency 'remote_table', '~>0.2.1'
     gem.require_path = "lib"
     gem.files.include %w(lib/erratum) unless gem.files.empty? # seems to fail once it's in the wild
     gem.rdoc_options << '--line-numbers' << '--inline-source'

data/VERSION

@@ -1 +1 @@
-0.1.4
+0.1.5

data/errata.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{errata}
-  s.version = "0.1.4"
+  s.version = "0.1.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Seamus Abshere", "Andy Rossmeissl"]
-  s.date = %q{2009-11-02}
+  s.date = %q{2010-02-25}
   s.description = %q{Correct strings based on remote errata files}
   s.email = %q{seamus@abshere.net}
   s.extra_rdoc_files = [
@@ -51,15 +51,15 @@ Gem::Specification.new do |s|
     s.specification_version = 3
 
     if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<activesupport>, [">= 0"])
-      s.add_runtime_dependency(%q<remote_table>, [">= 0"])
+      s.add_runtime_dependency(%q<activesupport>, ["~> 2.3.4"])
+      s.add_runtime_dependency(%q<remote_table>, ["~> 0.2.1"])
     else
-      s.add_dependency(%q<activesupport>, [">= 0"])
-      s.add_dependency(%q<remote_table>, [">= 0"])
+      s.add_dependency(%q<activesupport>, ["~> 2.3.4"])
+      s.add_dependency(%q<remote_table>, ["~> 0.2.1"])
     end
   else
-    s.add_dependency(%q<activesupport>, [">= 0"])
-    s.add_dependency(%q<remote_table>, [">= 0"])
+    s.add_dependency(%q<activesupport>, ["~> 2.3.4"])
+    s.add_dependency(%q<remote_table>, ["~> 0.2.1"])
   end
 end
 

data/lib/errata.rb

@@ -1,5 +1,4 @@
-require 'rubygems'
-require 'activesupport'
+require 'active_support'
 require 'remote_table'
 require 'erratum'
 require 'erratum/delete'
@@ -10,6 +9,8 @@ require 'erratum/transform'
 require 'erratum/truncate'
 
 class Errata
+  ERRATUM_TYPES = %w{delete replace simplify transform truncate}
+
   attr_reader :klass
   
   def initialize(options = {})
@@ -33,10 +34,10 @@ class Errata
   private
   
   def rejections
-    @_rejections ||= @_table.rows.map { |erratum| ::Errata::Erratum::Reject.new(self, erratum) if erratum[:action] == 'reject' }.compact
+    @_rejections ||= @_table.rows.map { |hash| hash.symbolize_keys!; ::Errata::Erratum::Reject.new(self, hash) if hash[:action] == 'reject' }.compact
   end
   
   def corrections
-    @_corrections ||= @_table.rows.map { |erratum| "::Errata::Erratum::#{erratum[:action].camelcase}".constantize.new(self, erratum) if %w{delete replace simplify transform truncate}.include?(erratum[:action]) }.compact
+    @_corrections ||= @_table.rows.map { |hash| hash.symbolize_keys!; "::Errata::Erratum::#{hash[:action].camelcase}".constantize.new(self, hash) if ERRATUM_TYPES.include?(hash[:action]) }.compact
   end
 end

data/lib/erratum.rb

@@ -4,10 +4,10 @@ class Errata
     delegate :klass, :to => :errata
     
     def initialize(errata, options = {})
-      raise "you can't set this from outside" if options.has_key?(:prefix)
+      raise "you can't set this from outside" if options[:prefix].present?
       @errata = errata
       @column = options[:section]
-      @matching_method = "#{options[:condition].gsub(/[^a-z0-9]/i, '_').downcase}?".to_sym if options[:condition]
+      @matching_method = "#{options[:condition].gsub(/[^a-z0-9]/i, '_').downcase}?".to_sym if options[:condition].present?
     end
     
     def inspect

data/test/errata_test.rb

@@ -1,34 +1,77 @@
 require 'test_helper'
 
-class Brewery
-  def self.is_microbrew?(row)
-    row[:volume] < 500
+class AutomobileVariant
+  class << self
+    def transmission_is_blank?(row)
+      row['transmission'].blank?
+    end
+
+    def is_a_2007_gmc_or_chevrolet?(row)
+      row['year'] == 2007 and %w(GMC CHEVROLET).include? row['MFR'].upcase
+    end
+
+    def is_a_porsche?(row)
+      row.slice('MFR', 'Manufacturer', 'carline_mfr_name').any? { |k, v| v.upcase == 'PORSCHE' }
+    end
+
+    def is_not_a_porsche?(row)
+      !is_a_porsche? row
+    end
+
+    def is_a_mercedes_benz?(row)
+      row.slice('MFR', 'Manufacturer', 'carline_mfr_name').any? { |k, v| v =~ /MERCEDES/i }
+    end
+
+    def is_a_lexus?(row)
+      row.slice('MFR', 'Manufacturer', 'carline_mfr_name').any? { |k, v| v.upcase == 'LEXUS' }
+    end
+
+    def is_a_bmw?(row)
+      row.slice('MFR', 'Manufacturer', 'carline_mfr_name').any? { |k, v| v.upcase == 'BMW' }
+    end
+
+    def is_a_ford?(row)
+      row.slice('MFR', 'Manufacturer', 'carline_mfr_name').any? { |k, v| v.upcase == 'FORD' }
+    end
+
+    def is_a_rolls_royce_and_model_contains_bentley?(row)
+      is_a_rolls_royce?(row) and model_contains_bentley?(row)
+    end
+
+    def is_a_bentley?(row)
+      row.slice('MFR', 'Manufacturer', 'carline_mfr_name').any? { |k, v| v.upcase == 'BENTLEY' }
+    end
+
+    def is_a_rolls_royce?(row)
+      row.slice('MFR', 'Manufacturer', 'carline_mfr_name').any? { |k, v| v =~ /ROLLS/i }
+    end
+
+    def is_a_turbo_brooklands?(row)
+      row.slice('CAR LINE', 'carline name', 'carline_name').any? { |k, v| v =~ /TURBO R\/RL BKLDS/i }
+    end
+
+    def model_contains_maybach?(row)
+      row.slice('CAR LINE', 'carline name', 'carline_name').any? { |k, v| v =~ /MAYBACH/i }
+    end
+    
+    def model_contains_bentley?(row)
+      row.slice('CAR LINE', 'carline name', 'carline_name').any? { |k, v| v =~ /BENTLEY/i }
+    end
   end
 end
 
 class ErrataTest < Test::Unit::TestCase
   def setup
-    @e = Errata.new(:url => 'http://static.brighterplanet.com/science/data/transport/automobiles/make_fleet_years/errata.csv')
-  end
-  
-  should "return implied matching methods" do
-    flunk "create a fake errata for Brewery"
-  end
-  
-  should "use matching methods" do
-    flunk "create a fake errata for Brewery"
+    @e = Errata.new(:url => 'http://spreadsheets.google.com/pub?key=t9WkYT39zjrStx7ruCFrZJg', :klass => AutomobileVariant)
   end
-  
+    
   should "correct rows" do
-    rover = { 'manufacturer_name' => 'foobar Austin Rover foobar' }
-    mercedes = { 'manufacturer_name' => 'MERCEDES' }
-    @e.correct!(mercedes)
-    @e.correct!(rover)
-    assert_equal 'Mercedes-Benz', mercedes['manufacturer_name']
-    assert_equal 'Rover',         rover['manufacturer_name']
+    alfa = { "carline_mfr_name"=>"ALFA ROMEO" }
+    @e.correct!(alfa)
+    assert_equal 'Alfa Romeo', alfa['carline_mfr_name']
   end
   
   should "reject rows" do
-    assert @e.rejects?('manufacturer_name' => 'AURORA CARS')
+    assert @e.rejects?('carline_mfr_name' => 'AURORA CARS')
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: errata
 version: !ruby/object:Gem::Version 
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors: 
 - Seamus Abshere
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-02 00:00:00 -05:00
+date: 2010-02-25 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -19,9 +19,9 @@ dependencies:
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
-        version: "0"
+        version: 2.3.4
     version: 
 - !ruby/object:Gem::Dependency 
   name: remote_table
@@ -29,9 +29,9 @@ dependencies:
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
-        version: "0"
+        version: 0.2.1
     version: 
 description: Correct strings based on remote errata files
 email: seamus@abshere.net