erb_lint 0.0.17 → 0.0.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a049e3c1eca3e9c562498feb09d4f6c5ddff17c
-  data.tar.gz: 006061a153ef9e833e59f0ed62214755d5b38ae5
+  metadata.gz: 0ae1dbd574b00046985466aacce7a126e9a61b34
+  data.tar.gz: 1649ae3b899e23ee9c02f5f40dfd6a9db02e2008
 SHA512:
-  metadata.gz: 3881b31aac9d98e16e47f63196a8bfedfec5469effd8bb0ce7c203185af82d8c73207469cf7e152a1437abeb2f76af1c453b569e88dd9059cf451e9b82b78331
-  data.tar.gz: 77682b7159225e7d9b2022ea8ee740d0c9cca7c12a3036ee1aa95e8bc403bb1a80462836a3ef67b79f2d71afbc2fb95ab6ebe5832cccaf6f8224f4576e85b3a7
+  metadata.gz: d6571d993f2acc94689f7711adb041dbca684b696f22548d85ed5af44a530143adf0acca04de2f19b46313223fbdeb8a3d539ac75827fd07d010c9280ef809d1
+  data.tar.gz: 1bd62fde864706db8442b6f03290ab71dcf4e94571aee526c425781469f5010f4d78ce8091cae3264f3a4d8927d5f4584f3d75c5770e056458f3f55decc4a69a

data/lib/erb_lint/linters/hard_coded_string.rb

@@ -0,0 +1,62 @@
+# frozen_string_literal: true
+
+require 'better_html/tree/tag'
+
+module ERBLint
+  module Linters
+    # Checks for hardcoded strings. Useful if you want to ensure a string can be translated using i18n.
+    class HardCodedString < Linter
+      include LinterRegistry
+
+      def offenses(processed_source)
+        hardcoded_strings = processed_source.ast.descendants(:text).each_with_object([]) do |text_node, to_check|
+          next if javascript?(processed_source, text_node)
+
+          offended_str = text_node.to_a.find { |node| relevant_node(node) }
+          to_check << [text_node, offended_str] if offended_str
+        end
+
+        hardcoded_strings.compact.map do |text_node, offended_str|
+          Offense.new(
+            self,
+            processed_source.to_source_range(text_node.loc.start, text_node.loc.stop),
+            message(offended_str)
+          )
+        end
+      end
+
+      private
+
+      def javascript?(processed_source, text_node)
+        ast = processed_source.parser.ast.to_a
+        index = ast.find_index(text_node)
+
+        previous_node = ast[index - 1]
+
+        if previous_node.type == :tag
+          tag = BetterHtml::Tree::Tag.from_node(previous_node)
+
+          tag.name == "script" && !tag.closing?
+        end
+      end
+
+      def relevant_node(inner_node)
+        if inner_node.is_a?(String)
+          inner_node.strip.empty? ? false : inner_node
+        else
+          false
+        end
+      end
+
+      def message(string)
+        stripped_string = string.strip
+
+        if stripped_string.length > 1
+          "String not translated: #{stripped_string}"
+        else
+          "Consider using Rails helpers to move out the single character `#{stripped_string}` from the html."
+        end
+      end
+    end
+  end
+end

data/lib/erb_lint/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ERBLint
-  VERSION = '0.0.17'
+  VERSION = '0.0.18'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: erb_lint
 version: !ruby/object:Gem::Version
-  version: 0.0.17
+  version: 0.0.18
 platform: ruby
 authors:
 - Justin Chan
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-01-19 00:00:00.000000000 Z
+date: 2018-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: better_html
@@ -141,6 +141,7 @@ files:
 - lib/erb_lint/linters/deprecated_classes.rb
 - lib/erb_lint/linters/erb_safety.rb
 - lib/erb_lint/linters/final_newline.rb
+- lib/erb_lint/linters/hard_coded_string.rb
 - lib/erb_lint/linters/rubocop.rb
 - lib/erb_lint/linters/rubocop_text.rb
 - lib/erb_lint/offense.rb