equalizer 0.0.8 → 0.0.9

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    ZGRlOGMwM2JjYmE4MzM0Yzg0YmQxN2MwYzZmM2U3MWIzNjkxNmNkMA==
-  data.tar.gz: !binary |-
-    ZDVhZGIwM2U5MTdhNWYyNDZjYTlkOTY4ZTM4NzZhNzEyOTQzZGRiZQ==
+SHA1:
+  metadata.gz: e395798ee318b7da8de8b5259ff85eca64aca178
+  data.tar.gz: ed52fb91d5e88f8e17dcce31953b3ce115bf201a
 SHA512:
-  metadata.gz: !binary |-
-    OGM3NDcwMzhjY2M3MWJjNDBlYWRjZDk4YWY4NjYyNTI1NzdiZDc3MzBiMGEz
-    ZjAwYmJhNzgwNTg4YjU5ZmFlOTU1N2NiYjBmMWY4NmU0N2ZhOWZjZTNiNzhi
-    ZTdiN2NjODk1YWMyNzE5OWY0ZjY2NmQ3ZjNhYjY5Yzk1NjQ5OTI=
-  data.tar.gz: !binary |-
-    MGM3YzJhODdkMDZhOTVmOWNkNWIzMTdhMWY1MjY5Njg1OWRmYWU5NDg5MGQw
-    M2RmNjVmOTM4OWYzODQ0NTk5Y2I3YTViYjgwMTdmMTI3MmVlMjVlZDZmMjE0
-    ZTc1Y2YzZGRhZWYyYTQyMWExNDJiYjY3NTljMDA5ZmIxYWVkZjI=
+  metadata.gz: 2eec628fe19db76bcf78f88722254ff19f80e5b50362bab177d1aec34edd527f265d89f9a2c7e536c26a55c5a12d7981d3af19bbf368717059abb0945ee7f0dc
+  data.tar.gz: 5e647a6611168410ede1fbc01c24f8a2dbbd422424a08ab620c2d170334c2cd9af8201a70534ab31d0e7c13dde04567f1b77a72792d9c3ef66818f2a3ec566fe

data/{config/rubocop.yml → .rubocop.yml}

@@ -2,9 +2,9 @@ AllCops:
   Includes:
     - '**/*.rake'
     - 'Gemfile'
-    - 'Gemfile.devtools'
+    - 'Rakefile'
   Excludes:
-    - '**/vendor/**'
+    - 'vendor/**'
 
 # Avoid parameter lists longer than five parameters.
 ParameterLists:
@@ -59,3 +59,11 @@ TrivialAccessors:
 # Allow empty lines around body
 EmptyLinesAroundBody:
   Enabled: false
+
+# Enforce Ruby 1.8-compatible hash syntax
+HashSyntax:
+  EnforcedStyle: hash_rockets
+
+# Allow dots at the end of lines
+DotPosition:
+  Enabled: false

data/.travis.yml

@@ -1,19 +1,26 @@
 language: ruby
+cache: bundler
 bundler_args: --without yard guard benchmarks
 script: "bundle exec rake ci"
 rvm:
+  - ree
+  - 1.8.7
+  - 1.9.2
   - 1.9.3
   - 2.0.0
   - ruby-head
   - rbx
 matrix:
   include:
+    - rvm: jruby-18mode
+      env: JRUBY_OPTS="$JRUBY_OPTS --debug"  # for simplecov
     - rvm: jruby-19mode
-      env: JRUBY_OPTS="$JRUBY_OPTS --debug"
+      env: JRUBY_OPTS="$JRUBY_OPTS --debug"  # for simplecov
+    - rvm: jruby-20mode
+      env: JRUBY_OPTS="$JRUBY_OPTS --debug"  # for simplecov
     - rvm: jruby-head
-      env: JRUBY_OPTS="$JRUBY_OPTS --debug"
-  allow_failures:
-    - rvm: 2.0.0  # travis broken
+      env: JRUBY_OPTS="$JRUBY_OPTS --debug"  # for simplecov
+  fast_finish: true
 notifications:
   irc:
     channels:

data/Gemfile

@@ -2,10 +2,27 @@
 
 source 'https://rubygems.org'
 
-gemspec
+gem 'rake'
+
+group :test do
+  gem 'backports'
+  gem 'coveralls', :require => false
+  gem 'json',      :platforms => [:ruby_19]
+  gem 'reek'
+  gem 'rspec',     '~> 2.14'
+  gem 'rubocop',   :platforms => [:ruby_19, :ruby_20]
+  gem 'simplecov', :require => false
+  gem 'yardstick'
+end
 
-group :development, :test do
-  gem 'devtools', git: 'https://github.com/rom-rb/devtools.git'
+platforms :jruby, :ruby_18 do
+  gem 'mime-types', '~> 1.25'
 end
 
-eval_gemfile 'Gemfile.devtools'
+platforms :rbx do
+  gem 'racc'
+  gem 'rubinius-coverage',  '~> 2.0'
+  gem 'rubysl', '~> 2.0'
+end
+
+gemspec

data/README.md

@@ -46,12 +46,45 @@ point_a.eql?(point_c)        # => false
 point_a.equal?(point_c)      # => false
 ```
 
+Supported Ruby Versions
+-----------------------
+
+This library aims to support and is [tested against][travis] the following Ruby
+implementations:
+
+* Ruby 1.8.7
+* Ruby 1.9.2
+* Ruby 1.9.3
+* Ruby 2.0.0
+* [JRuby][]
+* [Rubinius][]
+* [Ruby Enterprise Edition][ree]
+
+[jruby]: http://jruby.org/
+[rubinius]: http://rubini.us/
+[ree]: http://www.rubyenterpriseedition.com/
+
+If something doesn't work on one of these versions, it's a bug.
+
+This library may inadvertently work (or seem to work) on other Ruby versions or
+implementations, however support will only be provided for the implementations
+listed above.
+
+If you would like this library to support another Ruby version or
+implementation, you may volunteer to be a maintainer. Being a maintainer
+entails making sure all tests run and pass on that implementation. When
+something breaks on your implementation, you will be responsible for providing
+patches in a timely fashion. If critical issues for a particular implementation
+exist at the time of a major release, support for that Ruby version may be
+dropped.
+
 Credits
 -------
 
 * Dan Kubb ([dkubb](https://github.com/dkubb))
 * Piotr Solnica ([solnic](https://github.com/solnic))
 * Markus Schirp ([mbj](https://github.com/mbj))
+* Erik Michaels-Ober ([sferik](https://github.com/sferik))
 
 Contributing
 -------------

data/Rakefile

@@ -1,2 +1,39 @@
-require 'devtools'
-Devtools.init_rake_tasks
+# encoding: utf-8
+
+require 'bundler'
+Bundler::GemHelper.install_tasks
+
+require 'rspec/core/rake_task'
+RSpec::Core::RakeTask.new(:spec)
+
+task :test    => :spec
+task :default => :spec
+
+require 'reek/rake/task'
+Reek::Rake::Task.new do |reek|
+  reek.reek_opts     = '--quiet'
+  reek.fail_on_error = true
+  reek.config_files  = '.reek.yml'
+end
+
+begin
+  require 'rubocop/rake_task'
+  Rubocop::RakeTask.new
+rescue LoadError
+  desc 'Run RuboCop'
+  task :rubocop do
+    $stderr.puts 'Rubocop is disabled'
+  end
+end
+
+require 'yardstick/rake/measurement'
+Yardstick::Rake::Measurement.new do |measurement|
+  measurement.output = 'measurement/report.txt'
+end
+
+require 'yardstick/rake/verify'
+Yardstick::Rake::Verify.new do |verify|
+  verify.threshold = 100
+end
+
+task :ci => [:spec, :rubocop, :reek, :verify_measurements]

data/equalizer.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |gem|
   gem.require_paths    = %w[lib]
   gem.files            = `git ls-files`.split("\n")
   gem.test_files       = `git ls-files -- spec/{unit,integration}`.split("\n")
-  gem.extra_rdoc_files = %w[LICENSE README.md CONTRIBUTING.md TODO]
+  gem.extra_rdoc_files = %w[LICENSE README.md CONTRIBUTING.md]
 
   gem.add_development_dependency('bundler', '~> 1.3', '>= 1.3.5')
 end

data/lib/equalizer.rb

@@ -53,7 +53,7 @@ private
   def define_cmp_method
     keys = @keys
     define_method(:cmp?) do |comparator, other|
-      keys.all? { |key| send(key).public_send(comparator, other.send(key)) }
+      keys.all? { |key| send(key).send(comparator, other.send(key)) }
     end
     private :cmp?
   end
@@ -66,7 +66,7 @@ private
   def define_hash_method
     keys = @keys
     define_method(:hash) do ||
-      keys.map { |key| send(key).hash }.reduce(self.class.hash, :^)
+      keys.map(&method(:send)).push(self.class).hash
     end
   end
 

data/lib/equalizer/version.rb

@@ -3,6 +3,6 @@
 class Equalizer < Module
 
   # Gem version
-  VERSION = '0.0.8'.freeze
+  VERSION = '0.0.9'.freeze
 
 end # class Equalizer

data/spec/spec_helper.rb

@@ -20,7 +20,6 @@ if ENV['COVERAGE'] == 'true'
   end
 end
 
-require 'devtools/spec_helper'
 require 'equalizer'
 
 # TODO: FIXME!

data/spec/unit/equalizer/universal_spec.rb

@@ -24,8 +24,8 @@ describe Equalizer, '.new' do
     it { should be_frozen }
 
     it 'defines #hash and #inspect methods dynamically' do
-      expect(subject.public_instance_methods(false).map(&:to_s).sort)
-        .to eql(%w[hash inspect])
+      expect(subject.public_instance_methods(false).map(&:to_s).sort).
+        to eql(%w[hash inspect])
     end
 
     describe '#eql?' do
@@ -61,7 +61,7 @@ describe Equalizer, '.new' do
         expect(klass.instance_method(:hash).arity).to be(0)
       end
 
-      it { expect(instance.hash).to eql(klass.hash) }
+      it { expect(instance.hash).to eql([klass].hash) }
     end
 
     describe '#inspect' do
@@ -104,8 +104,8 @@ describe Equalizer, '.new' do
     it { should be_frozen }
 
     it 'defines #hash and #inspect methods dynamically' do
-      expect(subject.public_instance_methods(false).map(&:to_s).sort)
-        .to eql(%w[ hash inspect ])
+      expect(subject.public_instance_methods(false).map(&:to_s).sort).
+        to eql(%w[ hash inspect ])
     end
 
     describe '#eql?' do
@@ -144,15 +144,15 @@ describe Equalizer, '.new' do
 
     describe '#hash' do
       it 'returns the expected hash' do
-        expect(instance.hash)
-          .to eql(klass.hash ^ firstname.hash ^ lastname.hash)
+        expect(instance.hash).
+          to eql([firstname, lastname, klass].hash)
       end
     end
 
     describe '#inspect' do
       it 'returns the expected string' do
-        expect(instance.inspect)
-          .to eql('#<User firstname="John" lastname="Doe">')
+        expect(instance.inspect).
+          to eql('#<User firstname="John" lastname="Doe">')
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: equalizer
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Dan Kubb
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-02 00:00:00.000000000 Z
+date: 2013-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -18,7 +18,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.3.5
   type: :development
@@ -28,7 +28,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.3.5
 description: Module to define equality, equivalence and inspection methods
@@ -41,28 +41,19 @@ extra_rdoc_files:
 - LICENSE
 - README.md
 - CONTRIBUTING.md
-- TODO
 files:
 - .gitignore
+- .reek.yml
 - .rspec
+- .rubocop.yml
 - .ruby-gemset
 - .travis.yml
+- .yardstick.yml
 - CONTRIBUTING.md
 - Gemfile
-- Gemfile.devtools
-- Guardfile
 - LICENSE
 - README.md
 - Rakefile
-- TODO
-- config/devtools.yml
-- config/flay.yml
-- config/flog.yml
-- config/mutant.yml
-- config/reek.yml
-- config/roodi.yml
-- config/rubocop.yml
-- config/yardstick.yml
 - equalizer.gemspec
 - lib/equalizer.rb
 - lib/equalizer/version.rb
@@ -82,12 +73,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -101,4 +92,3 @@ test_files:
 - spec/unit/equalizer/methods/eql_predicate_spec.rb
 - spec/unit/equalizer/methods/equality_operator_spec.rb
 - spec/unit/equalizer/universal_spec.rb
-has_rdoc: 

data/Gemfile.devtools

@@ -1,68 +0,0 @@
-# encoding: utf-8
-
-group :development do
-  gem 'rake',  '~> 10.1.0'
-  gem 'rspec', '~> 2.14.1'
-  gem 'yard',  '~> 0.8.7'
-
-  platform :rbx do
-    gem 'rubysl-singleton', '~> 2.0.0'
-  end
-end
-
-group :yard do
-  gem 'kramdown', '~> 1.2.0'
-end
-
-group :guard do
-  gem 'guard',         '~> 1.8.1'
-  gem 'guard-bundler', '~> 1.0.0'
-  gem 'guard-rspec',   '~> 3.0.2'
-  gem 'guard-rubocop', '~> 0.2.0'
-  gem 'guard-mutant',  '~> 0.0.1'
-
-  # file system change event handling
-  gem 'listen',     '~> 1.3.0'
-  gem 'rb-fchange', '~> 0.0.6', require: false
-  gem 'rb-fsevent', '~> 0.9.3', require: false
-  gem 'rb-inotify', '~> 0.9.0', require: false
-
-  # notification handling
-  gem 'libnotify',               '~> 0.8.0', require: false
-  gem 'rb-notifu',               '~> 0.0.4', require: false
-  gem 'terminal-notifier-guard', '~> 1.5.3', require: false
-end
-
-group :metrics do
-  gem 'coveralls', '~> 0.7.0'
-  gem 'flay',      '~> 2.4.0'
-  gem 'flog',      '~> 4.2.0'
-  gem 'reek',      '~> 1.3.2'
-  gem 'rubocop',   '~> 0.15.0'
-  gem 'simplecov', '~> 0.8.2'
-  gem 'yardstick', '~> 0.9.7', git: 'https://github.com/dkubb/yardstick.git'
-
-  platforms :ruby_19, :ruby_20 do
-    gem 'mutant',          '~> 0.3.0.rc3', git: 'https://github.com/mbj/mutant.git'
-    gem 'unparser',        '~> 0.1.5',     git: 'https://github.com/mbj/unparser.git'
-    gem 'yard-spellcheck', '~> 0.1.5'
-  end
-
-  platform :rbx do
-    gem 'json',               '~> 1.8.1'
-    gem 'racc',               '~> 1.4.10'
-    gem 'rubysl-logger',      '~> 2.0.0'
-    gem 'rubysl-open-uri',    '~> 2.0.0'
-    gem 'rubysl-prettyprint', '~> 2.0.2'
-  end
-end
-
-group :benchmarks do
-  gem 'rbench', '~> 0.2.3'
-end
-
-platform :jruby do
-  group :jruby do
-    gem 'jruby-openssl', '~> 0.8.5'
-  end
-end

data/Guardfile

@@ -1,32 +0,0 @@
-# encoding: utf-8
-
-guard :bundler do
-  watch('Gemfile')
-  watch('Gemfile.lock')
-  watch(%w{.+.gemspec\z})
-end
-
-guard :rspec, cli: File.read('.rspec').split.join(' '), keep_failed: false do
-  # Run all specs if configuration is modified
-  watch('.rspec')              { 'spec' }
-  watch('Guardfile')           { 'spec' }
-  watch('Gemfile.lock')        { 'spec' }
-  watch('spec/spec_helper.rb') { 'spec' }
-
-  # Run all specs if supporting files are modified
-  watch(%r{\Aspec/(?:fixtures|lib|support|shared)/.+\.rb\z}) { 'spec' }
-
-  # Run unit specs if associated lib code is modified
-  watch(%r{\Alib/(.+)\.rb\z})                                         { |m| Dir["spec/unit/#{m[1]}*"]         }
-  watch(%r{\Alib/(.+)/support/(.+)\.rb\z})                            { |m| Dir["spec/unit/#{m[1]}/#{m[2]}*"] }
-  watch("lib/#{File.basename(File.expand_path('../', __FILE__))}.rb") { 'spec'                                }
-
-  # Run a spec if it is modified
-  watch(%r{\Aspec/(?:unit|integration)/.+_spec\.rb\z})
-end
-
-guard :rubocop, cli: %w[--config config/rubocop.yml] do
-  watch(%r{.+\.(?:rb|rake)\z})
-  watch(%r{\Aconfig/rubocop\.yml\z})  { |m| File.dirname(m[0]) }
-  watch(%r{(?:.+/)?\.rubocop\.yml\z}) { |m| File.dirname(m[0]) }
-end

data/config/devtools.yml

@@ -1,2 +0,0 @@
----
-unit_test_timeout: 0.1

data/config/flay.yml

@@ -1,3 +0,0 @@
----
-threshold: 6
-total_score: 25

data/config/flog.yml

@@ -1,2 +0,0 @@
----
-threshold: 18.7

data/config/mutant.yml

@@ -1,3 +0,0 @@
----
-name: equalizer
-namespace: Equalizer

data/config/roodi.yml

@@ -1,18 +0,0 @@
----
-AbcMetricMethodCheck:            { score: 10.3 }
-AssignmentInConditionalCheck:    { }
-CaseMissingElseCheck:            { }
-ClassLineCountCheck:             { line_count: 293 }
-ClassNameCheck:                  { pattern: !ruby/regexp '/\A(?:[A-Z]+|[A-Z][a-z](?:[A-Z]?[a-z])+)\z/' }
-ClassVariableCheck:              { }
-CyclomaticComplexityBlockCheck:  { complexity: 2 }
-CyclomaticComplexityMethodCheck: { complexity: 4 }
-EmptyRescueBodyCheck:            { }
-ForLoopCheck:                    { }
-# TODO: decrease line_count to 5 to 10
-MethodLineCountCheck:            { line_count: 14 }
-MethodNameCheck:                 { pattern: !ruby/regexp '/\A(?:[a-z\d](?:_?[a-z\d])+[?!=]?|\[\]=?|==|<=>|[+*&|-])\z/' }
-ModuleLineCountCheck:            { line_count: 295 }
-ModuleNameCheck:                 { pattern: !ruby/regexp '/\A(?:[A-Z]+|[A-Z][a-z](?:[A-Z]?[a-z])+)\z/' }
-# TODO: decrease parameter_count to 2 or less
-ParameterNumberCheck:            { parameter_count: 3 }