equalizer 0.0.1 → 0.0.2

data/.travis.yml

@@ -1,5 +1,6 @@
 language: ruby
-bundler_args: --without yard guard
+before_install: gem install bundler
+bundler_args: --without yard guard metrics
 script: "bundle exec rake spec"
 rvm:
   - 1.8.7

data/Gemfile

@@ -15,10 +15,6 @@ group :guard do
   gem 'guard-rspec',   '~> 1.2.1'
 end
 
-group :benchmarks do
-  gem 'rbench', '~> 0.2.3'
-end
-
 platform :jruby do
   group :jruby do
     gem 'jruby-openssl', '~> 0.7.4'

data/README.md

@@ -37,7 +37,7 @@ Examples
 class GeoLocation
   include Equalizer.new(:latitude, :longitude)
 
-  attr_reader :latitidue, :longitude
+  attr_reader :latitude, :longitude
 
   def initialize(latitude, longitude)
     @latitude, @longitude = latitude, longitude

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
 threshold: 6
-total_score: 29
+total_score: 41

data/lib/equalizer.rb

@@ -114,7 +114,7 @@ private
     # @api public
     def ==(other)
       other = coerce(other) if respond_to?(:coerce, true)
-      !!(self.class <=> other.class) && cmp?(__method__, other)
+      other.kind_of?(self.class) && cmp?(__method__, other)
     end
 
   end # module Methods

data/lib/equalizer/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 class Equalizer < Module
-  VERSION = '0.0.1'.freeze
+  VERSION = '0.0.2'.freeze
 end

data/spec/unit/equalizer/methods/equal_value_spec.rb

@@ -5,9 +5,10 @@ require 'spec_helper'
 describe Equalizer::Methods, '#==' do
   subject { object == other }
 
-  let(:object) { described_class.new(true) }
+  let(:object)          { described_class.new(true) }
+  let(:described_class) { Class.new(super_class)    }
 
-  let(:described_class) do
+  let(:super_class) do
     Class.new do
       include Equalizer::Methods
 
@@ -43,13 +44,25 @@ describe Equalizer::Methods, '#==' do
     end
   end
 
-  context 'with an equivalent object of a subclass' do
+  context 'with a subclass instance having equivalent obervable state' do
     let(:other) { Class.new(described_class).new(true) }
 
     it { should be(true) }
 
-    it 'is symmetric' do
-      should eql(other == object)
+    it 'is not symmetric' do
+      # the subclass instance should maintain substitutability with the object
+      # (in the LSP sense) the reverse is not true.
+      should_not eql(other == object)
+    end
+  end
+
+  context 'with a superclass instance having equivalent observable state' do
+    let(:other) { super_class.new(true) }
+
+    it { should be(false) }
+
+    it 'is not symmetric' do
+      should_not eql(other == object)
     end
   end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: equalizer
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 27
   prerelease: 
   segments: 
   - 0
   - 0
-  - 1
-  version: 0.0.1
+  - 2
+  version: 0.0.2
 platform: ruby
 authors: 
 - Dan Kubb
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-11-22 00:00:00 Z
+date: 2012-12-25 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: backports