equalizer 0.0.10 → 0.0.11

checksums.yaml

@@ -1,7 +1,7 @@
---- 
-SHA1: 
-  data.tar.gz: 6ee814edcff8e3dc43cbc0f346fd5476abe9355c
-  metadata.gz: 1e4dcd0c1065c612644e23e6da1fd99b542ebb91
-SHA512: 
-  data.tar.gz: 856b070b7bb7a3bd5041ac8a032a7bbc2bb0945bd3f276779c839ced2373dbc2bf76902d6d7d3096a9e4580095152d8da4f23643e9fea6ab4bb22dd6b489694a
-  metadata.gz: 418740bf5115aa42467cbaf213d8364b8524b5719a768989283758c8fa4e72dbf1a9a1f2556c28030988f7ea4c0c11981c058af06ac7a853e510794814a69aac
+---
+SHA1:
+  metadata.gz: dcbcd58301e2a2cef28808c325df7a4c51eb7714
+  data.tar.gz: e0790eb41a358a41e568eb3393e35fb424c1abc5
+SHA512:
+  metadata.gz: 6ef3745470a9bb334dfaa746c0246d4255f960fdcd9b4bac246ebcac5865e241ac415831a092c6997aec276db2fb0d77e8009fac76b46e694233ae99b0c92077
+  data.tar.gz: dc186fa2bd0482794f6f63c84db4f6bddee1eaf4c696ab8bae031e44e4656c1800430bc73b1ef1aeeb776b4343a8ec079e78efb4b85e09edb44f42c2c818a07b

data/.ruby-version

@@ -0,0 +1 @@
+ruby-2.2.1

data/.travis.yml

@@ -1,31 +1,21 @@
-before_install: gem update bundler
-cache: bundler
-sudo: false
-env:
-  global:
-    - JRUBY_OPTS="$JRUBY_OPTS --debug" # for simplecov
 language: ruby
+bundler_args: --without yard guard benchmarks
 script: "bundle exec rake ci"
+cache: bundler
+sudo: false
 rvm:
-  - 1.8.7
-  - 1.9.3
-  - 2.0.0
+  - 2.0
   - 2.1
   - 2.2
-  - jruby-18mode
-  - jruby-19mode
-  - jruby-head
-  - rbx-2
-  - ree
   - ruby-head
+  - rbx-2
 matrix:
+  include:
+    - rvm: jruby
+      env: JRUBY_OPTS="$JRUBY_OPTS --debug --2.0"  # for simplecov
+    - rvm: jruby-head
+      env: JRUBY_OPTS="$JRUBY_OPTS --debug --2.0"  # for simplecov
   allow_failures:
     - rvm: ruby-head
     - rvm: jruby-head
   fast_finish: true
-notifications:
-  irc:
-    channels:
-      - irc.freenode.org#rom-rb
-    on_success: never
-    on_failure: change

data/Gemfile

@@ -2,18 +2,8 @@
 
 source 'https://rubygems.org'
 
-gem 'rake'
-
-group :test do
-  gem 'backports'
-  gem 'coveralls'
-  gem 'json',                    :platforms => [:ruby_19]
-  gem 'mime-types',  '~> 1.25',  :platforms => [:jruby, :ruby_18]
-  gem 'rest-client', '~> 1.6.0', :platforms => [:jruby, :ruby_18]
-  gem 'rspec',       '~> 3.0'
-  gem 'rubocop',     '>= 0.25',  :platforms => [:ruby_19, :ruby_20, :ruby_21, :ruby_22]
-  gem 'simplecov',   '>= 0.9'
-  gem 'yardstick'
+group :development, :test do
+  gem 'devtools', '=  0.0.2', git: 'https://github.com/mbj/devtools.git'
 end
 
 gemspec

data/Rakefile

@@ -1,34 +1,5 @@
-# encoding: utf-8
-
 require 'bundler'
-Bundler::GemHelper.install_tasks
-
-require 'rspec/core/rake_task'
-RSpec::Core::RakeTask.new(:spec)
-
-task :test    => :spec
-task :default => :spec
+require 'devtools'
 
-begin
-  require 'rubocop/rake_task'
-  RuboCop::RakeTask.new do |task|
-    task.options = %w(--config config/rubocop.yml)
-  end
-rescue LoadError
-  desc 'Run RuboCop'
-  task :rubocop do
-    $stderr.puts 'RuboCop is disabled'
-  end
-end
-
-require 'yardstick/rake/measurement'
-Yardstick::Rake::Measurement.new do |measurement|
-  measurement.output = 'measurement/report.txt'
-end
-
-require 'yardstick/rake/verify'
-Yardstick::Rake::Verify.new do |verify|
-  verify.threshold = 100
-end
-
-task :ci => [:spec, :rubocop, :verify_measurements]
+Bundler::GemHelper.install_tasks
+Devtools.init_rake_tasks

data/config/devtools.yml

@@ -0,0 +1,2 @@
+---
+unit_test_timeout: 1

data/config/flay.yml

@@ -0,0 +1,4 @@
+---
+threshold: 0
+total_score: 0
+lib_dirs: []

data/config/flog.yml

@@ -0,0 +1,3 @@
+---
+threshold: 15.6
+lib_dirs: ['lib']

data/config/mutant.yml

@@ -0,0 +1,2 @@
+name: equalizer
+namespace: Equalizer

data/config/reek.yml

@@ -0,0 +1,105 @@
+---
+Attribute:
+  enabled: false
+  exclude: []
+BooleanParameter:
+  enabled: true
+  exclude: []
+ClassVariable:
+  enabled: true
+  exclude: []
+ControlParameter:
+  enabled: true
+  exclude: []
+DataClump:
+  enabled: true
+  exclude: []
+  max_copies: 2
+  min_clump_size: 2
+DuplicateMethodCall:
+  enabled: true
+  exclude: []
+  max_calls: 1
+  allow_calls: []
+FeatureEnvy:
+  enabled: true
+  exclude: []
+IrresponsibleModule:
+  enabled: true
+  exclude: []
+LongParameterList:
+  enabled: true
+  exclude: []
+  max_params: 2
+  overrides:
+    initialize:
+      max_params: 3
+LongYieldList:
+  enabled: true
+  exclude: []
+  max_params: 2
+NestedIterators:
+  enabled: true
+  exclude:
+  - Equalizer#define_cmp_method
+  - Equalizer#define_inspect_method
+  max_allowed_nesting: 1
+  ignore_iterators: []
+NilCheck:
+  enabled: true
+  exclude: []
+RepeatedConditional:
+  enabled: true
+  exclude: []
+  max_ifs: 1
+TooManyInstanceVariables:
+  enabled: true
+  exclude: []
+  max_instance_variables: 3
+TooManyMethods:
+  enabled: true
+  exclude: []
+  max_methods: 6
+TooManyStatements:
+  enabled: true
+  exclude:
+  - Equalizer#define_inspect_method
+  max_statements: 5
+UncommunicativeMethodName:
+  enabled: true
+  exclude: []
+  reject:
+  - !ruby/regexp /^[a-z]$/
+  - !ruby/regexp /[0-9]$/
+  - !ruby/regexp /[A-Z]/
+  accept: []
+UncommunicativeModuleName:
+  enabled: true
+  exclude: []
+  reject:
+  - !ruby/regexp /^.$/
+  - !ruby/regexp /[0-9]$/
+  accept: []
+UncommunicativeParameterName:
+  enabled: true
+  exclude: []
+  reject:
+  - !ruby/regexp /^.$/
+  - !ruby/regexp /[0-9]$/
+  - !ruby/regexp /[A-Z]/
+  accept: []
+UncommunicativeVariableName:
+  enabled: true
+  exclude: []
+  reject:
+  - !ruby/regexp /^.$/
+  - !ruby/regexp /[0-9]$/
+  - !ruby/regexp /[A-Z]/
+  accept: []
+UnusedParameters:
+  enabled: true
+  exclude: []
+UtilityFunction:
+  enabled: true
+  exclude: []
+  max_helper_calls: 0

data/config/rubocop.yml

@@ -1,54 +1,115 @@
-Metrics/BlockNesting:
-  Max: 2
-
-Metrics/LineLength:
-  AllowURI: true
-  Enabled: false
-
-Metrics/MethodLength:
-  CountComments: false
-  Max: 15
-
-Metrics/ParameterLists:
-  Max: 4
+# Avoid parameter lists longer than five parameters.
+ParameterLists:
+  Max: 3
   CountKeywordArgs: true
 
-Style/AccessModifierIndentation:
-  EnforcedStyle: outdent
+# Avoid more than `Max` levels of nesting.
+BlockNesting:
+  Max: 3
 
-Style/CollectionMethods:
+# Align with the style guide.
+CollectionMethods:
   PreferredMethods:
-    map:      'collect'
-    reduce:   'inject'
+    collect:  'map'
+    inject:   'reduce'
     find:     'detect'
     find_all: 'select'
 
-Style/Documentation:
+# Do not force public/protected/private keyword to be indented at the same
+# level as the def keyword. My personal preference is to outdent these keywords
+# because I think when scanning code it makes it easier to identify the
+# sections of code and visually separate them. When the keyword is at the same
+# level I think it sort of blends in with the def keywords and makes it harder
+# to scan the code and see where the sections are.
+AccessModifierIndentation:
+  Enabled: false
+
+# Limit line length
+LineLength:
+  Max: 106
+
+# Disable documentation checking until a class needs to be documented once
+Documentation:
+  Enabled: false
+
+# Do not always use &&/|| instead of and/or.
+AndOr:
+  Enabled: false
+
+# Do not favor modifier if/unless usage when you have a single-line body
+IfUnlessModifier:
+  Enabled: false
+
+# Allow case equality operator (in limited use within the specs)
+CaseEquality:
+  Enabled: false
+
+# Constants do not always have to use SCREAMING_SNAKE_CASE
+ConstantName:
   Enabled: false
 
-Style/DotPosition:
-  EnforcedStyle: trailing
+# Not all trivial readers/writers can be defined with attr_* methods
+TrivialAccessors:
+  Enabled: false
 
-Style/DoubleNegation:
+# Allow empty lines around class body
+EmptyLinesAroundClassBody:
   Enabled: false
 
-Style/EachWithObject:
+# Allow empty lines around module body
+EmptyLinesAroundModuleBody:
   Enabled: false
 
-Style/Encoding:
+# Allow empty lines around block body
+EmptyLinesAroundBlockBody:
   Enabled: false
 
-Style/HashSyntax:
-  EnforcedStyle: hash_rockets
+# Allow multiple line operations to not require indentation
+MultilineOperationIndentation:
+  Enabled: false
 
-Style/Lambda:
+# Prefer String#% over Kernel#sprintf
+FormatString:
   Enabled: false
 
-Style/RaiseArgs:
-  EnforcedStyle: compact
+# Use square brackets for literal Array objects
+PercentLiteralDelimiters:
+  PreferredDelimiters:
+    '%':  '{}'
+    '%i': '[]'
+    '%q': ()
+    '%Q': ()
+    '%r': '{}'
+    '%s': ()
+    '%w': '[]'
+    '%W': '[]'
+    '%x': ()
+
+# Use %i[...] for arrays of symbols
+SymbolArray:
+  Enabled: true
 
-Style/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
+# Align if/else blocks with the variable assignment
+EndAlignment:
+  AlignWith: variable
 
-Style/TrailingComma:
-  EnforcedStyleForMultiline: 'comma'
+# Do not always align parameters when it is easier to read
+AlignParameters:
+  Exclude:
+    - spec/**/*_spec.rb
+
+# Prefer #kind_of? over #is_a?
+ClassCheck:
+  EnforcedStyle: kind_of?
+
+# Do not prefer double quotes to be used when %q or %Q is more appropriate
+UnneededPercentQ:
+  Enabled: false
+
+# Allow a maximum ABC score
+Metrics/AbcSize:
+  Max: 8.6
+
+# Do not prefer lambda.call(...) over lambda.(...)
+LambdaCall:
+  Enabled: false

data/config/yardstick.yml

@@ -0,0 +1,34 @@
+---
+path: 'lib/**/*.rb'
+threshold: 100
+rules:
+  ApiTag::Presence:
+    enabled: true
+    exclude: []
+  ApiTag::Inclusion:
+    enabled: true
+    exclude: []
+  ApiTag::ProtectedMethod:
+    enabled: true
+    exclude: []
+  ApiTag::PrivateMethod:
+    enabled: true
+    exclude: []
+  ExampleTag:
+    enabled: true
+    exclude: []
+  ReturnTag:
+    enabled: true
+    exclude: []
+  Summary::Presence:
+    enabled: true
+    exclude: []
+  Summary::Length:
+    enabled: true
+    exclude: []
+  Summary::Delimiter:
+    enabled: true
+    exclude: []
+  Summary::SingleLine:
+    enabled: true
+    exclude: []

data/equalizer.gemspec

@@ -6,16 +6,16 @@ Gem::Specification.new do |gem|
   gem.name        = 'equalizer'
   gem.version     = Equalizer::VERSION.dup
   gem.authors     = ['Dan Kubb', 'Markus Schirp']
-  gem.email       = %w(dan.kubb@gmail.com mbj@schirp-dso.com)
+  gem.email       = %w[dan.kubb@gmail.com mbj@schirp-dso.com]
   gem.description = 'Module to define equality, equivalence and inspection methods'
   gem.summary     = gem.description
   gem.homepage    = 'https://github.com/dkubb/equalizer'
   gem.licenses    = 'MIT'
 
-  gem.require_paths    = %w(lib)
+  gem.require_paths    = %w[lib]
   gem.files            = `git ls-files`.split("\n")
   gem.test_files       = `git ls-files -- spec/{unit,integration}`.split("\n")
-  gem.extra_rdoc_files = %w(LICENSE README.md CONTRIBUTING.md)
+  gem.extra_rdoc_files = %w[LICENSE README.md CONTRIBUTING.md]
 
   gem.required_ruby_version = '>= 1.8.7'
 

data/lib/equalizer.rb

@@ -52,7 +52,9 @@ private
   def define_cmp_method
     keys = @keys
     define_method(:cmp?) do |comparator, other|
-      keys.all? { |key| send(key).send(comparator, other.send(key)) }
+      keys.all? do |key|
+        __send__(key).public_send(comparator, other.__send__(key))
+      end
     end
     private :cmp?
   end
@@ -65,7 +67,7 @@ private
   def define_hash_method
     keys = @keys
     define_method(:hash) do | |
-      keys.collect(&method(:send)).push(self.class).hash
+      keys.map(&method(:send)).push(self.class).hash
     end
   end
 
@@ -79,7 +81,7 @@ private
     define_method(:inspect) do | |
       klass = self.class
       name  = klass.name || klass.inspect
-      "#<#{name}#{keys.collect { |key| " #{key}=#{send(key).inspect}" }.join}>"
+      "#<#{name}#{keys.map { |key| " #{key}=#{__send__(key).inspect}" }.join}>"
     end
   end
 
@@ -113,7 +115,7 @@ private
     # @api public
     def ==(other)
       other = coerce(other).first if respond_to?(:coerce, true)
-      other.is_a?(self.class) && cmp?(__method__, other)
+      other.kind_of?(self.class) && cmp?(__method__, other)
     end
   end # module Methods
 end # class Equalizer

data/lib/equalizer/version.rb

@@ -2,5 +2,5 @@
 
 class Equalizer < Module
   # Gem version
-  VERSION = '0.0.10'.freeze
+  VERSION = '0.0.11'.freeze
 end # class Equalizer

data/spec/spec_helper.rb

@@ -4,7 +4,10 @@ if ENV['COVERAGE'] == 'true'
   require 'simplecov'
   require 'coveralls'
 
-  SimpleCov.formatters = [SimpleCov::Formatter::HTMLFormatter, Coveralls::SimpleCov::Formatter]
+  SimpleCov.formatters = [
+    SimpleCov::Formatter::HTMLFormatter,
+    Coveralls::SimpleCov::Formatter
+  ]
 
   SimpleCov.start do
     command_name 'spec:unit'
@@ -20,6 +23,8 @@ end
 require 'equalizer'
 
 RSpec.configure do |config|
+  config.raise_errors_for_deprecations!
+
   config.expect_with :rspec do |expect_with|
     expect_with.syntax = :expect
   end

data/spec/unit/equalizer/included_spec.rb

@@ -11,7 +11,7 @@ describe Equalizer, '#included' do
 
   before do
     # Prevent Module.included from being called through inheritance
-    described_class::Methods.stub(:included)
+    allow(described_class::Methods).to receive(:included)
   end
 
   around do |example|
@@ -36,7 +36,7 @@ describe Equalizer, '#included' do
         # Otherwise, other module includes (which get triggered internally
         # in RSpec when `change` is used for the first time, since it uses
         # autoloading for its matchers) will wrongly set this flag.
-        included = true if self.is_a?(Equalizer)
+        included = true if self.kind_of?(Equalizer)
       end
     end
 

data/spec/unit/equalizer/methods/equality_operator_spec.rb

@@ -83,7 +83,7 @@ describe Equalizer::Methods, '#==' do
       # declare a private #coerce method
       described_class.class_eval do
         def coerce(other)
-          [self.class.new(!!other), self]
+          [self.class.new(![nil, false].include?(other)), self]
         end
         private :coerce
       end
@@ -96,6 +96,26 @@ describe Equalizer::Methods, '#==' do
     end
   end
 
+  context 'with a different object after coercion' do
+    let(:other) { nil }
+
+    before do
+      # declare a private #coerce method
+      described_class.class_eval do
+        def coerce(other)
+          [self.class.new(![nil, false].include?(other)), self]
+        end
+        private :coerce
+      end
+    end
+
+    it { should be(false) }
+
+    it 'is symmetric' do
+      should eql(other == object)
+    end
+  end
+
   context 'with a different object' do
     let(:other) { described_class.new(false) }
 

data/spec/unit/equalizer/universal_spec.rb

@@ -12,7 +12,7 @@ describe Equalizer, '.new' do
 
     before do
       # specify the class #name method
-      klass.stub(:name).and_return(name)
+      allow(klass).to receive(:name).and_return(name)
       klass.send(:include, subject)
     end
 
@@ -23,8 +23,8 @@ describe Equalizer, '.new' do
     it { should be_frozen }
 
     it 'defines #hash and #inspect methods dynamically' do
-      expect(subject.public_instance_methods(false).collect(&:to_s).sort).
-        to eql(%w(hash inspect))
+      expect(subject.public_instance_methods(false).map(&:to_s).sort)
+        .to eql(%w[hash inspect])
     end
 
     describe '#eql?' do
@@ -75,7 +75,7 @@ describe Equalizer, '.new' do
   context 'with keys' do
     subject { object.new(*keys) }
 
-    let(:keys)       { [:firstname, :lastname].freeze }
+    let(:keys)       { %i[firstname lastname].freeze  }
     let(:firstname)  { 'John'                         }
     let(:lastname)   { 'Doe'                          }
     let(:instance)   { klass.new(firstname, lastname) }
@@ -93,8 +93,7 @@ describe Equalizer, '.new' do
 
     before do
       # specify the class #inspect method
-      klass.stub(:name).and_return(nil)
-      klass.stub(:inspect).and_return(name)
+      allow(klass).to receive_messages(name: nil, inspect: name)
       klass.send(:include, subject)
     end
 
@@ -103,8 +102,8 @@ describe Equalizer, '.new' do
     it { should be_frozen }
 
     it 'defines #hash and #inspect methods dynamically' do
-      expect(subject.public_instance_methods(false).collect(&:to_s).sort).
-        to eql(%w(hash inspect))
+      expect(subject.public_instance_methods(false).map(&:to_s).sort)
+        .to eql(%w[hash inspect])
     end
 
     describe '#eql?' do
@@ -143,15 +142,15 @@ describe Equalizer, '.new' do
 
     describe '#hash' do
       it 'returns the expected hash' do
-        expect(instance.hash).
-          to eql([firstname, lastname, klass].hash)
+        expect(instance.hash)
+          .to eql([firstname, lastname, klass].hash)
       end
     end
 
     describe '#inspect' do
       it 'returns the expected string' do
-        expect(instance.inspect).
-          to eql('#<User firstname="John" lastname="Doe">')
+        expect(instance.inspect)
+          .to eql('#<User firstname="John" lastname="Doe">')
       end
     end
   end

metadata

@@ -1,55 +1,66 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: equalizer
-version: !ruby/object:Gem::Version 
-  version: 0.0.10
+version: !ruby/object:Gem::Version
+  version: 0.0.11
 platform: ruby
-authors: 
+authors:
 - Dan Kubb
 - Markus Schirp
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2015-03-20 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  type: :development
-  version_requirements: &id001 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        version: "1.3"
+date: 2015-03-23 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
     - - ">="
-      - !ruby/object:Gem::Version 
+      - !ruby/object:Gem::Version
         version: 1.3.5
-  requirement: *id001
+  type: :development
   prerelease: false
-  name: bundler
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.3.5
 description: Module to define equality, equivalence and inspection methods
-email: 
+email:
 - dan.kubb@gmail.com
 - mbj@schirp-dso.com
 executables: []
-
 extensions: []
-
-extra_rdoc_files: 
+extra_rdoc_files:
 - LICENSE
 - README.md
 - CONTRIBUTING.md
-files: 
-- .gitignore
-- .rspec
-- .rubocop.yml
-- .ruby-gemset
-- .travis.yml
-- .yardstick.yml
+files:
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
+- ".ruby-gemset"
+- ".ruby-version"
+- ".travis.yml"
+- ".yardstick.yml"
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
+- config/devtools.yml
+- config/flay.yml
+- config/flog.yml
+- config/mutant.yml
+- config/reek.yml
 - config/rubocop.yml
+- config/yardstick.yml
 - equalizer.gemspec
 - lib/equalizer.rb
 - lib/equalizer/version.rb
@@ -60,33 +71,30 @@ files:
 - spec/unit/equalizer/methods/equality_operator_spec.rb
 - spec/unit/equalizer/universal_spec.rb
 homepage: https://github.com/dkubb/equalizer
-licenses: 
+licenses:
 - MIT
 metadata: {}
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  requirements: 
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
+    - !ruby/object:Gem::Version
       version: 1.8.7
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  requirements: 
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Module to define equality, equivalence and inspection methods
-test_files: 
+test_files:
 - spec/unit/equalizer/included_spec.rb
 - spec/unit/equalizer/methods/eql_predicate_spec.rb
 - spec/unit/equalizer/methods/equality_operator_spec.rb