RubyGems - epics - Versions diffs - 1.3.0 → 1.3.1 - Mend

epics 1.3.0 → 1.3.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (16) hide show

checksums.yaml +4 -4
data/CHANGELOG.md +5 -0
data/lib/epics/client.rb +5 -5
data/lib/epics/response.rb +14 -14
data/lib/epics/version.rb +1 -1
data/spec/client_spec.rb +2 -2
data/spec/fixtures/xml/ebics_business_nok.xml +20 -21
data/spec/fixtures/xml/ebics_technical_nok.xml +2 -2
data/spec/fixtures/xml/hpb_response_ebics_ns.xml +20 -0
data/spec/fixtures/xml/hpb_response_order.xml +4 -2
data/spec/fixtures/xml/ini_response_h004_ns.xml +13 -0
data/spec/fixtures/xml/upload_init_response.xml +1 -1
data/spec/middleware/parse_ebics_spec.rb +1 -1
data/spec/response_spec.rb +33 -3
metadata +7 -5
data/spec/fixtures/xml/hpb_response.xml +0 -21

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 374545797bb76c3cca30bc9e628692dc7e1d3667
-  data.tar.gz: 73abda6207abda78a72706b8e76161acfb1e73f1
+  metadata.gz: 61d881bf8791586ff4fa95db25764760a5ca0a1f
+  data.tar.gz: 63360ac97af8276e2338498e38f43e9c3460d10f
 SHA512:
-  metadata.gz: 34ff475ce4c532e56308cb300db75f1c87c0b9bf09e51093e80d4d09cef3c37510a49c48eef769277e32d74fa59dfb296dda228b91ca6e23a996585bd3e03fcd
-  data.tar.gz: 327e51904471698d960b82888a39eff70fb3516008f40d56af39ad6878e2c4444448eebbcf963f5fc061102d5b33cd8d21e813acb6058e2f51daa3af3b68077f
+  metadata.gz: d9d31d54ffdeb3c97f0a4c3b49192272b1ea6e1829a3de89b299a783cb28b487e12dfb5e1c531156a26083c38f3d774664942a9390dac99f0171c7b2e031137d
+  data.tar.gz: 856a8e8940b28ced56c3d02118dd1a819331d2eb16febbe08cf797e69e1099153456a3e3dcaec89d503a1b45a43a31f96f7287c740c81a9f4b22dd313983d460

data/CHANGELOG.md CHANGED Viewed

@@ -1,3 +1,8 @@
+### 1.3.1
+  * [ENHANCEMENT] make xpath namespaces explicit, so we can cover a wider
+  rage of responses
 ### 1.3.0
   * [BUGFIX] unzip C5X payloads

data/lib/epics/client.rb CHANGED Viewed

@@ -95,7 +95,7 @@ class Epics::Client
   end
   def HPB
-    Nokogiri::XML(download(Epics::HPB)).xpath("//xmlns:PubKeyValue").each do |node|
+    Nokogiri::XML(download(Epics::HPB)).xpath("//xmlns:PubKeyValue", xmlns: "urn:org:ebics:H004").each do |node|
       type = node.parent.last_element_child.content
       modulus  = Base64.decode64(node.at_xpath(".//*[local-name() = 'Modulus']").content)
@@ -136,14 +136,14 @@ class Epics::Client
   end
   def HAA
-    Nokogiri::XML(download(Epics::HAA)).at_xpath("//xmlns:OrderTypes").content.split(/\s/)
+    Nokogiri::XML(download(Epics::HAA)).at_xpath("//xmlns:OrderTypes", xmlns: "urn:org:ebics:H004").content.split(/\s/)
   end
   def HTD
     Nokogiri::XML(download(Epics::HTD)).tap do |htd|
-      @iban ||= htd.at_xpath("//xmlns:AccountNumber[@international='true']").text
-      @bic  ||= htd.at_xpath("//xmlns:BankCode[@international='true']").text
-      @name ||= htd.at_xpath("//xmlns:Name").text
+      @iban ||= htd.at_xpath("//xmlns:AccountNumber[@international='true']", xmlns: "urn:org:ebics:H004").text
+      @bic  ||= htd.at_xpath("//xmlns:BankCode[@international='true']", xmlns: "urn:org:ebics:H004").text
+      @name ||= htd.at_xpath("//xmlns:Name", xmlns: "urn:org:ebics:H004").text
     end.to_xml
   end

data/lib/epics/response.rb CHANGED Viewed

@@ -12,7 +12,7 @@ class Epics::Response
   end
   def technical_code
-    doc.xpath("//xmlns:header/xmlns:mutable/xmlns:ReturnCode").text
+    doc.xpath("//xmlns:header/xmlns:mutable/xmlns:ReturnCode", xmlns: "urn:org:ebics:H004").text
   end
   def business_error?
@@ -20,7 +20,7 @@ class Epics::Response
   end
   def business_code
-    doc.xpath("//xmlns:body/xmlns:ReturnCode").text
+    doc.xpath("//xmlns:body/xmlns:ReturnCode", xmlns: "urn:org:ebics:H004").text
   end
   def ok?
@@ -28,34 +28,34 @@ class Epics::Response
   end
   def last_segment?
-    !!doc.at_xpath("//xmlns:header/xmlns:mutable/*[@lastSegment='true']")
+    !!doc.at_xpath("//xmlns:header/xmlns:mutable/*[@lastSegment='true']", xmlns: "urn:org:ebics:H004")
   end
   def segmented?
-    !!doc.at_xpath("//xmlns:header/xmlns:mutable/xmlns:SegmentNumber")
+    !!doc.at_xpath("//xmlns:header/xmlns:mutable/xmlns:SegmentNumber", xmlns: "urn:org:ebics:H004")
   end
   def return_code
-    doc.xpath("//xmlns:ReturnCode").last.content
+    doc.xpath("//xmlns:ReturnCode", xmlns: "urn:org:ebics:H004").last.content
   rescue NoMethodError
     nil
   end
   def report_text
-    doc.xpath("//xmlns:ReportText").first.content
+    doc.xpath("//xmlns:ReportText", xmlns: "urn:org:ebics:H004").first.content
   end
   def transaction_id
-    doc.xpath("//xmlns:header/xmlns:static/xmlns:TransactionID").text
+    doc.xpath("//xmlns:header/xmlns:static/xmlns:TransactionID", xmlns: 'urn:org:ebics:H004').text
   end
   def order_id
-    doc.xpath("//xmlns:header/xmlns:mutable/xmlns:OrderID").text
+    doc.xpath("//xmlns:header/xmlns:mutable/xmlns:OrderID", xmlns: "urn:org:ebics:H004").text
   end
   def digest_valid?
     authenticated = doc.xpath("//*[@authenticate='true']").map(&:canonicalize).join
-    digest_value = doc.xpath("//ds:DigestValue").first
+    digest_value = doc.xpath("//ds:DigestValue", ds: "http://www.w3.org/2000/09/xmldsig#").first
     digest = Base64.encode64(digester.digest(authenticated)).strip
@@ -63,20 +63,20 @@ class Epics::Response
   end
   def signature_valid?
-    signature = doc.xpath("//ds:SignedInfo").first.canonicalize
-    signature_value = doc.xpath("//ds:SignatureValue").first
+    signature = doc.xpath("//ds:SignedInfo", ds: "http://www.w3.org/2000/09/xmldsig#").first.canonicalize
+    signature_value = doc.xpath("//ds:SignatureValue", ds: "http://www.w3.org/2000/09/xmldsig#").first
     client.bank_x.key.verify(digester, Base64.decode64(signature_value.content), signature)
   end
   def public_digest_valid?
-    encryption_pub_key_digest = doc.xpath("//xmlns:EncryptionPubKeyDigest").first
+    encryption_pub_key_digest = doc.xpath("//xmlns:EncryptionPubKeyDigest", xmlns: 'urn:org:ebics:H004').first
     client.e.public_digest == encryption_pub_key_digest.content
   end
   def order_data
-    order_data_encrypted = Base64.decode64(doc.xpath("//xmlns:OrderData").first.content)
+    order_data_encrypted = Base64.decode64(doc.xpath("//xmlns:OrderData", xmlns: 'urn:org:ebics:H004').first.content)
     data = (cipher.update(order_data_encrypted) + cipher.final)
@@ -93,7 +93,7 @@ class Epics::Response
   end
   def transaction_key
-    transaction_key_encrypted = Base64.decode64(doc.xpath("//xmlns:TransactionKey").first.content)
+    transaction_key_encrypted = Base64.decode64(doc.xpath("//xmlns:TransactionKey", xmlns: 'urn:org:ebics:H004').first.content)
     @transaction_key ||= client.e.key.private_decrypt(transaction_key_encrypted)
   end

data/lib/epics/version.rb CHANGED Viewed

@@ -1,3 +1,3 @@
 module Epics
-  VERSION = "1.3.0"
+  VERSION = "1.3.1"
 end

data/spec/client_spec.rb CHANGED Viewed

@@ -67,8 +67,8 @@ RSpec.describe Epics::Client do
     before do
       stub_request(:post, "https://194.180.18.30/ebicsweb/ebicsweb")
-        .with(:body => %r[<?xml(.*)ebicsNoPubKeyDigestsRequest>])
-        .to_return(status: 200, body: File.read(File.join(File.dirname(__FILE__), 'fixtures', 'xml', 'hpb_response.xml')))
+        .with(:body => %r[ebicsNoPubKeyDigestsRequest])
+        .to_return(status: 200, body: File.read(File.join(File.dirname(__FILE__), 'fixtures', 'xml', 'hpb_response_ebics_ns.xml')))
     end
     it { expect(subject.HPB).to match([be_a(Epics::Key), be_a(Epics::Key)]) }

data/spec/fixtures/xml/ebics_business_nok.xml CHANGED Viewed

@@ -1,21 +1,20 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<ebicsKeyManagementResponse xmlns="http://www.ebics.org/H003" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" Revision="1" Version="H003" xsi:schemaLocation="http://www.ebics.org/H003 http://www.ebics.org/H003/ebics_keymgmt_response.xsd">
-  <header authenticate="true">
-    <static/>
-    <mutable>
-      <ReturnCode>000000</ReturnCode>
-      <ReportText>[EBICS_OK] OK</ReportText>
-    </mutable>
-  </header>
-  <body>
-    <DataTransfer>
-      <DataEncryptionInfo authenticate="true">
-        <EncryptionPubKeyDigest Algorithm="http://www.w3.org/2001/04/xmlenc#sha256" Version="E002">rwIxSUJAVEFDQ0sdYe+CybdspMllDG6ArNtdCzUbT1E=</EncryptionPubKeyDigest>
-        <TransactionKey>CPdd6ODXrCxHWpYrwS/5a3NIZ1R2SDscHHJSONc2I7g8ara7qv5Ra7H03W+336DPQLZQxH+EBRWdE2FQ1vrVTcypK6fkFarmO1dEtQt6Ka89AozC7aQMyp4yGl+zlF+XvFkJXZbRXgoEOPsgcG0xM6nKLXnr1ThYRFOoAasigLDGwqxliyhoR94F9dL7YB8Le/uZeRj78mNp4smkE5ZKKyPhwVx+0IW78YuVCSC2c2qbsMmm4evAvycdpLfuuoG4KVlNMIlvkKeBfMZFELcmeKKm85D2zPYkZ7cqG2IfAAp5qdS6K8P7RY4gtjUhOtP5mi8bZt/ZcjioUmIR9dAMnA==</TransactionKey>
-      </DataEncryptionInfo>
-      <OrderData>lJ/v1HvOYAZKTPkxULH4mOcUy01+EaAsxLzCPhtieAo9m5AtU5URdyBVfmclHbtWe3ELb02lR37bChynq0Esqpljxx7CiB+kl/bVs7XkNQQmtGPlh08O7ApJ7AHdKPFFvE+SM2OWpSwUrqJGtmyaU6s+RM66o/3Q0wvKi4y3+Q2jm8nkiWZpPfNt52g4ReE9Ge86o+L+EBOBgZm634L5Z/i6pq908mXBAklPdk1ERdEgWONaOeYYmB70FToplR1gINJEF2CnfAtD/wV+DuQFPDth+EWHqhe3a4xO0d9eJ55ou2QCYOPUC2g/qz1sp7GR74W7P5IWJdmnUEuPFsKJ6OvM+1V8S06jZGDa/QhUGDK8F3G/TMP09W1MsrlQTRr3YQ5H43+pMY7I6Jysze+X9OKZZTTpv4GmYm1USjmraGyMuPF3j9hrlmpttK+1gg2WzytCJO44YsZp9ckls8JNK4bT5uwTuomKZoRgmiIOTcMh4VP7V28TWj2XdF+T6rBFILTvQyXMOzvbe1kLwg2O31JDBdJ8X1fHCYJxKsIrYCSDPz4sha8h7QmHrCSFmjoXb+LUElnbLXZVRkY5/Dc73EM6Es3wAgjwSJK2asRqdqU0PhbS5qpIlgYKsNcb+Wes</OrderData>
-    </DataTransfer>
-    <ReturnCode authenticate="true">091116</ReturnCode>
-    <TimestampBankParameter authenticate="true">2009-06-16T17:56:05.698+02:00</TimestampBankParameter>
-  </body>
-</ebicsKeyManagementResponse>
+<ebics:ebicsKeyManagementResponse xmlns:ebics="urn:org:ebics:H004" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" Revision="1" Version="H004" xsi:schemaLocation="urn:org:ebics:H004 ebics_keymgmt_response_H004.xsd">
+  <ebics:header authenticate="true">
+    <ebics:static />
+    <ebics:mutable>
+      <ebics:ReturnCode>000000</ebics:ReturnCode>
+      <ebics:ReportText>[EBICS_OK] OK</ebics:ReportText>
+    </ebics:mutable>
+  </ebics:header>
+  <ebics:body>
+    <ebics:DataTransfer>
+      <ebics:DataEncryptionInfo authenticate="true">
+        <ebics:EncryptionPubKeyDigest Algorithm="http://www.w3.org/2001/04/xmlenc#sha256" Version="E002">rwIxSUJAVEFDQ0sdYe+CybdspMllDG6ArNtdCzUbT1E=</ebics:EncryptionPubKeyDigest>
+        <ebics:TransactionKey>CPdd6ODXrCxHWpYrwS/5a3NIZ1R2SDscHHJSONc2I7g8ara7qv5Ra7H03W+336DPQLZQxH+EBRWdE2FQ1vrVTcypK6fkFarmO1dEtQt6Ka89AozC7aQMyp4yGl+zlF+XvFkJXZbRXgoEOPsgcG0xM6nKLXnr1ThYRFOoAasigLDGwqxliyhoR94F9dL7YB8Le/uZeRj78mNp4smkE5ZKKyPhwVx+0IW78YuVCSC2c2qbsMmm4evAvycdpLfuuoG4KVlNMIlvkKeBfMZFELcmeKKm85D2zPYkZ7cqG2IfAAp5qdS6K8P7RY4gtjUhOtP5mi8bZt/ZcjioUmIR9dAMnA==</ebics:TransactionKey>
+      </ebics:DataEncryptionInfo>
+      <ebics:OrderData>lJ/v1HvOYAZKTPkxULH4mOcUy01+EaAsxLzCPhtieAo9m5AtU5URdyBVfmclHbtWe3ELb02lR37bChynq0Esqpljxx7CiB+kl/bVs7XkNQQmtGPlh08O7ApJ7AHdKPFFvE+SM2OWpSwUrqJGtmyaU6s+RM66o/3Q0wvKi4y3+Q2jm8nkiWZpPfNt52g4ReE9Ge86o+L+EBOBgZm634L5Z/i6pq908mXBAklPdk1ERdEgWONaOeYYmB70FToplR1gINJEF2CnfAtD/wV+DuQFPDth+EWHqhe3a4xO0d9eJ55ou2QCYOPUC2g/qz1sp7GR74W7P5IWJdmnUEuPFsKJ6OvM+1V8S06jZGDa/QhUGDK8F3G/TMP09W1MsrlQTRr3YQ5H43+pMY7I6Jysze+X9OKZZTTpv4GmYm1USjmraGyMuPF3j9hrlmpttK+1gg2WzytCJO44YsZp9ckls8JNK4bT5uwTuomKZoRgmiIOTcMh4VP7V28TWj2XdF+T6rBFILTvQyXMOzvbe1kLwg2O31JDBdJ8X1fHCYJxKsIrYCSDPz4sha8h7QmHrCSFmjoXb+LUElnbLXZVRkY5/Dc73EM6Es3wAgjwSJK2asRqdqU0PhbS5qpIlgYKsNcb+Wes</ebics:OrderData>
+    </ebics:DataTransfer>
+    <ebics:ReturnCode authenticate="true">091116</ebics:ReturnCode>
+    <ebics:TimestampBankParameter authenticate="true">2007-10-19T14:58:39.467Z</ebics:TimestampBankParameter>
+  </ebics:body>
+</ebics:ebicsKeyManagementResponse>

data/spec/fixtures/xml/ebics_technical_nok.xml CHANGED Viewed

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<ebicsKeyManagementResponse xmlns="http://www.ebics.org/H003" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" Revision="1" Version="H003" xsi:schemaLocation="http://www.ebics.org/H003 http://www.ebics.org/H003/ebics_keymgmt_response.xsd">
+<ebicsKeyManagementResponse xmlns="urn:org:ebics:H004" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" Revision="1" Version="H004" xsi:schemaLocation="urn:org:ebics:H004 ebics_keymgmt_response_H004.xsd">
   <header authenticate="true">
     <static/>
     <mutable>
@@ -9,4 +9,4 @@
   </header>
   <body>
   </body>
-</ebicsKeyManagementResponse>
+</ebicsKeyManagementResponse>

data/spec/fixtures/xml/hpb_response_ebics_ns.xml ADDED Viewed

@@ -0,0 +1,20 @@
+<ebics:bicsKeyManagementResponse xmlns:ebics="urn:org:ebics:H004" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" Revision="1" Version="H004" xsi:schemaLocation="urn:org:ebics:H004 ebics_keymgmt_response_H004.xsd">
+  <ebics:header authenticate="true">
+    <ebics:static />
+    <ebics:mutable>
+      <ebics:ReturnCode>000000</ebics:ReturnCode>
+      <ebics:ReportText>[EBICS_OK] OK</ebics:ReportText>
+    </ebics:mutable>
+  </ebics:header>
+  <ebics:body>
+    <ebics:DataTransfer>
+      <ebics:DataEncryptionInfo authenticate="true">
+        <ebics:EncryptionPubKeyDigest Algorithm="http://www.w3.org/2001/04/xmlenc#sha256" Version="E002">rwIxSUJAVEFDQ0sdYe+CybdspMllDG6ArNtdCzUbT1E=</ebics:EncryptionPubKeyDigest>
+        <ebics:TransactionKey>CPdd6ODXrCxHWpYrwS/5a3NIZ1R2SDscHHJSONc2I7g8ara7qv5Ra7H03W+336DPQLZQxH+EBRWdE2FQ1vrVTcypK6fkFarmO1dEtQt6Ka89AozC7aQMyp4yGl+zlF+XvFkJXZbRXgoEOPsgcG0xM6nKLXnr1ThYRFOoAasigLDGwqxliyhoR94F9dL7YB8Le/uZeRj78mNp4smkE5ZKKyPhwVx+0IW78YuVCSC2c2qbsMmm4evAvycdpLfuuoG4KVlNMIlvkKeBfMZFELcmeKKm85D2zPYkZ7cqG2IfAAp5qdS6K8P7RY4gtjUhOtP5mi8bZt/ZcjioUmIR9dAMnA==</ebics:TransactionKey>
+      </ebics:DataEncryptionInfo>
+      <ebics:OrderData>tPp8sZbGSkjaUy4IoNektKEK1KekTQxLwIZ+AYhyuL99erg26xK1ZcvXd+vJwSfl5TV21qQHybID5CnnP5ZvjcxBdwrK0hyMyp2FYJAY16wLAt++Esydx55XSBvutQASBEnPd01uq3Gd4tPLLbrlBGCDEtqJcfbLEOyWvxYFNDb/HU6RpOCD7JN3jL+LRLsFfrZEK96QO8IzpCtiAYBJ6C3OaHsETt0wBx1lYy7JBSw+nIEEzE6+N3EjJjE3++9BfCDE0ca7kpWCSJ666dUuelPuIS45LjcFbTGROdZ1BTJc6F39Zjxud2yUJIEJINQUZA2O8628gVi2GvoUZuILFx1TsCik1T2ims7EVqkfSNEBpKCa3mtmNMEFepdXNTBm3Kf+J+5ATnqq1EJrYBkGpDPii4jgvVPNIkXJlx5DqqhgUUCShnCLOingwrE+z5ekRM5091iHl1C4APfR05gl0Q81D5HiV9m4CuMjx4Lp7mm0vdgP1LNiaA1BnKIeFob+4SN4Kv7AoP7nxk+3nINMd0yGujsnMx6WgGFn4lvv7IH250+LUZJM4rkdVx9FacxU+P+B6+GDHpLKZyT84WKvPXWnoIhPpykR/Pbysoe+WdAf7cMVp9K5Q5QhfPaMu2eIZjR5+IRIUXxhTo8k2vDG4XBcjgVygP5GJAN83pjXuwdo5JRxyGZAOqvBr7cHmmCG</ebics:OrderData>
+    </ebics:DataTransfer>
+    <ebics:ReturnCode authenticate="true">000000</ebics:ReturnCode>
+    <ebics:TimestampBankParameter authenticate="true">2007-10-19T14:58:39.467Z</ebics:TimestampBankParameter>
+  </ebics:body>
+</ebics:ebicsKeyManagementResponse>

data/spec/fixtures/xml/hpb_response_order.xml CHANGED Viewed

@@ -1,11 +1,12 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<HPBResponseOrderData xmlns="http://www.ebics.org/H003" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xsi:schemaLocation="http://www.ebics.org/H003 http://www.ebics.org/H003/ebics_orders.xsd">
+<HPBResponseOrderData xmlns="urn:org:ebics:H004" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xsi:schemaLocation="http://www.ebics.org/H003 http://www.ebics.org/H003/ebics_orders.xsd">
   <AuthenticationPubKeyInfo>
     <PubKeyValue>
       <ds:RSAKeyValue>
         <ds:Modulus>AJ2/0OoIZydb9sgKbiwqDcwA0NtcUMIYi6GK7PqoRszu1uytGnxJjQhGt62kMslWvLgebUSwdq/T3YyGsa3KQeIGaUUn9iqyu3BoNOMdo2DLN4NdGMY1WR/HbYRKR3JHyURhTBKw27KScRRdKGl6jY+VcXcTKJL8PjXMQH5cD6Gz</ds:Modulus>
         <ds:Exponent>AQAB</ds:Exponent>
       </ds:RSAKeyValue>
+      <TimeStamp>2007-03-13T11:33:16.616Z</TimeStamp>
     </PubKeyValue>
     <AuthenticationVersion>X002</AuthenticationVersion>
   </AuthenticationPubKeyInfo>
@@ -15,8 +16,9 @@
         <ds:Modulus>AJ2/0OoIZydb9sgKbiwqDcwA0NtcUMIYi6GK7PqoRszu1uytGnxJjQhGt62kMslWvLgebUSwdq/T3YyGsa3KQeIGaUUn9iqyu3BoNOMdo2DLN4NdGMY1WR/HbYRKR3JHyURhTBKw27KScRRdKGl6jY+VcXcTKJL8PjXMQH5cD6Gz</ds:Modulus>
         <ds:Exponent>AQAB</ds:Exponent>
       </ds:RSAKeyValue>
+      <TimeStamp>2007-03-13T11:33:16.616Z</TimeStamp>
     </PubKeyValue>
     <EncryptionVersion>E002</EncryptionVersion>
   </EncryptionPubKeyInfo>
   <HostID>SIZBN001</HostID>
-</HPBResponseOrderData>
+</HPBResponseOrderData>

data/spec/fixtures/xml/ini_response_h004_ns.xml ADDED Viewed

@@ -0,0 +1,13 @@
+<h004:ebicsKeyManagementResponse xmlns:h004="urn:org:ebics:H004" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="urn:org:ebics:H004 ebics_H004.xsd" Version="H004" Revision="1">
+  <h004:header authenticate="true">
+    <h004:static />
+    <h004:mutable>
+      <h004:OrderID>B004</h004:OrderID>
+      <h004:ReturnCode>000000</h004:ReturnCode>
+      <h004:ReportText>[EBICS_OK] OK</h004:ReportText>
+    </h004:mutable>
+  </h004:header>
+  <h004:body>
+    <h004:ReturnCode authenticate="true">000000</h004:ReturnCode>
+  </h004:body>
+</h004:ebicsKeyManagementResponse>

data/spec/fixtures/xml/upload_init_response.xml CHANGED Viewed

@@ -28,4 +28,4 @@
     <ReturnCode authenticate="true">000000</ReturnCode>
     <TimestampBankParameter authenticate="true">2009-06-16T17:56:05.698+02:00</TimestampBankParameter>
   </body>
-</ebicsResponse>
+</ebicsResponse>

data/spec/middleware/parse_ebics_spec.rb CHANGED Viewed

@@ -5,7 +5,7 @@ RSpec.describe Epics::ParseEbics do
       builder.adapter :test, Faraday::Adapter::Test::Stubs.new do |stub|
         stub.post('/business_nok') {[ 200, {}, File.read( File.join( File.dirname(__FILE__), '..', 'fixtures', 'xml', 'ebics_business_nok.xml') )  ]}
         stub.post('/technical_nok') {[ 200, {}, File.read( File.join( File.dirname(__FILE__), '..', 'fixtures', 'xml', 'ebics_technical_nok.xml') )  ]}
-        stub.post('/ok') {[ 200, {}, File.read( File.join( File.dirname(__FILE__), '..', 'fixtures', 'xml', 'hpb_response.xml') )  ]}
+        stub.post('/ok') {[ 200, {}, File.read( File.join( File.dirname(__FILE__), '..', 'fixtures', 'xml', 'hpb_response_ebics_ns.xml') )  ]}
       end
       builder.use Epics::ParseEbics
     end

data/spec/response_spec.rb CHANGED Viewed

@@ -10,6 +10,22 @@ RSpec.describe Epics::Response do
     end
   end
+  describe '#technical_code' do
+    let(:ebics_response) { File.read('spec/fixtures/xml/ini_response_h004_ns.xml') }
+    it 'is extracted from the response' do
+      expect(subject.technical_code).to eq("000000")
+    end
+  end
+  describe '#business_code' do
+    let(:ebics_response) { File.read('spec/fixtures/xml/ebics_business_nok.xml') }
+    it 'is extracted from the response' do
+      expect(subject.business_code).to eq("091116")
+    end
+  end
   describe '#signature_valid?' do
     let(:ebics_response) { File.read('spec/fixtures/xml/upload_init_response.xml') }
@@ -19,7 +35,7 @@ RSpec.describe Epics::Response do
   end
   describe '#public_digest_valid?' do
-    let(:ebics_response) { File.read('spec/fixtures/xml/hpb_response.xml') }
+    let(:ebics_response) { File.read('spec/fixtures/xml/hpb_response_ebics_ns.xml') }
     it "checks if //xmlns:EncryptionPubKeyDigest matches the user encryption key" do
       expect(subject.public_digest_valid?).to be(true)
@@ -27,7 +43,7 @@ RSpec.describe Epics::Response do
   end
   describe 'order_data' do
-    let(:ebics_response) { File.read('spec/fixtures/xml/hpb_response.xml') }
+    let(:ebics_response) { File.read('spec/fixtures/xml/hpb_response_ebics_ns.xml') }
     let(:order_data) { File.read('spec/fixtures/xml/hpb_response_order.xml') }
     it "retrieves the decrypted order data" do
@@ -35,6 +51,13 @@ RSpec.describe Epics::Response do
     end
   end
+  describe '#report_text' do
+    let(:ebics_response) { File.read('spec/fixtures/xml/sta_response.xml') }
+    it 'pulls the report_text from the response' do
+      expect(subject.report_text).to eq('[EBICS_OK] OK')
+    end
+  end
   describe '#transaction_id' do
     let(:ebics_response) { File.read('spec/fixtures/xml/sta_response.xml') }
     it 'pulls the transaction_id from the response' do
@@ -42,6 +65,13 @@ RSpec.describe Epics::Response do
     end
   end
+  describe '#order_id' do
+    let(:ebics_response) { File.read('spec/fixtures/xml/cd1_init_response.xml') }
+    it 'pulls the order_id from the response' do
+      expect(subject.order_id).to eq('N00L')
+    end
+  end
   describe '#last_segment?' do
     describe 'when its the last segement' do
       let(:ebics_response) { File.read('spec/fixtures/xml/sta_response.xml') }
@@ -69,7 +99,7 @@ RSpec.describe Epics::Response do
     end
     describe 'when the response is not segemnted' do
-      let(:ebics_response) { File.read('spec/fixtures/xml/hpb_response.xml') }
+      let(:ebics_response) { File.read('spec/fixtures/xml/hpb_response_ebics_ns.xml') }
       it 'will be false' do
         expect(subject.segmented?).to be(false)

metadata CHANGED Viewed

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: epics
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Lars Brillert
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-08-05 00:00:00.000000000 Z
+date: 2015-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -224,11 +224,12 @@ files:
 - spec/fixtures/xml/hia_request_order_data.xml
 - spec/fixtures/xml/hpb.xml
 - spec/fixtures/xml/hpb_request.xml
-- spec/fixtures/xml/hpb_response.xml
+- spec/fixtures/xml/hpb_response_ebics_ns.xml
 - spec/fixtures/xml/hpb_response_order.xml
 - spec/fixtures/xml/hpb_response_order_without_ns.xml
 - spec/fixtures/xml/htd_order_data.xml
 - spec/fixtures/xml/ini.xml
+- spec/fixtures/xml/ini_response_h004_ns.xml
 - spec/fixtures/xml/signature_pub_key_order_data.xml
 - spec/fixtures/xml/sta_response.xml
 - spec/fixtures/xml/sta_response_continued.xml
@@ -294,7 +295,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project:
-rubygems_version: 2.4.5
+rubygems_version: 2.4.8
 signing_key:
 specification_version: 4
 summary: a ruby implementation of the EBICS protocol
@@ -317,11 +318,12 @@ test_files:
 - spec/fixtures/xml/hia_request_order_data.xml
 - spec/fixtures/xml/hpb.xml
 - spec/fixtures/xml/hpb_request.xml
-- spec/fixtures/xml/hpb_response.xml
+- spec/fixtures/xml/hpb_response_ebics_ns.xml
 - spec/fixtures/xml/hpb_response_order.xml
 - spec/fixtures/xml/hpb_response_order_without_ns.xml
 - spec/fixtures/xml/htd_order_data.xml
 - spec/fixtures/xml/ini.xml
+- spec/fixtures/xml/ini_response_h004_ns.xml
 - spec/fixtures/xml/signature_pub_key_order_data.xml
 - spec/fixtures/xml/sta_response.xml
 - spec/fixtures/xml/sta_response_continued.xml

data/spec/fixtures/xml/hpb_response.xml DELETED Viewed

@@ -1,21 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<ebicsKeyManagementResponse xmlns="http://www.ebics.org/H003" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" Revision="1" Version="H003" xsi:schemaLocation="http://www.ebics.org/H003 http://www.ebics.org/H003/ebics_keymgmt_response.xsd">
-  <header authenticate="true">
-    <static/>
-    <mutable>
-      <ReturnCode>000000</ReturnCode>
-      <ReportText>[EBICS_OK] OK</ReportText>
-    </mutable>
-  </header>
-  <body>
-    <DataTransfer>
-      <DataEncryptionInfo authenticate="true">
-        <EncryptionPubKeyDigest Algorithm="http://www.w3.org/2001/04/xmlenc#sha256" Version="E002">rwIxSUJAVEFDQ0sdYe+CybdspMllDG6ArNtdCzUbT1E=</EncryptionPubKeyDigest>
-        <TransactionKey>CPdd6ODXrCxHWpYrwS/5a3NIZ1R2SDscHHJSONc2I7g8ara7qv5Ra7H03W+336DPQLZQxH+EBRWdE2FQ1vrVTcypK6fkFarmO1dEtQt6Ka89AozC7aQMyp4yGl+zlF+XvFkJXZbRXgoEOPsgcG0xM6nKLXnr1ThYRFOoAasigLDGwqxliyhoR94F9dL7YB8Le/uZeRj78mNp4smkE5ZKKyPhwVx+0IW78YuVCSC2c2qbsMmm4evAvycdpLfuuoG4KVlNMIlvkKeBfMZFELcmeKKm85D2zPYkZ7cqG2IfAAp5qdS6K8P7RY4gtjUhOtP5mi8bZt/ZcjioUmIR9dAMnA==</TransactionKey>
-      </DataEncryptionInfo>
-      <OrderData>lJ/v1HvOYAZKTPkxULH4mOcUy01+EaAsxLzCPhtieAo9m5AtU5URdyBVfmclHbtWe3ELb02lR37bChynq0Esqpljxx7CiB+kl/bVs7XkNQQmtGPlh08O7ApJ7AHdKPFFvE+SM2OWpSwUrqJGtmyaU6s+RM66o/3Q0wvKi4y3+Q2jm8nkiWZpPfNt52g4ReE9Ge86o+L+EBOBgZm634L5Z/i6pq908mXBAklPdk1ERdEgWONaOeYYmB70FToplR1gINJEF2CnfAtD/wV+DuQFPDth+EWHqhe3a4xO0d9eJ55ou2QCYOPUC2g/qz1sp7GR74W7P5IWJdmnUEuPFsKJ6OvM+1V8S06jZGDa/QhUGDK8F3G/TMP09W1MsrlQTRr3YQ5H43+pMY7I6Jysze+X9OKZZTTpv4GmYm1USjmraGyMuPF3j9hrlmpttK+1gg2WzytCJO44YsZp9ckls8JNK4bT5uwTuomKZoRgmiIOTcMh4VP7V28TWj2XdF+T6rBFILTvQyXMOzvbe1kLwg2O31JDBdJ8X1fHCYJxKsIrYCSDPz4sha8h7QmHrCSFmjoXb+LUElnbLXZVRkY5/Dc73EM6Es3wAgjwSJK2asRqdqU0PhbS5qpIlgYKsNcb+Wes</OrderData>
-    </DataTransfer>
-    <ReturnCode authenticate="true">000000</ReturnCode>
-    <TimestampBankParameter authenticate="true">2009-06-16T17:56:05.698+02:00</TimestampBankParameter>
-  </body>
-</ebicsKeyManagementResponse>