epay_tools 0.0.0 → 0.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e0100543f3eec103be865666ec628acb20c1f366
-  data.tar.gz: a9c15ea0e85a6af239e0beb3489c7562ae16a4e8
+  metadata.gz: 86a7d1fe9a1ab192dac56eda9de0603d138ef6fb
+  data.tar.gz: '009453ed0b480464cbb884fa4059c52195b1413c'
 SHA512:
-  metadata.gz: d008febfe28466ed72b3fc69ec8d62eb142650764102e81902ac847ba8543fbc2715a7ab525cd8c544d920973593a4037b942b6cb8d372b1add0177691c39bb5
-  data.tar.gz: c9692d6a863186ca8b43bf43d5dc550843941aac968a304ca75316bc4b494fe9f8255b2a6641a3ec23b4c978c9f46729b6ebcfb06de26aa1237f7aee6c4a1336
+  metadata.gz: 58121ca27e808864e2e140082c306d855b3575dd88381fc4d4d0d515907cb914f3515d65e2ea75e5742fb7370fb1306a0e3291a0ac9f34e57c1dd8b33a7443d4
+  data.tar.gz: 75b38dca8fde59b2de0628d108a7416e8b2fb14af96a5c8c3f58a8aee5c0b4a4f0c01030c60323f449e4dbc0c4a22cf32448071c9614135684cb24a181f9dbe6

data/.rubocop.yml

@@ -0,0 +1,86 @@
+AllCops:
+  DisplayCopNames: true
+  DisplayStyleGuide: true
+  Exclude:
+    - epay_tools.gemspec
+
+Layout/AccessModifierIndentation:
+  EnforcedStyle: outdent
+
+Layout/AlignParameters:
+  EnforcedStyle: with_fixed_indentation
+
+Layout/EmptyLines:
+  Enabled: false
+
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+Layout/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+
+Metrics/BlockLength:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Max: 10
+
+Metrics/LineLength:
+  Max: 160
+
+Metrics/MethodLength:
+  Max: 50
+
+Metrics/AbcSize:
+  Max: 25
+
+Metrics/ClassLength:
+  Max: 250
+
+# .find_each is not the same as .each
+Rails/FindEach:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  EnforcedStyle: compact
+
+Style/ConditionalAssignment:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Will report offences for many places that are much more readable without using a guard clause
+Style/GuardClause:
+  Enabled: false
+
+Style/LambdaCall:
+  Enabled: false
+
+Style/RegexpLiteral:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/StringLiteralsInInterpolation:
+  Enabled: false
+
+Style/NilComparison:
+  Enabled: false
+
+Style/SignalException:
+  EnforcedStyle: only_raise
+
+Style/SymbolArray:
+  Enabled: false
+
+Style/TrivialAccessors:
+  ExactNameMatch: true
+  Enabled: true

data/Gemfile

@@ -1,17 +1,12 @@
 source "https://rubygems.org"
-# Add dependencies required to use your gem here.
-# Example:
-#   gem "activesupport", ">= 2.3.5"
 
 gem "auto_autoloader", ">= 0.0.5"
 gem "service_pattern", ">= 0.0.3"
 
-# Add dependencies to develop your gem here.
-# Include everything needed to run rake, tests, features, etc.
-group :development do
-  gem "rspec", "~> 3.5.0"
-  gem "rdoc", "~> 3.12"
+group :development, :test do
+  gem "best_practice_project", "0.0.10"
   gem "bundler", "~> 1.0"
   gem "jeweler", "2.3.7"
-  gem "simplecov", ">= 0"
+  gem "rspec", "3.7.0"
+  gem "rubocop", "0.51.0"
 end

data/Gemfile.lock

@@ -2,13 +2,15 @@ GEM
   remote: https://rubygems.org/
   specs:
     addressable (2.4.0)
+    ast (2.3.0)
     auto_autoloader (0.0.5)
       string-cases
+    best_practice_project (0.0.10)
+      auto_autoloader (>= 0.0.5)
     builder (3.2.3)
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
     diff-lcs (1.3)
-    docile (1.1.5)
     faraday (0.9.2)
       multipart-post (>= 1.2, < 3)
     git (1.3.0)
@@ -47,45 +49,55 @@ GEM
       multi_json (~> 1.3)
       multi_xml (~> 0.5)
       rack (>= 1.2, < 3)
+    parallel (1.12.0)
+    parser (2.4.0.2)
+      ast (~> 2.3)
+    powerpack (0.1.1)
     psych (2.2.2)
     rack (2.0.3)
+    rainbow (2.2.2)
+      rake
     rake (12.3.0)
     rdoc (3.12.2)
       json (~> 1.4)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.4)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
+    rspec (3.7.0)
+      rspec-core (~> 3.7.0)
+      rspec-expectations (~> 3.7.0)
+      rspec-mocks (~> 3.7.0)
+    rspec-core (3.7.0)
+      rspec-support (~> 3.7.0)
+    rspec-expectations (3.7.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
+      rspec-support (~> 3.7.0)
+    rspec-mocks (3.7.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
+      rspec-support (~> 3.7.0)
+    rspec-support (3.7.0)
+    rubocop (0.51.0)
+      parallel (~> 1.10)
+      parser (>= 2.3.3.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 2.2.2, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.9.0)
     semver2 (3.4.2)
     service_pattern (0.0.3)
-    simplecov (0.15.1)
-      docile (~> 1.1.0)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.2)
     string-cases (0.0.4)
     thread_safe (0.3.6)
+    unicode-display_width (1.3.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   auto_autoloader (>= 0.0.5)
+  best_practice_project (= 0.0.10)
   bundler (~> 1.0)
   jeweler (= 2.3.7)
-  rdoc (~> 3.12)
-  rspec (~> 3.5.0)
+  rspec (= 3.7.0)
+  rubocop (= 0.51.0)
   service_pattern (>= 0.0.3)
-  simplecov
 
 BUNDLED WITH
    1.15.4

data/Rakefile

@@ -1,50 +1,35 @@
-# encoding: utf-8
-
-require 'rubygems'
-require 'bundler'
+require "rubygems"
+require "bundler"
 begin
   Bundler.setup(:default, :development)
 rescue Bundler::BundlerError => e
-  $stderr.puts e.message
-  $stderr.puts "Run `bundle install` to install missing gems"
+  warn e.message
+  warn "Run `bundle install` to install missing gems"
   exit e.status_code
 end
-require 'rake'
+require "rake"
 
-require 'jeweler'
+require "jeweler"
 Jeweler::Tasks.new do |gem|
   # gem is a Gem::Specification... see http://guides.rubygems.org/specification-reference/ for more options
   gem.name = "epay_tools"
   gem.homepage = "http://github.com/kaspernj/epay_tools"
   gem.license = "MIT"
-  gem.summary = %Q{Tools to implement the ePay payment gateway}
-  gem.description = %Q{Tools to implement the ePay payment gateway}
+  gem.summary = %(Tools to implement the ePay payment gateway)
+  gem.description = %(Tools to implement the ePay payment gateway)
   gem.email = "kaspernj@gmail.com"
   gem.authors = ["kaspernj"]
   # dependencies defined in Gemfile
 end
 Jeweler::RubygemsDotOrgTasks.new
 
-require 'rspec/core'
-require 'rspec/core/rake_task'
+require "rspec/core"
+require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new(:spec) do |spec|
-  spec.pattern = FileList['spec/**/*_spec.rb']
-end
-
-desc "Code coverage detail"
-task :simplecov do
-  ENV['COVERAGE'] = "true"
-  Rake::Task['spec'].execute
+  spec.pattern = FileList["spec/**/*_spec.rb"]
 end
 
-task :default => :spec
+task default: :spec
 
-require 'rdoc/task'
-Rake::RDocTask.new do |rdoc|
-  version = File.exist?('VERSION') ? File.read('VERSION') : ""
-
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title = "epay_tools #{version}"
-  rdoc.rdoc_files.include('README*')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
+require "best_practice_project"
+BestPracticeProject.load_tasks

data/VERSION

@@ -1 +1 @@
-0.0.0
+0.0.1

data/epay_tools.gemspec

@@ -2,11 +2,11 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: epay_tools 0.0.0 ruby lib
+# stub: epay_tools 0.0.1 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "epay_tools".freeze
-  s.version = "0.0.0"
+  s.version = "0.0.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
@@ -21,6 +21,7 @@ Gem::Specification.new do |s|
   s.files = [
     ".document",
     ".rspec",
+    ".rubocop.yml",
     "Gemfile",
     "Gemfile.lock",
     "LICENSE.txt",
@@ -32,7 +33,8 @@ Gem::Specification.new do |s|
     "lib/epay_tools/hash_calculator_service.rb",
     "lib/epay_tools/ordered_parameters.rb",
     "lib/epay_tools/params_generator_service.rb",
-    "spec/epay_tools_spec.rb",
+    "shippable.yml",
+    "spec/epay_tools/hash_calculator_service_spec.rb",
     "spec/spec_helper.rb"
   ]
   s.homepage = "http://github.com/kaspernj/epay_tools".freeze
@@ -46,28 +48,28 @@ Gem::Specification.new do |s|
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_runtime_dependency(%q<auto_autoloader>.freeze, [">= 0.0.5"])
       s.add_runtime_dependency(%q<service_pattern>.freeze, [">= 0.0.3"])
-      s.add_development_dependency(%q<rspec>.freeze, ["~> 3.5.0"])
-      s.add_development_dependency(%q<rdoc>.freeze, ["~> 3.12"])
+      s.add_development_dependency(%q<best_practice_project>.freeze, ["= 0.0.10"])
       s.add_development_dependency(%q<bundler>.freeze, ["~> 1.0"])
       s.add_development_dependency(%q<jeweler>.freeze, ["= 2.3.7"])
-      s.add_development_dependency(%q<simplecov>.freeze, [">= 0"])
+      s.add_development_dependency(%q<rspec>.freeze, ["= 3.7.0"])
+      s.add_development_dependency(%q<rubocop>.freeze, ["= 0.51.0"])
     else
       s.add_dependency(%q<auto_autoloader>.freeze, [">= 0.0.5"])
       s.add_dependency(%q<service_pattern>.freeze, [">= 0.0.3"])
-      s.add_dependency(%q<rspec>.freeze, ["~> 3.5.0"])
-      s.add_dependency(%q<rdoc>.freeze, ["~> 3.12"])
+      s.add_dependency(%q<best_practice_project>.freeze, ["= 0.0.10"])
       s.add_dependency(%q<bundler>.freeze, ["~> 1.0"])
       s.add_dependency(%q<jeweler>.freeze, ["= 2.3.7"])
-      s.add_dependency(%q<simplecov>.freeze, [">= 0"])
+      s.add_dependency(%q<rspec>.freeze, ["= 3.7.0"])
+      s.add_dependency(%q<rubocop>.freeze, ["= 0.51.0"])
     end
   else
     s.add_dependency(%q<auto_autoloader>.freeze, [">= 0.0.5"])
     s.add_dependency(%q<service_pattern>.freeze, [">= 0.0.3"])
-    s.add_dependency(%q<rspec>.freeze, ["~> 3.5.0"])
-    s.add_dependency(%q<rdoc>.freeze, ["~> 3.12"])
+    s.add_dependency(%q<best_practice_project>.freeze, ["= 0.0.10"])
     s.add_dependency(%q<bundler>.freeze, ["~> 1.0"])
     s.add_dependency(%q<jeweler>.freeze, ["= 2.3.7"])
-    s.add_dependency(%q<simplecov>.freeze, [">= 0"])
+    s.add_dependency(%q<rspec>.freeze, ["= 3.7.0"])
+    s.add_dependency(%q<rubocop>.freeze, ["= 0.51.0"])
   end
 end
 

data/lib/epay_tools/hash_calculator_service.rb

@@ -1,19 +1,4 @@
 class EpayTools::HashCalculatorService < ServicePattern::Service
-  DEFAULT_PARAMETERS = {
-    "merchantnumber" => nil,
-    "accepturl" => nil,
-    "callbackurl" => nil,
-    "orderid" => nil,
-    "amount" => nil,
-    "currency" => "DKK",
-    "ownreceipt" => "1",
-    "windowstate" => "2",
-    "instantcapture" => "1",
-    "paymentcollection" => "1",
-    "lockpaymentcollection" => "1",
-    "subscription" => "0"
-  }.freeze
-
   attr_reader :query_parameters, :epay_md5_key
 
   def initialize(query_parameters:, epay_md5_key:)
@@ -40,7 +25,7 @@ private
     parameters = {}
 
     EpayTools::OrderedParameters::ORDERED_PARAMETERS.each do |ordered_parameter|
-      parameters[selected_parameter] = query_parameters.fetch(ordered_parameter)
+      parameters[ordered_parameter] = query_parameters.fetch(ordered_parameter)
     end
 
     parameters

data/lib/epay_tools/ordered_parameters.rb

@@ -1,8 +1,8 @@
 class EpayTools::OrderedParameters
-  ORDERED_PARAMETERS = [
-    "merchantnumber", "accepturl", "callbackurl", "orderid",
-    "amount", "currency", "ownreceipt", "windowstate",
-    "instantcapture", "paymentcollection", "lockpaymentcollection",
-    "subscription"
+  ORDERED_PARAMETERS = %w[
+    merchantnumber accepturl callbackurl orderid
+    amount currency ownreceipt windowstate
+    instantcapture paymentcollection lockpaymentcollection
+    subscription
   ].freeze
 end

data/shippable.yml

@@ -0,0 +1,3 @@
+script:
+  - bundle exec rspec
+  - bundle exec rake best_practice_project:run

data/spec/epay_tools/hash_calculator_service_spec.rb

@@ -0,0 +1,39 @@
+require "spec_helper"
+
+describe EpayTools::HashCalculatorService do
+  let(:epay_parameters) do
+    {
+      "merchantnumber" => "123123",
+      "accepturl" => "http://example.com/epay_accept",
+      "callbackurl" => "http://example.com/epay_callback",
+      "orderid" => 123,
+      "amount" => 10_000,
+      "currency" => "DKK",
+      "ownreceipt" => "1",
+      "windowstate" => "2",
+      "instantcapture" => "1",
+      "paymentcollection" => "1",
+      "lockpaymentcollection" => "1",
+      "subscription" => "0",
+      "hash" => "edc52b2b2f619551146682061d3a9d0d"
+    }
+  end
+  let(:service) do
+    EpayTools::HashCalculatorService.new(
+      epay_md5_key: "secret-md5-key",
+      query_parameters: epay_parameters
+    )
+  end
+
+  describe "#calculated_hash" do
+    it "calculates the right hash" do
+      expect(service.__send__(:calculated_hash)).to eq "edc52b2b2f619551146682061d3a9d0d"
+    end
+  end
+
+  describe "#validated?" do
+    it "returns true when the hash is right" do
+      expect(service.__send__(:validated?)).to eq true
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,29 +1,15 @@
-require 'simplecov'
-
-module SimpleCov::Configuration
-  def clean_filters
-    @filters = []
-  end
-end
-
-SimpleCov.configure do
-  clean_filters
-  load_adapter 'test_frameworks'
-end
-
 ENV["COVERAGE"] && SimpleCov.start do
   add_filter "/.rvm/"
 end
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 
-require 'rspec'
-require 'epay_tools'
+require "rspec"
+require "epay_tools"
 
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
 RSpec.configure do |config|
-
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: epay_tools
 version: !ruby/object:Gem::Version
-  version: 0.0.0
+  version: 0.0.1
 platform: ruby
 authors:
 - kaspernj
@@ -39,75 +39,75 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.0.3
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: best_practice_project
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 3.5.0
+        version: 0.0.10
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 3.5.0
+        version: 0.0.10
 - !ruby/object:Gem::Dependency
-  name: rdoc
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.12'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.12'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: jeweler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 2.3.7
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 2.3.7
 - !ruby/object:Gem::Dependency
-  name: jeweler
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.3.7
+        version: 3.7.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.3.7
+        version: 3.7.0
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.51.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.51.0
 description: Tools to implement the ePay payment gateway
 email: kaspernj@gmail.com
 executables: []
@@ -118,6 +118,7 @@ extra_rdoc_files:
 files:
 - ".document"
 - ".rspec"
+- ".rubocop.yml"
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -129,7 +130,8 @@ files:
 - lib/epay_tools/hash_calculator_service.rb
 - lib/epay_tools/ordered_parameters.rb
 - lib/epay_tools/params_generator_service.rb
-- spec/epay_tools_spec.rb
+- shippable.yml
+- spec/epay_tools/hash_calculator_service_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/kaspernj/epay_tools
 licenses:

data/spec/epay_tools_spec.rb

@@ -1,7 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
-
-describe 'EpayTools' do
-  it 'fails' do
-    fail 'hey buddy, you should probably rename this file and start specing for real'
-  end
-end