ep-codebreaker 0.3.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1bfaaf8084c62deada86235e21b8d00083cffb19
-  data.tar.gz: 074d6e1faa9313dda342f0955185208eea75139f
+  metadata.gz: e05c4edb923a6f54eb0da845b28dd17f5570a5b9
+  data.tar.gz: a689f4e0784fb2e5c0f6624e8264e7b8ca615f84
 SHA512:
-  metadata.gz: c0972fdbfa7fc7b1df76b16f595080f1f88c5ed200c4839469af0cd01193b8723538e6949ba342cf1142999f43d075a38f28b3c24c328f75027bf03c4a3a28d7
-  data.tar.gz: 5a674713394eda837d6ef357282499cc913608276f307cf1d166bdbb61e4b4783a4114a379bc2daf827a0af08902ae046ddb9bb61872bb629c37c54bf5fdcb2a
+  metadata.gz: 9beefb2854278824b9c74a4db3b5b371db45e81f3c01c4a4fa5bf70c82c4018412215be06fbe9c1504419a7c38b8b54d19f61ec55b9fd3d761c995e73b342735
+  data.tar.gz: 23c3f048292b411c1cd4cf25fb9d2d5f6b2c3585cd73bd4f9f2ad1470f0eba09c9ba9028ff52f8a2262ef50579f24478a8cc3d7d8b314604164a2ace1016e87e

data/lib/ep-codebreaker/console_app.rb

@@ -57,9 +57,10 @@ module Codebreaker
 
       return 'No scores' if scores.empty?
 
-      scores.map
-            .with_index { |player, i| format("%2i #{player.formatted}", i + 1) }
-            .unshift(format('%2s %10s %6s', '', 'Name', 'Points'))
+      scores
+        .map
+        .with_index { |player, i| format("%2i #{player.formatted}", i + 1) }
+        .unshift(format('%2s %10s %6s', '', 'Name', 'Points'))
     end
 
     def check_guess(input)

data/lib/ep-codebreaker/game.rb

@@ -5,8 +5,6 @@ require_relative 'game_writer'
 
 module Codebreaker
   class Game
-    include GameWriter
-
     MIN    = 1
     MAX    = 6
     LENGTH = 4
@@ -14,9 +12,15 @@ module Codebreaker
     TRIES = 10
     HINTS = 3
 
-    private_constant :MIN, :MAX, :LENGTH, :TRIES, :HINTS
     attr_reader :tries_left, :hints_left
 
+    private_constant :MIN, :MAX, :LENGTH, :TRIES, :HINTS
+
+    def initialize(writer = GameWriter.new, player_class = Player)
+      @writer       = writer
+      @player_class = player_class
+    end
+
     def start
       @code             = Array.new(LENGTH) { rand(MIN..MAX) }.join
       @result           = ''
@@ -51,11 +55,11 @@ module Codebreaker
     end
 
     def save_score(name)
-      write Player.new(name, @tries_left, @hints_left)
+      @writer.write @player_class.new(name, @tries_left, @hints_left)
     end
 
     def high_scores
-      process_file
+      @writer.load_scores
     end
 
     def as_json
@@ -90,15 +94,14 @@ module Codebreaker
     end
 
     def generate_hint
-      hint = '_' * LENGTH
       index = @indexes_for_hint.delete(@indexes_for_hint.sample)
-      hint[index] = @code[index]
-      hint
+      ('_' * LENGTH).tap { |hint| hint[index] = @code[index] }
     end
 
     def verify(input)
-      regexp = Regexp.new("^[#{MIN}-#{MAX}]{#{LENGTH}}$")
-      msg = "Guesses must consist of #{LENGTH} digits from #{MIN} to #{MAX}"
+      regexp = /\A[#{MIN}-#{MAX}]{#{LENGTH}}\z/
+      msg    = "Guesses must consist of #{LENGTH} digits from #{MIN} to #{MAX}"
+
       raise(ArgumentError, msg) if !input.is_a?(String) || !input.match?(regexp)
     end
   end

data/lib/ep-codebreaker/game_writer.rb

@@ -3,21 +3,25 @@
 require 'yaml'
 
 module Codebreaker
-  module GameWriter
-    private
+  class GameWriter
+    FILE_NAME = 'scores.yml'
+    private_constant :FILE_NAME
 
-    FILE_NAME = 'scores.yml'.freeze
+    def initialize(file_name = nil)
+      @file_name = file_name || FILE_NAME
+    end
 
     def write(player)
       scores = process_file
       scores << player
       scores = scores.max_by(10, &:points)
-      File.open(FILE_NAME, 'w') { |f| f.write scores.to_yaml }
+      File.open(@file_name, 'w') { |f| f.write scores.to_yaml }
     end
 
     def process_file
-      return [] if !File.exist?(FILE_NAME) || File.zero?(FILE_NAME)
-      YAML.load_file(FILE_NAME)
+      return [] if !File.exist?(@file_name) || File.zero?(@file_name)
+      YAML.load_file(@file_name)
     end
+    alias load_scores process_file
   end
 end

data/lib/ep-codebreaker/player.rb

@@ -3,7 +3,7 @@
 module Codebreaker
   class Player
     def initialize(name, tries_left, hints_left)
-      self.name = name
+      self.name   = name
       @tries_left = tries_left
       @hints_left = hints_left
     end
@@ -28,7 +28,7 @@ module Codebreaker
 
     def name=(value)
       msg = 'The name must be between 1 and 10 characters long'
-      raise(ArgumentError, msg) unless (1...10).cover? value.length
+      raise(ArgumentError, msg) unless (1..10).cover?(value.length)
       @name = value
     end
   end

data/lib/ep-codebreaker/version.rb

@@ -1,3 +1,3 @@
 module Codebreaker
-  VERSION = '0.3.2'.freeze
+  VERSION = '0.4.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ep-codebreaker
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.4.0
 platform: ruby
 authors:
 - Eugene Poberezhny
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-06-22 00:00:00.000000000 Z
+date: 2017-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler