enumbler 0.8.2 → 0.9.0

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: c19dd611e21b3b0353a89e15197ff4b72fac3ebd779a7d6fcf7b89b1c25d4850
4
- data.tar.gz: 9f6659abc858f493b8c4575bfa58ee55c517874f56179d40d4b2003d3008690c
3
+ metadata.gz: af754378eb4d6913b7d2f6521ae88e1cc59ceb3b8d76211e1cad637bc154634f
4
+ data.tar.gz: 19fcc7da7e52d35a079e9fbb4da6781d84df7b704fe1482a69ec553edf2dd709
5
5
  SHA512:
6
- metadata.gz: 8826e464b99c946ea5d2bdc383f0ac92698f6a21737369c65cd6fbb15445fcab75183c57581b0737f6af103e985007070c7189a5eb1da6f4a8e542c4709f0643
7
- data.tar.gz: 69cfd3a985fb7563c95e96243335aa90e5d945ef8cec911ecf0f2c482806a91080c2224b23ec08780536a0f7dfcaa768787387f40884402192ab44b4ac50b15c
6
+ metadata.gz: db53c9304123815cbda6900f3855b33b6fe7100233bd8b0eb7dea3223fea32b57760fe0ea0adfe02b4f5cda86dea0bb8ce327873117369577045f7502ba4af07
7
+ data.tar.gz: cdc6f3e944d5b1e92b2a6f41f118ef6d4685bb4bf78ce01c267f9549b9a009daf9b9d3edacd9111acfac96b4f1a2571181e29207684f9e197fd4f12d9afc8e76
@@ -1,7 +1,6 @@
1
1
  AllCops:
2
- TargetRubyVersion: 2.6
3
- Exclude:
4
- - 'bin/pre_commit_rubocop.rb'
2
+ NewCops: enable
3
+ TargetRubyVersion: 2.5
5
4
 
6
5
  Layout/ArgumentAlignment:
7
6
  Enabled: true
@@ -11,16 +10,36 @@ Layout/FirstHashElementIndentation:
11
10
  Enabled: true
12
11
  EnforcedStyle: consistent
13
12
 
13
+ Layout/HashAlignment:
14
+ Enabled: true
15
+ # This allows "implicit" hash arguments (without curly braces) to be aligned
16
+ # differently.
17
+ EnforcedLastArgumentHashStyle: ignore_implicit
18
+
14
19
  Layout/LineLength:
15
20
  AllowURI: true
16
21
  Max: 119
17
22
 
23
+ Layout/MultilineMethodCallIndentation:
24
+ Enabled: true
25
+ EnforcedStyle: indented
26
+
18
27
  Lint/RaiseException:
19
28
  Enabled: true
20
29
 
21
30
  Lint/StructNewOverride:
22
31
  Enabled: true
23
32
 
33
+ Metrics:
34
+ Enabled: false
35
+
36
+ Naming/MethodParameterName:
37
+ Enabled: true
38
+ AllowedNames: [at, by, db, id, in, ip, of, on, to, tz]
39
+
40
+ Naming/PredicateName:
41
+ Enabled: true
42
+
24
43
  Style/Documentation:
25
44
  Enabled: false
26
45
 
@@ -33,6 +52,9 @@ Style/HashTransformKeys:
33
52
  Style/HashTransformValues:
34
53
  Enabled: true
35
54
 
55
+ Style/StringLiterals:
56
+ EnforcedStyle: double_quotes
57
+
36
58
  Style/TrailingCommaInHashLiteral:
37
59
  Enabled: true
38
60
  EnforcedStyleForMultiline: consistent_comma
@@ -41,5 +63,5 @@ Style/TrailingCommaInArrayLiteral:
41
63
  Enabled: true
42
64
  EnforcedStyleForMultiline: consistent_comma
43
65
 
44
- Metrics:
45
- Enabled: false
66
+ Style/TrailingCommaInArguments:
67
+ EnforcedStyleForMultiline: consistent_comma
data/Gemfile CHANGED
@@ -1,6 +1,6 @@
1
1
  # frozen_string_literal: true
2
2
 
3
- source 'https://rubygems.org'
3
+ source "https://rubygems.org"
4
4
 
5
5
  # Specify your gem's dependencies in enumbler.gemspec
6
6
  gemspec
@@ -1,9 +1,9 @@
1
1
  PATH
2
2
  remote: .
3
3
  specs:
4
- enumbler (0.8.2)
5
- activerecord (>= 5.2.3, < 6.1)
6
- activesupport (>= 5.2.3, < 6.1)
4
+ enumbler (0.9.0)
5
+ activerecord (>= 5.2.3, < 7)
6
+ activesupport (>= 5.2.3, < 7)
7
7
 
8
8
  GEM
9
9
  remote: https://rubygems.org/
data/Rakefile CHANGED
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
 
3
- require 'bundler/gem_tasks'
4
- require 'rspec/core/rake_task'
3
+ require "bundler/gem_tasks"
4
+ require "rspec/core/rake_task"
5
5
 
6
6
  RSpec::Core::RakeTask.new(:spec)
7
7
 
@@ -1,8 +1,8 @@
1
1
  #!/usr/bin/env ruby
2
2
  # frozen_string_literal: true
3
3
 
4
- require 'bundler/setup'
5
- require 'enumbler'
4
+ require "bundler/setup"
5
+ require "enumbler"
6
6
 
7
7
  # You can add fixtures and/or initialization code here to make experimenting
8
8
  # with your gem easier. You can also use a different console, if you like.
@@ -11,5 +11,5 @@ require 'enumbler'
11
11
  # require "pry"
12
12
  # Pry.start
13
13
 
14
- require 'irb'
14
+ require "irb"
15
15
  IRB.start(__FILE__)
@@ -1,8 +1,10 @@
1
1
  #!/usr/bin/env ruby
2
+ # frozen_string_literal: true
3
+
2
4
  # Put this file into your path and use `<file> install` to add a new hook
3
5
  # or use it as a binary to check changed files
4
6
 
5
- require 'shellwords'
7
+ require "shellwords"
6
8
 
7
9
  if ARGV == ["install"]
8
10
  exec "ln", "-sf", File.expand_path(File.basename(__FILE__), __dir__), ".git/hooks/pre-commit"
@@ -10,15 +12,23 @@ else
10
12
  raise unless ARGV == []
11
13
  end
12
14
 
13
- changed = `git status --porcelain`.
14
- split("\n").
15
- map { |l| l.split(" ", 2) }.
16
- select { |status, _| ["A", "AM", "M"].include?(status) }.
17
- map { |_, file| file.delete('"') }
15
+ changed = `git status --porcelain`
16
+ .split("\n")
17
+ .map { |l| l.split(" ", 2) }
18
+ .select { |status, _| %w[A AM M].include?(status) }
19
+ .map { |_, file| file.delete('"') }
18
20
 
19
21
  exit if changed.empty?
20
22
 
21
- parallel = ((File.read(".rubocop.yml").include?("UseCache: false") rescue false) ? "" : " --parallel")
23
+ parallel = (if begin
24
+ File.read(".rubocop.yml").include?("UseCache: false")
25
+ rescue StandardError
26
+ false
27
+ end
28
+ ""
29
+ else
30
+ " --parallel"
31
+ end)
22
32
  result = `bundle exec rubocop #{parallel} --color --force-exclusion #{changed.shelljoin}`
23
- puts result unless $?.success?
24
- exit $?.exitstatus
33
+ puts result unless $CHILD_STATUS.success?
34
+ exit $CHILD_STATUS.exitstatus
@@ -1,42 +1,42 @@
1
1
  # frozen_string_literal: true
2
2
 
3
- require_relative 'lib/enumbler/version'
3
+ require_relative "lib/enumbler/version"
4
4
 
5
5
  Gem::Specification.new do |spec|
6
- spec.name = 'enumbler'
6
+ spec.name = "enumbler"
7
7
  spec.version = Enumbler::VERSION
8
- spec.authors = ['Damon Timm']
9
- spec.email = ['damon@linguabee.com']
8
+ spec.authors = ["Damon Timm"]
9
+ spec.email = ["damon@linguabee.com"]
10
10
 
11
11
  spec.summary = "Enums are terrific, but lack integrity. Let's add some!"
12
- spec.description = 'A more complete description is forthcoming.'
13
- spec.homepage = 'https://github.com/linguabee/enumbler'
14
- spec.license = 'MIT'
15
- spec.required_ruby_version = Gem::Requirement.new('>= 2.5.0')
12
+ spec.description = "A more complete description is forthcoming."
13
+ spec.homepage = "https://github.com/linguabee/enumbler"
14
+ spec.license = "MIT"
15
+ spec.required_ruby_version = Gem::Requirement.new(">= 2.5.0")
16
16
 
17
- spec.metadata['allowed_push_host'] = 'https://rubygems.org'
17
+ spec.metadata["allowed_push_host"] = "https://rubygems.org"
18
18
 
19
- spec.metadata['homepage_uri'] = spec.homepage
20
- spec.metadata['source_code_uri'] = spec.homepage
21
- spec.metadata['changelog_uri'] = spec.homepage
19
+ spec.metadata["homepage_uri"] = spec.homepage
20
+ spec.metadata["source_code_uri"] = spec.homepage
21
+ spec.metadata["changelog_uri"] = spec.homepage
22
22
 
23
23
  # Specify which files should be added to the gem when it is released.
24
24
  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
25
25
  spec.files = Dir.chdir(File.expand_path(__dir__)) do
26
26
  `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
27
27
  end
28
- spec.bindir = 'exe'
28
+ spec.bindir = "exe"
29
29
  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
30
- spec.require_paths = ['lib']
31
-
32
- spec.add_dependency 'activerecord', ['>= 5.2.3', '< 6.1']
33
- spec.add_dependency 'activesupport', ['>= 5.2.3', '< 6.1']
34
-
35
- spec.add_development_dependency 'database_cleaner-active_record', '~> 1.8.0'
36
- spec.add_development_dependency 'fuubar', '~> 2.5'
37
- spec.add_development_dependency 'pry'
38
- spec.add_development_dependency 'rake', '~> 12.0'
39
- spec.add_development_dependency 'rspec', '~> 3.9.0'
40
- spec.add_development_dependency 'rubocop', '~> 0.91.0'
41
- spec.add_development_dependency 'sqlite3', '~> 1.4.0'
30
+ spec.require_paths = ["lib"]
31
+
32
+ spec.add_dependency "activerecord", [">= 5.2.3", "< 7"]
33
+ spec.add_dependency "activesupport", [">= 5.2.3", "< 7"]
34
+
35
+ spec.add_development_dependency "database_cleaner-active_record", "~> 1.8.0"
36
+ spec.add_development_dependency "fuubar", "~> 2.5"
37
+ spec.add_development_dependency "pry"
38
+ spec.add_development_dependency "rake", "~> 12.0"
39
+ spec.add_development_dependency "rspec", "~> 3.9.0"
40
+ spec.add_development_dependency "rubocop", "~> 0.91.0"
41
+ spec.add_development_dependency "sqlite3", "~> 1.4.0"
42
42
  end
@@ -0,0 +1,12 @@
1
+ # EXAMPLE USAGE
2
+ # Refer for explanation to following link:
3
+ # https://github.com/Arkweid/lefthook/blob/master/docs/full_guide.md
4
+
5
+ pre-commit:
6
+ parallel: true
7
+ commands:
8
+ rubocop:
9
+ tags: backend style
10
+ glob: "*.rb"
11
+ exclude: "application.rb|routes.rb"
12
+ run: bundle exec rubocop --force-exclusion {all_files}
@@ -1,14 +1,14 @@
1
1
  # frozen_string_literal: true
2
2
 
3
- require 'enumbler/core_ext/symbol/case_equality_operator'
3
+ require "enumbler/core_ext/symbol/case_equality_operator"
4
4
 
5
- require 'enumbler/collection'
6
- require 'enumbler/enumble'
7
- require 'enumbler/enabler'
8
- require 'enumbler/version'
5
+ require "enumbler/collection"
6
+ require "enumbler/enumble"
7
+ require "enumbler/enabler"
8
+ require "enumbler/version"
9
9
 
10
- require 'active_support/concern'
11
- require 'active_support/inflector'
10
+ require "active_support/concern"
11
+ require "active_support/inflector"
12
12
 
13
13
  # The Enumbler add integrity to our enum implementation!
14
14
  module Enumbler
@@ -16,7 +16,7 @@ module Enumbler
16
16
  super
17
17
  end
18
18
 
19
- def respond_to_missing?(method_name, include_private = false)
19
+ def respond_to_missing?(method_name, *args, &block)
20
20
  enumble = find { |e| e.enum == method_name }
21
21
  enumble.present? || super
22
22
  end
@@ -12,7 +12,7 @@ module Enumbler
12
12
  def enumble
13
13
  @enumble = self.class.find_enumble(id)
14
14
 
15
- raise Error, 'An enumble is not defined for this record!' if @enumble.nil?
15
+ raise Error, "An enumble is not defined for this record!" if @enumble.nil?
16
16
 
17
17
  @enumble
18
18
  end
@@ -332,7 +332,7 @@ module Enumbler
332
332
  # longer defined (default: false)
333
333
  # @param validate [Boolean] validate on save?
334
334
  def seed_the_enumbler(delete_missing_records: false, validate: true)
335
- max_database_id = all.order('id desc').take&.id || 0
335
+ max_database_id = all.order("id desc").take&.id || 0
336
336
  max_enumble_id = @enumbles.map(&:id).max
337
337
 
338
338
  # If we are not deleting records, we just need to update each listed
@@ -416,15 +416,15 @@ module Enumbler
416
416
 
417
417
  def detect_enumbler_conflict(enumble_name, method_name, klass_method: false)
418
418
  if klass_method && dangerous_class_method?(method_name)
419
- raise_conflict_error(enumble_name, method_name, type: 'class')
419
+ raise_conflict_error(enumble_name, method_name, type: "class")
420
420
  elsif klass_method && method_defined_within?(method_name, ActiveRecord::Relation)
421
- raise_conflict_error(enumble_name, method_name, type: 'class', source: ActiveRecord::Relation.name)
421
+ raise_conflict_error(enumble_name, method_name, type: "class", source: ActiveRecord::Relation.name)
422
422
  elsif !klass_method && dangerous_attribute_method?(method_name)
423
423
  raise_conflict_error(enumble_name, method_name)
424
424
  end
425
425
  end
426
426
 
427
- def raise_conflict_error(enumble_name, method_name, type: 'instance', source: 'ActiveRecord')
427
+ def raise_conflict_error(enumble_name, method_name, type: "instance", source: "ActiveRecord")
428
428
  raise Error,
429
429
  format(
430
430
  ENUMBLER_CONFLICT_MESSAGE,
@@ -432,7 +432,7 @@ module Enumbler
432
432
  klass: name,
433
433
  type: type,
434
434
  method: method_name,
435
- source: source
435
+ source: source,
436
436
  )
437
437
  end
438
438
 
@@ -456,7 +456,7 @@ module Enumbler
456
456
  "The model #{self} does not support the attribute(s): #{unsupported_attrs.keys.map(&:to_s).to_sentence}"
457
457
  rescue ActiveRecord::StatementInvalid
458
458
  warn "[Enumbler Warning] => Unable to find a table for #{self}."\
459
- 'This is to be expected if there is a pending migration; however, if there is not then something is amiss.'
459
+ "This is to be expected if there is a pending migration; however, if there is not then something is amiss."
460
460
  end
461
461
  end
462
462
  end
@@ -1,5 +1,5 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  module Enumbler
4
- VERSION = '0.8.2'
4
+ VERSION = "0.9.0"
5
5
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: enumbler
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.8.2
4
+ version: 0.9.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Damon Timm
8
8
  autorequire:
9
9
  bindir: exe
10
10
  cert_chain: []
11
- date: 2020-12-15 00:00:00.000000000 Z
11
+ date: 2021-01-12 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: activerecord
@@ -19,7 +19,7 @@ dependencies:
19
19
  version: 5.2.3
20
20
  - - "<"
21
21
  - !ruby/object:Gem::Version
22
- version: '6.1'
22
+ version: '7'
23
23
  type: :runtime
24
24
  prerelease: false
25
25
  version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
29
29
  version: 5.2.3
30
30
  - - "<"
31
31
  - !ruby/object:Gem::Version
32
- version: '6.1'
32
+ version: '7'
33
33
  - !ruby/object:Gem::Dependency
34
34
  name: activesupport
35
35
  requirement: !ruby/object:Gem::Requirement
@@ -39,7 +39,7 @@ dependencies:
39
39
  version: 5.2.3
40
40
  - - "<"
41
41
  - !ruby/object:Gem::Version
42
- version: '6.1'
42
+ version: '7'
43
43
  type: :runtime
44
44
  prerelease: false
45
45
  version_requirements: !ruby/object:Gem::Requirement
@@ -49,7 +49,7 @@ dependencies:
49
49
  version: 5.2.3
50
50
  - - "<"
51
51
  - !ruby/object:Gem::Version
52
- version: '6.1'
52
+ version: '7'
53
53
  - !ruby/object:Gem::Dependency
54
54
  name: database_cleaner-active_record
55
55
  requirement: !ruby/object:Gem::Requirement
@@ -169,6 +169,7 @@ files:
169
169
  - bin/pre_commit_rubocop.rb
170
170
  - bin/setup
171
171
  - enumbler.gemspec
172
+ - lefthook.yml
172
173
  - lib/enumbler.rb
173
174
  - lib/enumbler/collection.rb
174
175
  - lib/enumbler/core_ext/symbol/case_equality_operator.rb