enju_inter_library_loan 0.2.0.beta.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 898e7475ac7f7f654e572612a849329e6acc4a61
-  data.tar.gz: e3143faec0387d62e08bc875bdc8daa9259c3b0b
+  metadata.gz: 3f7f5bd108fbe02cf3c25d1807e9dda6db9162d9
+  data.tar.gz: ad2f073eba58cb32f640da9201f56bc3137855f0
 SHA512:
-  metadata.gz: 4287306f7f701305a6d95bf5553dff358156ee2c9eeba20da315fde38c0bd061a99da73778485d4a8536556a490fc0ddee0bd32a12e8511add1b8d2d2738a7a8
-  data.tar.gz: c53a4a69eb02d18ae1f9a1ac5fcc4b362f0378887b776c3788bc2aede93840ad55eef74901b91f308c36454d19b6e025780f061ee2cee3be38c83dbe1cbb546d
+  metadata.gz: 89974ba6a5ab1a10509e320c8e0f5b810349bbcfb4619b0bf9f6063b812f75b4626021640d6471d79809aead37477d6fa1db3b241e8170ca52544abf50eb9f1e
+  data.tar.gz: a13e01dfcff626094b16faac72243e6b0a40d02fc23da661f4cdce7ba84f9b3463dcaf3fa2c956afddd8422e356d6ab60815cec18093f14acd2e267b596ce05c

data/app/models/inter_library_loan_transition.rb

@@ -17,5 +17,5 @@ end
 #  inter_library_loan_id :integer
 #  created_at            :datetime
 #  updated_at            :datetime
-#  most_recent           :boolean
+#  most_recent           :boolean          not null
 #

data/db/migrate/20180107164929_add_constraints_to_most_recent_for_inter_library_loan_transitions.rb

@@ -0,0 +1,13 @@
+class AddConstraintsToMostRecentForInterLibraryLoanTransitions < ActiveRecord::Migration
+  disable_ddl_transaction!
+
+  def up
+    add_index :inter_library_loan_transitions, [:inter_library_loan_id, :most_recent], unique: true, where: "most_recent", name: "index_inter_library_loan_transitions_parent_most_recent" #, algorithm: :concurrently
+    change_column_null :inter_library_loan_transitions, :most_recent, false
+  end
+
+  def down
+    remove_index :inter_library_loan_transitions, name: "index_inter_library_loan_transitions_parent_most_recent"
+    change_column_null :inter_library_loan_transitions, :most_recent, true
+  end
+end

data/lib/enju_inter_library_loan/version.rb

@@ -1,3 +1,3 @@
 module EnjuInterLibraryLoan
-  VERSION = "0.2.0.beta.2"
+  VERSION = "0.2.0"
 end

data/spec/controllers/inter_library_loans_controller_spec.rb

@@ -8,7 +8,7 @@ describe InterLibraryLoansController do
   describe "GET index" do
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       it "assigns all inter_library_loans as @inter_library_loans" do
@@ -19,7 +19,7 @@ describe InterLibraryLoansController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       it "assigns all inter_library_loans as @inter_library_loans" do
@@ -30,7 +30,7 @@ describe InterLibraryLoansController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       it "assigns empty as @inter_library_loans" do
@@ -50,11 +50,11 @@ describe InterLibraryLoansController do
   describe "GET show" do
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       it "assigns the requested inter_library_loan as @inter_library_loan" do
-        inter_library_loan = FactoryGirl.create(:inter_library_loan)
+        inter_library_loan = FactoryBot.create(:inter_library_loan)
         get :show, :id => inter_library_loan.id
         assigns(:inter_library_loan).should eq(inter_library_loan)
       end
@@ -62,11 +62,11 @@ describe InterLibraryLoansController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       it "assigns the requested inter_library_loan as @inter_library_loan" do
-        inter_library_loan = FactoryGirl.create(:inter_library_loan)
+        inter_library_loan = FactoryBot.create(:inter_library_loan)
         get :show, :id => inter_library_loan.id
         assigns(:inter_library_loan).should eq(inter_library_loan)
       end
@@ -74,11 +74,11 @@ describe InterLibraryLoansController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       it "assigns the requested inter_library_loan as @inter_library_loan" do
-        inter_library_loan = FactoryGirl.create(:inter_library_loan)
+        inter_library_loan = FactoryBot.create(:inter_library_loan)
         get :show, :id => inter_library_loan.id
         assigns(:inter_library_loan).should eq(inter_library_loan)
       end
@@ -86,7 +86,7 @@ describe InterLibraryLoansController do
 
     describe "When not logged in" do
       it "assigns the requested inter_library_loan as @inter_library_loan" do
-        inter_library_loan = FactoryGirl.create(:inter_library_loan)
+        inter_library_loan = FactoryBot.create(:inter_library_loan)
         get :show, :id => inter_library_loan.id
         assigns(:inter_library_loan).should eq(inter_library_loan)
       end
@@ -96,7 +96,7 @@ describe InterLibraryLoansController do
   describe "GET new" do
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       it "assigns the requested inter_library_loan as @inter_library_loan" do
@@ -107,7 +107,7 @@ describe InterLibraryLoansController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       it "assigns the requested inter_library_loan as @inter_library_loan" do
@@ -118,7 +118,7 @@ describe InterLibraryLoansController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       it "should not assign the requested inter_library_loan as @inter_library_loan" do
@@ -140,11 +140,11 @@ describe InterLibraryLoansController do
   describe "GET edit" do
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       it "assigns the requested inter_library_loan as @inter_library_loan" do
-        inter_library_loan = FactoryGirl.create(:inter_library_loan)
+        inter_library_loan = FactoryBot.create(:inter_library_loan)
         get :edit, :id => inter_library_loan.id
         assigns(:inter_library_loan).should eq(inter_library_loan)
       end
@@ -152,11 +152,11 @@ describe InterLibraryLoansController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       it "assigns the requested inter_library_loan as @inter_library_loan" do
-        inter_library_loan = FactoryGirl.create(:inter_library_loan)
+        inter_library_loan = FactoryBot.create(:inter_library_loan)
         get :edit, :id => inter_library_loan.id
         assigns(:inter_library_loan).should eq(inter_library_loan)
       end
@@ -164,11 +164,11 @@ describe InterLibraryLoansController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       it "assigns the requested inter_library_loan as @inter_library_loan" do
-        inter_library_loan = FactoryGirl.create(:inter_library_loan)
+        inter_library_loan = FactoryBot.create(:inter_library_loan)
         get :edit, :id => inter_library_loan.id
         response.should be_forbidden
       end
@@ -176,7 +176,7 @@ describe InterLibraryLoansController do
 
     describe "When not logged in" do
       it "should not assign the requested inter_library_loan as @inter_library_loan" do
-        inter_library_loan = FactoryGirl.create(:inter_library_loan)
+        inter_library_loan = FactoryBot.create(:inter_library_loan)
         get :edit, :id => inter_library_loan.id
         response.should redirect_to(new_user_session_url)
       end

data/spec/dummy/db/migrate/032_create_checkins.rb

@@ -1,14 +1,11 @@
 class CreateCheckins < ActiveRecord::Migration
   def self.up
     create_table :checkins do |t|
-      t.integer :item_id, :null => false
-      t.integer :librarian_id
-      t.integer :basket_id
+      t.references :item, index: true, foreign_key: true, null: false
+      t.references :librarian, index: true
+      t.references :basket, index: true
       t.timestamps
     end
-    add_index :checkins, :item_id
-    add_index :checkins, :librarian_id
-    add_index :checkins, :basket_id
   end
 
   def self.down

data/spec/dummy/db/migrate/033_create_checkouts.rb

@@ -1,22 +1,17 @@
 class CreateCheckouts < ActiveRecord::Migration
   def self.up
     create_table :checkouts do |t|
-      t.integer :user_id
-      t.integer :item_id, :null => false
-      t.integer :checkin_id
-      t.integer :librarian_id
-      t.integer :basket_id
+      t.references :user, index: true, foreign_key: true
+      t.references :item, index: true, foreign_key: true, null: false
+      t.references :checkin, index: true, foreign_key: true
+      t.references :librarian, index: true
+      t.references :basket, index: true
       t.datetime :due_date
-      t.integer :checkout_renewal_count, :default => 0, :null => false
-      t.integer :lock_version, :default => 0, :null => false
+      t.integer :checkout_renewal_count, default: 0, null: false
+      t.integer :lock_version, default: 0, null: false
       t.timestamps
     end
-    add_index :checkouts, :user_id
-    add_index :checkouts, :item_id
-    add_index :checkouts, :basket_id
-    add_index :checkouts, [:item_id, :basket_id], :unique => true
-    add_index :checkouts, :librarian_id
-    add_index :checkouts, :checkin_id
+    add_index :checkouts, [:item_id, :basket_id], unique: true
   end
 
   def self.down

data/spec/dummy/db/migrate/035_create_reserves.rb

@@ -1,23 +1,18 @@
 class CreateReserves < ActiveRecord::Migration
   def self.up
     create_table :reserves do |t|
-      t.integer :user_id, :null => false
-      t.integer :manifestation_id, :null => false
-      t.integer :item_id
-      t.integer :request_status_type_id, :null => false
+      t.references :user, index: true, foreign_key: true, null: false
+      t.references :manifestation, index: true, null: false
+      t.references :item, index: true
+      t.references :request_status_type, null: false
       t.datetime :checked_out_at
       t.timestamps
       t.datetime :canceled_at
       t.datetime :expired_at
       t.datetime :deleted_at
-      t.boolean :expiration_notice_to_patron, :default => false
-      t.boolean :expiration_notice_to_library, :default => false
+      t.boolean :expiration_notice_to_patron, default: false
+      t.boolean :expiration_notice_to_library, default: false
     end
-
-    add_index :reserves, :user_id
-    add_index :reserves, :manifestation_id
-    add_index :reserves, :item_id
-    add_index :reserves, :request_status_type_id
   end
 
   def self.down

data/spec/dummy/db/migrate/059_create_libraries.rb

@@ -1,9 +1,9 @@
 class CreateLibraries < ActiveRecord::Migration
   def change
     create_table :libraries do |t|
-      t.string :name, :null => false
+      t.string :name, index: true, null: false
       t.text :display_name
-      t.string :short_display_name, :null => false
+      t.string :short_display_name, null: false
       t.string :zip_code
       t.text :street
       t.text :locality
@@ -12,17 +12,15 @@ class CreateLibraries < ActiveRecord::Migration
       t.string :telephone_number_2
       t.string :fax_number
       t.text :note
-      t.integer :call_number_rows, :default => 1, :null => false
-      t.string :call_number_delimiter, :default => "|", :null => false
-      t.integer :library_group_id, :default => 1, :null => false
-      t.integer :users_count, :default => 0, :null => false
+      t.integer :call_number_rows, default: 1, null: false
+      t.string :call_number_delimiter, default: "|", null: false
+      t.references :library_group, index: true, null: false
+      t.integer :users_count, default: 0, null: false
       t.integer :position
-      t.integer :country_id
+      t.references :country
 
       t.timestamps
       t.datetime :deleted_at
     end
-    add_index :libraries, :library_group_id
-    add_index :libraries, :name, :unique => true
   end
 end

data/spec/dummy/db/migrate/069_create_shelves.rb

@@ -1,15 +1,14 @@
 class CreateShelves < ActiveRecord::Migration
   def change
     create_table :shelves do |t|
-      t.string :name, :null => false
+      t.string :name, null: false
       t.text :display_name
       t.text :note
-      t.integer :library_id, :default => 1, :null => false
-      t.integer :items_count, :default => 0, :null => false
+      t.references :library, index: true, null: false
+      t.integer :items_count, default: 0, null: false
       t.integer :position
       t.timestamps
       t.datetime :deleted_at
     end
-    add_index :shelves, :library_id
   end
 end

data/spec/dummy/db/migrate/080_create_library_groups.rb

@@ -1,9 +1,9 @@
 class CreateLibraryGroups < ActiveRecord::Migration
   def change
     create_table :library_groups do |t|
-      t.string :name, :null => false
+      t.string :name, null: false
       t.text :display_name
-      t.string :short_name, :null => false
+      t.string :short_name, index: true, null: false
       t.text :my_networks
       t.text :login_banner
       t.text :note
@@ -12,6 +12,5 @@ class CreateLibraryGroups < ActiveRecord::Migration
 
       t.timestamps
     end
-    add_index :library_groups, :short_name
   end
 end

data/spec/dummy/db/migrate/120_create_baskets.rb

@@ -1,12 +1,11 @@
 class CreateBaskets < ActiveRecord::Migration
   def change
     create_table :baskets do |t|
-      t.integer :user_id
+      t.references :user, index: true
       t.text :note
-      t.integer :lock_version, :default => 0, :null => false
+      t.integer :lock_version, default: 0, null: false
 
       t.timestamps
     end
-    add_index :baskets, :user_id
   end
 end

data/spec/dummy/db/migrate/121_create_checked_items.rb

@@ -1,14 +1,13 @@
 class CreateCheckedItems < ActiveRecord::Migration
   def self.up
     create_table :checked_items do |t|
-      t.integer :item_id, :null => false
-      t.integer :basket_id, :null => false
-      t.datetime :due_date, :null => false
+      t.references :item, index: true, foreign_key: true, null: false
+      t.references :basket, index: true, foreign_key: true, null: false
+      t.references :librarian, index: true
+      t.datetime :due_date, null: false
 
       t.timestamps
     end
-    add_index :checked_items, :item_id
-    add_index :checked_items, :basket_id
   end
 
   def self.down

data/spec/dummy/db/migrate/127_create_use_restrictions.rb

@@ -1,7 +1,7 @@
 class CreateUseRestrictions < ActiveRecord::Migration
   def self.up
     create_table :use_restrictions do |t|
-      t.string :name, :null => false
+      t.string :name, null: false
       t.text :display_name
       t.text :note
       t.integer :position

data/spec/dummy/db/migrate/129_create_item_has_use_restrictions.rb

@@ -1,13 +1,11 @@
 class CreateItemHasUseRestrictions < ActiveRecord::Migration
   def self.up
     create_table :item_has_use_restrictions do |t|
-      t.integer :item_id, :null => false
-      t.integer :use_restriction_id, :null => false
+      t.references :item, index: true, foreign_key: true, null: false
+      t.references :use_restriction, index: true, foreign_key: true, null: false
 
       t.timestamps
     end
-    add_index :item_has_use_restrictions, :item_id
-    add_index :item_has_use_restrictions, :use_restriction_id
   end
 
   def self.down

data/spec/dummy/db/migrate/132_create_circulation_statuses.rb

@@ -1,7 +1,7 @@
 class CreateCirculationStatuses < ActiveRecord::Migration
   def self.up
     create_table :circulation_statuses do |t|
-      t.string :name, :null => false
+      t.string :name, null: false
       t.text :display_name
       t.text :note
       t.integer :position

data/spec/dummy/db/migrate/20081006090811_create_subscriptions.rb

@@ -1,17 +1,14 @@
 class CreateSubscriptions < ActiveRecord::Migration
   def change
     create_table :subscriptions do |t|
-      t.text :title, :null => false
+      t.text :title, null: false
       t.text :note
-      #t.integer :subscription_list_id, :integer
-      t.integer :user_id
-      t.integer :order_list_id
+      t.references :user, index: true
+      t.references :order_list, index: true
       t.datetime :deleted_at
-      t.integer :subscribes_count, :default => 0, :null => false
+      t.integer :subscribes_count, default: 0, null: false
 
       t.timestamps
     end
-    add_index :subscriptions, :user_id
-    add_index :subscriptions, :order_list_id
   end
 end

data/spec/dummy/db/migrate/20081006093246_create_subscribes.rb

@@ -1,14 +1,13 @@
 class CreateSubscribes < ActiveRecord::Migration
   def change
     create_table :subscribes do |t|
-      t.integer :subscription_id, :null => false
-      t.integer :work_id, :null => false
-      t.datetime :start_at, :null => false
-      t.datetime :end_at, :null => false
+      t.references :subscription, index: true, null: false
+      t.integer :work_id, null: false
+      t.datetime :start_at, null: false
+      t.datetime :end_at, null: false
 
       t.timestamps
     end
-    add_index :subscribes, :subscription_id
     add_index :subscribes, :work_id
   end
 end