engineyard-serverside 2.8.0.pre3 → 2.8.0.pre4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4f62183fe729c31f95a7c8a797d59a559661283bae8a0d5b4f9646636dec46b0
-  data.tar.gz: 846fe5db5d2ce9170e898a61781b85f62b57bf9f1a72e96199ce1ecce8d0e623
+  metadata.gz: ae5f22352514fece09ff9eb57f642aa6d3cd5b8503c397aef41ffd45e11de6c0
+  data.tar.gz: 9e2732d61febae63336b3ea57805a8ab8736cfa332e52a7bf666e738d766e95e
 SHA512:
-  metadata.gz: df74e00e97f29706b0218f94ea32924b024a890b9f5d35c269691fe18839597fc84a9ea85c39b6ac761d6d5b6af7a0733bf7dd2bcbba5375f97258fa3bf44a55
-  data.tar.gz: 4eba7badbf030c15c60875286c7d6ff66a92b909ecd8613f653f0348d58b27ae5058b8a118506aaf21cfcd9891f38be47d1b07032105452e6c3090439eca57c2
+  metadata.gz: 160b8f26f18d7aa68badd7e5bd55883c0630f77a8f3b62eb9e643e69ca639d4a55d983806b85b3495d37d8fcfc9aaf801b587a6314ef6c74222e9a5f5ca21f96
+  data.tar.gz: e2e81cbef5a4ed51780c9c7ade4d39598bd2eabbc9e0ae6afe81539484c9c8a598807b07180589e9af8a884ffc50fa1e122b4c7187c579ea70fb8f0c0a8d6651

data/lib/engineyard-serverside/callbacks/collection/base.rb

@@ -20,6 +20,10 @@ module EY
             hooks
           end
 
+          def empty?
+            hooks.empty?
+          end
+
           def matching(callback)
             favor(
               :ruby,
@@ -37,11 +41,14 @@ module EY
           end
 
           def execute(config, shell, callback)
-            Executor.execute(
-              config,
-              shell,
-              matching(callback)
-            )
+            matches = matching(callback)
+
+            if matches.empty?
+              shell.info("No hooks detected for #{callback}. Skipping.")
+              return
+            end
+
+            Executor.execute(config, shell, matches)
           end
 
           private

data/lib/engineyard-serverside/callbacks/distributor.rb

@@ -6,13 +6,8 @@ module EY
     module Callbacks
 
       module Distributor
-        def self.distribute(runner, hooks)
-          ViabilityFilter.
-            new.
-            call({:candidates => hooks, :shell => runner.shell}).
-            and_then {|callback_name|
-              Remote.distribute(runner, callback_name)
-            }
+        def self.distribute(runner, callback_name)
+          Remote.distribute(runner, callback_name)
         end
       end
 

data/lib/engineyard-serverside/callbacks/executor/executable.rb

@@ -29,6 +29,8 @@ module EY
 
           def validate_hook(input = {})
             unless hook_path.executable?
+              shell.warning("Skipping possible deploy hook #{hook} because it is not executable.")
+
               return Failure(
                 input.merge(
                   {

data/lib/engineyard-serverside/cli/workflows/calling_deploy_hooks.rb

@@ -11,8 +11,7 @@ module EY
         class CallingDeployHooks < Base
           private
           def procedure
-            Callbacks.
-              load(config.paths).
+            Callbacks.load(config.paths).
               execute(config, shell, hook_name)
           end
 

data/lib/engineyard-serverside/deploy.rb

@@ -5,7 +5,7 @@ require 'engineyard-serverside/rails_assets'
 require 'engineyard-serverside/maintenance'
 require 'engineyard-serverside/dependency_manager'
 require 'engineyard-serverside/dependency_manager/legacy_helpers'
-require 'engineyard-serverside/callbacks'
+require 'engineyard-serverside/callbacks/distributor'
 
 module EY
   module Serverside
@@ -451,9 +451,8 @@ defaults:
       end
 
       def callback(what)
-        load_callbacks
         @callbacks_reached ||= true
-        @callbacks_collection.distribute(self, what)
+        Callbacks::Distributor.distribute(self, what)
       end
 
       def source
@@ -512,10 +511,6 @@ defaults:
       def compile_assets
         RailsAssets.detect_and_compile(config, shell, self)
       end
-
-      def load_callbacks
-        @callbacks_collection ||= Callbacks.load(paths)
-      end
     end   # DeployBase
 
     class Deploy < DeployBase

data/lib/engineyard-serverside/version.rb

@@ -1,5 +1,5 @@
 module EY
   module Serverside
-    VERSION = '2.8.0.pre3'
+    VERSION = '2.8.0.pre4'
   end
 end

data/spec/archive_deploy_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+class EY::Serverside::Source::Archive
+  def fetch_command
+    "cp #{uri} #{source_cache}"
+  end
+end
+
+describe "Deploying a simple application" do
+
+  before(:all) do
+    adapter = EY::Serverside::Adapter.new do |args|
+      args.account_name = "account"
+      args.app = "application_name"
+      args.stack = "nginx_unicorn"
+      args.environment_name = "environment_name"
+      args.framework_env = "production"
+      args.archive = FIXTURES_DIR.join('retwisj.war')
+      args.verbose = true
+      args.instances = [{ :hostname => "localhost", :roles => ["solo"], :name => "single" }]
+      args.serverside_version = Gem::Version.create(EY::Serverside::VERSION.dup).release
+      args.config = {
+        "deploy_to" => deploy_dir.to_s,
+        "group"            => GROUP
+      }
+    end
+    argv = adapter.deploy.commands.last.to_argv[2..-1]
+    with_mocked_commands do
+      capture do
+        EY::Serverside::CLI::App.start(argv)
+      end
+    end
+  end
+
+  it "exploded the war" do
+    %w(META-INF WEB-INF).each {|dir|
+      File.exists?(deploy_dir.join('current', dir))
+    }
+  end
+
+  it "creates a REVISION file" do
+    path = deploy_dir.join('current', 'REVISION')
+    expect(path).to exist
+    checksum = File.read(path).strip
+    expect(checksum).to match(/7400dc058376745c11a98f768b799c6651428857\s+.*retwisj.war$/)
+  end
+
+  it "restarts the app servers" do
+    restart = deploy_dir.join('current', 'restart')
+    expect(restart).to exist
+    expect(restart.read.chomp).to eq(%|LANG="en_US.UTF-8" /engineyard/bin/app_application_name deploy|)
+  end
+end

data/spec/basic_deploy_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe "Deploying a simple application" do
+  before(:all) do
+    deploy_test_application('not_bundled')
+  end
+
+  it "creates a REVISION file" do
+    expect(deploy_dir.join('current', 'REVISION')).to exist
+  end
+
+  it "restarts the app servers" do
+    restart = deploy_dir.join('current', 'restart')
+    expect(restart).to exist
+    expect(restart.read.chomp).to eq(%|LANG="en_US.UTF-8" /engineyard/bin/app_rails31 deploy|)
+  end
+
+  it "reuses the same active_release directory if a release_path is specified (such as in integrate)" do
+    path = @config.paths.active_release
+    expect(path.parent.children.size).to eq(1)
+
+    redeploy_test_application('config' => {'release_path' => path.to_s})
+
+    expect(path.parent.children.size).to eq(1)
+  end
+end

data/spec/bundler_deploy_spec.rb

@@ -0,0 +1,160 @@
+require 'spec_helper'
+
+describe "Deploying an application that uses Bundler" do
+  VERSION_PATTERN = Regexp.quote(::EY::Serverside::DependencyManager::Bundler.default_version)
+  PARALLEL_JOBS = ::EY::Serverside::DependencyManager::Bundler.jobs_number
+
+  context "with a Gemfile.lock" do
+    before(:all) do
+      deploy_test_application('ey_yml')
+      @install_bundler_command = @deployer.commands.grep(/gem install bundler/).first
+      @bundle_install_command  = @deployer.commands.grep(/bundle _#{VERSION_PATTERN}_ install/).first
+    end
+
+    it "runs the right bundler command" do
+      expect(@install_bundler_command).not_to be_nil
+      expect(@install_bundler_command).to match(/install bundler .* -v "#{VERSION_PATTERN}"/)
+    end
+
+    it "runs 'bundle install' with --deployment" do
+      expect(@bundle_install_command).not_to be_nil
+      expect(@bundle_install_command).to include('--deployment')
+    end
+
+    it "runs 'bundle install' with --jobs #{PARALLEL_JOBS}" do
+      expect(@bundle_install_command).not_to be_nil
+      expect(@bundle_install_command).to include("--jobs #{PARALLEL_JOBS}")
+    end
+
+    it "removes bundled_gems directory if the ruby or system version changed" do
+      should_run_clear_bundle_cmd = @deployer.commands.grep(/diff/).first
+      expect(should_run_clear_bundle_cmd).not_to be_nil
+      clear_bundle_cmd = @deployer.commands.grep(/rm -Rf \S+\/bundled_gems/).first
+      expect(clear_bundle_cmd).not_to be_nil
+    end
+
+    it "has the binstubs in the path when migrating" do
+      expect(deploy_dir.join('path-when-migrating').read).to include('ey_bundler_binstubs')
+    end
+
+    it "creates a ruby version file" do
+      expect(deploy_dir.join('shared', 'bundled_gems', 'RUBY_VERSION')).to exist
+    end
+
+    it "creates a system version file" do
+      expect(deploy_dir.join('shared', 'bundled_gems', 'SYSTEM_VERSION')).to exist
+    end
+
+    it "generates bundler binstubs" do
+      pending "doesn't work with mocked bundler"
+      expect(deploy_dir.join('current', 'ey_bundler_binstubs', 'rake')).to exist
+    end
+  end
+
+  context "with clean option" do
+    before(:all) do
+      deploy_test_application('ey_yml', 'clean' => true)
+    end
+
+    it "removes bundled_gems directory if the ruby or system version changed" do
+      should_run_clear_bundle_cmd = @deployer.commands.grep(/diff/).first
+      expect(should_run_clear_bundle_cmd).to be_nil
+      clear_bundle_cmd = @deployer.commands.grep(/rm -Rf \S+\/bundled_gems/).first
+      expect(clear_bundle_cmd).not_to be_nil
+    end
+
+  end
+
+  context "with bundler disabled in ey.yml" do
+    before(:all) do
+      deploy_test_application('bundler_disabled')
+    end
+
+    it "does not run bundler commands" do
+      expect(@deployer.commands.grep(/gem install bundler/)).to be_empty
+      expect(@deployer.commands.grep(/bundle _.*_ install/)).to be_empty
+    end
+
+    it "still runs the hooks" do
+      expect(deploy_dir.join('current', 'before_bundle.ran' )).to exist
+      expect(deploy_dir.join('current', 'after_bundle.ran' )).to exist
+    end
+  end
+
+  context "without a Gemfile.lock" do
+    before(:all) do
+      deploy_test_application('no_gemfile_lock')
+      @install_bundler_command = @deployer.commands.grep(/gem install bundler/).first
+      @bundle_install_command  = @deployer.commands.grep(/bundle _#{VERSION_PATTERN}_ install/).first
+    end
+
+    it "installs the proper Bundler version" do
+      expect(@install_bundler_command).not_to be_nil
+      expect(@install_bundler_command).to match(/unset RUBYOPT && gem list bundler | grep "bundler " | egrep -q "#{VERSION_PATTERN}[,)]" || gem install bundler -q --no-rdoc --no-ri -v "#{VERSION_PATTERN}"/)
+    end
+
+    it "runs 'bundle install' without --deployment" do
+      expect(@bundle_install_command).not_to be_nil
+      expect(@bundle_install_command).not_to match(/--deployment/)
+    end
+
+    it "runs 'bundle install' with --jobs #{PARALLEL_JOBS}" do
+      expect(@bundle_install_command).not_to be_nil
+      expect(@bundle_install_command).to include("--jobs #{PARALLEL_JOBS}")
+    end
+
+    it "exports GIT_SSH for the bundle install" do
+      expect(@bundle_install_command).to match(/export GIT_SSH/)
+    end
+
+    it "puts down RUBY_VERSION and SYSTEM_VERSION" do
+      expect(deploy_dir.join('shared', 'bundled_gems', 'RUBY_VERSION')).to exist
+      expect(deploy_dir.join('shared', 'bundled_gems', 'SYSTEM_VERSION')).to exist
+    end
+
+    it "warns that using a lockfile is idiomatic" do
+      out = read_output
+      expect(out).to match(/WARNING: Gemfile found but Gemfile.lock is missing!/)
+    end
+  end
+
+  context "without a Gemfile.lock and ignoring the warning" do
+    before(:all) do
+      deploy_test_application('no_gemfile_lock', 'config' => {'ignore_gemfile_lock_warning' => true})
+      expect(@config.ignore_gemfile_lock_warning).to be_truthy
+      @install_bundler_command = @deployer.commands.grep(/gem install bundler/).first
+      @bundle_install_command  = @deployer.commands.grep(/bundle _#{VERSION_PATTERN}_ install/).first
+    end
+
+    it "should not warn" do
+      out = read_output
+      expect(out).not_to match(/WARNING/)
+    end
+  end
+
+  context "with a failing Gemfile" do
+    before(:all) do
+      begin
+        deploy_test_application('bundle_fails', 'bundle_install_fails' => true, 'verbose' => false)
+      rescue EY::Serverside::RemoteFailure
+      end
+    end
+
+    it "prints the failure to the log" do
+      out = read_output
+      expect(out).to match(%r|bundle install failure|)
+      expect(deploy_dir.join('current', 'after_bundle.ran' )).not_to exist
+    end
+  end
+
+  context "with outdated bundler" do
+    before :all do
+      deploy_test_application( "bundler_old" )
+      @bundle_install_command = @deployer.commands.grep( /bundle _1.3.6_ install/ ).first
+    end
+
+    it "doesn't run 'bundle install' with --jobs" do
+      expect( @bundle_install_command ).to_not include "--jobs"
+    end
+  end
+end

data/spec/configuration_spec.rb

@@ -0,0 +1,206 @@
+require 'spec_helper'
+
+describe EY::Serverside::Deploy::Configuration do
+  describe "default options" do
+    it "has defaults" do
+      @config = EY::Serverside::Deploy::Configuration.new({
+        'app' => 'app_name',
+        'environment_name' => 'env_name',
+        'account_name' => 'acc',
+        'framework_env' => 'production',
+      })
+      expect(@config.app_name).to eq("app_name")
+      expect(@config.environment_name).to eq("env_name")
+      expect(@config.account_name).to eq("acc")
+      expect(@config.migrate).to eq(nil)
+      expect(@config.migrate?).to eq(false)
+      expect(@config.branch).to eq("master")
+      expect(@config.ref).to eq("master")
+      expect(@config.maintenance_on_migrate).to eq(true)
+      expect(@config.maintenance_on_restart).to eq(true)
+      expect(@config.required_downtime_stack?).to eq(true)
+      expect(@config.framework_env).to eq("production")
+      expect(@config.precompile_assets).to eq("detect")
+      expect(@config.precompile_assets_inferred?).to eq(true)
+      expect(@config.skip_precompile_assets?).to eq(false)
+      expect(@config.precompile_assets?).to eq(false)
+      expect(@config.asset_roles).to eq([:app_master, :app, :solo])
+      expect(@config.user).to eq(ENV['USER'])
+      expect(@config.group).to eq(ENV['USER'])
+      expect(@config.verbose).to eq(false)
+      expect(@config.copy_exclude).to eq([])
+      expect(@config.ignore_database_adapter_warning).to eq(false)
+      expect(@config.ignore_ey_config_warning).to eq(false)
+      expect(@config.ignore_gemfile_lock_warning).to eq(false)
+      expect(@config.bundle_without).to eq(%w[test development])
+      expect(@config.extra_bundle_install_options).to eq(%w[--without test development])
+      expect(@config.deployed_by).to eq("Automation (User name not available)")
+      expect(@config.input_ref).to eq(@config.branch)
+      expect(@config.keep_releases).to eq(3)
+      expect(@config.keep_failed_releases).to eq(3)
+    end
+
+    it "raises when required options are not given" do
+      @config = EY::Serverside::Deploy::Configuration.new({})
+      expect { @config.app_name }.to raise_error
+      expect { @config.environment_name }.to raise_error
+      expect { @config.account_name }.to raise_error
+      expect { @config.framework_env }.to raise_error
+    end
+  end
+
+  context "strategies" do
+    let(:options) do
+      { "app" => "serverside" }
+    end
+
+    it "uses strategy if set" do
+      @config = EY::Serverside::Deploy::Configuration.new(
+        options.merge({'strategy' => 'IntegrationSpec', 'git' => 'git@github.com:engineyard/todo.git'})
+      )
+      capture do # deprecation warning
+        expect(@config.source(test_shell)).to be_a_kind_of(EY::Serverside::Source::IntegrationSpec)
+      end
+      expect(read_output).to include("DEPRECATION WARNING: The configuration key 'strategy' is deprecated in favor of 'source_class'.")
+    end
+
+    it "uses source_class if set" do
+      @config = EY::Serverside::Deploy::Configuration.new(
+        options.merge({'source_class' => 'IntegrationSpec', 'git' => 'git@github.com:engineyard/todo.git'})
+      )
+      expect(@config.source(test_shell)).to be_a_kind_of(EY::Serverside::Source::IntegrationSpec)
+    end
+
+    it "infers a git source" do
+      @config = EY::Serverside::Deploy::Configuration.new(
+        options.merge({ 'git' => 'git@github.com:engineyard/todo.git' })
+      )
+      expect(@config.source(test_shell)).to be_a_kind_of(EY::Serverside::Source::Git)
+    end
+
+    it "infers a archive source" do
+      @config = EY::Serverside::Deploy::Configuration.new(
+        options.merge({'archive' => 'https://github.com/engineyard/todo/archive/master.zip'})
+      )
+
+      expect(@config.source(test_shell)).to be_a_kind_of(EY::Serverside::Source::Archive)
+    end
+  end
+
+  context "command line options" do
+    before do
+      @config = EY::Serverside::Deploy::Configuration.new({
+        'repository_cache' => @tempdir,
+        'app' => 'app_name',
+        'stack' => 'nginx_passenger',
+        'framework_env' => 'development',
+        'environment_name' => 'env_name',
+        'account_name' => 'acc',
+        'branch' => 'branch_from_command_line',
+        'config' => MultiJson.dump({'custom' => 'custom_from_extra_config', 'maintenance_on_migrate' => 'false', 'precompile_assets' => 'false', 'deployed_by' => 'Martin Emde', 'input_ref' => 'input_branch'})
+      })
+    end
+
+    it "underrides options with config (directly supplied options take precedence over 'config' options)" do
+      expect(@config.maintenance_on_migrate).to eq(false)
+      expect(@config.branch).to eq("branch_from_command_line")
+    end
+
+    it "corrects command line supplied precompile_assets string (which relies on having a special not-set value of nil, so can't be a boolean)" do
+      expect(@config.skip_precompile_assets?).to eq(true)
+      expect(@config.precompile_assets?).to eq(false)
+      expect(@config.precompile_assets_inferred?).to eq(false)
+    end
+
+    it "doesn't require downtime on restart for nginx_passenger" do
+      expect(@config.maintenance_on_migrate).to eq(false)
+      expect(@config.maintenance_on_restart).to eq(false)
+    end
+
+    it "doesn't bundle --without the framework_env" do
+      expect(@config.bundle_without).to eq(%w[test])
+    end
+
+    it "gets deployed_by and input_ref correct" do
+      expect(@config.deployed_by).to eq("Martin Emde")
+      expect(@config.input_ref).to eq("input_branch")
+    end
+  end
+
+  describe "ey.yml loading" do
+    before(:each) do
+      @tempdir = `mktemp -d -t ey_yml_spec.XXXXX`.strip
+      @config = EY::Serverside::Deploy::Configuration.new({
+        'repository_cache' => @tempdir,
+        'app' => 'app_name',
+        'environment_name' => 'env_name',
+        'account_name' => 'acc',
+        'migrate' => nil,
+        'branch' => 'branch_from_command_line',
+        'config' => MultiJson.dump({'custom' => 'custom_from_extra_config', 'maintenance_on_migrate' => 'false'})
+      })
+
+      @deploy = FullTestDeploy.new(test_servers, @config, test_shell)
+
+      @yaml_data = {
+        'environments' => {
+          'env_name' => {
+            'copy_exclude' => ['.git'],
+            'migrate' => true,
+            'migration_command' => 'uh oh',
+            'branch' => 'branch_from_ey_yml',
+            'custom' => 'custom_from_ey_yml',
+            'bundle_without' => 'only test',
+            'maintenance_on_migrate' => true,
+          }
+        }
+      }
+    end
+
+    def write_ey_yml(relative_path, data)
+      FileUtils.mkdir_p(File.join(
+        @tempdir,
+        File.dirname(relative_path)))
+
+      File.open(File.join(@tempdir, relative_path), 'w') do |f|
+        f.write data.to_yaml
+      end
+    end
+
+    it "requires 'ey.yml' and adds any defined methods to the deploy" do
+      write_ey_yml 'ey.yml', @yaml_data
+      @deploy.load_ey_yml
+      expect(@deploy.config.copy_exclude).to eq(['.git'])
+    end
+
+    it "falls back to 'config/ey.yml'" do
+      write_ey_yml 'config/ey.yml', @yaml_data
+      @deploy.load_ey_yml
+      expect(@deploy.config.copy_exclude).to eq(['.git'])
+    end
+
+    it "loads at lower priority than command line options" do
+      write_ey_yml 'ey.yml', @yaml_data
+      @deploy.load_ey_yml
+      expect(@deploy.config.migrate?).to eq(false)
+    end
+
+    it "loads at lower priority than json config option" do
+      write_ey_yml 'ey.yml', @yaml_data
+      @deploy.load_ey_yml
+      expect(@deploy.config.branch).to eq('branch_from_command_line')
+    end
+
+    it "loads bundle_without from the config, which overrides the default" do
+      write_ey_yml 'ey.yml', @yaml_data
+      @deploy.load_ey_yml
+      expect(@deploy.config.bundle_without).to eq('only test')
+    end
+
+    it "overrides boolean ey.yml only options with --conifg strings" do
+      write_ey_yml 'ey.yml', @yaml_data
+      @deploy.load_ey_yml
+      expect(@deploy.config).not_to be_maintenance_on_migrate
+    end
+  end
+end