engaging_networks 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ad132e63642e804398bce5424f1cf63c814ae67f
-  data.tar.gz: 62e650e7c5007ee3ed6b7f9749bfbf506600be19
+  metadata.gz: 31f38da22fceb9c370a1cee4e7fc45b653e16875
+  data.tar.gz: c42d864e578aa5e1d9a21aa982ebd183eb9c2b27
 SHA512:
-  metadata.gz: 8c08078367980d7f084b788d80e2b7257e265d9cf3a9a43721cf86a0b2105118396c3ca731764e613efc9c06a28ce733740026938e5d5b8c4bf1c0c7030032a6
-  data.tar.gz: bab9d5592f51d724353e315f852ed030a09b6da152531fcce807af08d4b062d5c5cc3aaea8cfebb46001a58e50e480b965621eff293d8f47d5e247cf61aeba31
+  metadata.gz: ceb58c8f7206cec503ea1871f597c10595ea65cb9c1fc4519c84dbf7c9221fa6e53b0d4d65f46184fca7629bef0ff08cf30d977c958afe1b4928c60d369e4c54
+  data.tar.gz: c34eaeaea2cb9899470aa15ad52944a00114be4553f4fc0e1dd28758228aa07e29a8c59931dcf465aa8b85d6b8dd77e256c6c6d3d4437083c21632c1b75fc235

data/.ruby-version

@@ -1 +1 @@
-2.2.4
+2.3.3

data/Gemfile

@@ -11,5 +11,5 @@ group :development do
   gem 'webmock'
   gem 'pry-byebug'
   gem "bundler"
-  gem "jeweler", "~> 2.0.0"
+  gem "jeweler"
 end

data/Gemfile.lock

@@ -1,121 +1,127 @@
 GEM
   remote: http://rubygems.org/
   specs:
-    activemodel (4.2.6)
-      activesupport (= 4.2.6)
-      builder (~> 3.1)
-    activesupport (4.2.6)
+    activemodel (5.1.0)
+      activesupport (= 5.1.0)
+    activesupport (5.1.0)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (~> 0.7)
-      json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
-      thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
-    addressable (2.4.0)
-    builder (3.2.2)
-    byebug (9.0.5)
+    addressable (2.5.1)
+      public_suffix (~> 2.0, >= 2.0.2)
+    builder (3.2.3)
+    byebug (9.0.6)
     coderay (1.1.1)
+    concurrent-ruby (1.0.5)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
-    diff-lcs (1.2.5)
-    domain_name (0.5.20160310)
+    diff-lcs (1.3)
+    domain_name (0.5.20170404)
       unf (>= 0.0.5, < 1.0.0)
     faraday (0.9.2)
       multipart-post (>= 1.2, < 3)
-    faraday_middleware (0.10.0)
-      faraday (>= 0.7.4, < 0.10)
+    faraday_middleware (0.11.0.1)
+      faraday (>= 0.7.4, < 1.0)
     git (1.3.0)
-    github_api (0.14.0)
-      addressable (~> 2.4.0)
-      descendants_tracker (~> 0.0.4)
+    github_api (0.11.3)
+      addressable (~> 2.3)
+      descendants_tracker (~> 0.0.1)
       faraday (~> 0.8, < 0.10)
-      hashie (>= 3.4)
+      hashie (>= 1.2)
+      multi_json (>= 1.7.5, < 2.0)
+      nokogiri (~> 1.6.0)
       oauth2
-    hashdiff (0.3.0)
-    hashie (3.4.4)
+    hashdiff (0.3.4)
+    hashie (3.5.5)
     highline (1.7.8)
-    http-cookie (1.0.2)
+    http-cookie (1.0.3)
       domain_name (~> 0.5)
-    i18n (0.7.0)
-    jeweler (2.0.1)
+    i18n (0.8.1)
+    jeweler (2.3.5)
       builder
       bundler (>= 1.0)
       git (>= 1.2.5)
-      github_api
+      github_api (~> 0.11.0)
       highline (>= 1.6.15)
       nokogiri (>= 1.5.10)
+      psych (~> 2.2)
       rake
       rdoc
-    json (1.8.3)
-    jwt (1.5.1)
-    mechanize (2.7.4)
+      semver2
+    json (2.1.0)
+    jwt (1.5.6)
+    mechanize (2.7.5)
       domain_name (~> 0.5, >= 0.5.1)
       http-cookie (~> 1.0)
-      mime-types (>= 1.17.2, < 3)
+      mime-types (>= 1.17.2)
       net-http-digest_auth (~> 1.1, >= 1.1.1)
       net-http-persistent (~> 2.5, >= 2.5.2)
       nokogiri (~> 1.6)
       ntlm-http (~> 0.1, >= 0.1.1)
       webrobots (>= 0.0.9, < 0.2)
     method_source (0.8.2)
-    mime-types (2.99.2)
+    mime-types (3.1)
+      mime-types-data (~> 3.2015)
+    mime-types-data (3.2016.0521)
     mini_portile2 (2.1.0)
-    minitest (5.9.0)
+    minitest (5.10.1)
     multi_json (1.12.1)
-    multi_xml (0.5.5)
+    multi_xml (0.6.0)
     multipart-post (2.0.0)
-    net-http-digest_auth (1.4)
+    net-http-digest_auth (1.4.1)
     net-http-persistent (2.9.4)
-    nokogiri (1.6.8)
+    nokogiri (1.6.8.1)
       mini_portile2 (~> 2.1.0)
-      pkg-config (~> 1.1.7)
     ntlm-http (0.1.1)
-    oauth2 (1.1.0)
-      faraday (>= 0.8, < 0.10)
-      jwt (~> 1.0, < 1.5.2)
+    oauth2 (1.3.1)
+      faraday (>= 0.8, < 0.12)
+      jwt (~> 1.0)
       multi_json (~> 1.3)
       multi_xml (~> 0.5)
       rack (>= 1.2, < 3)
-    pkg-config (1.1.7)
-    pry (0.10.3)
+    pry (0.10.4)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
-    pry-byebug (3.4.0)
+    pry-byebug (3.4.2)
       byebug (~> 9.0)
       pry (~> 0.10)
-    rack (1.6.4)
-    rake (11.1.2)
-    rdoc (4.2.2)
-      json (~> 1.4)
-    rspec (3.4.0)
-      rspec-core (~> 3.4.0)
-      rspec-expectations (~> 3.4.0)
-      rspec-mocks (~> 3.4.0)
-    rspec-core (3.4.4)
-      rspec-support (~> 3.4.0)
-    rspec-expectations (3.4.0)
+    psych (2.2.4)
+    public_suffix (2.0.5)
+    rack (2.0.1)
+    rake (12.0.0)
+    rdoc (5.1.0)
+    rspec (3.5.0)
+      rspec-core (~> 3.5.0)
+      rspec-expectations (~> 3.5.0)
+      rspec-mocks (~> 3.5.0)
+    rspec-core (3.5.4)
+      rspec-support (~> 3.5.0)
+    rspec-expectations (3.5.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-mocks (3.4.1)
+      rspec-support (~> 3.5.0)
+    rspec-mocks (3.5.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-support (3.4.1)
+      rspec-support (~> 3.5.0)
+    rspec-support (3.5.0)
     safe_yaml (1.0.4)
+    semver2 (3.4.2)
     slop (3.6.0)
-    thread_safe (0.3.5)
-    tzinfo (1.2.2)
+    thread_safe (0.3.6)
+    tzinfo (1.2.3)
       thread_safe (~> 0.1)
     unf (0.1.4)
       unf_ext
-    unf_ext (0.0.7.2)
-    vertebrae (0.2.11)
+    unf_ext (0.0.7.4)
+    vertebrae (0.4.1)
       activesupport
-      faraday
+      faraday (>= 0.9.2)
       faraday_middleware
       hashie
-    webmock (2.1.0)
+    webmock (3.0.1)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
       hashdiff
@@ -128,7 +134,7 @@ DEPENDENCIES
   activemodel (>= 3.2)
   activesupport (>= 3.2)
   bundler
-  jeweler (~> 2.0.0)
+  jeweler
   json
   mechanize
   pry-byebug
@@ -137,4 +143,4 @@ DEPENDENCIES
   webmock
 
 BUNDLED WITH
-   1.12.5
+   1.14.6

data/VERSION

@@ -1 +1 @@
-0.2.1
+0.2.2

data/engaging_networks.gemspec

@@ -2,18 +2,18 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: engaging_networks 0.2.1 ruby lib
+# stub: engaging_networks 0.2.2 ruby lib
 
 Gem::Specification.new do |s|
-  s.name = "engaging_networks"
-  s.version = "0.2.1"
+  s.name = "engaging_networks".freeze
+  s.version = "0.2.2"
 
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.require_paths = ["lib"]
-  s.authors = ["Josh Levinger", "Nathan Woodhull"]
-  s.date = "2016-06-10"
-  s.description = "Gem for interacting with the Engaging Networks API"
-  s.email = "josh@levinger.net"
+  s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib".freeze]
+  s.authors = ["Josh Levinger".freeze, "Nathan Woodhull".freeze]
+  s.date = "2017-05-01"
+  s.description = "Gem for interacting with the Engaging Networks API".freeze
+  s.email = "josh@levinger.net".freeze
   s.extra_rdoc_files = [
     "LICENSE.txt",
     "README.md"
@@ -70,48 +70,48 @@ Gem::Specification.new do |s|
     "spec/fixtures/import.service/success.txt",
     "spec/spec_helper.rb"
   ]
-  s.homepage = "http://github.com/jlev/engaging_networks"
-  s.licenses = ["MIT"]
-  s.rubygems_version = "2.4.8"
-  s.summary = "A wrapper for the Engaging Networks API"
+  s.homepage = "http://github.com/jlev/engaging_networks".freeze
+  s.licenses = ["MIT".freeze]
+  s.rubygems_version = "2.6.11".freeze
+  s.summary = "A wrapper for the Engaging Networks API".freeze
 
   if s.respond_to? :specification_version then
     s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<vertebrae>, [">= 0"])
-      s.add_runtime_dependency(%q<json>, [">= 0"])
-      s.add_runtime_dependency(%q<activesupport>, [">= 3.2"])
-      s.add_runtime_dependency(%q<activemodel>, [">= 3.2"])
-      s.add_runtime_dependency(%q<mechanize>, [">= 0"])
-      s.add_development_dependency(%q<rspec>, ["~> 3.4"])
-      s.add_development_dependency(%q<webmock>, [">= 0"])
-      s.add_development_dependency(%q<pry-byebug>, [">= 0"])
-      s.add_development_dependency(%q<bundler>, [">= 0"])
-      s.add_development_dependency(%q<jeweler>, ["~> 2.0.0"])
+      s.add_runtime_dependency(%q<vertebrae>.freeze, [">= 0"])
+      s.add_runtime_dependency(%q<json>.freeze, [">= 0"])
+      s.add_runtime_dependency(%q<activesupport>.freeze, [">= 3.2"])
+      s.add_runtime_dependency(%q<activemodel>.freeze, [">= 3.2"])
+      s.add_runtime_dependency(%q<mechanize>.freeze, [">= 0"])
+      s.add_development_dependency(%q<rspec>.freeze, ["~> 3.4"])
+      s.add_development_dependency(%q<webmock>.freeze, [">= 0"])
+      s.add_development_dependency(%q<pry-byebug>.freeze, [">= 0"])
+      s.add_development_dependency(%q<bundler>.freeze, [">= 0"])
+      s.add_development_dependency(%q<jeweler>.freeze, [">= 0"])
     else
-      s.add_dependency(%q<vertebrae>, [">= 0"])
-      s.add_dependency(%q<json>, [">= 0"])
-      s.add_dependency(%q<activesupport>, [">= 3.2"])
-      s.add_dependency(%q<activemodel>, [">= 3.2"])
-      s.add_dependency(%q<mechanize>, [">= 0"])
-      s.add_dependency(%q<rspec>, ["~> 3.4"])
-      s.add_dependency(%q<webmock>, [">= 0"])
-      s.add_dependency(%q<pry-byebug>, [">= 0"])
-      s.add_dependency(%q<bundler>, [">= 0"])
-      s.add_dependency(%q<jeweler>, ["~> 2.0.0"])
+      s.add_dependency(%q<vertebrae>.freeze, [">= 0"])
+      s.add_dependency(%q<json>.freeze, [">= 0"])
+      s.add_dependency(%q<activesupport>.freeze, [">= 3.2"])
+      s.add_dependency(%q<activemodel>.freeze, [">= 3.2"])
+      s.add_dependency(%q<mechanize>.freeze, [">= 0"])
+      s.add_dependency(%q<rspec>.freeze, ["~> 3.4"])
+      s.add_dependency(%q<webmock>.freeze, [">= 0"])
+      s.add_dependency(%q<pry-byebug>.freeze, [">= 0"])
+      s.add_dependency(%q<bundler>.freeze, [">= 0"])
+      s.add_dependency(%q<jeweler>.freeze, [">= 0"])
     end
   else
-    s.add_dependency(%q<vertebrae>, [">= 0"])
-    s.add_dependency(%q<json>, [">= 0"])
-    s.add_dependency(%q<activesupport>, [">= 3.2"])
-    s.add_dependency(%q<activemodel>, [">= 3.2"])
-    s.add_dependency(%q<mechanize>, [">= 0"])
-    s.add_dependency(%q<rspec>, ["~> 3.4"])
-    s.add_dependency(%q<webmock>, [">= 0"])
-    s.add_dependency(%q<pry-byebug>, [">= 0"])
-    s.add_dependency(%q<bundler>, [">= 0"])
-    s.add_dependency(%q<jeweler>, ["~> 2.0.0"])
+    s.add_dependency(%q<vertebrae>.freeze, [">= 0"])
+    s.add_dependency(%q<json>.freeze, [">= 0"])
+    s.add_dependency(%q<activesupport>.freeze, [">= 3.2"])
+    s.add_dependency(%q<activemodel>.freeze, [">= 3.2"])
+    s.add_dependency(%q<mechanize>.freeze, [">= 0"])
+    s.add_dependency(%q<rspec>.freeze, ["~> 3.4"])
+    s.add_dependency(%q<webmock>.freeze, [">= 0"])
+    s.add_dependency(%q<pry-byebug>.freeze, [">= 0"])
+    s.add_dependency(%q<bundler>.freeze, [">= 0"])
+    s.add_dependency(%q<jeweler>.freeze, [">= 0"])
   end
 end
 

data/lib/engaging_networks/action.rb

@@ -3,6 +3,7 @@ require 'nokogiri'
 
 module EngagingNetworks
   class InvalidActionError < StandardError ; end
+  class InvalidJsonResponseError < StandardError ; end
 
   class Action < Base
     # individual get unavailable
@@ -49,7 +50,11 @@ module EngagingNetworks
         rsp = client.post_request_with_get_params(action_path, {'format'=>'json'}, post_params)
         action.raw_response = rsp
         body = rsp.body
-        json_body = JSON.parse(body)
+        begin
+          json_body = JSON.parse(body)
+        rescue JSON::ParserError => e
+          raise EngagingNetworks::InvalidJsonResponseError.new("Unable to parse JSON, Engaging Networks responded with: #{ body }; json: #{e.message} headers: #{rsp.headers} status: #{rsp.status}")
+        end
 
         # parse json for first form field, apisuccess div
         if json_body['messages'].empty? || body =~ /apisuccess/

data/lib/engaging_networks/api.rb

@@ -3,10 +3,9 @@ require 'engaging_networks/request/multitoken'
 module EngagingNetworks
   class API < Vertebrae::API
 
-    def request_with_wrapper( *args )
-      EngagingNetworks::Response::Wrapper.new( request_without_wrapper( *args ) )
+    def request(*args)
+      EngagingNetworks::Response::Wrapper.new( super(*args) )
     end
-    alias_method_chain :request, :wrapper
 
     def default_options
       {
@@ -90,4 +89,4 @@ module EngagingNetworks
       end
     end
   end
-end
+end

data/lib/engaging_networks/campaign.rb

@@ -1,4 +1,7 @@
 module EngagingNetworks
+  class CampaignDuplicationError < StandardError
+  end
+
   class Campaign < Base
     def get(campaignId)
       client.get_request(data_path, {service: 'EaCampaignInfo', campaignId: campaignId,
@@ -26,7 +29,7 @@ module EngagingNetworks
         if response.body =~ /uploaded successfully/
           action.job_id = /# is (\d*)/.match(response.body)[1]
         else
-          raise "error while duplicating campaign: #{response.body}"
+          raise CampaignDuplicationError.new("error while duplicating campaign: #{response.body}")
         end
       end
 
@@ -45,4 +48,5 @@ module EngagingNetworks
     end
 
   end
+
 end

data/lib/engaging_networks/version.rb

@@ -1,10 +1,10 @@
 module EngagingNetworks
   module VERSION
     MAJOR = 0
-    MINOR = 1
-    PATCH = 0
+    MINOR = 2
+    PATCH = 2
     BUILD = nil
 
     STRING = [MAJOR, MINOR, PATCH, BUILD].compact.join('.')
   end
-end
+end

data/spec/engaging_networks/action_spec.rb

@@ -50,5 +50,13 @@ describe EngagingNetworks::Action do
         expect { en.action.create(input_hash) }.to raise_error(EngagingNetworks::InvalidActionError)
       end
     end
+
+    describe 'invalid json' do
+      let(:body) { '{hello: unclosed'}
+
+      it 'should raise' do
+        expect { en.action.create(input_hash) }.to raise_error(EngagingNetworks::InvalidJsonResponseError)
+      end
+    end
   end
 end

data/spec/engaging_networks/campaign_spec.rb

@@ -70,7 +70,7 @@ describe EngagingNetworks::Campaign do
       let(:body) { fixture('import.service/error.txt') }
 
       it 'should raise an exception' do
-        expect { en.campaign.duplicate(params) }.to raise_error(StandardError)
+        expect { en.campaign.duplicate(params) }.to raise_error(EngagingNetworks::CampaignDuplicationError).with_message('error while duplicating campaign: Error: Unable to process your import. Please contact support.')
       end
     end
   end
@@ -106,4 +106,4 @@ describe EngagingNetworks::Campaign do
     let(:body) { fixture('EaCampaignInfo/success_array.xml') }
     let(:status) { 200 }
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: engaging_networks
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Josh Levinger
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-10 00:00:00.000000000 Z
+date: 2017-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: vertebrae
@@ -141,16 +141,16 @@ dependencies:
   name: jeweler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '0'
 description: Gem for interacting with the Engaging Networks API
 email: josh@levinger.net
 executables: []
@@ -229,7 +229,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: A wrapper for the Engaging Networks API