enabler 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7292b10984446825ad2199ad40de2589136c203b
-  data.tar.gz: 9ef0a852a2c72b8a1dec129969731e6525946834
+  metadata.gz: 96b2c11e3a376fc692ebc89c2d14cd0113093bab
+  data.tar.gz: be2f56970f93247b164e6298dcaa0eff9bf422b7
 SHA512:
-  metadata.gz: 27d862408a5fb3547f41365ef5cd4e562302e2a5f6e69e9642147a522f8f9bf45d1e6f3bd938d3f27a3d4433c37d9a86579ac70942548d22e0a24dbc0ccb671a
-  data.tar.gz: 94f7ff34fbaaabd17e1f5535a6e4b4e969503234219ce54157b9aa3f553ce437dc7d0c266a07ab1d415a9cf418a0bebb37b2e87bc9f92b2a72acbd4ad60b845a
+  metadata.gz: 3c3a80480396a8eea950ea3d0d1cbc156f4d32e9fcdaf7866cf3aa16dd962fb4d5bde000aae0777feb9806a77025659b660565b005669f439a7929a7cecd270b
+  data.tar.gz: d7221069538d4e6b3be21c018827b971027773d7c2bae1d42b951bddad65ce0bfd1057daf971acbdf807e3999bdeb04d9806426c27320f1675eb904ea33bfa25

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    enabler (0.0.1)
+    enabler (0.0.3)
       redis
 
 GEM

data/lib/enabler/config.rb

@@ -0,0 +1,30 @@
+module Enabler
+  class Config
+    include Singleton
+
+    def rule(feature, &block)
+      rules << Rule.new(feature.to_sym, block)
+    end
+
+    def after_enabling(feature, &block)
+      after_enablings[feature.to_sym] = block
+    end
+
+    def after_disabling(feature, &block)
+      after_disablings[feature.to_sym] = block
+    end
+
+    def rules
+      @rules ||= []
+    end
+
+    def after_enablings
+      @after_enables ||= {}
+    end
+
+    def after_disablings
+      @after_enables ||= {}
+    end
+
+  end
+end

data/lib/enabler/rule.rb

@@ -1,15 +1,19 @@
 module Enabler
-	class Rule
+  class Rule
 
-		attr_reader :feature, :definition
+    attr_reader :feature, :definition
 
-		def initialize(feature, definition)
-			@feature, @definition = feature, definition
-		end
+    def initialize(feature, definition)
+      @feature, @definition = feature, definition
+    end
 
-		def enabled?(model)
-			definition.call(model)
-		end
+    def enabled?(model)
+      definition.call(model)
+    end
 
-	end
+    def self.find feature
+      ::Enabler.config.rules.select { |item| item.feature == feature.to_sym }
+    end
+
+  end
 end

data/lib/enabler/version.rb

@@ -1,3 +1,3 @@
 module Enabler
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/enabler.rb

@@ -1,54 +1,55 @@
+require "singleton"
 require "enabler/version"
+
+require "enabler/config"
 require "enabler/storage/redis"
 require "enabler/errors/rule_already_defined_error"
 require "enabler/rule"
 
 module Enabler
+  class << self 
 
-	def self.store=(val)
-		@@store = val
-	end
+    def store=(val)
+      @@store = val
+    end
 
-	def self.store
-		@@store
-	end
+    def store
+      @@store
+    end
 
-	def self.enabled?(feature, object)
-		enabled_via_rule?(feature, object) || 
-			enabled_via_storage?(feature, object)
-	end
+    def enable!(feature, object)
+      store.add!(feature, object)
+      config.after_enablings[feature].call(object) if config.after_enablings[feature]
+    end
 
-	def self.enabled_via_storage?(feature, object)
-		store.enabled?(feature, object)
-	end
+    def disable!(feature, object)
+      store.remove!(feature, object)
+      config.after_disablings[feature].call(object) if config.after_disablings[feature]
+    end
 
-	def self.enabled_via_rule?(feature, object)
-		sym = feature.to_sym
-		r = self.rule(sym)
-		return false unless r
-		r.enabled?(object)
-	end
+    def enabled?(feature, object)
+      enabled_via_rule?(feature, object) || enabled_via_storage?(feature, object)
+    end
 
-	def self.enable!(feature, object)
-		store.add!(feature, object)
-	end
+    def config
+      Enabler::Config.instance
+    end
 
-	def self.disable!(feature, object)
-		store.remove!(feature, object)
-	end
+    def configure(&block)
+      config.instance_eval &block
+    end
 
-	def self.rules
-		@@rules ||= [] 
-	end
+    private
 
-	def self.rule(feature)
-		self.rules.select { |item| item.feature == feature.to_sym }.first
-	end
+    def enabled_via_storage?(feature, object)
+      store.enabled?(feature, object)
+    end
 
-	def self.define_rule!(feature, &block)
-		sym = feature.to_sym
-		raise Errors::RuleAlreadyDefinedError if self.rule(sym)
-		self.rules << Rule.new(sym, block)
-	end
+    def enabled_via_rule?(feature, object)
+      Array(Rule.find(feature.to_sym)).map do |r| 
+        r.enabled? object 
+      end.include? true
+    end
 
+  end
 end

data/spec/enabler/config_spec.rb

@@ -0,0 +1,27 @@
+require 'enabler'
+
+describe Enabler::Config do
+  let(:processor) { Proc.new { true } }
+  subject { Enabler::Config.instance }
+
+  describe "rule" do
+    it "adds the rule" do
+      expect { 
+        subject.rule :dance, &processor 
+      }.to change { 
+        subject.rules.length 
+      }.from(0).to 1
+    end
+  end
+
+  describe "after_enabling" do
+    before { subject.after_enabling :dance, &processor }
+    specify { subject.after_enablings[:dance].should == processor }
+  end
+
+  describe "after_disabling" do
+    before { subject.after_enabling :dance, &processor }
+    specify { subject.after_disablings[:dance].should == processor }
+  end
+end
+

data/spec/enabler/rule_spec.rb

@@ -1,17 +1,17 @@
 require 'enabler'
 
 describe Enabler::Rule do
-	let(:model) { double('Model', id:1) }
-	let(:pass_rule_def) { Proc.new { |model| model.id == 1 } }
-	let(:fail_rule_def) { Proc.new { |model| model.id != 1} }
+  let(:model) { double('Model', id:1) }
+  let(:pass_rule_def) { Proc.new { |model| model.id == 1 } }
+  let(:fail_rule_def) { Proc.new { |model| model.id != 1} }
 
-	context "with a passing rule" do
-		subject { Enabler::Rule.new(:jump, pass_rule_def) }
-		specify { subject.enabled?(model).should be_true }
-	end
+  context "with a passing rule" do
+    subject { Enabler::Rule.new(:jump, pass_rule_def) }
+    specify { subject.enabled?(model).should be_true }
+  end
 
-	context "with a failing rule" do
-		subject { Enabler::Rule.new(:jump, fail_rule_def) }
-		specify { subject.enabled?(model).should be_false }
-	end
+  context "with a failing rule" do
+    subject { Enabler::Rule.new(:jump, fail_rule_def) }
+    specify { subject.enabled?(model).should be_false }
+  end
 end

data/spec/enabler/storage/redis_spec.rb

@@ -2,39 +2,39 @@ require 'mock_redis'
 require 'enabler'
 
 describe Enabler::Storage::Redis do
-	let(:redis) { MockRedis.new }
-	let(:model) { double('Model', id:1, class:'Model') }
-	subject { Enabler::Storage::Redis.new(redis) }
+  let(:redis) { MockRedis.new }
+  let(:model) { double('Model', id:1, class:'Model') }
+  subject { Enabler::Storage::Redis.new(redis) }
 
-	describe "#add!" do
-		it "adds the id to the correct set in redis" do
-			expect{ 
-				subject.add!(:dance, model) 
-			}.to change{
-				redis.sismember('enabler::model::dance', 1) 
-			}.from(false).to(true)
-		end
-	end
+  describe "#add!" do
+    it "adds the id to the correct set in redis" do
+      expect{ 
+        subject.add!(:dance, model) 
+      }.to change{
+        redis.sismember('enabler::model::dance', 1) 
+      }.from(false).to(true)
+    end
+  end
 
-	describe "#remove!" do
-		before { subject.add!(:dance, model)	}
-		it "removes the id from the correct set in redis" do
-			expect{ 
-				subject.remove!(:dance, model) 
-			}.to change{
-				redis.sismember('enabler::model::dance', 1) 
-			}.from(true).to(false)
-		end
-	end
+  describe "#remove!" do
+    before { subject.add!(:dance, model)	}
+    it "removes the id from the correct set in redis" do
+      expect{ 
+        subject.remove!(:dance, model) 
+      }.to change{
+        redis.sismember('enabler::model::dance', 1) 
+      }.from(true).to(false)
+    end
+  end
 
 
-	describe "#enabled?" do
-		context "when id is in set" do
-			before { subject.add!(:dance, model) }
-			specify { subject.enabled?(:dance, model).should be_true }
-		end
-		context "when id is not in set" do
-			specify { subject.enabled?(:dance, model).should be_false }
-		end
-	end
+  describe "#enabled?" do
+    context "when id is in set" do
+      before { subject.add!(:dance, model) }
+      specify { subject.enabled?(:dance, model).should be_true }
+    end
+    context "when id is not in set" do
+      specify { subject.enabled?(:dance, model).should be_false }
+    end
+  end
 end

data/spec/enabler_spec.rb

@@ -1,55 +1,93 @@
 require 'enabler'
 
 describe Enabler do
-	let(:store) { double('Store', add!:true, remove!:true) }
-	let(:model) { double('Model', id:1, class:'Model') }
-	before { Enabler.store = store }
-
-	describe ".enabled?" do
-
-		context "when store has feature enabled" do
-			before { store.stub(:enabled?) { true } }
-			specify { Enabler.enabled?(:dance, model).should be_true }
-		end
-
-		context "when store has feature disabled" do
-			before { store.stub(:enabled?) { false } }
-			specify { Enabler.enabled?(:dance, model).should be_false }
-		end
-
-	end
-
-	describe ".enable!" do
-		it "calls set on the store" do
-			store.should_receive(:add!).with(:dance, model)
-			Enabler.enable! :dance, model
-		end
-	end
-
-	describe ".disable!" do
-		it "calls set on the store" do
-			store.should_receive(:remove!).with(:dance, model)
-			Enabler.disable! :dance, model
-		end
-	end
-
-	describe ".rules" do
-		context "with no rules set" do
-			specify { Enabler.rules.should be == [] }
-		end
-
-		context "with rules set" do
-			let(:rule_def) { Proc.new{ true} }
-			before do
-				Enabler.define_rule! :boogie, &rule_def
-			end
-			after do
-				Enabler.class_variable_set(:@@rules, [])
-			end
-      
-			specify { Enabler.rules.length.should be == 1 }
-			specify { Enabler.rule(:boogie).feature.should == :boogie }
-			specify { Enabler.rule(:boogie).definition.should == rule_def }
-		end
-	end
+  let(:store) { double('Store', add!:true, remove!:true) }
+  let(:model) { double('Model', id:1, class:'Model') }
+
+  after do 
+    Enabler.config.instance_variable_set(:@rules, []) 
+    Enabler.config.instance_variable_set(:@after_enablings, {})
+    Enabler.config.instance_variable_set(:@after_disablings, {})
+  end
+
+  before { Enabler.store = store }
+
+  describe ".enabled?" do
+
+    context "when store has feature enabled" do
+      before { store.stub(:enabled?) { true } }
+      specify { Enabler.enabled?(:dance, model).should be_true }
+    end
+
+    context "when store has feature disabled" do
+      before { store.stub(:enabled?) { false } }
+      specify { Enabler.enabled?(:dance, model).should be_false }
+    end
+
+  end
+
+  describe ".enable!" do
+    it "calls set on the store" do
+      store.should_receive(:add!).with(:dance, model)
+      Enabler.enable! :dance, model
+    end
+    context "with after callbacks" do
+      before do
+        Enabler.configure do
+          after_enabling :dance do |object|
+            object.stub(:stubbed).and_return true
+            object.stubbed
+          end
+        end
+      end
+      it "calls the after_enabling callback" do
+        model.should_receive :stubbed
+        Enabler.enable! :dance, model
+      end
+    end
+  end
+
+  describe ".disable!" do
+    it "calls set on the store" do
+      store.should_receive(:remove!).with(:dance, model)
+      Enabler.disable! :dance, model
+    end
+    context "with after callbacks" do
+      before do
+        Enabler.configure do
+          after_disabling :dance do |object|
+            object.stub(:stubbed).and_return true
+            object.stubbed
+          end
+        end
+      end
+      it "calls the after_enabling callback" do
+        model.should_receive :stubbed
+        Enabler.disable! :dance, model
+      end
+    end
+  end
+
+  describe "rules" do
+    context "with no rules set" do
+      specify { Enabler.config.rules.should be == [] }
+    end
+
+    context "with rules set" do
+      before do
+        Enabler.configure do
+          rule :boogie do
+            true
+          end
+        end
+      end
+      after do
+        Enabler.class_variable_set(:@@rules, [])
+      end
+
+      specify { Enabler.config.rules.length.should be == 1 }
+      specify { Enabler::Rule.find(:boogie).first.feature.should == :boogie }
+      specify { Enabler::Rule.find(:boogie).first.definition.call.should be_true }
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: enabler
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Luke Roberts
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-14 00:00:00.000000000 Z
+date: 2014-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -96,10 +96,12 @@ files:
 - Rakefile
 - enabler.gemspec
 - lib/enabler.rb
+- lib/enabler/config.rb
 - lib/enabler/errors/rule_already_defined_error.rb
 - lib/enabler/rule.rb
 - lib/enabler/storage/redis.rb
 - lib/enabler/version.rb
+- spec/enabler/config_spec.rb
 - spec/enabler/rule_spec.rb
 - spec/enabler/storage/redis_spec.rb
 - spec/enabler_spec.rb
@@ -128,6 +130,7 @@ signing_key:
 specification_version: 4
 summary: Enable features
 test_files:
+- spec/enabler/config_spec.rb
 - spec/enabler/rule_spec.rb
 - spec/enabler/storage/redis_spec.rb
 - spec/enabler_spec.rb