empty_eye 0.4.1 → 0.4.2

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # 0.4.1 / 2012-03-11 / Grady Griffin
 
+* reorganized some methods
+* added logic to free up complex data structures once they are not needed
+* fixed some comment typos
+* added comments
+* updated reflect\_on\_multiple\_associations to work as intended
+
+# 0.4.1 / 2012-03-11 / Grady Griffin
+
 * added homepage to gemspec
 
 # 0.4.0 / 2012-03-11 / Grady Griffin

data/lib/empty_eye/active_record/base.rb

@@ -3,7 +3,7 @@ module ActiveRecord
     
     class << self
     
-      #am i an mti class? easier than making a new class type ... i tried
+      #am i a mti class? easier than making a new class type ... i tried
       def mti_class?
         extended_with.any?
       end
@@ -11,7 +11,7 @@ module ActiveRecord
       #interface for building mti_class
       #primary table is not necessary if the table named correctly (Bar => bars_core)
       #OR if the class inherits a primary table
-      #simply wrap your greasy association in this block
+      #simply wrap your greasy associations in this block
       def mti_class(primary_table = nil)
         self.primary_key = "id"
         raise(EmptyEye::AlreadyExtended, "MTI class method already invoked") if mti_class?
@@ -36,7 +36,7 @@ module ActiveRecord
         extended_with.primary.shard
       end
       
-      #we dont need no freakin' finder
+      #we dont need no freakin' type condition
       #the view handles this
       def finder_needs_type_condition?
         !mti_class? and super
@@ -62,9 +62,9 @@ module ActiveRecord
       end
       
       #determine the primary table
-      #first detrmine if our view name exists; this will need to chage one day
+      #first determine if our view name exists; this will need to change one day
       #if they didnt specify try using the core convention else the superclass
-      #if they specified use what the set
+      #if they specified use what they set
       def set_mti_primary_table(primary_table_name)
         @mti_primary_table = if ordinary_table_exists?
           raise(EmptyEye::ViewNameError, "MTI view cannot be created because a table named '#{compute_view_name}' already exists")
@@ -83,7 +83,7 @@ module ActiveRecord
       #we could use the baked in version for now
       def reflect_on_multiple_associations(*assoc_types)
         assoc_types.collect do |assoc_type| 
-          reflect_on_all_associations
+          reflect_on_all_associations(assoc_type)
         end.flatten.uniq
       end
 
@@ -92,7 +92,7 @@ module ActiveRecord
         connection.tables_without_views.include?(compute_view_name)
       end
     
-      #drop the view; dont check if we can just rescue any errors
+      #drop the view; dont check if we can, just rescue any errors
       #create the view
       def create_view
         connection.execute("DROP VIEW #{table_name}") rescue nil
@@ -105,15 +105,17 @@ module ActiveRecord
       end
       
       #we know how to rebuild the validations from the shards
-      #lets call our inherited validation here
+      #lets call our inherited validations here
       def inherit_mti_validations
         extended_with.validations.each {|args| send(*args)}
+        #no need to keep these in memory
+        extended_with.free_validations
       end
     end
     
     private
     
-    #a pseudo association method back to instances primary shard
+    #a pseudo association method mapping us back to instances primary shard
     def mti_primary_shard
       @mti_primary_shard ||= if new_record?
         self.class.mti_primary_shard.new(:mti_instance => self)

data/lib/empty_eye/errors.rb

@@ -2,4 +2,5 @@ module EmptyEye
   class AlreadyExtended < StandardError; end
   class ViewNameError < StandardError; end
   class InvalidUpdate < StandardError; end
+  class NotYetSupported < StandardError; end
 end

data/lib/empty_eye/shard.rb

@@ -1,8 +1,8 @@
 module EmptyEye
   module Shard
     
-    #a module that extendd the class that serves as a pointer to the primary table
-    #when there is a superclass the will inherit from that else it will inherit from ActiveRecord
+    #module which extends the class that serves as a pointer to the primary table
+    #when there is a superclass the shard will inherit from that, else it will inherit from ActiveRecord
     #the primary shard manages all the MTI associated tables for the master class
     
     def self.included(base)
@@ -10,8 +10,11 @@ module EmptyEye
     end
     
     #the instance that owns this primary shard
+    #we usually know the master instance ahead of time
+    #so we should take care to set this manually
+    #we want to avoid the lookup
     def mti_instance
-      @mti_instance
+      @mti_instance || mti_master_class.find_by_id(id)
     end
     
     #setter used to associate the primary shard with the master instance
@@ -72,7 +75,7 @@ module EmptyEye
         reflection
       end
 
-      #finder methods should use the master classes base class not the shards
+      #finder methods should use the master class's type not the shard's
       def type_condition(table = arel_table)
         sti_column = table[inheritance_column.to_sym]
 

data/lib/empty_eye/version.rb

@@ -2,7 +2,7 @@ module EmptyEye
   module VERSION
     MAJOR = 0
     MINOR = 4
-    TINY = 1
+    TINY = 2
 
     STRING = [MAJOR, MINOR, TINY].join('.')
   end

data/lib/empty_eye/view_extension.rb

@@ -68,7 +68,6 @@ module EmptyEye
       parent.base_class.name if polymorphic_type
     end
 
-    #value computed to remove this from column map; no need for the view to have it
     def polymorphic_type
       return unless association.options[:as]
       "#{association.options[:as]}_type"

data/lib/empty_eye/view_extension_collection.rb

@@ -79,7 +79,7 @@ module EmptyEye
         query.where(primary.type_column.eq(primary.type_value))
       end
       
-      #build veiw creation statement
+      #build view creation statement
       "CREATE VIEW #{parent.table_name} AS\n#{query.to_sql}"
     end
     
@@ -123,6 +123,11 @@ module EmptyEye
         super
       end
     end
+
+    #we dont need to keep this data
+    def free_validations
+      @validations = nil
+    end
     
     private
     

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: empty_eye
 version: !ruby/object:Gem::Version 
-  hash: 13
+  hash: 11
   prerelease: 
   segments: 
   - 0
   - 4
-  - 1
-  version: 0.4.1
+  - 2
+  version: 0.4.2
 platform: ruby
 authors: 
 - thegboat