emittance-resque 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 13c0a85b693a713e1516141499eb505a4f206703
-  data.tar.gz: 42c7494bab9c927ffd9d1ee0af4700f4b6cc0f42
+  metadata.gz: 07eeee5c1b4e819e217d2529be7667ec484255ed
+  data.tar.gz: 6809f675cc3214a215d4187a93f0559f2bf0e6df
 SHA512:
-  metadata.gz: 98b97e70e34f312e8df01bf5037c24644a4e47ced94d8596ab2b05cbe8a4b5dcbedf484f59a56d7beb71df7a912f611982f5d17e713ae4519ba1ad62c464fddc
-  data.tar.gz: a1156e2290cbfa4af0a146d4b7ab3b19fb4494af4c887d836abfad0917693d2f782cb8a566de10e3436c107ecda87b82e38f16d653ce669ba64457ef0f90aebc
+  metadata.gz: 8bdfe8c467d68f18edef7689069ed2126be7fe70e381936b9fd14d3d9e5405479c59dd1e97ef6ccbfbc456dd59fc5dcb171c31bc00c004dba246dfc4bd66b7e5
+  data.tar.gz: 3ca8455325a20f5cc9d14af2ad177bb692c63ad1b0b4ec08cc019d695ed65432286ee508f000db520524fe8ad10abe36bb88d5a1380d958ec946fc8b391f12a1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    emittance-resque (0.1.1)
+    emittance-resque (0.2.0)
       emittance (>= 0.1.1)
       resque
 
@@ -24,7 +24,7 @@ GEM
     concurrent-ruby (1.0.5)
     diff-lcs (1.3)
     docile (1.1.5)
-    emittance (0.1.1)
+    emittance (0.1.3)
     i18n (0.9.1)
       concurrent-ruby (~> 1.0)
     json (2.1.0)

data/lib/emittance/resque/dispatcher.rb

@@ -8,9 +8,7 @@ module Emittance
   end
 end
 
-require 'emittance/resque/job'
-require 'emittance/resque/dispatcher/job_klass_name'
-require 'emittance/resque/dispatcher/job_klass'
+require 'emittance/resque/process_event_job'
 require 'emittance/resque/event_serializer'
 require 'emittance/resque/event_serializer/default'
 
@@ -20,7 +18,10 @@ module Emittance
     # The Resque dispatcher for Emittance.
     #
     class Dispatcher
-      Jobs = Module.new
+      MethodCallRegistration = Struct.new(:klass_name, :method_name, :queue)
+
+      PROCESS_EVENT_JOB = Emittance::Resque::ProcessEventJob
+      DEFAULT_QUEUE = :default
 
       class << self
         include Emittance::Helpers::ConstantHelpers
@@ -28,10 +29,10 @@ module Emittance
         private
 
         def _process_event(event)
-          jobs = registrations_for(event.class)
+          registrations = registrations_for(event.class)
           serialized_event = serialize_event(event)
 
-          jobs.each { |job| enqueue_job job, serialized_event }
+          registrations.each { |registration| enqueue_job registration, serialized_event }
         end
 
         def _register(_identifier, &_callback)
@@ -41,47 +42,31 @@ module Emittance
         def _register_method_call(identifier, object, method_name)
           validate_method_call object, method_name
 
-          event_klass = find_event_klass(identifier)
-          klass_name = method_call_job_klass_name(event_klass, object, method_name)
-          klass = method_call_job_klass(object, method_name)
-
-          set_namespaced_constant_by_name("#{Jobs.name}::#{klass_name}", klass) unless Jobs.const_defined?(klass_name)
-          registrations_for(identifier) << klass
+          registrations_for(identifier) << new_registration(object, method_name)
         end
 
-        def enqueue_job(job, event)
-          ::Resque.enqueue job, event
+        def new_registration(object, method_name)
+          MethodCallRegistration.new(object.name, method_name)
         end
 
-        def find_event_klass(event)
-          Emittance::EventLookup.find_event_klass(event)
-        end
+        def enqueue_job(registration, event)
+          queue = queue_from_registration(registration)
 
-        def serialize_event(event)
-          Emittance::Resque::EventSerializer.serialize(event)
+          ::Resque.enqueue_to queue, PROCESS_EVENT_JOB, registration.klass_name, registration.method_name, event
         end
 
-        def method_call_job_klass_name(event_klass, object, method_name)
-          JobKlassName.new(event_klass, object, method_name).generate
+        def queue_from_registration(registration)
+          registration.queue || DEFAULT_QUEUE
         end
 
-        def job_klass(callback)
-          JobKlass.new(callback).generate
-        end
-
-        def method_call_job_klass(object, method_name)
-          callback = lambda_for_method_call(object, method_name)
-          job_klass callback
+        def serialize_event(event)
+          Emittance::Resque::EventSerializer.serialize event
         end
 
         def validate_method_call(object, _method_name)
           error_msg = 'Emittance::Resque can only call methods on classes and modules'
           raise InvalidCallbackError, error_msg unless object.is_a?(Module)
         end
-
-        def lambda_for_method_call(object, method_name)
-          ->(event) { object.send method_name, event }
-        end
       end
     end
   end

data/lib/emittance/resque/process_event_job.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+module Emittance
+  module Resque
+    ##
+    # The job that is enqueued when an event is emitted.
+    #
+    class ProcessEventJob
+      @queue = :default
+
+      class << self
+        def perform(klass_name, method_name, serialized_event)
+          deserialized_event = Emittance::Resque::EventSerializer.deserialize(serialized_event)
+          new(klass_name, method_name, deserialized_event).perform
+        end
+      end
+
+      def initialize(klass_name, method_name, event)
+        @klass_name = klass_name
+        @method_name = method_name
+        @event = event
+      end
+
+      def perform
+        klass.send method_name, event
+      end
+
+      private
+
+      attr_reader :klass_name, :method_name, :event
+
+      def klass
+        Object.const_get(klass_name)
+      end
+    end
+  end
+end

data/lib/emittance/resque/version.rb

@@ -2,6 +2,6 @@
 
 module Emittance
   module Resque
-    VERSION = '0.1.1'
+    VERSION = '0.2.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: emittance-resque
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Tyler Guillen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-12-29 00:00:00.000000000 Z
+date: 2018-01-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: emittance
@@ -161,13 +161,11 @@ files:
 - lib/emittance/resque.rb
 - lib/emittance/resque/broker.rb
 - lib/emittance/resque/dispatcher.rb
-- lib/emittance/resque/dispatcher/job_klass.rb
-- lib/emittance/resque/dispatcher/job_klass_name.rb
 - lib/emittance/resque/errors.rb
 - lib/emittance/resque/event_serializer.rb
 - lib/emittance/resque/event_serializer/active_record.rb
 - lib/emittance/resque/event_serializer/default.rb
-- lib/emittance/resque/job.rb
+- lib/emittance/resque/process_event_job.rb
 - lib/emittance/resque/version.rb
 homepage: https://github.com/aastronautss/emittance-resque
 licenses:

data/lib/emittance/resque/dispatcher/job_klass.rb

@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-module Emittance
-  module Resque
-    class Dispatcher
-      ##
-      # Use this to build a job class from a callback block/proc/lambda.
-      #
-      class JobKlass
-        # The name of the method used by the background job library to perform the job.
-        PERFORM_METHOD_NAME = :perform
-
-        def initialize(callback, queue: :default)
-          @callback = callback
-          @queue = queue
-        end
-
-        def generate
-          klass = Class.new(Emittance::Resque::Job)
-          klass.send(:define_method, PERFORM_METHOD_NAME, callback)
-          klass.instance_variable_set '@queue', queue
-
-          klass
-        end
-
-        private
-
-        attr_reader :callback, :queue
-      end
-    end
-  end
-end

data/lib/emittance/resque/dispatcher/job_klass_name.rb

@@ -1,46 +0,0 @@
-# frozen_string_literal: true
-
-module Emittance
-  module Resque
-    class Dispatcher
-      ##
-      # Use this to build job class names.
-      #
-      class JobKlassName
-        include Emittance::Helpers::StringHelpers
-
-        SUFFIX = 'Job'
-
-        def initialize(event_klass, object, method_name)
-          @event_klass = event_klass
-          @object = object
-          @method_name = method_name
-        end
-
-        def generate
-          "#{prefix}::#{base_name}#{suffix}"
-        end
-
-        private
-
-        attr_reader :event_klass, :object, :method_name
-
-        def prefix
-          event_klass.name
-        end
-
-        def base_name
-          "#{object}::#{formatted_method_name}"
-        end
-
-        def suffix
-          SUFFIX
-        end
-
-        def formatted_method_name
-          camel_case(method_name.to_s)
-        end
-      end
-    end
-  end
-end

data/lib/emittance/resque/job.rb

@@ -1,20 +0,0 @@
-# frozen_string_literal: true
-
-require 'emittance/resque/event_serializer'
-
-module Emittance
-  module Resque
-    ##
-    # Wrapper calls for resque jobs to dispatch.
-    #
-    class Job
-      class << self
-        def perform(event)
-          deserialized_event = Emittance::Resque::EventSerializer.deserialize(event)
-
-          new.perform(deserialized_event)
-        end
-      end
-    end
-  end
-end