embulk-parser-regex 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 180e9d8ef6ff872d1aa840f937972ba228b2762c
-  data.tar.gz: 5ae14fb13a5ac890f8f4c7224cf14fbe660ddb22
+  metadata.gz: e8d133ba73ccd1e36f1080041375467f531f756c
+  data.tar.gz: 1e35069e1548167e77161aaa4af85d9069e29856
 SHA512:
-  metadata.gz: bf0f5d97601bd217bc28b955d1046456d9231c9cbf7614c82fe90dfe70fb43716ce09ab3762e0bf2737ffc9a1e6774e23086e7a61c2b5526afc284619df89a0d
-  data.tar.gz: 7e1a23835f82c112616998ce5c121ddac25299ac0d91afb934b6a5f8218b295a561a7842446b261a79a83dea9d267dca1d60f827e3a72e99675c824b4ee40a7d
+  metadata.gz: d603860a6064bab07f8951f66c632d35af221f7665c4f7b6faf435aba86ebed2666f54cf65b3d63e9d798395cf17cabc37fefe7394a928f4f2e8de81e6009c55
+  data.tar.gz: f6d21ac5993d9727b6c02ad7d315bfe282d4f44a32016bd389315ce3acaecaa7c9eb094a1fef5509eee3b67ec79f9b823808d23ac54b647f319cbf5a8c8a21a1

data/README.md

@@ -53,3 +53,9 @@ $ embulk guess -g regex config.yml -o guessed.yml
 ```
 $ ./gradlew gem  # -t to watch change of files and rebuild continuously
 ```
+
+## Run checkstyle:
+
+```
+$ ./gradlew check
+```

data/build.gradle

@@ -2,6 +2,7 @@ plugins {
     id "com.jfrog.bintray" version "1.1"
     id "com.github.jruby-gradle.base" version "0.1.5"
     id "java"
+    id "checkstyle"
 }
 
 import com.github.jrubygradle.JRubyExec
@@ -13,15 +14,22 @@ configurations {
     provided
 }
 
-version = "0.2.0"
+version = "0.2.1"
+
+sourceCompatibility = 1.7
+targetCompatibility = 1.7
 
 dependencies {
-    compile  "org.embulk:embulk-core:0.7.4"
-    provided "org.embulk:embulk-core:0.7.4"
+    compile  "org.embulk:embulk-core:0.8.+"
+    provided "org.embulk:embulk-core:0.8.+"
     // compile "YOUR_JAR_DEPENDENCY_GROUP:YOUR_JAR_DEPENDENCY_MODULE:YOUR_JAR_DEPENDENCY_VERSION"
     testCompile "junit:junit:4.+"
 }
 
+checkstyle {
+    toolVersion = '6.7'
+}
+
 task classpath(type: Copy, dependsOn: ["jar"]) {
     doFirst { file("classpath").deleteDir() }
     from (configurations.runtime - configurations.provided + files(jar.archivePath))

data/src/main/java/org/embulk/parser/regex/RegexParserPlugin.java

@@ -14,6 +14,7 @@ import org.embulk.spi.util.DynamicColumnSetter;
 import org.embulk.spi.util.LineDecoder;
 import org.embulk.spi.util.Timestamps;
 import org.embulk.spi.util.dynamic.*;
+import org.slf4j.Logger;
 
 import java.util.HashMap;
 import java.util.Map;
@@ -42,6 +43,12 @@ public class RegexParserPlugin implements ParserPlugin {
             extends Task, TimestampFormatter.TimestampColumnOption {
     }
 
+    private final Logger log;
+
+    public RegexParserPlugin() {
+        log = Exec.getLogger(RegexParserPlugin.class);
+    }
+
     public void transaction(ConfigSource config, ParserPlugin.Control control) {
         PluginTask task = config.loadConfig(PluginTask.class);
         control.run(task.dump(), task.getSchemaConfig().toSchema());
@@ -59,18 +66,23 @@ public class RegexParserPlugin implements ParserPlugin {
                 timestampParsers, taskSource.loadTask(PluginTaskFormatter.class));
 
         while (input.nextFile()) {
+
+            int lineNumber = 0;
+
             while (true) {
                 String line = lineDecoder.poll();
+                lineNumber++;
+
                 if (line == null) {
                     break;
                 }
                 Matcher matcher = pattern.matcher(line);
                 if (!matcher.matches()) {
                     if (task.getSkipIfUnmatch()) {
-                        // TODO: How to Log?
+                        log.warn(String.format("Skipped unmatched line %d: %s", lineNumber, line));
                         continue;
                     } else {
-                        throw new DataException("Unmatched Line: " + line);
+                        throw new DataException(String.format("Unmatched Line at line %d: %s", lineNumber, line));
                     }
                 }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: embulk-parser-regex
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Ken Morishita
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-08-31 00:00:00.000000000 Z
+date: 2016-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -65,7 +65,7 @@ files:
 - sample/simple/data_simple_1.txt
 - src/main/java/org/embulk/parser/regex/RegexParserPlugin.java
 - src/test/java/org/embulk/parser/regex/TestRegexParserPlugin.java
-- classpath/embulk-parser-regex-0.2.0.jar
+- classpath/embulk-parser-regex-0.2.1.jar
 homepage: https://github.com/mokemokechicken/embulk-parser-regex
 licenses:
 - MIT