embulk-output-oracle 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1a79bcbce78533d883cb6e0a3841e8aaf188e01f
-  data.tar.gz: 5d2db1a232285ddb3760ba920e646f510a284cce
+  metadata.gz: f90682291054c54ff4e0f63ab186669c440fd6a6
+  data.tar.gz: 96d29462e71befb92de6c15ad57d90e18a9cce30
 SHA512:
-  metadata.gz: 7a65fe88370857e27c6a213c38efd364a33bcb02b8de88453e4bab0dfa820228c1088512394a228374efed68dbc4939a6a9901efa8eb24cfd6af137d024d0875
-  data.tar.gz: d2e4a43b12a9632e0ea5b503cbf096c2073c32769de7d5a7f3e9d6812853f5bc99c46771f99ecaa93f078c320fa4f37989e9cb0dbe451ffafdeb530f05921746
+  metadata.gz: ea6510701f23a9239704394579198f2e610c1164177c2f40d24251b430a4cf0a47e2c898cde16672de95c589ef38602c00d2faef1f5ddd6bb5bfc84a35967927
+  data.tar.gz: 28c048cde2c7f6d71125cc1c7a691df00f7d704c36e42cbead22f1c76708f94e88e46005cf2435329c0e38b8c45d73e0e9d45a7e79965e5bec302e7afefd41a8

data/README.md

@@ -32,11 +32,11 @@ Oracle output plugins for Embulk loads records to Oracle.
 ### Modes
 
 * **insert**:
-  * Behavior: This mode writes rows to some intermediate tables first. If all those tasks run correctly, runs `INSERT INTO <target_table> SELECT * FROM <intermediate_table_1> UNION ALL SELECT * FROM <intermediate_table_2> UNION ALL ...` query.
+  * Behavior: This mode writes rows to some intermediate tables first. If all those tasks run correctly, runs `INSERT INTO <target_table> SELECT * FROM <intermediate_table_1> UNION ALL SELECT * FROM <intermediate_table_2> UNION ALL ...` query. If the target table doesn't exist, it is created automatically.
   * Transactional: Yes. This mode successfully writes all rows, or fails with writing zero rows.
   * Resumable: Yes.
 * **insert_direct**:
-  * Behavior: This mode inserts rows to the target table directly.
+  * Behavior: This mode inserts rows to the target table directly. If the target table doesn't exist, it is created automatically.
   * Transactional: No. If fails, the target table could have some rows inserted.
   * Resumable: No.
 * **truncate_insert**:
@@ -44,7 +44,7 @@ Oracle output plugins for Embulk loads records to Oracle.
   * Transactional: Yes.
   * Resumable: Yes.
 * **replace**:
-  * Behavior: Same with `insert` mode excepting that it truncates the target table right before the last `INSERT ...` query.
+  * Behavior: This mode writes rows to an intermediate table first. If all those tasks run correctly, drops the target table and alters the name of the intermediate table into the target table name.
   * Transactional: Yes.
   * Resumable: No.
 
@@ -155,6 +155,6 @@ For Linux (x64) (only Ubuntu Server 14.04 is tested)
 (6) Execute src/main/cpp/linux/build.sh .
 
 ***
-<img src="https://www.yourkit.com/images/yklogo.png" alt="YourKit"/> is used to improve performance of embulk-output-oracle.  
-YourKit supports open source projects with its full-featured Java Profiler.  
-YourKit, LLC is the creator of <a href="https://www.yourkit.com/java/profiler/index.jsp">YourKit Java Profiler</a> and <a href="https://www.yourkit.com/.net/profiler/index.jsp">YourKit .NET Profiler</a>, innovative and intelligent tools for profiling Java and .NET applications.  
+<img src="https://www.yourkit.com/images/yklogo.png" alt="YourKit"/> is used to improve performance of embulk-output-oracle.
+YourKit supports open source projects with its full-featured Java Profiler.
+YourKit, LLC is the creator of <a href="https://www.yourkit.com/java/profiler/index.jsp">YourKit Java Profiler</a> and <a href="https://www.yourkit.com/.net/profiler/index.jsp">YourKit .NET Profiler</a>, innovative and intelligent tools for profiling Java and .NET applications.

data/src/test/java/org/embulk/output/oracle/OracleOutputPluginTest.java

@@ -134,12 +134,30 @@ public class OracleOutputPluginTest
         invoke("testInsert");
     }
 
+    @Test
+    public void testInsertCreate() throws Exception
+    {
+        invoke("testInsertCreate");
+    }
+
     @Test
     public void testInsertEmpty() throws Exception
     {
         invoke("testInsertEmpty");
     }
 
+    @Test
+    public void testTruncateInsert() throws Exception
+    {
+        invoke("testTruncateInsert");
+    }
+
+    @Test
+    public void testTruncateInsertCreate() throws Exception
+    {
+        invoke("testTruncateInsertCreate");
+    }
+
     @Test
     public void testInsertDirect() throws Exception
     {

data/src/test/java/org/embulk/output/oracle/OracleOutputPluginTestImpl.java

@@ -65,8 +65,8 @@ public class OracleOutputPluginTestImpl
 
         } catch (SQLException e) {
             System.err.println(e);
-            //throw new RuntimeException("You should prepare a schema on Oracle (database = 'TESTDB', user = 'TEST_USER', password = 'test_pw').");
-            System.err.println("Warning: prepare a schema on Oracle (database = 'TESTDB', user = 'TEST_USER', password = 'test_pw').");
+            //throw new RuntimeException("You should prepare a schema on Oracle (database = 'TESTDB', user = 'TEST_USER', password = 'test_pw', charset = UTF-8).");
+            System.err.println("Warning: prepare a schema on Oracle (database = 'TESTDB', user = 'TEST_USER', password = 'test_pw', charset = UTF-8).");
             // for example
             //   CREATE USER EMBULK_USER IDENTIFIED BY "embulk_pw";
             //   GRANT DBA TO EMBULK_USER;
@@ -89,6 +89,17 @@ public class OracleOutputPluginTestImpl
         assertTable(table);
     }
 
+    public void testInsertCreate() throws Exception
+    {
+        String table = "TEST1";
+
+        dropTable(table);
+
+        run("/yml/test-insert.yml");
+
+        assertGeneratedTable1(table);
+    }
+
     public void testInsertEmpty() throws Exception
     {
         String table = "TEST1";
@@ -101,6 +112,30 @@ public class OracleOutputPluginTestImpl
         assertTableEmpty(table);
     }
 
+    public void testTruncateInsert() throws Exception
+    {
+        String table = "TEST1";
+
+        dropTable(table);
+        createTable(table);
+        insertRecord(table);
+
+        run("/yml/test-truncate-insert.yml");
+
+        assertTable(table);
+    }
+
+    public void testTruncateInsertCreate() throws Exception
+    {
+        String table = "TEST1";
+
+        dropTable(table);
+
+        run("/yml/test-truncate-insert.yml");
+
+        assertGeneratedTable1(table);
+    }
+
     public void testInsertDirect() throws Exception
     {
         String table = "TEST1";
@@ -236,7 +271,7 @@ public class OracleOutputPluginTestImpl
 
     public void testReplaceLongNameMultibyte() throws Exception
     {
-        String table = "ＴＥＳＴ12345678901234567890";
+        String table = "ＴＥＳＴ123456789012345678";
 
         run("/yml/test-replace-long-name-multibyte.yml");
 
@@ -274,6 +309,11 @@ public class OracleOutputPluginTestImpl
         executeSQL(sql);
     }
 
+    private void insertRecord(String table) throws SQLException
+    {
+        executeSQL(String.format("INSERT INTO %s VALUES('9999', NULL, NULL, NULL, NULL, NULL)", table));
+    }
+
     private void assertTable(String table) throws Exception
     {
         // datetime of UTC will be inserted by embulk.

data/src/test/resources/yml/test-replace-long-name-multibyte.yml

@@ -20,7 +20,7 @@ out:
     database: TESTDB
     user: TEST_USER
     password: test_pw
-    table: ＴＥＳＴ12345678901234567890
+    table: ＴＥＳＴ123456789012345678
     mode: replace
     column_options:
       VARCHAR2_ITEM: {type: 'VARCHAR2(40)'}

data/src/test/resources/yml/test-truncate-insert.yml

@@ -0,0 +1,25 @@
+in:
+  type: file
+  path_prefix: '/data/test1/test1.csv'
+  parser:
+    charset: UTF-8
+    newline: CRLF
+    type: csv
+    delimiter: ','
+    quote: ''
+    columns:
+    - {name: ID, type: string}
+    - {name: VARCHAR2_ITEM, type: string}
+    - {name: INTEGER_ITEM, type: long}
+    - {name: NUMBER_ITEM, type: string}
+    - {name: DATE_ITEM, type: timestamp, format: '%Y/%m/%d'}
+    - {name: TIMESTAMP_ITEM, type: timestamp, format: '%Y/%m/%d %H:%M:%S'}
+out:
+    type: oracle
+    host: localhost
+    database: TESTDB
+    user: TEST_USER
+    password: test_pw
+    table: TEST1
+    mode: truncate_insert
+    #driver_path: driver/ojdbc7.jar

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: embulk-output-oracle
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Sadayuki Furuhashi
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-12-08 00:00:00.000000000 Z
+date: 2015-12-17 00:00:00.000000000 Z
 dependencies: []
 description: Inserts or updates records to a table.
 email:
@@ -68,9 +68,10 @@ files:
 - src/test/resources/yml/test-replace-long-name.yml
 - src/test/resources/yml/test-replace.yml
 - src/test/resources/yml/test-string-timestamp.yml
+- src/test/resources/yml/test-truncate-insert.yml
 - src/test/resources/yml/test-url.yml
-- classpath/embulk-output-jdbc-0.4.2.jar
-- classpath/embulk-output-oracle-0.4.2.jar
+- classpath/embulk-output-jdbc-0.4.3.jar
+- classpath/embulk-output-oracle-0.4.3.jar
 homepage: https://github.com/embulk/embulk-output-jdbc
 licenses:
 - Apache 2.0