embulk-input-mixpanel 0.3.3 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 48c99d14bae13fa0257e070bc5b99d444679392a
-  data.tar.gz: 8327dd45de51b2dab42754f212e5c6861621de7f
+  metadata.gz: 4f7e9eb914b30c6a19d3afe35b5b5314497c0c83
+  data.tar.gz: 1b3d12b83c9c06d66657b6e370ad2c28446b1754
 SHA512:
-  metadata.gz: ecb93dd7bade9b667d94a5f5cea247d6f46b1e1ad87d6046f6377f9495456e40f91b97a44a1440cbd04b8d4bbb15a2a223fbed7612469e08e427e32bc4e94db9
-  data.tar.gz: 94e3728eed0ce17d7178557556077f1d37049881567715523955c9888560d4886d774440206570cbf463822f2f82f19b2d216aa293bd8be1d1f0b27d3ea566a1
+  metadata.gz: 20a77df82f23049667d97de1a245a46844733983c5fece681dd53857507ec7eae6b1ee5a6ccefe325c48038c215584bf5590c93f710af44a64bfa1c206c4712b
+  data.tar.gz: d9536d638c52cac6af9936bea589b408a8f1106509ed6a60d929c3cec06d2bb96d29444a7666194b50ed581d210df599914f8d979d37a23a7ac0e8cf30b2bfe7

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.3.4 - 2015-11-02
+
+* [enhancement] Create `unknown_columns` only when option is true [#32](https://github.com/treasure-data/embulk-input-mixpanel/pull/32)
+
 ## 0.3.3 - 2015-10-29
 
 * [enhancement] Exponential backoff retry [#31](https://github.com/treasure-data/embulk-input-mixpanel/pull/31)

data/embulk-input-mixpanel.gemspec

@@ -1,7 +1,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = "embulk-input-mixpanel"
-  spec.version       = "0.3.3"
+  spec.version       = "0.3.4"
   spec.authors       = ["yoshihara", "uu59"]
   spec.summary       = "Mixpanel input plugin for Embulk"
   spec.description   = "Loads records from Mixpanel."

data/lib/embulk/input/mixpanel.rb

@@ -25,6 +25,8 @@ module Embulk
         range = RangeGenerator.new(from_date, fetch_days).generate_range
         Embulk.logger.info "Try to fetch data from #{range.first} to #{range.last}"
 
+        fetch_unknown_columns = config.param(:fetch_unknown_columns, :bool, default: true)
+
         task = {
           params: export_params(config),
           dates: range,
@@ -32,7 +34,7 @@ module Embulk
           api_key: config.param(:api_key, :string),
           api_secret: config.param(:api_secret, :string),
           schema: config.param(:columns, :array),
-          fetch_unknown_columns: config.param(:fetch_unknown_columns, :bool, default: true),
+          fetch_unknown_columns: fetch_unknown_columns,
           retry_initial_wait_sec: config.param(:retry_initial_wait_sec, :integer, default: 1),
           retry_limit: config.param(:retry_limit, :integer, default: 5),
         }
@@ -44,8 +46,9 @@ module Embulk
           Column.new(nil, name, type, column["format"])
         end
 
-        # for unknown columns
-        columns << Column.new(nil, "unknown_columns", :string)
+        if fetch_unknown_columns
+          columns << Column.new(nil, "unknown_columns", :string)
+        end
 
         resume(task, columns, 1, &control)
       end

data/test/embulk/input/test_mixpanel.rb

@@ -333,12 +333,9 @@ module Embulk
         end
 
         def columns
-          unknown_columns = [Column.new(nil, "unknown_columns", :string)]
-          configured_columns = schema.map do |col|
+          schema.map do |col|
             Column.new(nil, col["name"], col["type"].to_sym)
           end
-
-          configured_columns + unknown_columns
         end
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: embulk-input-mixpanel
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
 platform: ruby
 authors:
 - yoshihara
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-10-29 00:00:00.000000000 Z
+date: 2015-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement