embulk-filter-distinct 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2a22e5f7f1bec26311291809343774c9d5563abb
-  data.tar.gz: a299a75dd6efa46f3051b6f4c6b8a0ce5dc661a5
+  metadata.gz: d599cdfb56035c6d6cb89ac29440ed549ccbecec
+  data.tar.gz: 9f78869da19e5367ff6ecdc8281fcc634dd13edf
 SHA512:
-  metadata.gz: b33112403b386df0fffc317b8690bac18cbb96bd6c8b9a72903c113dd87a7ba7b5b3b466342e355834a69bde0c8a9198c61d5ce1393279b06c648e2b07baf215
-  data.tar.gz: 440db0f0e64bc4b9216317cad7f1a5f87af9fefb0d86ef206d9cd6c1a3e4a8d893c2d071b82c96c385f8edb4b482cf4cba062d3ca9928a5b634a7048ee6ab1d1
+  metadata.gz: 488c534c6fe14eb5cb63c267b96c4f725a15f5cdc608ca5ea9a7dc05a3f9f3aeb49dd620ed3b6b82e2ee4cc69cdadd4090f76b7115edb6ae47ae4388d3c27f69
+  data.tar.gz: bed20d3550b27ab998d11a2dad42ad66a855c467c06fdce3a850de537d9f3d9b23fd21aaeeb4d7ef984c295d2534fc2d387711edac4c1e6530b391de82ca5ab8

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+0.0.3 (2016-01-05)
+==================
+
+- Cosmetic Change: Rename class name
+- Cosmetic Change: Rename variables
+- Cosmetic Change: Change indents
+
 0.0.2 (2015-12-09)
 ==================
 

data/build.gradle

@@ -15,7 +15,7 @@ configurations {
     provided
 }
 
-version = "0.0.2"
+version = "0.0.3"
 sourceCompatibility = 1.7
 targetCompatibility = 1.7
 

data/src/main/java/org/embulk/filter/distinct/{FilteredPageOutput.java → DistinctFilterPageOutput.java}

@@ -1,9 +1,7 @@
 package org.embulk.filter.distinct;
 
 import com.google.common.base.Optional;
-import com.google.common.base.Strings;
 import com.google.common.collect.ImmutableList;
-import com.google.common.collect.ObjectArrays;
 import com.google.common.collect.Sets;
 import org.embulk.filter.distinct.DistinctFilterPlugin.PluginTask;
 import org.embulk.spi.Column;
@@ -22,20 +20,20 @@ import java.util.Set;
 /**
  * Created by takahiro.nakayama on 12/6/15.
  */
-class FilteredPageOutput
+class DistinctFilterPageOutput
     implements PageOutput
 {
-    private final static Logger logger = Exec.getLogger(FilteredPageOutput.class);
+    private final static Logger logger = Exec.getLogger(DistinctFilterPageOutput.class);
     private final PageReader pageReader;
     private final PageBuilder pageBuilder;
     private final ColumnVisitorImpl visitor;
     private final Schema outputSchema;
     private final List<Column> distinctColumns;
 
-    private final static Set<List<Object>> filter = Sets.newConcurrentHashSet();
+    private final static Set<List<Object>> set = Sets.newConcurrentHashSet();
 
-    FilteredPageOutput(PluginTask task, Schema inputSchema,
-                       Schema outputSchema, PageOutput pageOutput)
+    DistinctFilterPageOutput(PluginTask task, Schema inputSchema,
+                             Schema outputSchema, PageOutput pageOutput)
     {
         this.pageReader = new PageReader(inputSchema);
         this.pageBuilder = new PageBuilder(Exec.getBufferAllocator(), outputSchema, pageOutput);
@@ -100,12 +98,12 @@ class FilteredPageOutput
         return builder.build();
     }
 
-    private boolean isDistinct(List<Object> key) {
-        if (filter.add(key)) {
+    private boolean isDistinct(List<Object> values) {
+        if (set.add(values)) {
             return true;
         }
         else {
-            logger.debug("Duplicated key: {}", key);
+            logger.debug("Duplicated values: {}", values);
             return false;
         }
     }

data/src/main/java/org/embulk/filter/distinct/DistinctFilterPlugin.java

@@ -2,7 +2,6 @@ package org.embulk.filter.distinct;
 
 import com.google.common.collect.ImmutableList;
 import org.embulk.config.Config;
-import org.embulk.config.ConfigDefault;
 import org.embulk.config.ConfigException;
 import org.embulk.config.ConfigInject;
 import org.embulk.config.ConfigSource;
@@ -35,7 +34,7 @@ public class DistinctFilterPlugin
 
     @Override
     public void transaction(ConfigSource config, Schema inputSchema,
-            FilterPlugin.Control control)
+                            FilterPlugin.Control control)
     {
         PluginTask task = config.loadConfig(PluginTask.class);
 
@@ -59,8 +58,8 @@ public class DistinctFilterPlugin
                            final Schema outputSchema, final PageOutput output)
     {
         final PluginTask task = taskSource.loadTask(PluginTask.class);
-        return new FilteredPageOutput(task, inputSchema,
-                                      outputSchema, output);
+        return new DistinctFilterPageOutput(task, inputSchema,
+                                            outputSchema, output);
     }
 
     private List<Column> convertNameToColumn(Schema inputSchema, List<String> columnNames)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: embulk-filter-distinct
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Civitaspo
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-12-09 00:00:00.000000000 Z
+date: 2016-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -58,10 +58,10 @@ files:
 - gradlew.bat
 - lib/embulk/filter/distinct.rb
 - src/main/java/org/embulk/filter/distinct/ColumnVisitorImpl.java
+- src/main/java/org/embulk/filter/distinct/DistinctFilterPageOutput.java
 - src/main/java/org/embulk/filter/distinct/DistinctFilterPlugin.java
-- src/main/java/org/embulk/filter/distinct/FilteredPageOutput.java
 - src/test/java/org/embulk/filter/distinct/TestDistinctFilterPlugin.java
-- classpath/embulk-filter-distinct-0.0.2.jar
+- classpath/embulk-filter-distinct-0.0.3.jar
 homepage: https://github.com/civitaspo/embulk-filter-distinct
 licenses:
 - MIT