embulk-filter-column 0.5.3 → 0.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b597e430acd8f39ad24000c423fc00ad0396b84c
-  data.tar.gz: 1ab18bcd72e1e49d9aaf65f7343a11b9421e61ae
+  metadata.gz: 0cad32bb6df05ff04fb0501b8b893812d999969e
+  data.tar.gz: 7c0047d6f7dc5542195abd36a63e50aebdaa405a
 SHA512:
-  metadata.gz: 53d313c43ce6557672c2e4c78782a7089132fb87c9942210d4dd18844f143e3a046f4cb0b8561101100406e0a5df6351652b4afa18ff14ebde30cf818495cad6
-  data.tar.gz: ba2fb51e24bf1925ce078e545bf143345324b6ad332c96fa0184bc0a98b639d4df8d911ea3d3f84fa61c27c8458952a8f7c77f9813b850af4b3205548c6cecc0
+  metadata.gz: 1da990ff7ca9e14bbb7e385998309a979ef8376b3c25d8a117296ea121c82a91bf7cca8ee18439cf3b895b83a54901e37bcb6696ae618d4ee1c71755c1b92fc2
+  data.tar.gz: dbb3eb97dc117998562791b05ff846078be14cc365f754312e575ad8d0a576fe6575c3c471c6d55cd7fa8884146191cf56faa7e3b0f6a519c8f14d855ab23158

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# 0.5.4 (2016-08-05)
+
+Enhancements: 
+
+* raise ConfigException if json path ends with `[*]` (columns and add_columns)
+
 # 0.5.3 (2016-06-21)
 
 Changes:

data/README.md

@@ -114,9 +114,9 @@ C40P5H1WcBx-aWFDJCI8th6QPEI2DOUgupt_gB8UutE,7323
 For type: json column, you can specify [JSONPath](http://goessner.net/articles/JsonPath/) for column's name as:
 
 ```
-$.payload.key1
-$.payload.array[0]
-$.payload.array[*]
+- {name: $.payload.key1}
+- {name: "$.payload.array[0]"}
+- {name: "$.payload.array[*]"}
 ```
 
 EXAMPLE:
@@ -128,9 +128,33 @@ EXAMPLE:
 NOTE:
 
 * JSONPath syntax is not fully supported
-* Embulk's type: json cannot have timestamp column, so `type: timesatmp` for `add_columns` or `columns` with default is not available
-* `src` (to rename or copy columns) for `add_columns` or `columns` is only partially supported yet
-  * the json path directory must be same, for example, `{name: $.foo.copy, src: $foo.bar}` works, but `{name: $foo.copy, src: $.bar.baz}` does not work
+* `type: timesatmp` for `add_columns` or `columns` is not available because Embulk's `type: json` cannot have timestamp column
+
+NOTE:
+
+To deeply visit json path such as `$.payload.foo.bar`, you have to write its upper paths together like:
+
+```
+- (name: $.payload.foo}
+- {name: $.payload.foo.bar}
+```
+
+NOTE:
+
+`src` (to rename or copy columns) is only partially supported yet. The upper json path must be same like:
+
+```
+- {name: $.payload.foo}
+- {name: $.payload.foo.dest, src: $.payload.foo.src}
+```
+
+Below does not work yet.
+
+```
+- {name: $.payload.foo}
+- {name: $.payload.bar}
+- {name: $.payload.foo.dest, src: $.payload.bar.src}
+```
 
 ## ToDo
 

data/build.gradle

@@ -15,7 +15,7 @@ configurations {
     provided
 }
 
-version = "0.5.3"
+version = "0.5.4"
 sourceCompatibility = 1.7
 targetCompatibility = 1.7
 

data/src/main/java/org/embulk/filter/column/JsonColumn.java

@@ -47,6 +47,9 @@ public class JsonColumn
         this.pathValue = ValueFactory.newString(path);
         this.parentPath = parentPath(path);
         this.baseName = baseName(path);
+        if (this.baseName.equals("[*]")) {
+            throw new ConfigException(String.format("%s wrongly ends with [*], perhaps you can remove the [*]", path));
+        }
         this.baseIndex = baseIndex(path);
         this.parentPathValue = ValueFactory.newString(parentPath);
         this.baseNameValue = ValueFactory.newString(baseName);

data/src/test/java/org/embulk/filter/column/TestJsonVisitor.java

@@ -1,5 +1,6 @@
 package org.embulk.filter.column;
 
+import org.embulk.config.ConfigException;
 import org.embulk.EmbulkTestRuntime;
 import org.embulk.config.ConfigLoader;
 import org.embulk.config.ConfigSource;
@@ -55,6 +56,18 @@ public class TestJsonVisitor
         return new JsonVisitor(task, inputSchema, outputSchema);
     }
 
+    @Test(expected = ConfigException.class)
+    public void configException_Columns()
+    {
+        PluginTask task = taskFromYamlString(
+                "type: column",
+                "columns:",
+                "  - {name: \"$.json1.b.b[*]\"}");
+        Schema inputSchema = Schema.builder().build();
+        // b[*] should be written as b
+        jsonVisitor(task, inputSchema);
+    }
+
     @Test
     public void buildShouldVisitSet()
     {
@@ -311,7 +324,7 @@ public class TestJsonVisitor
                 "type: column",
                 "drop_columns:",
                 "  - {name: \"$.json1.k1[0].k1\"}",
-                "  - {name: \"$.json1.k2[*]\"}");
+                "  - {name: \"$.json1.k2[*]\"}"); // ending with [*] is allowed for drop_columns, but not for others
         Schema inputSchema = Schema.builder()
                 .add("json1", JSON)
                 .add("json2", JSON)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: embulk-filter-column
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.4
 platform: ruby
 authors:
 - Naotoshi Seo
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-06-21 00:00:00.000000000 Z
+date: 2016-08-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -71,7 +71,7 @@ files:
 - src/test/java/org/embulk/filter/column/TestColumnVisitorImpl.java
 - src/test/java/org/embulk/filter/column/TestJsonColumn.java
 - src/test/java/org/embulk/filter/column/TestJsonVisitor.java
-- classpath/embulk-filter-column-0.5.3.jar
+- classpath/embulk-filter-column-0.5.4.jar
 homepage: https://github.com/sonots/embulk-filter-column
 licenses:
 - MIT