ember-cli-rails 0.14.0 → 0.14.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f6524eb048b09d9e7144570bf4c65ede7e324ba40f2ee0631f8c07c9c221be98
-  data.tar.gz: a8687bff15afeaefc6261599be718e7d01833237790a9b25c156178f26d692bc
+  metadata.gz: 89fb2f98a617de8c232e28b044db803f37f5a0b94147bdff07ebf45be3338d7f
+  data.tar.gz: 572e612fcac29c7cb1f4d74a28b40e839a07906a4bdca14d03ba1ba4e44c9577
 SHA512:
-  metadata.gz: 9dfcb02b1ad578537c39c1b9758bdd40136bef8deca5470f3ddfa05541dc3bb2030b3f0788ca68b21bae92e2a0f96ccde2fc7392d0e7ef1ea87cd1142217cf7e
-  data.tar.gz: 58cfebef2e7e1614beea6a6f93099c98c9f9d0d21964ddd037924e2496aa5015f4f1e19e11fc489e0c4306393f23c693b9704f8837f981e34479dbbeaa69f6ac
+  metadata.gz: 631a8276c052830df276b0a53c4ccb46f2b80a6f71ef346002fe260222bc9f4852efc38ddab155c92af8a67e9efad2ab5c91124af2b34eb7cc942f418d097aeb
+  data.tar.gz: 1dbc29b10d0f912dd1f9d19419a00d6df87311d6d9e4d2b9448812848916ad53745e81900b7e538e894da77d58987ed7831a18d47da6b0f6476b8f87b4449af0

data/CHANGELOG.md

@@ -1,3 +1,30 @@
+0.14.1
+------
+
+* Build a Vite-based application with `vite build`, the command its own
+  `build` script runs, rather than with `ember build`. `ember build --help`
+  calls itself a "Vestigial command in Vite-based projects" and points at
+  that script. What the build writes is unchanged, and so is the classic
+  blueprint, which keeps building with `ember build`. The `silent` option
+  now quiets a Vite build with `--logLevel error`, which drops the progress
+  output and keeps the errors
+* Recognise an application as Vite-based from any of the six names Vite
+  resolves its configuration from, rather than only `vite.config.js`,
+  `vite.config.mjs` and `vite.config.ts`. An application configured in
+  `vite.config.mts`, `vite.config.cts` or `vite.config.cjs` was taken for a
+  classic one and served with `ember build --watch`, which a Vite-based
+  project rejects
+* Report the whole build failure of a classic application in the
+  `EmberCli::BuildError` message, instead of only its first line. Such an
+  application builds in the background, and `BuildMonitor` turns what
+  `ember build --watch` writes into the exception; the line naming the file
+  that failed to build is rarely the first one, so a parse error arrived
+  with its message and line number but no way to tell which file it came
+  from
+* Pass `--watcher` to `ember build` only when the build watches. The flag
+  names the backend that watches the file system, so it did nothing for a
+  one-off build
+
 0.14.0
 ------
 

data/README.md

@@ -77,7 +77,9 @@ c.app :frontend, path: "~/projects/my-ember-app"
 - `path` - the path where your Ember CLI application is located. The default
   value is the name of your app in the Rails root.
 
-- `silent` - this provides `--silent` option for Ember CLI commands to control verbosity of their output.
+- `silent` - quiets the build. A classic application is built with
+  `ember build --silent`; a Vite-based one with `vite build --logLevel error`,
+  which keeps errors while dropping the progress output.
 
 - `package_manager` - the package manager that installs the application's
   NodeJS dependencies: `:npm` (the default), `:yarn`, or `:pnpm`. Name the

data/lib/ember_cli/build_monitor.rb

@@ -41,6 +41,7 @@ module EmberCli
 
     def build_errors
       error_lines.
+        map(&:chomp).
         reject { |line| is_blank_or_backtrace?(line) }.
         reject { |line| is_deprecation_warning?(line) }.
         reject { |line| is_building_notice?(line) }
@@ -75,11 +76,11 @@ module EmberCli
     end
 
     def raise_build_error!
-      backtrace = build_errors.first
-      message = "#{name.inspect} has failed to build: #{backtrace}"
+      errors = build_errors
+      message = "#{name.inspect} has failed to build: #{errors.join("\n")}"
 
       error = BuildError.new(message)
-      error.set_backtrace(backtrace)
+      error.set_backtrace(errors)
 
       fail error
     end

data/lib/ember_cli/command.rb

@@ -14,7 +14,11 @@ module EmberCli
     end
 
     def build(watch: false)
-      ember_build(watch: watch)
+      if paths.vite?
+        vite_build
+      else
+        ember_build(watch: watch)
+      end
     end
 
     # Boots Vite's development server for an application generated with the
@@ -43,11 +47,53 @@ module EmberCli
       options.fetch(:silent) { false }
     end
 
+    def build_environment
+      if EmberCli.env == "production"
+        "production"
+      else
+        "development"
+      end
+    end
+
+    # The Vite-based blueprint (`ember-cli >= 6.8`)
+    #
+    # Builds the application the way its own `build` script does.
+    # `ember build` still drives such a build today, but `ember build --help`
+    # calls it a "Vestigial command in Vite-based projects" and has dropped
+    # every option but `--environment`, `--suppress-sizes` and
+    # `--output-path`.
+    #
+    # `--emptyOutDir` is needed because the output directory is outside the
+    # Ember application, where Vite leaves stale files in place unless asked
+    # to clear them.
+    def vite_build
+      line = Terrapin::CommandLine.new(paths.vite, [
+        "build",
+        "--mode :mode",
+        "--outDir :output_path",
+        "--emptyOutDir",
+        ("--logLevel error" if silent?),
+      ].compact.join(" "))
+
+      line.command(
+        mode: build_environment,
+        output_path: paths.dist,
+      )
+    end
+
+    # The classic blueprint
+    #
+    # Builds the application with `ember build`, which watches for changes
+    # when asked. A Vite-based project has no equivalent: `ember build` there
+    # refuses `--watch`, and its development server watches instead.
+    #
+    # `--watcher` names the backend that watches, so it rides along only
+    # when the build watches.
     def ember_build(watch: false)
       line = Terrapin::CommandLine.new(paths.ember, [
         "build",
         ("--watch" if watch),
-        ("--watcher :watcher" if process_watcher),
+        ("--watcher :watcher" if watch && process_watcher),
         ("--silent" if silent?),
         "--environment :environment",
         "--output-path :output_path",
@@ -59,13 +105,5 @@ module EmberCli
         watcher: process_watcher,
       )
     end
-
-    def build_environment
-      if EmberCli.env == "production"
-        "production"
-      else
-        "development"
-      end
-    end
   end
 end

data/lib/ember_cli/path_set.rb

@@ -4,6 +4,17 @@ module EmberCli
   class PathSet
     PACKAGE_MANAGERS = %i[npm yarn pnpm].freeze
 
+    # Every name Vite resolves its configuration file from. An application
+    # that keeps its configuration under any of them is Vite-based.
+    VITE_CONFIG_FILES = %w[
+      vite.config.js
+      vite.config.mjs
+      vite.config.cjs
+      vite.config.ts
+      vite.config.mts
+      vite.config.cts
+    ].freeze
+
     # npm ships with NodeJS, so it has no installation instructions of its own
     # to point at when its executable is missing.
     INSTALL_INSTRUCTIONS = {
@@ -55,8 +66,7 @@ module EmberCli
     # Apps generated with the Vite-based blueprint (`ember-cli >= 6.8`)
     # ship a Vite config file at their root.
     def vite?
-      %w[vite.config.mjs vite.config.js vite.config.ts].
-        any? { |config| root.join(config).exist? }
+      VITE_CONFIG_FILES.any? { |config| root.join(config).exist? }
     end
 
     def ember

data/lib/ember_cli/version.rb

@@ -1,3 +1,3 @@
 module EmberCli
-  VERSION = "0.14.0".freeze
+  VERSION = "0.14.1".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ember-cli-rails
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.14.1
 platform: ruby
 authors:
 - Pavel Pravosud