emailist 0.0.11 → 0.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ea1f09f66e64ad8005b9d4e80a07eaa83abdfac4
-  data.tar.gz: 2c2f3d54c20853665a717038512e5813de2f1815
+  metadata.gz: 5b41ead369300322d3a618548b730b1e54500bb8
+  data.tar.gz: 1a8e709aa20fdd8f3dfccd02cec1150665251661
 SHA512:
-  metadata.gz: 2f0808c9a72e5575db6dc6fe02c6984308e44c737f9ab3b79b88251b31aa5546e4b2103906a5481314b85d6fa9728b4dfbb8ff096abbdc32a3c0b7ab1c59b3f1
-  data.tar.gz: b57d4132097165d97a5f658a53aec0c33638df8e410e169e54da0d7024204be28e8f5579e6f49d67acde76814ee5b219110f01be4f2c60e6445d0b7b8999631d
+  metadata.gz: 576e5cf4f9814273e94be3441a064eb7f07117c1ef2c98bb11a93f54a28c826efbd4c5577e171dfb2430510a9d72e40743d998482dbea57d5a30b6a74a8191b1
+  data.tar.gz: 97d3312b05ce5fb86e2d74e69c483f6eded698fa7ede435d8a0a9300c467ec3d6834d3754215a872a62d6424a87f23c8ece627a05462ba6524254548753b2e3a

data/README.md

@@ -50,16 +50,22 @@ Invalid emails are attempted to be cleaned:
 		emails.add('fred.smith@example.com.')
 		=> ['fred.smith@example.com']
 
-Finally, invalid TLDs raise `Emailist::InvalidTLD`:
+Invalid TLDs (after cleaning) raise `Emailist::InvalidTLD`:
 
 		emails = Emailist.new
 		emails.add('bob.jones@fooo.baar')
 		=> # raises Emailist::InvalidTLD
 
+Finally, if you want to verify hosts (example.com in bob.jones@example.com), do:
+
+		emails = Emailist.new(verify_hosts: true)
+		emails.add('bob.jones@af983h98hsdf98hgiau3hnvgbjiobj8.com')
+		=> # raises Emailist::HostDead
+
 ## Ideas For Improvement
 
 1. Some kind of "best-guess" algorithm that can take invalid TLDs and find the most likely intended TLD (e.g. I'm getting some emails from my parser that have an 'E', like 'bob.jones@blah.comE' -- this clearly is supposed to be '.com'). Perhaps Levenshtein distance could be useful for this.
-2. Ping email domains and raise an error when they're unresponsive. Not sure if this is a good idea, though. Might have some negative side effects that I'm not considering.
+2. Fix `possible_email` gem -- Rapportive still has an API but they've modified it, so the code for the gem doesn't work. This will require reverse-engineering the API, as they don't offer access publicly. Not sure if it's even possible, but worth a try.
 
 ## Contributing
 

data/emailist.gemspec

@@ -27,5 +27,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "shoulda-matchers"
 
+  spec.add_runtime_dependency "net-ping"
   spec.add_runtime_dependency "possible_email"
 end

data/lib/emailist/errors.rb

@@ -1,5 +1,6 @@
 class Emailist < Array
 	class InvalidTLD < StandardError; end
 	class InvalidEmailFormat < StandardError; end
-	class CantVerifyProfile < StandardError; end
+	class HostDead < StandardError; end
+	class ProfileNotFound < StandardError; end
 end

data/lib/emailist/version.rb

@@ -1,3 +1,3 @@
 class Emailist < Array
-  VERSION = "0.0.11"
+  VERSION = "0.0.12"
 end

data/lib/emailist.rb

@@ -1,3 +1,4 @@
+require "net/ping"
 require "possible_email"
 
 require "emailist/version"
@@ -18,7 +19,8 @@ class Emailist < Array
 	]
 
 
-	def initialize(verify_profiles: false)
+	def initialize(verify_hosts: false, verify_profiles: false)
+		@verify_hosts = verify_hosts
 		@verify_profiles = verify_profiles
 	end
 
@@ -127,21 +129,12 @@ class Emailist < Array
 
 		email = "#{local}@#{domain}".downcase
 
-# HAVE TO TRY AND REVERSE ENGINEER RAPPORTIVE/LINKEDIN API
-# FOR POSSIBLE_EMAIL GEM TO WORK. THIS FUNCTIONALITY REQUIRES
-# THAT API, WHICH APPARENTLY HAS BEEN SHUT DOWN FOR THE PUBLIC.
-=begin
-		if @verify_profiles
-			begin
-				response = [PossibleEmail.find_profile(email)].flatten
-				if response.empty?
-					raise Emailist::CantVerifyProfile
-				end
-			rescue PossibleEmail::InvalidEmailFormat
-				raise Emailist::InvalidEmailFormat
-			end
+		#if @verify_profiles
+		#	 raise Emailist::ProfileNotFound if !profile_found?(email)
+		#end
+		if @verify_hosts
+			raise Emailist::HostDead if !host_alive?(email)
 		end
-=end
 
 		email
 	end
@@ -153,5 +146,53 @@ private
 		uniq!
 		return self
 	end
+
+	def host_alive?(email)
+		domain = email.split('@').last
+
+		result = if live_hosts.include?(domain)
+			true
+		elsif dead_hosts.include?(domain)
+			false
+		else
+	    Net::Ping::External.new(domain).ping?
+	  end
+
+	  if result
+	  	live_hosts.push(domain)
+	  	live_hosts.uniq!
+	  else
+	  	dead_hosts.push(domain)
+	  	dead_hosts.uniq!
+	  end
+
+	  result
+	end
+
+	def live_hosts
+		@live_hosts ||= []
+	end
+
+	def dead_hosts
+		@dead_hosts ||= []
+	end
+
+	def profile_found?(email)
+		# HAVE TO TRY AND REVERSE ENGINEER RAPPORTIVE/LINKEDIN API
+		# FOR POSSIBLE_EMAIL GEM TO WORK. THIS FUNCTIONALITY REQUIRES
+		# THAT API, WHICH APPARENTLY HAS BEEN SHUT DOWN FOR THE PUBLIC.
+=begin
+				if @verify_profiles
+					begin
+						response = [PossibleEmail.find_profile(email)].flatten
+						if response.empty?
+							raise Emailist::CantVerifyProfile
+						end
+					rescue PossibleEmail::InvalidEmailFormat
+						raise Emailist::InvalidEmailFormat
+					end
+				end
+=end		
+	end
   
 end

data/spec/emailist_spec.rb

@@ -73,18 +73,26 @@ describe "Emailist" do
 		end
 	end
 
-	context "raises errors" do
+	describe "raises errors" do
 		it "when an email contains no valid TLD" do
 			expect { @email_list.add('bob.jones@yahoo.gloopoopoop') }.to raise_error Emailist::InvalidTLD
 		end
 
-		#it "when an email is in an invalid format (for possible_email)" do
-		#	@email_list = Emailist.new(verify_profiles: true)
-		#	expect { @email_list._push('bob.jones@gloopoopoop') }.to raise_error Emailist::InvalidEmailFormat
-		#end
+		it "when an email's host is dead (with verify_hosts turned on)" do
+			@email_list = Emailist.new(verify_hosts: true)
+			expect { @email_list.add('bob.jones@gloopoop.poop.ad9f8u4nfaj0.com') }.to raise_error Emailist::HostDead
+		end
+	end
 
-		#it "when a profile can't be verified" do
-		#end
+	describe "does not raise errors" do
+		it "when an email contains a valid TLD" do
+			expect { @email_list.add('bob.jones@yahoo.com') }.to_not raise_error
+		end
+
+		it "when an email's host is up (with verify_hosts turned on)" do
+			@email_list = Emailist.new(verify_hosts: true)
+			expect { @email_list.add('bob.jones@yahoo.com') }.to_not raise_error
+		end
 	end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: emailist
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
 platform: ruby
 authors:
 - Ethan Barron
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: net-ping
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: possible_email
   requirement: !ruby/object:Gem::Requirement