email_reply_parser 0.2.0 → 0.3.0

data/README.md

@@ -7,7 +7,16 @@ This is what GitHub uses to display comments that were created from
 email replies.  This code is being open sourced in an effort to
 crowdsource the quality of our email representation.
 
-See more at http://help.github.com/code/email_reply_parser/
+See more at the [Rocco docs][rocco].
+
+[rocco]: http://help.github.com/code/email_reply_parser/
+
+## Problem?
+
+If you have a question about the behavior and formatting of email replies on GitHub, check out [support][support].  If you have a specific issue regarding this library, then hit up the [Issues][issues].
+
+[support]: http://support.github.com/
+[issues]: https://github.com/github/email_reply_parser/issues
 
 ## Installation
 

data/email_reply_parser.gemspec

@@ -13,8 +13,8 @@ Gem::Specification.new do |s|
   ## If your rubyforge_project name is different, then edit it and comment out
   ## the sub! line in the Rakefile
   s.name              = 'email_reply_parser'
-  s.version           = '0.2.0'
-  s.date              = '2011-03-17'
+  s.version           = '0.3.0'
+  s.date              = '2011-08-23'
   s.rubyforge_project = 'email_reply_parser'
 
   ## Make sure your summary is short. The description may be as long
@@ -68,6 +68,7 @@ Gem::Specification.new do |s|
     test/emails/email_1_1.txt
     test/emails/email_1_2.txt
     test/emails/email_1_3.txt
+    test/emails/email_1_4.txt
   ]
   # = MANIFEST =
 

data/lib/email_reply_parser.rb

@@ -30,7 +30,7 @@ require 'strscan'
 #
 # [mail]: https://github.com/mikel/mail
 class EmailReplyParser
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 
   # Splits an email body into a list of Fragments.
   #
@@ -74,7 +74,7 @@ class EmailReplyParser
       @fragment = nil
 
       # Use the StringScanner to pull out each line of the email content.
-      @scanner  = StringScanner.new(text)
+      @scanner = StringScanner.new(text)
       while line = @scanner.scan_until(/\n/)
         scan_line(line)
       end
@@ -113,7 +113,7 @@ class EmailReplyParser
 
       # We're looking for leading `>`'s to see if this line is part of a
       # quoted Fragment.
-      line_levels = line =~ /(>+)$/ ? $1.size : 0
+      is_quoted = !!(line =~ /(>+)$/)
 
       # Mark the current Fragment as a signature if the current line is empty
       # and the Fragment starts with a common signature indicator.
@@ -128,14 +128,14 @@ class EmailReplyParser
       # reply header also counts as part of the quoted Fragment, even though
       # it doesn't start with `>`.
       if @fragment &&
-          ((@fragment.quoted? != line_levels.zero?) ||
-           (@fragment.quoted? && quote_header?(line)))
+          ((@fragment.quoted? == is_quoted) ||
+           (@fragment.quoted? && (quote_header?(line) || line == EMPTY)))
         @fragment.lines << line
 
       # Otherwise, finish the fragment and start a new one.
       else
         finish_fragment
-        @fragment = Fragment.new(!line_levels.zero?, line)
+        @fragment = Fragment.new(is_quoted, line)
       end
     end
 

data/test/email_reply_parser_test.rb

@@ -63,6 +63,14 @@ I am currently using the Java HTTP API.\n", reply.fragments[0].to_s
     assert_match /^_/, reply.fragments[5].to_s
   end
 
+  def test_recognizes_date_string_above_quote
+    reply = email :email_1_4
+
+    assert_match /^Awesome/, reply.fragments[0].to_s
+    assert_match /^On/,      reply.fragments[1].to_s
+    assert_match /Loader/,   reply.fragments[1].to_s
+  end
+
   def email(name)
     body = IO.read EMAIL_FIXTURE_PATH.join("#{name}.txt").to_s
     EmailReplyParser.read body

data/test/emails/email_1_4.txt

@@ -0,0 +1,5 @@
+Awesome! I haven't had another problem with it.
+
+On Aug 22, 2011, at 7:37 PM, defunkt<reply@reply.github.com> wrote:
+
+> Loader seems to be working well.

metadata

@@ -1,13 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: email_reply_parser
 version: !ruby/object:Gem::Version 
-  hash: 23
   prerelease: false
   segments: 
   - 0
-  - 2
+  - 3
   - 0
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors: 
 - Rick Olson
@@ -15,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-17 00:00:00 -07:00
+date: 2011-08-23 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -38,6 +37,7 @@ files:
 - test/emails/email_1_1.txt
 - test/emails/email_1_2.txt
 - test/emails/email_1_3.txt
+- test/emails/email_1_4.txt
 has_rdoc: true
 homepage: http://github.com/github/email_reply_parser
 licenses: []
@@ -48,27 +48,23 @@ rdoc_options:
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
       segments: 
       - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: email_reply_parser
-rubygems_version: 1.3.7
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 2
 summary: Short description used in Gem listings.