em-ssh 0.4.2 → 0.4.3

data/lib/em-ssh/ext/net/ssh/connection/channel.rb

@@ -0,0 +1,24 @@
+module Net; module SSH; module Connection
+  # Moneky patching is the root of all evil.
+  #
+  # Net:SSH::Connection::Channel doesn't expect its #connection to every be
+  # nil. EM::Ssh unsets the Channels @connection to facilitate garbage
+  # collection when the session is closed. Anything that maintains a reference
+  # to a Channel could still call Channel#wait, Channel#active?, so we need a
+  # guard in those methods.
+  #
+  # TODO be a good citizen. Verify that the possible memory leak in
+  # EM::Ssh::Session is also possible in Net::SSHi::Connection and submit a
+  # pull request with fixes.
+  class Channel
+    def active?
+      return unless connection
+      connection.channels.key?(local_id)
+    end
+
+    def wait
+      return unless connection
+      connection.loop { active? }
+    end
+  end
+end; end; end

data/lib/em-ssh/version.rb

@@ -1,5 +1,5 @@
 module EventMachine
   class Ssh
-    VERSION='0.4.2'
+    VERSION='0.4.3'
   end # class::Ssh
 end # module::EventMachine

data/lib/em-ssh.rb

@@ -81,3 +81,5 @@ require 'em-ssh/server-version'
 require 'em-ssh/packet-stream'
 require 'em-ssh/authentication-session'
 require 'em-ssh/session'
+# load our evil monkey patch
+require 'em-ssh/ext/net/ssh/connection/channel'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: em-ssh
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-04 00:00:00.000000000 Z
+date: 2012-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eventmachine
@@ -87,6 +87,7 @@ files:
 - lib/em-ssh/authentication-session.rb
 - lib/em-ssh/callbacks.rb
 - lib/em-ssh/connection.rb
+- lib/em-ssh/ext/net/ssh/connection/channel.rb
 - lib/em-ssh/log.rb
 - lib/em-ssh/packet-stream.rb
 - lib/em-ssh/server-version.rb