em-pg-client-helper 0.1.0 → 0.1.1

data/lib/em-pg-client-helper.rb

@@ -46,6 +46,19 @@ module PG::EM::Client::Helper
 
 	# Execute code in a transaction.
 	#
+	# Calling this method opens up a transaction (by executing `BEGIN`), and
+	# then runs the supplied block, passing in a transaction object which you
+	# can use to execute SQL commands.  When the block completes, a `COMMIT`
+	# will automatically be executed, unless you have manually called
+	# `txn.commit` or `txn.rollback`.  Since `db_transaction` returns a
+	# deferrable, you should use `#callback` to specify what to run after the
+	# transaction completes.
+	#
+	# If an SQL error occurs during the transaction, the block's execution
+	# will be aborted, a `ROLLBACK` will be executed, and the `#errback`
+	# block (if defined) on the deferrable will be executed (rather than the
+	# `#callback` block).
+	#
 	# Arguments:
 	#
 	#  * `db` -- A PG::EM::Client or PG::EM::ConnectionPool instance, against
@@ -79,7 +92,7 @@ module PG::EM::Client::Helper
 	# decided to put in their names.
 	#
 	def quote_identifier(id)
-		'"' + id.gsub(/"/, '""') + '"'
+		"\"#{id.gsub(/"/, '""')}\""
 	end
 
 	class Transaction
@@ -140,6 +153,11 @@ module PG::EM::Client::Helper
 		# successfully.
 		#
 		def exec(sql, values=[], &blk)
+			unless @active
+				raise RuntimeError,
+				      "Cannot execute a query in a transaction that has been closed"
+			end
+
 			df = @conn.exec_defer(sql, values).
 			       errback { |ex| rollback(ex) }
 			df.callback(&blk) if blk

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: em-pg-client-helper
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-20 00:00:00.000000000 Z
+date: 2014-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: git-version-bump
@@ -236,7 +236,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3158041732847442492
+      hash: -2023776752281468626
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -245,7 +245,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3158041732847442492
+      hash: -2023776752281468626
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23