elmas 2.3.3 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 71737a3f3e2f0e9d90a1f1816f7e5f54344927aa
-  data.tar.gz: 87a2626e71be182b8e9dcd3298d9cde389575a5f
+  metadata.gz: 9a9ed5ba705a72bd6891dcf22693b1266785c87a
+  data.tar.gz: 9e096590a3fbcf310c117c0ca80b66564c924d99
 SHA512:
-  metadata.gz: b28dcd6d710c644d20de49836a15bfa4254ef588da710ee9654711daa3abbb9ebbbe0a6b0a124377b33a5a911df4fd951db1fe5ce709d32fe431cbdf287d5978
-  data.tar.gz: e003e7bcad6733aa1575e8a9952b00ff585a3e33baa82a3606065ff095fccdc87a40acf1ce899d3930159e254ac3bc1e59c7fa902091c4ceb74e0a956e74fa8e
+  metadata.gz: dd2449651468db6b7dcadc2b32a478903055c7f4f43e4cc9c0ed78803cc2e9a5bb0ac37682f0f920c583fd3864f8a2a6e92f2ce77b6e8ad1f89c3b6f0afdcdca
+  data.tar.gz: 23773f8506826a87f8ff24b4b2570ee0653e0c441d15fac620597314331408b4446caac447b50829d7144af8f086f9b871e3c4696e609c1f343fbc2870ebceeb

data/Changelog.md

@@ -1,3 +1,10 @@
+## 2.4.0
+
+- Add security measures for constantizing Exact Resources thanks to @confiks
+- Add possibility to filter on Date or Time. Added test for BankEntry. thanks to @confiks
+- Custom exception shouldn't inherit Exception. Use StandardError instead. thanks to @confiks
+- Let go of unecessary dev dependency versions
+
 ## 2.3.3
 
 - Add bank accounts resource

data/elmas.gemspec

@@ -17,20 +17,20 @@ Gem::Specification.new do |spec|
   spec.version       = Elmas::Version.to_s
 
   spec.add_dependency "faraday", [">= 0.8", "< 0.10"]
-  spec.add_dependency "mechanize", "2.6.0"
+  spec.add_dependency "mechanize", ">= 2.6.0"
   spec.add_dependency "activesupport"
 
   spec.add_development_dependency "bundler"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency("rspec", "~> 3.0")
-  spec.add_development_dependency("simplecov")
-  spec.add_development_dependency("simplecov-rcov")
-  spec.add_development_dependency("webmock", "~> 1.6")
-  spec.add_development_dependency("rubycritic", "~> 1.4.0")
-  spec.add_development_dependency("guard-rspec")
-  spec.add_development_dependency("guard-rubocop")
-  spec.add_development_dependency("listen", "~> 3.0")
-  spec.add_development_dependency("ruby_dep", "~> 1.3")
-  spec.add_development_dependency("mutant-rspec")
-  spec.add_development_dependency("dotenv")
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "simplecov-rcov"
+  spec.add_development_dependency "webmock"
+  spec.add_development_dependency "rubycritic"
+  spec.add_development_dependency "guard-rspec"
+  spec.add_development_dependency "guard-rubocop"
+  spec.add_development_dependency "listen"
+  spec.add_development_dependency "ruby_dep"
+  spec.add_development_dependency "mutant-rspec"
+  spec.add_development_dependency "dotenv"
 end

data/lib/elmas/exception.rb

@@ -1,5 +1,5 @@
 module Elmas
-  class BadRequestException < Exception
+  class BadRequestException < StandardError
     def initialize(response, parsed)
       @response = response
       @parsed = parsed
@@ -11,5 +11,5 @@ module Elmas
     end
   end
 
-  class UnauthorizedException < Exception; end
+  class UnauthorizedException < StandardError; end
 end

data/lib/elmas/oauth.rb

@@ -48,14 +48,14 @@ module Elmas
       options[:response_type] ||= "code"
       options[:redirect_uri] ||= redirect_uri
       params = authorization_params.merge(options)
-      uri = URI("https://start.exactonline.nl/api/oauth2/auth/")
+      uri = URI("#{base_url}/api/oauth2/auth/")
       uri.query = URI.encode_www_form(params)
       uri.to_s
     end
 
     # Return an access token from authorization
     def get_access_token(code, _options = {})
-      conn = Faraday.new(url: "https://start.exactonline.nl") do |faraday|
+      conn = Faraday.new(url: base_url) do |faraday|
         faraday.request :url_encoded
         faraday.adapter Faraday.default_adapter
       end

data/lib/elmas/resources/sales_entry.rb

@@ -9,12 +9,12 @@ module Elmas
     end
 
     def mandatory_attributes
-      [:journal, :contact, :sales_entry_lines]
+      [:journal, :customer, :sales_entry_lines]
     end
 
     def other_attributes
       [
-        :batch_number, :currency, :customer, :document, :due_date, :entry_date,
+        :batch_number, :currency, :document, :due_date, :entry_date,
         :entry_number, :invoice_number, :order_number, :payment_condition,
         :payment_reference, :process_number, :rate, :reporting_period,
         :reporting_year, :reversal, :VAT_amount_FC, :your_ref, :description

data/lib/elmas/result_set.rb

@@ -44,8 +44,13 @@ module Elmas
 
     def resource_class
       @resource_class ||= begin
-        constant_name = Utils.modulize(type)
-        Object.const_get(constant_name)
+        constant_name = type.classify
+        fail NameError unless constant_name =~ /\A[a-zA-Z0-9]+\z/
+
+        klass = Elmas.const_get(constant_name, false)
+        fail NameError unless klass.included_modules.include?(Elmas::Resource)
+
+        klass
       rescue NameError
         Elmas.info("Unknown resource encountered, proceed as usual but further resource details might have to be implemented")
         Class.new { include Elmas::Resource }

data/lib/elmas/uri.rb

@@ -46,12 +46,17 @@ module Elmas
 
       # Convert a value to something usable in an ExactOnline request
       def sanitize_value(value)
-        if value.is_a?(String)
+        case value
+        when String
           if value =~ /[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}/
             "guid'#{value}'"
           else
             "'#{value}'"
           end
+
+        when Date, Time
+          "datetime'#{value.strftime('%FT%TZ')}'"
+
         else
           value
         end

data/lib/elmas/version.rb

@@ -1,8 +1,8 @@
 module Elmas
   class Version
     MAJOR = 2
-    MINOR = 3
-    PATCH = 3
+    MINOR = 4
+    PATCH = 0
 
     class << self
       def to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: elmas
 version: !ruby/object:Gem::Version
-  version: 2.3.3
+  version: 2.4.0
 platform: ruby
 authors:
 - Marthyn
@@ -34,14 +34,14 @@ dependencies:
   name: mechanize
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.6.0
 - !ruby/object:Gem::Dependency
@@ -76,30 +76,30 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -132,30 +132,30 @@ dependencies:
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubycritic
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -188,30 +188,30 @@ dependencies:
   name: listen
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: ruby_dep
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mutant-rspec
   requirement: !ruby/object:Gem::Requirement