eligo-rails 0.0.3 → 0.0.4

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    eligo (0.0.1)
+    eligo-rails (0.0.3)
       jquery-rails (~> 1.0)
       railties (~> 3.1.0)
 
@@ -79,6 +79,6 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  eligo!
+  eligo-rails!
   jasmine-headless-webkit (~> 0.8.4)
   jasmine-spec-extras (~> 0.0.2)

data/README.md

@@ -0,0 +1 @@
+[![Build Status](https://secure.travis-ci.org/lmarburger/eligo-rails.png)](http://travis-ci.org/lmarburger/eligo-rails)

data/Rakefile

@@ -45,15 +45,17 @@ end
 
 
 begin
-  require 'jasmine'
-  load 'jasmine/tasks/jasmine.rake'
+  require 'jasmine-headless-webkit'
+  Jasmine::Headless::Task.new
 rescue LoadError
-  task :jasmine do
-    abort "Jasmine is not available. In order to run jasmine, you must: (sudo) gem install jasmine"
+  task :jasmine-headless do
+    abort "jasmine-headless-webkit is not available. In order to run, you must: (sudo) gem install jasmine-headless-webkit"
   end
 end
 
-task :default => :jasmine
+task :default => 'jasmine:headless'
+
+
 
 #############################################################################
 #

data/eligo-rails.gemspec

@@ -13,8 +13,8 @@ Gem::Specification.new do |s|
   ## If your rubyforge_project name is different, then edit it and comment out
   ## the sub! line in the Rakefile
   s.name              = 'eligo-rails'
-  s.version           = '0.0.3'
-  s.date              = '2012-01-05'
+  s.version           = '0.0.4'
+  s.date              = '2012-01-07'
 
   ## Make sure your summary is short. The description may be as long
   ## as you like.
@@ -54,6 +54,7 @@ Gem::Specification.new do |s|
   s.files = %w[
     Gemfile
     Gemfile.lock
+    README.md
     Rakefile
     eligo-rails.gemspec
     lib/eligo-rails.rb

data/lib/eligo-rails.rb

@@ -1,6 +1,6 @@
 module Eligo
   module Rails
-    VERSION = '0.0.3'
+    VERSION = '0.0.4'
 
     class Engine < ::Rails::Engine
     end

data/spec/javascripts/shift_clickable_spec.coffee

@@ -19,7 +19,10 @@ describe 'shiftClickable()', ->
     third   = createCheckbox()
     list.shiftClickable()
 
-  shiftClickEvent = -> jQuery.Event 'click', shiftKey: true
+  shiftEvent = (event) ->
+    event or= 'click'
+    jQuery.Event event, shiftKey: true
+
   createCheckbox  = ->
     $('<input type="checkbox">')
       .attr('id', checkID++)
@@ -41,7 +44,7 @@ describe 'shiftClickable()', ->
 
   it 'checks checkboxes between last and shift-clicked checkboxes', ->
     first.trigger 'click'
-    third.trigger shiftClickEvent()
+    third.trigger shiftEvent()
 
     deferExpect ->
       expect(first) .toBeChecked()
@@ -56,7 +59,7 @@ describe 'shiftClickable()', ->
 
   it 'checks checkboxes when shift-clicking parent list item', ->
     first.trigger 'click'
-    third.closest('li').trigger shiftClickEvent()
+    third.closest('li').trigger shiftEvent()
 
     deferExpect ->
       expect(first) .toBeChecked()
@@ -66,7 +69,7 @@ describe 'shiftClickable()', ->
   it 'triggers the change event on checkboxes', ->
     first.trigger 'click'
     spyOnEvent second, 'change'
-    third.trigger shiftClickEvent()
+    third.trigger shiftEvent()
 
     deferExpect ->
       expect('change').toHaveBeenTriggeredOn(first)
@@ -75,7 +78,7 @@ describe 'shiftClickable()', ->
 
   it 'checks checkboxes below the shift-clicked checkbox', ->
     third.trigger 'click'
-    first.trigger shiftClickEvent()
+    first.trigger shiftEvent()
 
     deferExpect ->
       expect(first) .toBeChecked()
@@ -83,7 +86,7 @@ describe 'shiftClickable()', ->
       expect(third) .toBeChecked()
 
   it 'sets a default anchor', ->
-    second.trigger shiftClickEvent()
+    second.trigger shiftEvent()
 
     deferExpect ->
       expect(first) .toBeChecked()
@@ -91,7 +94,7 @@ describe 'shiftClickable()', ->
 
   it 'does not check checkboxes above the selected group', ->
     second.trigger 'click'
-    third .trigger shiftClickEvent()
+    third .trigger shiftEvent()
 
     deferExpect ->
       expect(second).toBeChecked()
@@ -100,7 +103,7 @@ describe 'shiftClickable()', ->
 
   it 'does not check checkboxes below the selected group', ->
     first .trigger 'click'
-    second.trigger shiftClickEvent()
+    second.trigger shiftEvent()
 
     deferExpect ->
       expect(first) .toBeChecked()
@@ -110,7 +113,7 @@ describe 'shiftClickable()', ->
   it 'unchecks checkboxes between last and shift-clicked checkboxes', ->
     group = [ third, second, first ]
     checkbox.trigger 'click' for checkbox in group
-    third.trigger shiftClickEvent()
+    third.trigger shiftEvent()
 
     deferExpect ->
       expect(first) .not.toBeChecked()
@@ -120,7 +123,7 @@ describe 'shiftClickable()', ->
   it 'handles shift-clicks on appended checkboxes', ->
     late = createCheckbox()
     second.trigger 'click'
-    late  .trigger shiftClickEvent()
+    late  .trigger shiftEvent()
 
     deferExpect ->
       expect(second).toBeChecked()
@@ -131,7 +134,7 @@ describe 'shiftClickable()', ->
     firstLate  = createCheckbox()
     secondLate = createCheckbox()
     second    .trigger 'click'
-    secondLate.trigger shiftClickEvent()
+    secondLate.trigger shiftEvent()
 
     deferExpect ->
       expect(second)    .toBeChecked()
@@ -148,10 +151,33 @@ describe 'shiftClickable()', ->
       firstLate.add(secondLate).closest('li')
         .insertBefore(second.closest('li'))
 
-      first.trigger shiftClickEvent()
+      first.trigger shiftEvent()
 
     deferExpect ->
       expect(first)     .toBeChecked()
       expect(firstLate) .toBeChecked()
       expect(secondLate).toBeChecked()
       expect(second)    .toBeChecked()
+
+
+  describe 'text selection', ->
+    emptyMock = removeMock = null
+
+    beforeEach ->
+      selectionStub = sinon.stub()
+      emptyMock  = selectionStub.empty           = sinon.mock()
+      removeMock = selectionStub.removeAllRanges = sinon.mock()
+      sinon.stub(window, 'getSelection').returns(selectionStub)
+
+    afterEach ->
+      window.getSelection.restore()
+      emptyMock .verify()
+      removeMock.verify()
+
+    it 'prevents selecting text when shift-clicking a list item', ->
+      first.trigger shiftEvent 'mousedown'
+
+    it 'does nothing when clicking an item', ->
+      emptyMock .never()
+      removeMock.never()
+      first.trigger 'mousedown'

data/vendor/assets/javascripts/shift_clickable.coffee

@@ -19,19 +19,25 @@ $.fn.shiftClickable = ->
       .prop('checked', checked)
       .change()
 
-  list.click (e) ->
-    clicked = $ e.target
-    if clicked.is 'li'
-      clicked.find(checkboxSelector)
-        .trigger $.Event('click', shiftKey: e.shiftKey)
-    else
-      clicked = clicked.closest 'li'
+  list
+    .mousedown (e) ->
+      return unless e.shiftKey
+      window.getSelection?().empty?()
+      window.getSelection?().removeAllRanges?()
 
-    # It seems WebKit triggers `change` before `click`, but I'm not too
-    # confident that all browsers must trigger events in exactly the same way.
-    # Defer setting the value to be sure the checkbox has its new value.
-    window.setTimeout(
-      ->
-        shiftClick clicked if e.shiftKey
-        anchor = clicked
-      1)
+    .click (e) ->
+      clicked = $ e.target
+      if clicked.is 'li'
+        clicked.find(checkboxSelector)
+          .trigger $.Event('click', shiftKey: e.shiftKey)
+      else
+        clicked = clicked.closest 'li'
+
+      # It seems WebKit triggers `change` before `click`, but I'm not too
+      # confident that all browsers must trigger events in exactly the same way.
+      # Defer setting the value to be sure the checkbox has its new value.
+      window.setTimeout(
+        ->
+          shiftClick clicked if e.shiftKey
+          anchor = clicked
+        1)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eligo-rails
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-01-05 00:00:00.000000000 Z
+date: 2012-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
-  requirement: &70188917783640 !ruby/object:Gem::Requirement
+  requirement: &70104276728640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 3.1.0
   type: :runtime
   prerelease: false
-  version_requirements: *70188917783640
+  version_requirements: *70104276728640
 - !ruby/object:Gem::Dependency
   name: jquery-rails
-  requirement: &70188917782640 !ruby/object:Gem::Requirement
+  requirement: &70104276727560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: '1.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70188917782640
+  version_requirements: *70104276727560
 - !ruby/object:Gem::Dependency
   name: jasmine-headless-webkit
-  requirement: &70188917781460 !ruby/object:Gem::Requirement
+  requirement: &70104276726580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 0.8.4
   type: :development
   prerelease: false
-  version_requirements: *70188917781460
+  version_requirements: *70104276726580
 - !ruby/object:Gem::Dependency
   name: jasmine-spec-extras
-  requirement: &70188917780220 !ruby/object:Gem::Requirement
+  requirement: &70104276725280 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,7 +54,7 @@ dependencies:
         version: 0.0.2
   type: :development
   prerelease: false
-  version_requirements: *70188917780220
+  version_requirements: *70104276725280
 description: Add shift-click selection to a list of checkboxes.
 email: larry@marburger.cc
 executables: []
@@ -63,6 +63,7 @@ extra_rdoc_files: []
 files:
 - Gemfile
 - Gemfile.lock
+- README.md
 - Rakefile
 - eligo-rails.gemspec
 - lib/eligo-rails.rb