elibri_onix 0.2.12 → 0.2.13

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    elibri_onix (0.2.12)
+    elibri_onix (0.2.13)
       activesupport (>= 2.3.5)
       elibri_onix_dict (>= 0.0.5)
       i18n
@@ -15,7 +15,7 @@ GEM
       multi_json (~> 1.0)
     coderay (1.0.6)
     elibri_onix_dict (0.0.22)
-    i18n (0.6.4)
+    i18n (0.6.5)
     json (1.7.6)
     json (1.7.6-java)
     metaclass (0.0.1)
@@ -24,7 +24,7 @@ GEM
     minitest (3.0.1)
     mocha (0.11.4)
       metaclass (~> 0.0.1)
-    multi_json (1.7.7)
+    multi_json (1.8.2)
     nokogiri (1.6.0)
       mini_portile (~> 0.5.0)
     pry (0.9.9.6)

data/lib/elibri_onix/external_id.rb

@@ -13,7 +13,11 @@ module ExternalId
   end
 
   def eid
-    @id_before_type_cast.split(":")[1].to_i
+    begin
+      @id_before_type_cast.split(":")[1].to_i
+    rescue
+      nil
+    end
   end
   
   def id

data/lib/elibri_onix/version.rb

@@ -2,7 +2,7 @@ module Elibri
   module ONIX
     z = $VERBOSE
     $VERBOSE = nil
-    VERSION = "0.2.12"
+    VERSION = "0.2.13"
     Version = VERSION
     $VERBOSE = z
   end

data/test/elibri_group_contributor_test.rb

@@ -0,0 +1,26 @@
+#encoding: UTF-8
+require 'helper'
+
+describe Elibri::ONIX::Release_3_0::ONIXMessage do
+
+  it "should be able to parse contributors info" do
+    product = load_fixture("onix_published_group_product_example.xml")
+
+    assert !product.no_contributor?
+    assert product.unnamed_persons?
+
+    cont1 = product.contributors[0]
+    cont2 = product.contributors[1]
+
+#    assert_equal "contributorid:255", cont1.id_before_type_cast
+    assert_nil cont1.eid
+    assert_nil cont1.datestamp_before_type_cast
+
+    assert_equal "author", cont1.role_name
+    assert_equal nil, cont1.person_name
+    assert_equal ["praca zbiorowa"], product.authors
+    assert !cont1.biographical_note.present?
+
+  end
+
+end

data/test/fixtures/onix_published_group_product_example.xml

@@ -0,0 +1,55 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ONIXMessage release="3.0" xmlns="http://ns.editeur.org/onix/3.0/reference" xmlns:elibri="http://elibri.com.pl/ns/extensions">
+  <elibri:Dialect>3.0.1</elibri:Dialect>
+  <Header>
+    <Sender>
+      <SenderName>Elibri.com.pl</SenderName>
+      <ContactName>Tomasz Meka</ContactName>
+      <EmailAddress>kontakt@elibri.com.pl</EmailAddress>
+    </Sender>
+    <SentDateTime>20111111</SentDateTime>
+  </Header>
+  <Product>
+    <RecordReference>fdb8fa072be774d97a97</RecordReference>
+    <NotificationType>03</NotificationType>
+    <ProductIdentifier>
+      <ProductIDType>15</ProductIDType>
+      <IDValue>9788324799992</IDValue>
+    </ProductIdentifier>
+    <DescriptiveDetail>
+      <ProductComposition>00</ProductComposition>
+      <ProductForm>BA</ProductForm>
+      <TitleDetail>
+        <TitleType>01</TitleType>
+        <TitleElement>
+          <TitleElementLevel>01</TitleElementLevel>
+          <TitleText>Taka jest nasza wiara</TitleText>
+        </TitleElement>
+      </TitleDetail>
+      <Contributor>
+        <ContributorRole>A01</ContributorRole>
+        <UnnamedPersons>04</UnnamedPersons>
+      </Contributor>
+    </DescriptiveDetail>
+    <PublishingDetail>
+      <Publisher>
+        <PublishingRole>01</PublishingRole>
+        <PublisherIdentifier>
+          <PublisherIDType>01</PublisherIDType>
+          <IDTypeName>ElibriPublisherCode</IDTypeName>
+          <IDValue>11</IDValue>
+        </PublisherIdentifier>
+        <PublisherName>GREG</PublisherName>
+      </Publisher>
+      <CityOfPublication>Warszawa</CityOfPublication>
+      <PublishingStatus>04</PublishingStatus>
+      <SalesRights>
+        <SalesRightsType>01</SalesRightsType>
+        <Territory>
+          <RegionsIncluded>WORLD</RegionsIncluded>
+        </Territory>
+      </SalesRights>
+    </PublishingDetail>
+    <elibri:preview_exists>false</elibri:preview_exists>
+  </Product>
+</ONIXMessage>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: elibri_onix
 version: !ruby/object:Gem::Version
-  version: 0.2.12
+  version: 0.2.13
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-26 00:00:00.000000000 Z
+date: 2013-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -238,6 +238,7 @@ files:
 - test/elibri_extensions_test.rb
 - test/elibri_extent_test.rb
 - test/elibri_formats_and_protection_test.rb
+- test/elibri_group_contributor_test.rb
 - test/elibri_languages_test.rb
 - test/elibri_licence_information_test.rb
 - test/elibri_measurement_test.rb
@@ -273,6 +274,7 @@ files:
 - test/fixtures/onix_out_of_print_product_example.xml
 - test/fixtures/onix_preorder_product_example.xml
 - test/fixtures/onix_product_form_example.xml
+- test/fixtures/onix_published_group_product_example.xml
 - test/fixtures/onix_published_product_example.xml
 - test/fixtures/onix_publisher_info_example.xml
 - test/fixtures/onix_record_identifiers_example.xml
@@ -301,7 +303,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2082582836940986665
+      hash: 3259318260067271762
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -310,7 +312,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2082582836940986665
+      hash: 3259318260067271762
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25
@@ -326,6 +328,7 @@ test_files:
 - test/elibri_extensions_test.rb
 - test/elibri_extent_test.rb
 - test/elibri_formats_and_protection_test.rb
+- test/elibri_group_contributor_test.rb
 - test/elibri_languages_test.rb
 - test/elibri_licence_information_test.rb
 - test/elibri_measurement_test.rb
@@ -361,6 +364,7 @@ test_files:
 - test/fixtures/onix_out_of_print_product_example.xml
 - test/fixtures/onix_preorder_product_example.xml
 - test/fixtures/onix_product_form_example.xml
+- test/fixtures/onix_published_group_product_example.xml
 - test/fixtures/onix_published_product_example.xml
 - test/fixtures/onix_publisher_info_example.xml
 - test/fixtures/onix_record_identifiers_example.xml