elfproef 0.1.4 → 0.2.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 9ab3e58a3cab6c6c8ea36c8d0c4551af46785674
+  data.tar.gz: 4f6a5c6b02b9a1ae173fe6e7c27ad39a9fe1bf15
+SHA512:
+  metadata.gz: 8f4aef3dff74627d99f913cbb605100f7fc184066e38f04868636f3120cd3429c8c4096a9c00e5656664e98d3fcf02d08dab8742e7869e150a886657af714d66
+  data.tar.gz: cef822a4cfa414fecbb64aaf7d93c915b57808ecb3668ea5e7237190144ed118571e26a232bb9f68450fc13d9617231e41e260b616d8ec0bd6907cbef01fcdea

data/.travis.yml

@@ -1,6 +1,4 @@
 language: ruby
 rvm:
-  - ree
-  - 1.8.7
-  - 1.9.2
-  - 1.9.3
+  - 1.9.3
+  - 2.0.0

data/README.md

@@ -2,11 +2,13 @@
 
 [![Build Status](https://secure.travis-ci.org/sytzeloor/elfproef.png?branch=master)](http://travis-ci.org/sytzeloor/elfproef)
 
-This gem adds three validators to your arsenal:
+## Features
 
-  * BsnValidator will validate Burgerservicenummers (Dutch social security numbers). It accepts both 8 and 9 digit BSN numbers.
-  * BankAccountValidator will validate ING accounts (1-7 digits), and 9 or 10 digit bank account numbers using the elven-test.
-  * PaymentReferenceValidator will validate betalingskenmerken (Dutch payment reference numbers) using a weighted modulus 11 and a length check.
+* Validate international IBAN account numbers
+* Validate Dutch BSN (Social Security) numbers (8 or 9 digits)
+* Validates Dutch bank account numbers (9 or 10 digits)
+* Allow for 1-7 digit ING bank account numbers
+* Validate Dutch payment reference numbers (betalingskenmerken)
 
 ## Installation
 
@@ -22,27 +24,35 @@ and run
 
 	bundle install
 
+## Compatibility
+
+As of elfproef-0.2.0 you need ruby-1.9.3 or up, ruby-2.0.0 is preferred.
+
+If your project is stuck at <= ruby-1.9.2, use the latest elfproef-0.1.x release.
+
+    gem 'elfproef', '0.1.4'
+
 ## Usage
 
-Using the BsnValidator
+Using the BsnValidator:
 
     class User < ActiveRecord::Base
       validates :bsn_number, bsn: true
     end
 
-Using the BankAccountValidator
+Using the BankAccountValidator:
 
     class User < ActiveRecord::Base
       validates :account_number, bank_account: true
 	end
 
-Using the PaymentReferenceValidator
+Using the PaymentReferenceValidator:
 
     class User < ActiveRecord::Base
       validates :reference, payment_reference: true
     end
 
-You can also use these validators without `ActiveRecord` by including `ActiveModel::Validations`.
+You can also use these validators without `ActiveRecord` by including `ActiveModel::Validations`:
    
     class AwesomeDutchPerson
       include ActiveModel::Validations
@@ -81,7 +91,7 @@ create a pull request.
 
 ## License
 
-Copyright (c) 2012 Sytze Loor
+Copyright (c) 2012-2013 Sytze Loor, Ariejan de Vroom
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/lib/elfproef/bank_account_validator.rb

@@ -19,15 +19,19 @@ class BankAccountValidator < ::ActiveModel::EachValidator
   #
   def self.validate_account_number(value, options = {})
     number = value.to_s.gsub(/\D/, '').strip
-
     # Not valid if length is 0, 8 or > 10
-    return false if number.length == 0 || number.length == 8 || number.length > 10
+    return false if number.length == 0 || number.length == 8 || (value.length > 10 && value.length < 15) || value.length > 31
 
     # ING account numbers
     return true if (1..7).include?(number.length)
 
     # Validate length 9 and 10 numbers as bank accounts
-    self.validate_with_eleven_test(number)
+    return true if self.validate_with_eleven_test(number) if (number.length == 9 || number.length == 10)
+
+    # If all other validations are failing, we are possibly dealing with an IBAN number
+    return true if self.validate_with_iban_test(value)
+
+    return false
   end
 
   private
@@ -57,4 +61,30 @@ class BankAccountValidator < ::ActiveModel::EachValidator
 
     sum % 11 == 0
   end
+
+  # Perform the mod-97 test (as described in ISO 7064)
+  # Check that the total IBAN length is correct as per the country. If not, the IBAN is invalid.
+  # Move the four initial characters to the end of the string.
+  # Replace each letter in the string with two digits, thereby expanding the string, where A = 10, B = 11, ..., Z = 35.
+  # Interpret the string as a decimal integer and compute the remainder of that number on division by 97.
+  #
+  # If the remainder of the test equals 1, the IBAN is valid
+  def self.validate_with_iban_test(value)
+    country_prefix = to_ascii_code(value[0..3])
+    bank_code = to_ascii_code(value[4..7])
+    bank_number = value[8..value.length]
+    ("#{bank_code}#{bank_number}#{country_prefix}".to_i % 97) == 1
+  end
+
+  def self.to_ascii_code(value)
+    converted_value = ""
+    value.each_byte do |byte|
+      if (65..90).include?(byte)
+        converted_value += (byte - 55).to_s
+      else
+        converted_value += byte.chr
+      end
+    end
+    return converted_value
+  end
 end

data/lib/elfproef/version.rb

@@ -1,3 +1,3 @@
 module Elfproef
-  VERSION= "0.1.4"
+  VERSION= "0.2.0"
 end

data/spec/bank_account_validator_spec.rb

@@ -66,6 +66,26 @@ describe BankAccountValidator do
     subject.should be_valid
   end
 
+  it 'accepts a Dutch IBAN bank account number' do
+    subject.account = 'NL91ABNA0417164300'
+    subject.should be_valid
+  end
+
+  it 'accepts a German IBAN bank account number' do
+    subject.account = 'DE89370400440532013000'
+    subject.should be_valid
+  end
+
+  it 'accepts a Belgium IBAN bank account number' do
+    subject.account = 'BE68539007547034'
+    subject.should be_valid
+  end
+
+  it 'rejects an invalid iban bank account' do
+    subject.account = 'NL11ABNA1111111'
+    subject.should_not be_valid
+  end
+
   it "rejects on an 8 digit number" do
     subject.account = "12345678"
     subject.should_not be_valid

metadata

@@ -1,82 +1,81 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: elfproef
-version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 0
-  - 1
-  - 4
-  version: 0.1.4
+version: !ruby/object:Gem::Version
+  version: 0.2.0
 platform: ruby
-authors: 
+authors:
 - Sytze Loor
 - Ariejan de Vroom
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-08-30 00:00:00 +02:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2013-07-16 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: rake
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        version: "0"
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: rspec
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        version: "0"
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: guard-rspec
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        version: "0"
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: activemodel
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        version: "0"
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: activemodel
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id004
-description: Validation for Dutch bank account numbers, Citizen Service Numbers (BSN) and Payment reference
-email: 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Validation for Dutch bank account numbers, Citizen Service Numbers (BSN)
+  and Payment reference
+email:
 - sytze@tweedledum.nl
 - ariejan@ariejan.net
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - .travis.yml
 - Gemfile
@@ -93,37 +92,31 @@ files:
 - spec/bsn_validator_spec.rb
 - spec/payment_reference_validator_spec.rb
 - spec/spec_helper.rb
-has_rdoc: true
 homepage: https://github.com/sytzeloor/elfproef
 licenses: []
-
+metadata: {}
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      segments: 
-      - 0
-      version: "0"
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: elfproef
-rubygems_version: 1.3.6
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
-summary: Validation for Dutch bank account numbers, Citizen Service Numbers (BSN) and Payment reference
-test_files: 
+specification_version: 4
+summary: Validation for Dutch bank account numbers, Citizen Service Numbers (BSN)
+  and Payment reference
+test_files:
 - spec/bank_account_validator_spec.rb
 - spec/bsn_validator_spec.rb
 - spec/payment_reference_validator_spec.rb