elfproef 0.1.1 → 0.1.2

data/README.md

@@ -42,6 +42,20 @@ You can also use these validators without `ActiveRecord` by including `ActiveMod
       validates :bsn, bsn: true
     end
 
+## I18n
+
+Add the following to your locale file:
+
+    en:
+      activemodel:
+        errors:
+          models:
+            YOUR_MODEL:
+              attributes:
+                ATTRIBUTE:
+                  invalid_bank_account: "is not a valid bank account number"
+                  invalid_bsn: "is not a valid BSN"
+
 ## Bugs / Feature Requests
 
 Please post them to

data/lib/elfproef/bank_account_validator.rb

@@ -1,11 +1,15 @@
-require "active_model"
-require "active_model/validations"
+require 'active_model/validator'
+require 'active_support/concern'
 
 # Validates if the specified value is a valid
 # bank account number using the 11-test
-class BankAccountValidator < ActiveModel::EachValidator
+class BankAccountValidator < ::ActiveModel::EachValidator
+  extend ActiveSupport::Concern
+
   def validate_each(record, attribute, value)
-    record.errors.add(attribute, options[:message] || "is not valid") unless validate_account_number(value, options)
+    unless validate_account_number(value, options)
+      record.errors.add(attribute, :invalid_bank_account, options)
+    end
   end
 
   private

data/lib/elfproef/bsn_validator.rb

@@ -5,7 +5,9 @@ require "active_model/validations"
 # Burgerservicenummer (Dutch social security number)
 class BsnValidator < ActiveModel::EachValidator
   def validate_each(record, attribute, value)
-    record.errors.add(attribute, options[:message] || "is not valid") unless validate_bsn(value, options)
+    unless validate_bsn(value, options)
+      record.errors.add(attribute, :invalid_bsn, options)
+    end
   end
 
   private
@@ -22,6 +24,20 @@ class BsnValidator < ActiveModel::EachValidator
     validate_with_advanced_eleven_test(bsn)
   end
 
+  # Performs the advanced 11-test on a
+  # 8 or 9 digit account number
+  #
+  #  For 9 digits (prefix with a 0 for 8 digits):
+  #
+  #   123456782
+  #   ABCDEFGHI
+  #
+  #   sum = 9*A + 8*B + 7*C + 6*D + 5*E + 4*F + 3*G + 2*H + -1*I
+  #
+  # Note the -1*I!
+  #
+  # If sum % 11 is 0, the number is valid, otherwise
+  # a typo has been made or the number is outright invalid.
   def validate_with_advanced_eleven_test(number)
     # Make sure we have 9 digits
     number = "0#{number}" if number.size == 8

data/lib/elfproef/version.rb

@@ -1,3 +1,3 @@
 module Elfproef
-  VERSION= "0.1.1"
+  VERSION= "0.1.2"
 end

data/spec/bank_account_validator_spec.rb

@@ -1,16 +1,16 @@
 require File.dirname(__FILE__) + '/spec_helper'
 
+class BankAccountTest
+  include ActiveModel::Validations
+  attr_accessor :account
+  validates :account, :bank_account => true
+end
+
 describe BankAccountValidator do
   subject {
-    Class.new do
-      include ActiveModel::Validations
-      attr_accessor :account
-      validates :account, :bank_account => true
-    end.new
+    BankAccountTest.new
   }
 
-  let(:errors) { ["is not valid"] }
-
   it "accepts 1 digit ING accounts" do
     subject.account = "1"
     subject.should be_valid
@@ -56,21 +56,21 @@ describe BankAccountValidator do
     subject.should be_valid
   end
 
-  it "fails on an 8 digit number" do
+  it "rejects on an 8 digit number" do
     subject.account = "12345678"
     subject.should_not be_valid
-    subject.errors[:account].should == errors
+    subject.errors[:account].should be_present
   end
 
-  it "fails on obviously wrong numbers" do
+  it "rejects on obviously wrong numbers" do
     subject.account = "CHUCKNORRIS"
     subject.should_not be_valid
-    subject.errors[:account].should == errors
+    subject.errors[:account].should be_present
   end
 
-  it "fails on 1 digit errors" do
+  it "rejects on 1 digit errors" do
     subject.account = "133456789"
     subject.should_not be_valid
-    subject.errors[:account].should == errors
+    subject.errors[:account].should be_present
   end
 end

data/spec/bsn_validator_spec.rb

@@ -1,16 +1,16 @@
 require File.dirname(__FILE__) + '/spec_helper'
 
+class BsnTest
+  include ActiveModel::Validations
+  attr_accessor :number
+  validates :number, :bsn => true
+end
+
 describe BsnValidator do
   subject {
-    Class.new do
-      include ActiveModel::Validations
-      attr_accessor :number
-      validates :number, :bsn => true
-    end.new
+    BsnTest.new
   }
 
-  let(:errors) { ["is not valid"] }
-
   it "accepts an 8 digit bsn" do
     subject.number = "12345672"
     subject.should be_valid
@@ -24,24 +24,24 @@ describe BsnValidator do
   it "rejects too short bsn numbers" do
     subject.number = "123"
     subject.should_not be_valid
-    subject.errors[:number].should == errors
+    subject.errors[:number].should be_present
   end
 
   it "rejects too long bsn numbers" do
     subject.number = "123456789012345"
     subject.should_not be_valid
-    subject.errors[:number].should == errors
+    subject.errors[:number].should be_present
   end
 
   it "rejects obvious incorrect bsn numbers" do
     subject.number = "NOTAXES"
     subject.should_not be_valid
-    subject.errors[:number].should == errors
+    subject.errors[:number].should be_present
   end
 
   it "rejects mistyped bsn numbers" do
     subject.number = "123456789012345"
     subject.should_not be_valid
-    subject.errors[:number].should == errors
+    subject.errors[:number].should be_present
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: elfproef
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -10,11 +10,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-03-14 00:00:00.000000000 Z
+date: 2012-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70120115123800 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70120115123800
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70120115121940 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +38,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70120115121940
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &70120115121320 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +54,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70120115121320
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &70120115115360 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,7 +70,12 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70120115115360
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Validation for Dutch bank account numbers and Citizen Service Numbers
   (BSN)
 email:
@@ -93,7 +113,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1005749835368650019
+      hash: -3163671652779921677
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -102,10 +122,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1005749835368650019
+      hash: -3163671652779921677
 requirements: []
 rubyforge_project: elfproef
-rubygems_version: 1.8.11
+rubygems_version: 1.8.19
 signing_key: 
 specification_version: 3
 summary: Validation for Dutch bank account numbers and Citizen Service Numbers (BSN)