elfproef 0.0.2 → 0.0.3

data/.travis.yml

@@ -1,5 +1,6 @@
 language: ruby
 rvm:
+  - ree
   - 1.8.7
   - 1.9.2
   - 1.9.3

data/README.md

@@ -28,10 +28,10 @@ and run
 Simply add "validates_elfproef_of" to your model class.
 
 	class User < ActiveRecord::Base
-        # Validate with 11-test, do not allow 7 digit ING account numbers
+    # Validate with 11-test, do not allow 7 digit ING account numbers
 		validates :bsn, elfproef: true
 
-        # Validate bank account numbers with 11-test, allow 7 digit ING account numbers
+    # Validate bank account numbers with 11-test, allow 7 digit ING account numbers
 		validates :bank_account, elfproef: { allow_ing: true }
 	end
 

data/lib/elfproef.rb

@@ -19,10 +19,10 @@ module Elfproef
   # http://nl.wikipedia.org/wiki/Elfproef
   def self.elfproef(number, options = {})
     number, sum = number.to_s, 0
-    number.gsub!(/\D/, '')                   # strip out any non-digit character.
-    return true if options[:allow_ing] && number.length == 7        # always pass postbank accounts (7 digits)
-    return false unless number =~ /^\d{9}$/  # account should be exactly 9 digits
-    (1..9).each do |c|
+    number.gsub!(/\D/, '')                                                # strip out any non-digit character.
+    return true if options[:allow_ing] && (1..7).include?(number.length)  # always pass ING accounts (between 1 and 7 digits)
+    return false unless (9..10).include?(number.length)                   # account should be exactly 9 or 10 digits
+    (1..number.length).each do |c|
       sum += number[-c].chr.to_i * c
     end
     sum % 11 == 0

data/lib/version.rb

@@ -1,3 +1,3 @@
 module Elfproef
-  VERSION= "0.0.2"
+  VERSION= "0.0.3"
 end

data/spec/elfproef_spec.rb

@@ -40,7 +40,6 @@ describe Elfproef do
     Elfproef.elfproef('1234567', opts).should == true
   end
 
-
   shared_examples_for "elfproef validations" do
     subject { account_class.new }
 
@@ -50,21 +49,61 @@ describe Elfproef do
     end
 
     it "fails with an obviously wrong number" do
-      subject.account = "666"
+      subject.account = "12345678901"
       subject.should_not be_valid
       subject.errors[:account].should == errors
     end
 
-    it "passes with a ING number" do
+    it "passes with a 7-diget ING number" do
       subject.account = "1234567"
       subject.should be_valid
     end
 
-    it "passes with a valid bank number" do
+    it "passes with a 6-digit ING number" do
+      subject.account = "123456"
+      subject.should be_valid
+    end
+
+    it "passes with a 5-digit ING number" do
+      subject.account = "12345"
+      subject.should be_valid
+    end
+
+    it "passes with a 4-digit ING number" do
+      subject.account = "1234"
+      subject.should be_valid
+    end
+
+    it "passes with a 3-digit ING number" do
+      subject.account = "123"
+      subject.should be_valid
+    end
+
+    it "passes with a 2-digit ING number" do
+      subject.account = "12"
+      subject.should be_valid
+    end
+
+    it "passes with a 1-digit ING number" do
+      subject.account = "1"
+      subject.should be_valid
+    end
+
+    it "passes with a ING number starting with a P (from Postbank)" do
+      subject.account = "P1234567"
+      subject.should be_valid
+    end
+
+    it "passes with a valid 9-digit bank number" do
       subject.account = "123456789"
       subject.should be_valid
     end
 
+    it "passes with a valid 10-digit bank number" do
+      subject.account = "0123456789"
+      subject.should be_valid
+    end
+
     it "fails with an wrong bank number" do
       subject.account = "999999999"
       subject.should_not be_valid
@@ -92,11 +131,16 @@ describe Elfproef do
       subject.errors[:account].should == errors
     end
 
-    it "passes with a valid bank number" do
+    it "passes with a valid 9-digit bank number" do
       subject.account = "123456789"
       subject.should be_valid
     end
 
+    it "passes with a valid 10-digit bank number" do
+      subject.account = "0123456789"
+      subject.should be_valid
+    end
+
     it "fails with an wrong bank number" do
       subject.account = "999999999"
       subject.should_not be_valid

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: elfproef
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -14,7 +14,7 @@ date: 2012-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70335074770740 !ruby/object:Gem::Requirement
+  requirement: &70105363295440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70335074770740
+  version_requirements: *70105363295440
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70335074769940 !ruby/object:Gem::Requirement
+  requirement: &70105363294960 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +33,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70335074769940
+  version_requirements: *70105363294960
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &70335074769340 !ruby/object:Gem::Requirement
+  requirement: &70105363294520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +44,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70335074769340
+  version_requirements: *70105363294520
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &70335074768620 !ruby/object:Gem::Requirement
+  requirement: &70105363293980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,7 +55,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70335074768620
+  version_requirements: *70105363293980
 description: Validation for Dutch bank account numbers and Citizen Service Numbers
   (BSN)
 email:
@@ -87,21 +87,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -1245454335303518199
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -1245454335303518199
 requirements: []
 rubyforge_project: elfproef
-rubygems_version: 1.8.11
+rubygems_version: 1.8.17
 signing_key: 
 specification_version: 3
 summary: Validation for Dutch bank account numbers and Citizen Service Numbers (BSN)