elfproef 0.0.1 → 0.0.2

data/.travis.yml

@@ -0,0 +1,5 @@
+language: ruby
+rvm:
+  - 1.8.7
+  - 1.9.2
+  - 1.9.3

data/README.md

@@ -1,5 +1,7 @@
 # Elfproef
 
+[![Build Status](https://secure.travis-ci.org/sytzeloor/elfproef.png?branch=master)](http://travis-ci.org/sytzeloor/elfproef)
+
 This gem adds a validation method for Dutch bank account numbers and
 Citizen Service Numbers (BSN). These can be validated using the
 so-called Elfproef.
@@ -26,8 +28,11 @@ and run
 Simply add "validates_elfproef_of" to your model class.
 
 	class User < ActiveRecord::Base
-		validates :bank_account, elfproef: true
+        # Validate with 11-test, do not allow 7 digit ING account numbers
 		validates :bsn, elfproef: true
+
+        # Validate bank account numbers with 11-test, allow 7 digit ING account numbers
+		validates :bank_account, elfproef: { allow_ing: true }
 	end
 
 ## Bugs / Feature Requests
@@ -66,4 +71,4 @@ MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
 LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
 OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/elfproef.gemspec

@@ -5,9 +5,9 @@ require "version"
 Gem::Specification.new do |s|
   s.name        = "elfproef"
   s.version     = Elfproef::VERSION
-  s.authors     = ["Sytze Loor"]
-  s.email       = ["sytze@tweedledum.nl"]
-  s.homepage    = ""
+  s.authors     = ["Sytze Loor", "Ariejan de Vroom"]
+  s.email       = ["sytze@tweedledum.nl", "ariejan@ariejan.net"]
+  s.homepage    = "https://github.com/sytzeloor/elfproef"
   s.summary     = %q{Validation for Dutch bank account numbers and Citizen Service Numbers (BSN)}
   s.description = %q{Validation for Dutch bank account numbers and Citizen Service Numbers (BSN)}
 
@@ -25,4 +25,4 @@ Gem::Specification.new do |s|
 
   s.add_dependency "activemodel"
 
-end
+end

data/lib/elfproef.rb

@@ -5,7 +5,7 @@ require "active_model/validations"
 class ElfproefValidator < ActiveModel::EachValidator
   # implement the method where the validation logic must reside
   def validate_each(record, attribute, value)
-    record.errors.add(attribute, options[:message] || "is not valid") unless Elfproef.elfproef(value)
+    record.errors.add(attribute, options[:message] || "is not valid") unless Elfproef.elfproef(value, options)
   end
 end
 
@@ -17,14 +17,14 @@ module Elfproef
   # Postbank bank accounts (7 digits) cannot be validated using the elfproef and
   # will always return 0 (success).
   # http://nl.wikipedia.org/wiki/Elfproef
-  def self.elfproef(number)
+  def self.elfproef(number, options = {})
     number, sum = number.to_s, 0
     number.gsub!(/\D/, '')                   # strip out any non-digit character.
-    return true if number.length == 7        # always pass postbank accounts (7 digits)
+    return true if options[:allow_ing] && number.length == 7        # always pass postbank accounts (7 digits)
     return false unless number =~ /^\d{9}$/  # account should be exactly 9 digits
     (1..9).each do |c|
       sum += number[-c].chr.to_i * c
     end
     sum % 11 == 0
   end
-end
+end

data/lib/version.rb

@@ -1,3 +1,3 @@
 module Elfproef
-  VERSION= "0.0.1"
-end
+  VERSION= "0.0.2"
+end

data/spec/elfproef_spec.rb

@@ -1,8 +1,13 @@
 require File.dirname(__FILE__) + '/spec_helper'
 
 describe Elfproef do
-
   account_class = Class.new do
+    include ActiveModel::Validations
+    attr_accessor :account
+    validates :account, :elfproef => { :allow_ing => true }
+  end
+
+  bank_only_class = Class.new do
     include ActiveModel::Validations
     attr_accessor :account
     validates :account, :elfproef => true
@@ -27,8 +32,12 @@ describe Elfproef do
     Elfproef.elfproef(123456789).should == true
     Elfproef.elfproef('12.34.56.789').should == true
     Elfproef.elfproef('12 34 56 789').should == true
-    Elfproef.elfproef(1234567).should == true
-    Elfproef.elfproef('1234567').should == true
+  end
+
+  it "tests valid ING accounts" do
+    opts = { :allow_ing => true }
+    Elfproef.elfproef(1234567, opts).should == true
+    Elfproef.elfproef('1234567', opts).should == true
   end
 
 
@@ -61,11 +70,47 @@ describe Elfproef do
       subject.should_not be_valid
       subject.errors[:account].should == errors
     end
+  end
+
+  shared_examples_for "elfproef, bank accounts only validations" do
+    subject { bank_only_class.new }
+
+    it "fails when empty" do
+      subject.should_not be_valid
+      subject.errors[:account].should == errors
+    end
+
+    it "fails with an obviously wrong number" do
+      subject.account = "666"
+      subject.should_not be_valid
+      subject.errors[:account].should == errors
+    end
+
+    it "fails with a ING number" do
+      subject.account = "1234567"
+      subject.should_not be_valid
+      subject.errors[:account].should == errors
+    end
 
+    it "passes with a valid bank number" do
+      subject.account = "123456789"
+      subject.should be_valid
+    end
+
+    it "fails with an wrong bank number" do
+      subject.account = "999999999"
+      subject.should_not be_valid
+      subject.errors[:account].should == errors
+    end
   end
 
-  describe "English validations" do
+  describe "bank + ing validations" do
     let!(:errors) { [ "is not valid"] }
     it_should_behave_like "elfproef validations"
   end
-end
+
+  describe "bank only validations" do
+    let!(:errors) { [ "is not valid"] }
+    it_should_behave_like "elfproef, bank accounts only validations"
+  end
+end

metadata

@@ -1,11 +1,12 @@
 --- !ruby/object:Gem::Specification
 name: elfproef
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
 - Sytze Loor
+- Ariejan de Vroom
 autorequire: 
 bindir: bin
 cert_chain: []
@@ -13,7 +14,7 @@ date: 2012-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70344757390700 !ruby/object:Gem::Requirement
+  requirement: &70335074770740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +22,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70344757390700
+  version_requirements: *70335074770740
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70344757390200 !ruby/object:Gem::Requirement
+  requirement: &70335074769940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +33,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70344757390200
+  version_requirements: *70335074769940
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &70344757389760 !ruby/object:Gem::Requirement
+  requirement: &70335074769340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +44,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70344757389760
+  version_requirements: *70335074769340
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &70344757389240 !ruby/object:Gem::Requirement
+  requirement: &70335074768620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,16 +55,18 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70344757389240
+  version_requirements: *70335074768620
 description: Validation for Dutch bank account numbers and Citizen Service Numbers
   (BSN)
 email:
 - sytze@tweedledum.nl
+- ariejan@ariejan.net
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - README.md
 - Rakefile
@@ -72,7 +75,7 @@ files:
 - lib/version.rb
 - spec/elfproef_spec.rb
 - spec/spec_helper.rb
-homepage: ''
+homepage: https://github.com/sytzeloor/elfproef
 licenses: []
 post_install_message: 
 rdoc_options: []
@@ -84,15 +87,21 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -1245454335303518199
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -1245454335303518199
 requirements: []
 rubyforge_project: elfproef
-rubygems_version: 1.8.17
+rubygems_version: 1.8.11
 signing_key: 
 specification_version: 3
 summary: Validation for Dutch bank account numbers and Citizen Service Numbers (BSN)