elementary-rpc 1.2.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 56fcda60e0f593913eeafcab46d20825dd8e8e20
-  data.tar.gz: a75f8e552bde90fc53250b704107da1ed4ae07e7
+  metadata.gz: 9bcc7e0abcf56202698d9b852c208a0fe8e5bf24
+  data.tar.gz: a7c0bcba0eee1e4a21bde6c30a9fa05fb6b68200
 SHA512:
-  metadata.gz: ec48386473339fefb812d282caef334ca3d139f172b2e38c3fe0427e3241fc3666920168334c31a8b3ece8fa7eacf34d627ab9e37a7fd4fb52be908fbb264635
-  data.tar.gz: 199316aa44f9d82c1845f8cfc7cfc28062073c74c6c604b4b45d2f1f037a6e1db7629f7926e1958543f9b5c0ca112369897932075ee90cf919a8d938b7036ae9
+  metadata.gz: 16397a5bece8062d1de4189cdb8355e8379aca6bdf6d2b4c6fbf799700cb5758fb452b3b241cbbe59256b60f3c4202115cb696f4555bc2d26cec49705db07cdb
+  data.tar.gz: 976eccc0b54ad4f07f6a607b05ef173f0fdb53bda76427c61e31d21dc835cea5da2ddd842358d47e206554267ad763f2f6c5542207d52c4be2c0af7475b7d493

data/Gemfile

@@ -4,7 +4,7 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'rack'
-gem 'protobuf', :github => 'lookout/protobuffy'
+gem 'protobuffy', :github => 'lookout/protobuffy'
 
 group :test do
   gem 'rspec'

data/README.md

@@ -46,8 +46,12 @@ Elementary.use(Elementary::Middleware::Statsd, :client => Statsd.instance)
 
 # Create our Connection object that knows about our Protobuf service
 # definition
-c = Elementary::Connection.new(Echoserv::Simple, :hosts => hosts)
+def connection
+  return @connection if @connection
 
+  @connection = Elementary::Connection.new(Echoserv::Simple,
+                                             :hosts => hosts)
+end
 # Create a Protobuf message to send over RPC
 msg = Echoserv::String.new(:data => str)
 
@@ -91,4 +95,57 @@ TODO: Write usage instructions here
 
 ### Testing
 
+Install ha-proxy for your OS
+ For Mac OSX, good reference source is http://nepalonrails.tumblr.com/post/9674428224/setup-haproxy-for-development-environment-on-mac
+ Sample ha-proxy config
+
+ cat /etc/haproxy.conf
+ global
+   maxconn 4096
+   pidfile ~/tmp/haproxy-queue.pid
+   log /tmp/haproxy/log    local0
+   log /tmp/haproxy/log    local1 notice
+
+ defaults
+   log global
+   mode http
+   timeout connect 300000
+   timeout client 300000
+   timeout server 300000
+   maxconn 2000
+   option redispatch
+   retries 3
+   option httpclose
+   option httplog
+   option forwardfor
+   option httpchk HEAD / HTTP/1.0
+
+ frontend http-farm-1
+   bind :8080
+   default_backend app1latest
+
+ frontend http-farm-2
+   bind :8070
+   default_backend app2latest
+
+ backend app1latest
+   balance roundrobin
+   server localhost_8000 localhost:8000
+
+ backend app2latest
+   balance roundrobin
+
+ listen haproxyapp_admin:9100 127.0.0.1:9100
+   mode http
+   stats uri /
+
+Start ha-proxy listener
+ haproxy -f /etc/haproxy.conf
+
+Start the server hosting the rpc as below:
 `bundle exec rpc_server start ./spec/support/simpleservice.rb -p 8000 --http`
+
+Run the tests
+ `bundle exec rspec spec`
+
+

data/lib/elementary/connection.rb

@@ -17,7 +17,7 @@ module Elementary
     # @param [Hash] opts
     # @options opts [Symbol] :transport Defaults to :http, must map to a class
     #   in the +Elementary::Transport+ module
-    # @optiosn opts [Array] :hosts An array of {:host => 'localhost', :port =>
+    # @options opts [Array] :hosts An array of {:host => 'localhost', :port =>
     #   8080} hashes to instruct the connection
     # @option opts [Hash] :transport_options A +Hash+ of request options that
     #   will be passed down to the transport layer. This will depend on what

data/lib/elementary/middleware/raise_on_status.rb

@@ -0,0 +1,89 @@
+require 'faraday'
+
+module Elementary
+  module Middleware
+    class HttpStatusError < StandardError; end
+    ##
+    # Raise an exception for certain HTTP response status codes
+    #
+    # Examples
+    #
+    #   Faraday.new do |conn|
+    #     conn.request :raise_on_status
+    #     conn.adapter ...
+    #   end
+    #
+    # The above example will raise an HttpStatusError if the response
+    # contains a code in the range 300 through 600.
+    #
+    # You can also pair this with the retry middleware to attempt
+    # to recover from intermittent failures...
+    #
+    #   Faraday.new do |conn|
+    #     conn.request :retry, max: 2, interval: 0.05,
+    #                          interval_randomness: 0.5, backoff_factor: 2
+    #                          exceptions: [Faraday::TimeoutError, SecurityEvents::HttpStatusError]
+    #     conn.request :raise_on_status
+    #     conn.adapter ...
+    #   end
+    #
+    # This example will do the same as the first, but the exception
+    # will be caught by the retry middleware and the request will be
+    # executed up to two more times before raising.
+    # NOTE: Middleware order matters here!
+    #
+    class RaiseOnStatus < Faraday::Middleware
+
+      DEFAULT_STATUS_ARRAY = [300..600]
+      ERROR_HEADER_MSG = 'x-protobuf-error'
+      ERROR_HEADER_CODE = 'x-protobuf-error-reason'
+
+      dependency do
+        require 'set'
+      end
+
+      # Public: Initialize middleware
+      def initialize(app)
+        super(app)
+        status_array ||= DEFAULT_STATUS_ARRAY
+        @status_set = status_option_array_to_set(status_array)
+      end
+
+      def call(request_env)
+        begin
+          @app.call(request_env).on_complete do |response_env|
+            status = response_env[:status]
+            if @status_set.include? status
+              error_msg = response_env[:response_headers][ERROR_HEADER_MSG]
+              error_code = response_env[:response_headers][ERROR_HEADER_CODE]
+              if error_msg
+                raise Elementary::Errors::RPCFailure, "Error #{error_code}: #{error_msg}"
+              else
+                method = response_env.method.to_s.upcase
+                url = response_env.url.to_s
+                raise HttpStatusError, "#{method} #{url} returned an HTTP response status of #{status}, so an exception was raised."
+              end
+            end
+          end
+        rescue Faraday::ClientError => e
+          raise HttpStatusError, "#{e.message}"
+        end
+      end
+
+      private
+
+      # Private: Construct a set of status codes.
+      #
+      # Accepts an array of Numeric and Enumerable objects which are added or merged to form a set.
+      def status_option_array_to_set(status_array)
+        set = Set.new
+        status_array.each do |item|
+          set.add item if item.is_a? Numeric
+          set.merge item if item.is_a? Enumerable
+        end
+        set
+      end
+    end
+    Faraday::Request.register_middleware :raise_on_status => lambda { RaiseOnStatus }
+    end
+  end

data/lib/elementary/transport/http.rb

@@ -2,15 +2,12 @@ require 'rubygems'
 require 'cgi'
 require 'faraday'
 require 'socket'
-
 require 'elementary/errors'
 require 'elementary/future'
 
 module Elementary
   module Transport
     class HTTP
-      ERROR_HEADER_MSG = 'x-protobuf-error'
-      ERROR_HEADER_CODE = 'x-protobuf-error-reason'
 
       # Create a HTTP transport object for sending protobuf objects to the
       # service host names enumerated in +hosts+
@@ -24,6 +21,7 @@ module Elementary
       end
 
       def call(service, rpc_method, *params)
+
         begin
           response = client.post do |h|
             path = "#{CGI.escape(service.name)}/#{rpc_method.method}"
@@ -31,16 +29,8 @@ module Elementary
             h.body = params[0].encode
           end
 
-          error_msg = response.headers[ERROR_HEADER_MSG]
-          error_code = response.headers[ERROR_HEADER_CODE]
-
-          if error_msg
-            raise Elementary::Errors::RPCFailure, "Error #{error_code}: #{error_msg}"
-          end
-
           return rpc_method[:response_type].decode(response.body)
         rescue StandardError => e
-          #puts "EXCEPTION #{e.inspect}"
           raise
         end
       end
@@ -60,10 +50,10 @@ module Elementary
 
         faraday_options = @options.merge({:url => host_url})
         @client = Faraday.new(faraday_options) do |f|
+          f.request :raise_on_status
           f.response :logger
           f.adapter :net_http_persistent
         end
-
         return @client
       end
     end

data/lib/elementary/version.rb

@@ -1,4 +1,4 @@
 
 module Elementary
-  VERSION = "1.2.0"
+  VERSION = "2.0.0"
 end

data/spec/connection_spec.rb

@@ -81,7 +81,6 @@ describe Elementary::Connection do
       end
     end
 
-
     describe 'an error request', :type => :integration do
       describe 'rpc' do
         describe '#error' do
@@ -105,26 +104,39 @@ describe Elementary::Connection do
       describe 'rpc' do
         describe '#echo' do
           let(:request) { Elementary::Rspec::String.new(:data => 'rspec') }
-          subject(:response) { connection.rpc.echo(request) }
-
-          before :each do
-            Elementary.use Elementary::Middleware::Dummy, :rspec => true
-            expect_any_instance_of(Elementary::Middleware::Dummy).to \
-                    receive(:call).and_call_original
+          context 'with http connection failure due to haproxy resolving service to wrong host or port' do
+            let(:opts) { { 'hosts' => [{'host' => 'localhost', 'port' => '8090'}] } }
+            subject(:response) { connection.rpc.echo(request) }
+
+            before :each do
+              response.value
+            end
+
+            it { should be_rejected }
+            it { should be_instance_of Elementary::Future }
+            it 'should have a connection refused reason' do
+              expect(response.reason).not_to be_nil
+              expect(response.reason.to_s).to eq("connection refused: localhost:8090")
+            end
           end
-
-          it 'should have a value containing the echoed string' do
-            puts "Sending req #{Time.now.to_f}"
-            expect(response).to be_instance_of Elementary::Future
-
-            puts "Waiting for future #{Time.now.to_f}"
-            value = response.value # Wait on the future
-            puts "Future responded: #{Time.now.to_f}"
-
-            expect(response).not_to be_rejected
-            expect(value.data).to eql('rspec')
+          context 'with http connection success' do
+            let(:opts) { { 'hosts' => [{'host' => 'localhost', 'port' => '8000'}] } }
+            subject(:response) { connection.rpc.echo(request) }
+
+            before :each do
+              Elementary.use Elementary::Middleware::Dummy, :rspec => true
+              expect_any_instance_of(Elementary::Middleware::Dummy).to \
+                      receive(:call).and_call_original
+            end
+
+            it 'should have a value containing the echoed string' do
+              expect(response).to be_instance_of Elementary::Future
+              value = response.value # Wait on the future
+              expect(response).not_to be_rejected
+              expect(value.data).to eql('rspec')
+            end
           end
-        end
+         end
       end
     end
   end

data/spec/elementary_client_using_anti_pattern_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+require 'support/clients/base_elementary_client'
+require 'support/clients/elementary_client_using_anti_pattern'
+
+def sendAndVerify(msg)
+  response = client.invoke_echo_service(Elementary::Rspec::String.new(:data => msg))
+  expect(response).to be_rejected
+  expect(response.reason.class).to be Elementary::Middleware::HttpStatusError
+  expect(response.reason.message).to include("connection refused: localhost:8090")
+end
+
+# This test requires that no process be listening at localhost:8090
+describe ElementaryClientUsingAntiPattern, "http connection returning error code 503", :type => :integration do
+  subject (:client) {ElementaryClientUsingAntiPattern.new()}
+  describe "#initialize" do
+    it "creates a connection" do
+      expect(client.connection).not_to be_nil
+    end
+  end
+  describe "#invoke_service" do
+    context 'with http connection returning error connection refused' do
+      it "invokes echo service" do
+        sendAndVerify('rspec1')
+      end
+    end
+  end
+end

data/spec/sample_elementary_client_spec.rb

@@ -0,0 +1,97 @@
+require 'spec_helper'
+require 'support/clients/base_elementary_client'
+require 'support/clients/sample_elementary_client'
+
+def send_and_verify_http_error_503(msg)
+  response = client.invoke_error_service(Elementary::Rspec::String.new(:data => msg))
+  expect(response).to be_rejected
+  expect(response.reason.class).to be Elementary::Middleware::HttpStatusError
+  expect(response.reason.message).to include("returned an HTTP response status of 503, so an exception was raised.")
+end
+
+def send_and_verify_http_error_500(msg)
+  response = client.invoke_error_service(Elementary::Rspec::String.new(:data => msg))
+  expect(response).to be_rejected
+  expect(response.reason.class).to be Elementary::Errors::RPCFailure
+  expect(response.reason.message).to include("sample failure")
+end
+
+def send_and_verify_http_error_400(msg)
+  response = client.invoke_bad_request_data_service(Elementary::Rspec::String.new(:data => msg))
+  expect(response).to be_rejected
+  expect(response.reason.class).to be Elementary::Errors::RPCFailure
+  expect(response.reason.message).to include("sample bad request data failure")
+end
+
+def send_and_verify_http_error_404(msg)
+  response = client.invoke_service_not_found_service(Elementary::Rspec::String.new(:data => msg))
+  expect(response).to be_rejected
+  expect(response.reason.class).to be Elementary::Errors::RPCFailure
+  expect(response.reason.message).to include("sample service not found failure")
+end
+
+def send_and_verify_connection_refused(msg)
+  response = client.invoke_error_service(Elementary::Rspec::String.new(:data => msg))
+  expect(response).to be_rejected
+  expect(response.reason.class).to be Elementary::Middleware::HttpStatusError
+  expect(response.reason.message).to include("connection refused: localhost:8090")
+end
+
+# This test requires ha-proxy to be listening at localhost:8080, but no real rpc to be available
+describe SampleElementaryClient, "http connection returning error code 503", :type => :integration do
+  subject (:client) {SampleElementaryClient.new(8070)}
+  describe "#initialize" do
+    it "creates a connection" do
+      expect(client.connection).not_to be_nil
+    end
+  end
+  describe "#invoke_error_service" do
+    context 'with http connection returning error code 503' do
+      it "invokes error service" do
+        send_and_verify_http_error_503('rspec1')
+      end
+    end
+  end
+end
+
+# This test requires that no process be listening at localhost:8090
+describe SampleElementaryClient, "http connection returning connection refused error", :type => :integration do
+  subject (:client) {SampleElementaryClient.new(8090)}
+  describe "#initialize" do
+    it "creates a connection" do
+      expect(client.connection).not_to be_nil
+    end
+  end
+  describe "#invoke_error_service" do
+    context 'with http connection failed' do
+      it "invokes error service" do
+        send_and_verify_connection_refused('rspec1')
+      end
+    end
+  end
+end
+
+# These tests requires ha-proxy to be listening at localhost:8080 routing requests to online rpc server
+describe SampleElementaryClient, "rpc requests returning non-connection related errors", :type => :integration do
+  subject (:client) {SampleElementaryClient.new(8080)}
+  describe "#initialize" do
+    it "creates a connection" do
+      expect(client.connection).not_to be_nil
+    end
+  end
+  describe "#invoke_bad_request_data_service", "handles http error 400" do
+    it "invokes bad request data service" do
+      send_and_verify_http_error_400('rspec1')
+    end
+  end
+  describe "#invoke_service_not_found_service", "handles http error 404" do
+    it "invokes service not found service" do
+      send_and_verify_http_error_404('rspec1')
+    end
+  end
+  describe "#invoke_service_returning_failure", "handles http error 500" do
+    it "invokes service returning failure" do
+      send_and_verify_http_error_500('rspec1')
+    end
+  end
+end

data/spec/support/clients/base_elementary_client.rb

@@ -0,0 +1,31 @@
+require 'elementary'
+
+class BaseElementaryClient
+  attr_accessor :connection
+
+  def invoke_error_service(request)
+    result = connection.rpc.error(request)
+    return handle(result)
+  end
+
+  def invoke_bad_request_data_service(request)
+    result = connection.rpc.bad_request_data_method(request)
+    return handle(result)
+  end
+
+  def invoke_service_not_found_service(request)
+    result = connection.rpc.service_not_found_method(request)
+    return handle(result)
+  end
+
+  def invoke_echo_service(request)
+    result = connection.rpc.echo(request)
+    return handle(result)
+  end
+
+  def handle(result)
+    result.value
+    return result
+  end
+
+end

data/spec/support/clients/elementary_client_using_anti_pattern.rb

@@ -0,0 +1,13 @@
+require 'elementary'
+
+class ElementaryClientUsingAntiPattern < BaseElementaryClient
+  # This class demonstrates an anti-pattern of creating connection
+  # at initialization only. Although it works mostly, this pattern should not be used,
+  # since the connection should be re-established any time the connection object becomes nil.
+
+  def initialize
+    @connection = Elementary::Connection.new(Elementary::Rspec::Simple,
+                                             :hosts => [{'host' => 'localhost', 'port' => '8090'}])
+  end
+end
+

data/spec/support/clients/sample_elementary_client.rb

@@ -0,0 +1,12 @@
+require 'elementary'
+
+class SampleElementaryClient < BaseElementaryClient
+  def initialize(port)
+    @port = port
+  end
+  def connection
+    return @connection if @connection
+    @connection = Elementary::Connection.new(Elementary::Rspec::Simple,
+                                             :hosts => [{'host' => 'localhost', 'port' => @port}])
+  end
+end

data/spec/support/proto/simpleservice.proto

@@ -9,4 +9,6 @@ message String {
 service Simple {
   rpc Echo (String) returns (String);
   rpc Error (String) returns (String);
+  rpc BadRequestDataMethod (String) returns (String);
+  rpc ServiceNotFoundMethod (String) returns (String);
 }

data/spec/support/simpleservice.pb.rb

@@ -28,6 +28,8 @@ module Elementary
     class Simple < ::Protobuf::Rpc::Service
       rpc :echo, ::Elementary::Rspec::String, ::Elementary::Rspec::String
       rpc :error, ::Elementary::Rspec::String, ::Elementary::Rspec::String
+      rpc :bad_request_data_method, ::Elementary::Rspec::String, ::Elementary::Rspec::String
+      rpc :service_not_found_method, ::Elementary::Rspec::String, ::Elementary::Rspec::String
     end
 
   end

data/spec/support/simpleservice.rb

@@ -1,4 +1,5 @@
 require './spec/support/simpleservice.pb'
+require 'protobuf/rpc/error'
 
 module Elementary
   module Rspec
@@ -13,6 +14,14 @@ module Elementary
       def error
         rpc_failed 'sample failure'
       end
+
+      def bad_request_data_method
+        fail ::Protobuf::Rpc::BadRequestData, 'sample bad request data failure'
+      end
+
+      def service_not_found_method
+        fail ::Protobuf::Rpc::ServiceNotFound, 'sample service not found failure'
+      end
     end
   end
 end

metadata

@@ -1,111 +1,111 @@
 --- !ruby/object:Gem::Specification
 name: elementary-rpc
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 2.0.0
 platform: ruby
 authors:
 - R. Tyler Croy
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-10-10 00:00:00.000000000 Z
+date: 2015-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
-  type: :development
+  name: bundler
   prerelease: false
+  type: :development
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
-  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  name: rake
   prerelease: false
+  type: :development
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: concurrent-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.7.0
-  type: :runtime
+  name: concurrent-ruby
   prerelease: false
+  type: :runtime
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.7.0
 - !ruby/object:Gem::Dependency
-  name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.9.0
-  type: :runtime
+  name: faraday
   prerelease: false
+  type: :runtime
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.9.0
 - !ruby/object:Gem::Dependency
-  name: net-http-persistent
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 2.9.4
-  type: :runtime
+  name: net-http-persistent
   prerelease: false
+  type: :runtime
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 2.9.4
 - !ruby/object:Gem::Dependency
-  name: lookout-statsd
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.9.0
-  type: :runtime
+  name: lookout-statsd
   prerelease: false
+  type: :runtime
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.9.0
 - !ruby/object:Gem::Dependency
-  name: hashie
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  name: hashie
   prerelease: false
+  type: :runtime
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: BLANK
@@ -115,8 +115,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
+- .gitignore
+- .rspec
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -129,16 +129,22 @@ files:
 - lib/elementary/future.rb
 - lib/elementary/middleware.rb
 - lib/elementary/middleware/dummy.rb
+- lib/elementary/middleware/raise_on_status.rb
 - lib/elementary/middleware/statsd.rb
 - lib/elementary/transport.rb
 - lib/elementary/transport/http.rb
 - lib/elementary/version.rb
 - spec/connection_spec.rb
+- spec/elementary_client_using_anti_pattern_spec.rb
 - spec/elementary_spec.rb
 - spec/executor_spec.rb
 - spec/future_spec.rb
 - spec/middleware/statsd_spec.rb
+- spec/sample_elementary_client_spec.rb
 - spec/spec_helper.rb
+- spec/support/clients/base_elementary_client.rb
+- spec/support/clients/elementary_client_using_anti_pattern.rb
+- spec/support/clients/sample_elementary_client.rb
 - spec/support/proto/simpleservice.proto
 - spec/support/simpleservice.pb.rb
 - spec/support/simpleservice.rb
@@ -147,33 +153,38 @@ homepage: ''
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
-signing_key: 
+rubyforge_project:
+rubygems_version: 2.4.5
+signing_key:
 specification_version: 4
 summary: Gem supporting Protobuf RPC in a simple way
 test_files:
 - spec/connection_spec.rb
+- spec/elementary_client_using_anti_pattern_spec.rb
 - spec/elementary_spec.rb
 - spec/executor_spec.rb
 - spec/future_spec.rb
 - spec/middleware/statsd_spec.rb
+- spec/sample_elementary_client_spec.rb
 - spec/spec_helper.rb
+- spec/support/clients/base_elementary_client.rb
+- spec/support/clients/elementary_client_using_anti_pattern.rb
+- spec/support/clients/sample_elementary_client.rb
 - spec/support/proto/simpleservice.proto
 - spec/support/simpleservice.pb.rb
 - spec/support/simpleservice.rb