el_finder 1.0.2 → 1.0.3

data/lib/el_finder/connector.rb

@@ -292,7 +292,8 @@ module ElFinder
 
     #
     def _edit
-      if perms_for(@target)[:write] == true
+      perms = perms_for(@target)
+      if perms[:read] == true && perms[:write] == true
         @target.open('w') { |f| f.write @params[:content] }
         @response[:file] = cdc_for(@target)
       else
@@ -321,7 +322,8 @@ module ElFinder
         command_not_implemented
       else
         if @target.file?
-          if perms_for(@target)[:write] == true
+          perms = perms_for(@target)
+          if perms[:read] == true && perms[:write] == true
             image_resize_handler.resize(@target, :width => @params[:width].to_i, :height => @params[:height].to_i)
             @response[:select] = [to_hash(@target)]
             _open(@current)

data/lib/el_finder/version.rb

@@ -1,3 +1,3 @@
 module ElFinder
-  VERSION = '1.0.2'
+  VERSION = '1.0.3'
 end 

data/test/test_el_finder.rb

@@ -565,6 +565,19 @@ class TestElFinder < Test::Unit::TestCase
     assert_not_equal 'Hello', File.read(File.join(@vroot, 'README.txt'))
   end
 
+  def test_edit_permissions_read
+    @elfinder.options = {
+      :perms => {
+        'README.txt' => {:read => false}
+      }
+    }
+    h, r = @elfinder.run(:cmd => 'open', :init => 'true', :target => '')
+    file = r[:cdc].find{|e| e[:name] == 'README.txt'}
+    h, r = @elfinder.run(:cmd => 'edit', :target => file[:hash], :content => 'Hello')
+    assert_match(/access denied/i, r[:error])
+    assert_not_equal 'Hello', File.read(File.join(@vroot, 'README.txt'))
+  end
+
   def test_resize_permissions_write
     @elfinder.options = {
       :perms => {
@@ -574,6 +587,21 @@ class TestElFinder < Test::Unit::TestCase
     h, r = @elfinder.run(:cmd => 'open', :init => 'true', :target => '')
     file = r[:cdc].find{|e| e[:name] == 'pjkh.png'}
     h, r = @elfinder.run(:cmd => 'resize', :target => file[:hash], :current => r[:cwd][:hash], :width => '50', :height => '25')
+    assert_match(/access denied/i, r[:error])
+    assert File.exist?(File.join(@vroot, 'pjkh.png'))
+    assert_equal '100x100', ElFinder::ImageSize.for(File.join(@vroot, 'pjkh.png')).to_s
+  end
+
+  def test_resize_permissions_read
+    @elfinder.options = {
+      :perms => {
+        'pjkh.png' => {:read => false}
+      }
+    }
+    h, r = @elfinder.run(:cmd => 'open', :init => 'true', :target => '')
+    file = r[:cdc].find{|e| e[:name] == 'pjkh.png'}
+    h, r = @elfinder.run(:cmd => 'resize', :target => file[:hash], :current => r[:cwd][:hash], :width => '50', :height => '25')
+    assert_match(/access denied/i, r[:error])
     assert File.exist?(File.join(@vroot, 'pjkh.png'))
     assert_equal '100x100', ElFinder::ImageSize.for(File.join(@vroot, 'pjkh.png')).to_s
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: el_finder
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 17
   prerelease: false
   segments: 
   - 1
   - 0
-  - 2
-  version: 1.0.2
+  - 3
+  version: 1.0.3
 platform: ruby
 authors: 
 - Philip Hallstrom
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-12-31 00:00:00 -08:00
+date: 2011-01-03 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency