einvoicing 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c103791ffce05b80340cbae5a1b09a00f4b5408edd8a70bfac567898be951ee9
-  data.tar.gz: 7db7faa121b1e2ab57c6ed9d467602eef8771a61acd57d0ea28eb53050ad9301
+  metadata.gz: 24047fa12d3baaca75ebea76468a98ee023e5716bdee7dfa90f7f532e13ab5d1
+  data.tar.gz: 934ca40e5c588c9593d39b839e13eabd413b34b3f36f56d5481e99dddb5a1b69
 SHA512:
-  metadata.gz: 5812428fa6b471a0cc5a34787e74fd473e3ffd5520226e736ce0fc6b144b054caf70c636f8b8b2a2acd834e4ff0d1f8db4bf47747b934e5dfa29e0d217333117
-  data.tar.gz: 1cf58d2a1cc101430435611c5091510ec62e48d9c2d0e33e01a827853aecf92ed69d1a57b9cc20a1d245e97768014ff350b669bf51c928d9892b18ebb21c13e4
+  metadata.gz: 54accf1d18eb7e32a35aba28d1c5c9f362eb1de5f19025b89c784724285ce59535394c603b9272a678a8bda7b1b13ae6f6a4dfca949528a303cf41a070681c43
+  data.tar.gz: 2eebc04105e663f581c83c6e81523aceba000188f0fc4b00c15138094d7659008bf59ce98b7afa5f867d875e307b806dbbea5281824d7d8c3eb11659976f7e86

data/config/locales/einvoicing.en.yml

@@ -25,3 +25,9 @@ en:
         quantity_invalid: "Line %{index}: quantity must be positive"
         unit_price_invalid: "Line %{index}: unit price must be non-negative"
         vat_rate_invalid: "Line %{index}: VAT rate must be a known French rate (0%%, 5.5%%, 10%%, 20%%)"
+    formats:
+      unknown_format: "Unknown format: %{fmt}. Use :cii or :ubl"
+      unknown_market: "Unknown market: %{market}. Use :fr"
+      invalid_pdf: "pdf_data does not appear to be a valid PDF (missing %PDF- magic bytes)"
+    tax:
+      invalid_rate: "rate must be >= 0, got %{rate}"

data/config/locales/einvoicing.fr.yml

@@ -25,3 +25,9 @@ fr:
         quantity_invalid: "Ligne %{index} : la quantité doit être positive"
         unit_price_invalid: "Ligne %{index} : le prix unitaire doit être non négatif"
         vat_rate_invalid: "Ligne %{index} : le taux de TVA doit être un taux français standard (0%%, 5,5%%, 10%%, 20%%)"
+    formats:
+      unknown_format: "Format inconnu : %{fmt}. Utilisez :cii ou :ubl"
+      unknown_market: "Marché inconnu : %{market}. Utilisez :fr"
+      invalid_pdf: "pdf_data ne semble pas être un PDF valide (octets magiques %PDF- manquants)"
+    tax:
+      invalid_rate: "le taux doit être >= 0, valeur reçue : %{rate}"

data/lib/einvoicing/formats/facturx.rb

@@ -31,7 +31,7 @@ module Einvoicing
       # @return [String] binary Factur-X PDF/A-3 content
       def self.embed(pdf_data, xml_string, profile: CONFORMANCE)
         unless pdf_data.to_s.b.start_with?("%PDF-")
-          raise ArgumentError, "pdf_data does not appear to be a valid PDF (missing %PDF- magic bytes)"
+          raise ArgumentError, Einvoicing::I18n.t("formats.invalid_pdf")
         end
 
         require "hexapdf"
@@ -66,7 +66,7 @@ module Einvoicing
         names_dict[:EmbeddedFiles][:Names] << FILENAME << filespec
 
         # 3. Set AF array on the catalog.
-        doc.catalog[:AF] = [filespec]
+        doc.catalog[:AF] = [ filespec ]
 
         # 4. Add OutputIntent (required for PDF/A-3 conformance).
         add_output_intent(doc)
@@ -183,7 +183,7 @@ module Einvoicing
           DestOutputProfile:         icc_stream
         })
 
-        doc.catalog[:OutputIntents] = [output_intent]
+        doc.catalog[:OutputIntents] = [ output_intent ]
       end
 
       private_class_method def self.md5(bytes)

data/lib/einvoicing/i18n.rb

@@ -1,22 +1,33 @@
 # frozen_string_literal: true
 
+require "i18n"
+
 module Einvoicing
-  # Thin wrapper around ::I18n with graceful fallback for standalone use.
-  # When used outside Rails, ::I18n may not be available; in that case the
-  # dotted key string is returned as-is.
+  # Thin wrapper around ::I18n for gem-internal translations.
+  # Loads the gem's own locale files on setup; in Rails apps the engine
+  # already handles the load_path, so duplicates are skipped.
   module I18n
     DEFAULT_LOCALE = :en
+    LOCALES_PATH = File.expand_path("../../config/locales", __dir__)
 
-    def self.t(key, **options)
-      return key.to_s unless defined?(::I18n)
+    def self.setup
+      locale_files = Dir[File.join(LOCALES_PATH, "*.yml")]
+      new_files = locale_files - ::I18n.load_path
+      return if new_files.empty?
+
+      ::I18n.load_path += new_files
+      ::I18n.backend.load_translations
+    end
 
-      locale = options.delete(:locale) { ::I18n.locale rescue DEFAULT_LOCALE }
+    def self.t(key, **options)
+      locale = options.delete(:locale) { ::I18n.locale }
       ::I18n.t("einvoicing.#{key}", locale: locale, **options)
     rescue ::I18n::MissingTranslationData
-      # Fallback to English if translation missing in current locale
       ::I18n.t("einvoicing.#{key}", locale: DEFAULT_LOCALE, **options)
     rescue StandardError
       key.to_s
     end
   end
 end
+
+Einvoicing::I18n.setup

data/lib/einvoicing/invoice.rb

@@ -88,7 +88,7 @@ module Einvoicing
     private
 
     def compute_tax_breakdown(lines)
-      grouped = lines.group_by { |l| [l.vat_rate, l.category] }
+      grouped = lines.group_by { |l| [ l.vat_rate, l.category ] }
       grouped.map do |(rate, category), rate_lines|
         taxable = rate_lines.sum(BigDecimal("0"), &:net_amount).round(2, :half_up)
         tax_amt = rate_lines.sum(BigDecimal("0"), &:vat_amount).round(2, :half_up)

data/lib/einvoicing/party.rb

@@ -27,13 +27,13 @@ module Einvoicing
       resolved_endpoint_id = endpoint_id || siret || email
       resolved_endpoint_scheme = if endpoint_scheme
                                    endpoint_scheme
-                                 elsif endpoint_id
+      elsif endpoint_id
                                    nil  # caller must supply scheme when explicit
-                                 elsif siret
+      elsif siret
                                    "0002"  # SIRET scheme — Peppol EAS FR standard
-                                 elsif email
+      elsif email
                                    "EM"    # email fallback (not in Peppol EAS, use for non-Peppol)
-                                 end
+      end
       super(name: name, street: street, city: city, postal_code: postal_code,
             country_code: country_code, siren: siren, siret: siret,
             vat_number: vat_number, email: email,

data/lib/einvoicing/tax.rb

@@ -11,7 +11,7 @@ module Einvoicing
     # @param tax_amount [Numeric] VAT amount for this rate
     # @param category [Symbol, nil] nil for standard/zero, :reverse_charge for AE
     def initialize(rate:, taxable_amount:, tax_amount:, category: nil)
-      raise ArgumentError, "rate must be >= 0, got #{rate}" if rate.to_f.negative?
+      raise ArgumentError, Einvoicing::I18n.t("tax.invalid_rate", rate: rate) if rate.to_f.negative?
 
       super
     end

data/lib/einvoicing/validators/fr.rb

@@ -159,8 +159,8 @@ module Einvoicing
 
       def self.validate_lines(lines)
         if lines.nil? || lines.empty?
-          return [{ field: :lines, error: :lines_empty,
-                    message: Einvoicing::I18n.t("errors.invoice.lines_empty") }]
+          return [ { field: :lines, error: :lines_empty,
+                    message: Einvoicing::I18n.t("errors.invoice.lines_empty") } ]
         end
 
         lines.each_with_index.flat_map do |line, idx|
@@ -178,7 +178,7 @@ module Einvoicing
                { field: :"line_#{n}_unit_price", error: :unit_price_invalid,
                  message: Einvoicing::I18n.t("errors.line.unit_price_invalid", index: n) }
              end),
-            (unless [0.0, 0.055, 0.10, 0.20].include?(line.vat_rate.to_f.round(3))
+            (unless [ 0.0, 0.055, 0.10, 0.20 ].include?(line.vat_rate.to_f.round(3))
                { field: :"line_#{n}_vat_rate", error: :vat_rate_invalid,
                  message: Einvoicing::I18n.t("errors.line.vat_rate_invalid", index: n) }
              end)

data/lib/einvoicing/validators/peppol.rb

@@ -86,18 +86,18 @@ module Einvoicing
       private_class_method :download
 
       def self.run_saxon(xml_string)
-        input  = Tempfile.new(["peppol-input",  ".xml"])
-        output = Tempfile.new(["peppol-output", ".svrl"])
+        input  = Tempfile.new([ "peppol-input",  ".xml" ])
+        output = Tempfile.new([ "peppol-output", ".svrl" ])
 
         begin
           input.write(xml_string)
           input.close
           output.close
 
-          cmd = ["java", "-jar", SAXON_JAR,
+          cmd = [ "java", "-jar", SAXON_JAR,
                  "-s:#{input.path}",
                  "-xsl:#{XSLT_PATH}",
-                 "-o:#{output.path}"]
+                 "-o:#{output.path}" ]
 
           _, stderr, status = Open3.capture3(*cmd)
 

data/lib/einvoicing/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Einvoicing
-  VERSION = "0.5.0"
+  VERSION = "0.6.0"
 end

data/lib/einvoicing/xml_builder.rb

@@ -5,7 +5,7 @@ module Einvoicing
   # Produces indented XML with proper attribute and text escaping.
   class XMLBuilder
     def initialize
-      @parts = ['<?xml version="1.0" encoding="UTF-8"?>']
+      @parts = [ '<?xml version="1.0" encoding="UTF-8"?>' ]
       @depth = 0
     end
 

data/lib/einvoicing.rb

@@ -61,7 +61,7 @@ module Einvoicing
     case format
     when :cii then Formats::CII.generate(invoice)
     when :ubl then Formats::UBL.generate(invoice)
-    else raise ArgumentError, "Unknown format: #{format.inspect}. Use :cii or :ubl"
+    else raise ArgumentError, Einvoicing::I18n.t("formats.unknown_format", fmt: format.inspect)
     end
   end
 
@@ -81,7 +81,7 @@ module Einvoicing
   def self.validate(invoice, market: :fr)
     case market
     when :fr then Validators::FR.validate(invoice)
-    else raise ArgumentError, "Unknown market: #{market.inspect}. Use :fr"
+    else raise ArgumentError, Einvoicing::I18n.t("formats.unknown_market", market: market.inspect)
     end
   end
 
@@ -98,6 +98,6 @@ module Einvoicing
     pdf_out = pdf ? embed(pdf, xml_str) : nil
     { valid: errors.empty?, errors: errors, xml: xml_str, pdf: pdf_out }
   rescue StandardError => e
-    { valid: false, errors: [{ field: :unknown, error: :exception, message: e.message }], xml: nil, pdf: nil }
+    { valid: false, errors: [ { field: :unknown, error: :exception, message: e.message } ], xml: nil, pdf: nil }
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: einvoicing
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Nathan Le Ray
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: i18n
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -44,14 +58,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.65'
+        version: '1.70'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.65'
+        version: '1.70'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails-omakase
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement