einvoice 1.3 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8073afaa58225b965eeed8fb135712ab8b1b76c95b759324f35e875bf9eacb32
-  data.tar.gz: ed9440ffcba86cdbf84e98b0030fb3e53c9e1b7418551c99cd102639c4921712
+  metadata.gz: 2393870fedb2a46c8a29d7c903b109080499b621904e46d45b505c33e8e3147c
+  data.tar.gz: c8ad7c8e9e6674887af0458bc00ed362e182ad39a2d30d7a4624f537e96e1c0d
 SHA512:
-  metadata.gz: f0d297e2b70749e83b4ebf531ee49597d72ee6404a295eb3abd03c6e68e06da500cbbdfc6fe556fb8be761786b1ef4a9b11626e7e5758eda12f0cbf13420ba1d
-  data.tar.gz: 75ca49a608cbd45bcc1fdc8575183d98ab079ec18684e073da6e944fc77f63eaa072e9e87d32e360ee8bda102dcccc9ed9b01fb3853d7a842d67368cd7de0f48
+  metadata.gz: d44581204a25dcd2f434510535ae5d5803263310ecbb6431590c5c9bc7398a10e63c0d9391c12d86417a2040cc5031c884fba915e7015c394ff32e14ed880801
+  data.tar.gz: 4076e9ef62d58aba07a0261dfee0b989d58a6eb41ade8b582e1770fde2f1f709e7a6308260a6b3312221454b1e97651489343cfc63beba4d8e86d9189868a10e

data/.github/workflows/build.yml

@@ -30,7 +30,10 @@ jobs:
       - name: Run tests
         run: bundle exec rspec
 
-      - name: Publish code coverage
-        uses: paambaati/codeclimate-action@v9
-        env:
-          CC_TEST_REPORTER_ID: 134e1f1cc8b60db4f2a491152c9227a6dbbfbeba5c1d05ee8b44cd78a1069f28
+      - name: Upload coverage to Codecov
+        if: matrix.ruby-version == '3.4'
+        uses: codecov/codecov-action@v5
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          files: ./coverage/lcov.info
+          fail_ci_if_error: true

data/.github/workflows/cron.yml

@@ -2,17 +2,30 @@ name: Daily update
 on:
   schedule:
     - cron: 0 0 * * *
+  workflow_dispatch:
+
+permissions:
+  contents: write
+
 jobs:
   build:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-ruby@v1
-    - name: bundle and run rake update
+    - uses: actions/checkout@v4
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: '3.3'
+        bundler-cache: true
+    - name: Update donation unit list
+      run: bundle exec rake update_donation_unit
+    - name: Commit and push changes
       run: |
-        bundle install --jobs 4 --retry 3
-        bundle exec rake update_donation_unit
-    - uses: mikeal/publish-to-github-action@master
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        BRANCH_NAME: 'main'
+        if git diff --quiet; then
+          echo "Donation unit list is up to date"
+          exit 0
+        fi
+        git config user.name "github-actions[bot]"
+        git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
+        git add lib/einvoice/donation_unit_list.json
+        git commit -m "Automated donation unit list update"
+        git push

data/CHANGELOG.md

@@ -0,0 +1,53 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/).
+
+## [1.4.0] - 2026-08-08
+
+### Changed
+- **TLS certificate verification is now enabled by default.** Previously every
+  request was sent with `ssl: { verify: false }`, regardless of configuration.
+  If you were relying on that behavior (e.g. against an endpoint with an
+  incomplete certificate chain), set `config.ssl_verify = false` or pass
+  `ssl_verify: false` to `Provider.new` to restore the old behavior.
+- `Client` now delegates to the provider via `public_send` instead of `send`,
+  and implements `respond_to_missing?`. Private provider methods (e.g.
+  `encrypt`, `connection`) are no longer reachable through `Client`.
+
+### Fixed
+- `TotalValidator` comparison was inverted and compared a `String` against an
+  `Integer`, so it never actually validated anything. It now correctly fails
+  when `total` doesn't match the sum of item totals.
+- `AllowanceNumberValidator` and `IssueItem#invoiceTime`'s format regexp had
+  broken escape sequences (`\A` and `\d` collapsing to literal characters in a
+  double-quoted string), causing them to reject all valid input.
+- `ItemListValidator` pushed directly onto `record.errors[:itemList]`, which
+  is deprecated in Rails 6.1 and removed in 7.0. It now uses `errors.add` and
+  actually registers errors again.
+- Tradevan response decoding used `JSON.load`, which is unsafe for untrusted
+  input. Switched to `JSON.parse`.
+- `lib/einvoice/donation_unit_list.json` was stale since 2023-12 (the
+  scheduled update workflow had been silently broken), causing
+  `DonationUnitValidator` to reject currently valid donation codes and accept
+  retired ones. The list has been refreshed (~340 entries changed).
+
+### Added
+- Specs for `Client` delegation, `Configuration#ssl_verify`,
+  `Provider#connection` SSL behavior, the validator fixes above, and the
+  previously-untested `decode_tradevan` middleware.
+
+### Internal
+- CI coverage reporting migrated from Code Climate (discontinued) to Codecov.
+- The scheduled `cron.yml` workflow that refreshes the donation unit list
+  has been repaired — it depended on two archived GitHub Actions
+  (`actions/setup-ruby`, `mikeal/publish-to-github-action`) and hadn't run
+  successfully since 2023-12.
+
+---
+
+Versions prior to 1.4.0 were not tracked in this file. See the
+[release history](https://github.com/abookyun/einvoice/releases) and
+[commit log](https://github.com/abookyun/einvoice/commits/main/) for earlier changes.

data/Gemfile

@@ -3,7 +3,6 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in einvoice.gemspec
 gemspec
 
-# Integrate CodeClimate Code Coverage into TravisCI
-# https://github.com/codeclimate/test-reporter/issues/413
-gem 'simplecov', require: false, group: :test
-gem "simplecov_json_formatter", require: false, group: :test
+gem "ostruct", require: false, group: :development
+gem "simplecov", require: false, group: :test
+gem "simplecov-lcov", require: false, group: :test

data/README.md

@@ -1,7 +1,6 @@
 # Einvoice
 [![Build Status](https://github.com/abookyun/einvoice/actions/workflows/build.yml/badge.svg)](https://github.com/abookyun/einvoice/actions/workflows/build.yml)
-[![Code Climate](https://codeclimate.com/github/abookyun/einvoice/badges/gpa.svg)](https://codeclimate.com/github/abookyun/einvoice)
-[![Test Coverage](https://codeclimate.com/github/abookyun/einvoice/badges/coverage.svg)](https://codeclimate.com/github/abookyun/einvoice/coverage)
+[![codecov](https://codecov.io/github/abookyun/einvoice/graph/badge.svg?token=yxJNmXiUyp)](https://codecov.io/github/abookyun/einvoice)
 
 ## What's E-Invoice
 
@@ -42,8 +41,25 @@ Einvoice.configure do |config|
   config.client_secret = ENV['EINVOICE_CLIENT_SECRET']
   config.encryption_keys = ENV['ENCRYPTION_KEYS']
   config.format = "json"
+  # config.ssl_verify = false # disable TLS certificate verification (default: true)
 end
 ```
+### SSL certificate verification
+
+By default, `einvoice` verifies the TLS certificate of the configured
+endpoint (`config.ssl_verify` defaults to `true`). If you need to disable
+this — for example when testing against an endpoint with an incomplete
+certificate chain — you can opt out:
+
+```ruby
+config.ssl_verify = false
+```
+
+Or per-provider:
+
+```ruby
+Einvoice::Tradevan::Provider.new(ssl_verify: false)
+```
 
 ### Initialize
 

data/lib/einvoice/client.rb

@@ -7,7 +7,15 @@ module Einvoice
     end
 
     def method_missing(m, *args, &block)
-      provider.send(m, *args, &block)
+      if provider.respond_to?(m)
+        provider.public_send(m, *args, &block)
+      else
+        super
+      end
+    end
+
+    def respond_to_missing?(m, include_private = false)
+      provider.respond_to?(m) || super
     end
   end
 end

data/lib/einvoice/configuration.rb

@@ -8,7 +8,8 @@ module Einvoice
       :client_id,
       :client_secret,
       :encryption_keys,
-      :format
+      :format,
+      :ssl_verify
     ].freeze
 
     DEFAULT_CLIENT_ID = nil
@@ -17,6 +18,7 @@ module Einvoice
     DEFAULT_ENDPOINT_URL = nil
     DEFAULT_FORMAT = ""
     DEFAULT_ENCRYPTION_KEYS = {}
+    DEFAULT_SSL_VERIFY = true
 
     attr_accessor *VALID_OPTIONS_KEYS
 
@@ -41,6 +43,7 @@ module Einvoice
       self.endpoint_url    = DEFAULT_ENDPOINT_URL
       self.encryption_keys = DEFAULT_ENCRYPTION_KEYS
       self.format          = DEFAULT_FORMAT
+      self.ssl_verify      = DEFAULT_SSL_VERIFY
     end
   end
 end

data/lib/einvoice/connection.rb

@@ -8,7 +8,8 @@ module Einvoice
     def connection(options = {})
       connection_options = {
         headers: { "Accept" => "application/#{format}; charset=utf-8" },
-        url: endpoint
+        url: endpoint,
+        ssl: { verify: ssl_verify != false }
       }.merge(options)
 
       ::Faraday::Connection.new(connection_options) do |connection|