ehon 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 26332159b5ba10a4e88371c85265c39a3a088f8a
-  data.tar.gz: a7a7588f7a1b3fd8fea85c18464eec0f750957cc
+  metadata.gz: bcd69fa42ac239571bb6f7baafaf8c55aa9e6772
+  data.tar.gz: 489e87a3f7a78fef9496c8e7f587eab0e4b99b21
 SHA512:
-  metadata.gz: da617d040c65e82e0b3e6c569a27855baa70509b35cd2bf91bf173e07ba7336b6c61664a04f4efc1538af2dc419094f96408366f59913b2a88471dff2a24929d
-  data.tar.gz: 77abcc82ffabafec73fb62fb2181df3a31d65a25465d46c9d420a5207cc669b882b01d1149328c2ebe6ea9de960a21025183ca8dd7cb263f59a93054760a2aa2
+  metadata.gz: f68deac97792f5c76523edc1b328af422698fdeb714ee87c076398b3100e4813c7d39e7ce6a3178b572cff7a63c7e7df84a0d23dfcda813bc84fdeb024274fa3
+  data.tar.gz: 852faeb8faf196d081cd9df96ce74ca9b6b9610e99d71a6f8e8aea186e595949f25d156c02750ce0eafe22fd127bafc6d4c6b57e24b3840ab3f909f7cfccd970

data/README.md

@@ -67,7 +67,7 @@ DeviceTypel::IOS.android? #=> false
 
 ## Contributing
 
-1. Fork it ( http://github.com/<my-github-username>/ehon/fork )
+1. Fork it ( http://github.com/hekk/ehon/fork )
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)

data/lib/ehon.rb

@@ -24,10 +24,14 @@ module Ehon
   end
 
   def method_missing(symbol, *args)
-    return self.options[symbol] if respond_to?(symbol)
+    return read_attribute(symbol) if respond_to?(symbol)
     super
   end
 
+  def read_attribute(symbol)
+    self.options[symbol]
+  end
+
   module ClassMethods
     attr_accessor :contents, :default_options
 
@@ -52,7 +56,7 @@ module Ehon
       findeds = queries.map {|query|
         next self.contents[query] unless query.is_a?(Hash)
         self.contents.values.find {|instance|
-          query.all? {|key, value| instance.options[key] == value }
+          query.all? {|key, value| instance.read_attribute(key) == value }
         }
       }.compact
       queries.size == 1 ? findeds.first : findeds

data/lib/ehon/version.rb

@@ -1,3 +1,3 @@
 module Ehon
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/ehon_spec.rb

@@ -71,6 +71,22 @@ describe Ehon do
           end
         end
       end
+
+      context 'with string key hash' do
+        let(:name) { 'scroll' }
+
+        before do
+          @instance = subject.page(1, 'name' => name)
+        end
+
+        it 'should not be able to respond to name' do
+          expect(@instance).to_not be_respond_to(:name)
+        end
+
+        it 'should be able to fetch name through read_attribute' do
+          expect(@instance.read_attribute('name')).to eq(name)
+        end
+      end
     end
 
     context 'with default options' do
@@ -82,7 +98,7 @@ describe Ehon do
       end
 
       it "should has default option {key: 'value'}" do
-        expect(Item.default_options).to eq({key: 'value'})
+        expect(subject.default_options).to eq({key: 'value'})
       end
 
       it "instacne should respond to key and return 'value'" do
@@ -108,6 +124,29 @@ describe Ehon do
         expect(@instance_without_block).to_not be_respond_to(:potion?)
       end
     end
+
+    context 'custom method' do
+      before do
+        class Item
+          def name
+            name  = read_attribute(:name)
+            value = read_attribute(:value)
+            "%s(%d)" % [name, value]
+          end
+        end
+        @instance = subject.page(1, name: 'potion', value: 5)
+      end
+
+      after do
+        class Item
+          remove_method :name
+        end
+      end
+
+      it 'should override name attribute' do
+        expect(@instance.name).to eq('potion(5)')
+      end
+    end
   end
 
   describe '#==(other)' do
@@ -274,10 +313,10 @@ describe Ehon do
     end
 
     context 'with id and query' do
-        it "find with `[1, {value: 10}]` should return item id `potion` and `high potion`" do
-          finded = subject.find([1, {value: 10}])
-          expect(finded.map(&:name)).to eq(['potion', 'high potion'])
-        end
+      it "find with `[1, {value: 10}]` should return item id `potion` and `high potion`" do
+        finded = subject.find([1, {value: 10}])
+        expect(finded.map(&:name)).to eq(['potion', 'high potion'])
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ehon
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Tomohiro Nishimura