effective_test_bot 1.1.2 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2a36dd85a7f66b33cf3fdc0508b65b1770a1422e3a13d894b514adedaec140aa
-  data.tar.gz: 8a0c3fbad9e4e215daeeb8c9dd3e0218a645b4cc279b8ebaf198d3c5f6ac8c3b
+  metadata.gz: eb70d79c59a6971cd71b7473836a0c8d32bddc718b88f1643c8859be73393c01
+  data.tar.gz: 2758973ff90e358433c44a528691425863ccadcdd58840737ea5c78a0d27923d
 SHA512:
-  metadata.gz: b650ba5b81172e4a22fc8cc41d195fa909abe04cdf2ccb2488956563f797d16dee3a935e88375302af9d8794867f023bde921672f590b915978dd8b50d68122d
-  data.tar.gz: 77a754437f4d2d614bcf1219eb8de8602b90e695d702a22c58ffe11305304e7581bae115257637876c5fb53e44a1cc36a93ef3acf3d9f39f9294f80568c28618
+  metadata.gz: f11567a699e875251431ca2d96232aed6e1c35c910f8d54fc4e732f7fe9f5b53c9312077f054cead0951f591d161c20cc6f3a02b76f0e07bf2918e54dd65831a
+  data.tar.gz: 528f4cd925c04064df27a94bc80180ad92c99bfd6d466cf09cab8966afc3d068d96c49ac4152915524eb30ca6fa50426d14f932bacbdba54afe9e1dd12c5cfbe

data/README.md

@@ -531,8 +531,8 @@ rails test:bot:fails
 # Only runs failed tests and stops after first failure
 rails test:bot:fails
 
-# Purges all screenshots and fails
-rails test:bot:purge
+# Clobber (delete) all screenshots and fails
+rails test:bot:clobber
 ```
 
 ## Animated gifs and screenshots
@@ -584,7 +584,7 @@ To delete all tour and autosave on failure animated .gifs, run the following:
 
 ```
 # Deletes all tour and failure animated .gifs
-rails test:bot:purge
+rails test:bot:clobber
 ```
 
 As well, to enable tour mode when running the standard `rails test`:

data/config/effective_test_bot.rb

@@ -47,9 +47,9 @@ if Rails.env.test?
     # Also enabled the crud_test #tour type tests
     #
     # You can override this default by setting an ENV or calling
-    # `rake test:bot TOUR=true` or `rake test:bot TEST=posts TOUR=verbose`
+    # `rake test:bot TOUR=true` or `rake test:bot TEST=posts TOUR=extreme`
     #
-    # Valid values are true / false / :verbose
+    # Valid values are true / false / :extreme
     config.tour_mode = false
 
     # Rmagick gem is required for animated gifs

data/lib/effective_test_bot.rb

@@ -95,7 +95,7 @@ module EffectiveTestBot
 
   def self.tour_mode?
     if ENV['TOUR'].present?
-      ['true', 'extreme', 'verbose', 'debug'].include?(ENV['TOUR'].to_s.downcase)
+      ENV['TOUR'].to_s != 'false'
     else
       screenshots? && (tour_mode != false)
     end
@@ -110,14 +110,6 @@ module EffectiveTestBot
     end
   end
 
-  def self.tour_mode_verbose?
-    if ENV['TOUR'].present?
-      ['true', 'extreme', 'verbose', 'debug'].include?(ENV['TOUR'].to_s.downcase)
-    else
-      screenshots? && ['extreme', 'verbose', 'debug'].include?(tour_mode.to_s)
-    end
-  end
-
   def self.passed_tests
     @@passed_tests ||= load_passed_tests
   end
@@ -129,10 +121,11 @@ module EffectiveTestBot
   end
 
   def self.save_passed_test(name)
-    EffectiveTestBot.passed_tests[name] = true
+    return if EffectiveTestBot.passed_tests[name] == true
 
+    EffectiveTestBot.passed_tests[name] = true
     Dir.mkdir(passed_tests_path) unless File.exist?(passed_tests_path)
-    File.open(passed_tests_filename, 'w') { |file| passed_tests.each { |test_name, _| file.puts(test_name) } }
+    File.open(passed_tests_filename, 'a') { |file| file.puts(name) }
   end
 
   private

data/lib/effective_test_bot/version.rb

@@ -1,3 +1,3 @@
 module EffectiveTestBot
-  VERSION = '1.1.2'.freeze
+  VERSION = '1.1.3'.freeze
 end

data/lib/tasks/effective_test_bot_tasks.rake

@@ -10,7 +10,7 @@
 
 # rails test:bot:seed
 # rails test:bot:environment
-# rails test:bot:purge
+# rails test:bot:clobber
 
 # rails test:bot:tours
 # rails test:bot:tours TEST=documents
@@ -54,10 +54,10 @@ namespace :test do
     end
 
     desc 'Deletes all effective_test_bot temporary, failure and tour screenshots'
-    task :purge do
+    task :clobber do
       FileUtils.rm_rf(Rails.root + 'test/tours')
       FileUtils.rm_rf(Rails.root + 'tmp/test_bot')
-      puts "Successfully purged all effective_test_bot screenshots"
+      puts "Successfully clobbered all effective_test_bot screenshots"
     end
 
     desc 'Runs effective_test_bot environment test in tour mode'

data/test/concerns/test_botable/base_dsl.rb

@@ -42,7 +42,7 @@ module TestBotable
           raise 'expected resource to be a Class or Instance or String' unless obj.kind_of?(Class) || obj.kind_of?(ActiveRecord::Base) || obj.kind_of?(String)
 
           if obj.kind_of?(String) # Let's assume this is a controller, 'admin/jobs', or just 'jobs', or 'jobs_controller'
-            obj.sub!('_controller', '')
+            obj = obj.sub('_controller', '')
 
             (*namespace, klass) = obj.split('/')
             namespace = Array(namespace).join('/').presence

data/test/support/effective_test_bot_assertions.rb

@@ -102,7 +102,7 @@ module EffectiveTestBotAssertions
   end
 
   def assert_no_ajax_requests(message: "(no_ajax_requests) :count: Unexpected AJAX requests present")
-    active = page.evaluate_script('$.active')
+    active = (page.evaluate_script('$.active') rescue nil)
     assert (active.blank? || active.zero?), message.sub(':count:', active.to_s)
   end
 
@@ -117,7 +117,13 @@ module EffectiveTestBotAssertions
   end
 
   def assert_no_js_errors(message: nil, strict: false)
-    error = (page.driver.browser.manage.logs.get(:browser).first rescue '') # headless_chrome
+    error = ''
+
+    begin
+      error = page.driver.browser.manage.logs.get(:browser).first # headless_chrome
+    rescue NotImplementedError
+      return
+    end
 
     if strict == false
       return if error.to_s.include?('Failed to load resource')
@@ -134,14 +140,14 @@ module EffectiveTestBotAssertions
   # It ensures there are no HTML5 validation errors that would prevent the form from being submit
   # Browsers seem to only consider visible fields, so we will to
   def assert_no_html5_form_validation_errors(message: nil)
-    errors = all(':invalid', visible: true).map { |field| field['name'] }
+    errors = all(':invalid', visible: true, wait: false).map { |field| field['name'] }
     assert errors.blank?, message || "(no_html5_form_validation_errors) Unable to submit form, unexpected HTML5 validation error present on the following fields:\n#{errors.join("\n")}"
   end
 
   # Rails jquery-ujs data-disable-with
   # = f.button :submit, 'Save', data: { disable_with: 'Saving...' }
   def assert_jquery_ujs_disable_with(label = nil, message: nil)
-    submits = label.present? ? all("input[type='submit']", text: label) : all("input[type='submit']")
+    submits = label.present? ? all("input[type='submit']", text: label, wait: false) : all("input[type='submit']", wait: false)
     all_disabled_with = submits.all? { |submit| submit['data-disable-with'].present? }
 
     assert all_disabled_with, message || "(jquery_ujs_disable_with) Expected rails jquery-ujs data-disable-with to be present on #{(label || "all input[type='submit'] fields")}\nInclude it on your submit buttons by adding \"data: { disable_with: 'Saving...' }\""

data/test/support/effective_test_bot_form_faker.rb

@@ -41,9 +41,9 @@ module EffectiveTestBotFormFaker
         end
       elsif classes.include?('numeric')
         value_for_input_numeric_field(field, "input.numeric[name$='[#{attribute}]']")
-      elsif classes.include?('email') || attribute.include?('email')
+      elsif classes.include?('email') || classes.include?('effective_email') || attribute.include?('email')
         Faker::Internet.email
-      elsif classes.include?('price') # effective_form_inputs price
+      elsif classes.include?('price') || classes.include?('effective_price')
         4.times.map { DIGITS.sample }.join('') + '.00'
       elsif classes.include?('numeric') || classes.include?('effective_number_text') || classes.include?('effective_integer') || attribute.include?('number')
         min = (Float(field['min']) rescue 1)
@@ -135,19 +135,35 @@ module EffectiveTestBotFormFaker
   private
 
   def fill_value_for_field(fills, attributes, value, field_name)
-    return if fills.blank? || (attributes.blank? && value.blank?)
+    return nil if fills.blank? || (attributes.blank? && value.blank?)
 
+    fill = nil
+
+    # Match by attributes
     key = nil
+
     attributes.reverse_each do |name|  # match last_name, then something_attributes.last_name, then user.something_attributes.last_name
       key = (key.present? ? "#{name}.#{key}" : name) # builds up the string as we go along
 
-      return :unselect if field_name == 'select' && fills.key?(key) && [nil, ''].include?(fills[key])
-      return fills[key].to_s if fills.key?(key)
+      if fills.key?(key)
+        fill = fills[key].to_s
+        fill = :unselect if field_name == 'select' && fills[key].blank?
+      end
+
+      break if fill.present?
     end
 
-    return fills[value] if fills.key?(value)
+    # Match by value
+    fill ||= fills[value]
+
+    # If this is a file field, make sure the file is present at Rails.root/test/fixtures/
+    if fill.present? && field_name == 'input_file'
+      filename = (fill.to_s.include?('/') ? fill : "#{Rails.root}/test/fixtures/#{fill}")
+      raise("Warning: Unable to load fill file #{fill}. Expected file #{filename}") unless File.exists?(filename)
+      return filename
+    end
 
-    nil
+    fill.presence
   end
 
   def value_for_input_select_field(field, fill_value)
@@ -155,7 +171,7 @@ module EffectiveTestBotFormFaker
     country_code = field['name'].to_s.include?('country_code')
 
     if fill_value.present? # accept a value or text
-      field.all('option:enabled').each do |option|
+      field.all('option:enabled', wait: false).each do |option|
         if (option.text == fill_value || option.value.to_s == fill_value)
           @filled_country_fields = option.value if country_code
           return option.text
@@ -163,7 +179,7 @@ module EffectiveTestBotFormFaker
       end
     end
 
-    option = field.all('option:enabled').select { |option| option.value.present? }.sample
+    option = field.all('option:enabled', wait: false).select { |option| option.value.present? }.sample
 
     @filled_country_fields = option.try(:value) if country_code # So Postal Code can be set to a valid one
 
@@ -231,7 +247,7 @@ module EffectiveTestBotFormFaker
 
     return number if field['max'].blank?
 
-    shared_max_fields = all(selector)
+    shared_max_fields = all(selector, wait: false)
     return number if shared_max_fields.length <= 1
 
     # So there's definitely 2+ fields that share the same max, named the same

data/test/support/effective_test_bot_form_filler.rb

@@ -6,7 +6,7 @@ module EffectiveTestBotFormFiller
 
   # Fill a boostrap tabs based form
   def fill_bootstrap_tabs_form(fills = {})
-    tabs = all("a[data-toggle='tab']")
+    tabs = all("a[data-toggle='tab']", wait: false)
 
     # If there's only 1 tab, just fill it out
     (fill_form_fields(fills) and return) unless tabs.length > 1
@@ -16,7 +16,7 @@ module EffectiveTestBotFormFiller
     # Then we start at the first, and go left-to-right through all the tabs
     # clicking each one and filling any form fields found within
 
-    active_tab = all("li.active > a[data-toggle='tab']").first
+    active_tab = all("li.active > a[data-toggle='tab']", wait: false).first
 
     tab_content = if active_tab && active_tab['href'].present?
       find('div' + active_tab['href']).find(:xpath, '..')
@@ -25,7 +25,7 @@ module EffectiveTestBotFormFiller
     excluding_fields_with_parent(tab_content) { fill_form_fields(fills) }
 
     # Refresh the tabs, as they may have changed
-    tabs = all("a[data-toggle='tab']")
+    tabs = all("a[data-toggle='tab']", wait: false)
 
     # Click through each tab and fill the form inside it.
     tabs.each do |tab|
@@ -39,7 +39,7 @@ module EffectiveTestBotFormFiller
     end
 
     # If there is no visible submits, go back to the first tab
-    if all(:css, "input[type='submit']").length == 0
+    if all("input[type='submit']", wait: false).length == 0
       tabs.first.click()
       synchronize!
       save_test_bot_screenshot
@@ -55,7 +55,7 @@ module EffectiveTestBotFormFiller
 
     5.times do 
       # Support for the cocoon gem
-      fields = all('a.add_fields[data-association-insertion-template],a.has_many_add').reject { |field| seen[field_key(field)] }
+      fields = all('a.add_fields[data-association-insertion-template],a.has_many_add', wait: false).reject { |field| seen[field_key(field)] }
 
       fields.each do |field|
         seen[field_key(field)] = true
@@ -108,7 +108,7 @@ module EffectiveTestBotFormFiller
         when 'select', 'select_select-one', 'select_select-multiple'
           fill_input_select(field, value)
         when 'input_file'
-          fill_input_file(file, value)
+          fill_input_file(field, value)
         when 'input_submit', 'input_search', 'input_button'
           skip_field_screenshot = true # Do nothing
         else
@@ -171,20 +171,18 @@ module EffectiveTestBotFormFiller
   end
 
   def fill_input_select(field, value)
-    if EffectiveTestBot.tour_mode_extreme? && field['class'].to_s.include?('select2') # select2
+    if EffectiveTestBot.tour_mode_extreme? && select2_input?(field)
       try_script "$('select##{field['id']}').select2('open')"
       save_test_bot_screenshot
     end
 
-    if field.all('option:enabled').length > 0 && value != :unselect
+    if field.all('option:enabled', wait: false).length > 0 && value != :unselect
       Array(value).each do |value|
         field.select(value.to_s, match: :first, disabled: false)
       end
     end
 
-    if field['class'].to_s.include?('select2')
-      try_script "$('select##{field['id']}').select2('close')"
-    end
+    close_effective_select(field)
   end
 
   def fill_input_file(field, value)
@@ -244,9 +242,20 @@ module EffectiveTestBotFormFiller
   end
 
   def clear_effective_select(field)
+    return unless effective_select_input?(field)
     try_script "$('select##{field['id']}').val('').trigger('change.select2')"
   end
 
+  def close_effective_select(field)
+    return unless effective_select_input?(field)
+    try_script "$('select##{field['id']}').select2('close')"
+  end
+
+  def close_effective_date_time_picker(field)
+    return unless effective_date_input?(field)
+    # TODO
+  end
+
   private
 
   # Takes a capybara element
@@ -258,13 +267,25 @@ module EffectiveTestBotFormFiller
 
   def ckeditor_text_area?(field)
     return false unless field.tag_name == 'textarea'
-    (field['class'].to_s.include?('ckeditor') || all("span[id='cke_#{field['id']}']").present?)
+    (field['class'].to_s.include?('ckeditor') || all("span[id='cke_#{field['id']}']", wait: false).present?)
   end
 
   def custom_control_input?(field) # Bootstrap 4 radios and checks
     field['class'].to_s.include?('custom-control-input')
   end
 
+  def effective_date_input?(field)
+    field['class'].to_s.include?('effective_date')
+  end
+
+  def file_input?(field)
+    field['type'] == 'file'
+  end
+
+  def effective_select_input?(field)
+    field['class'].to_s.include?('select2') || field['class'].to_s.include?('effective_select')
+  end
+
   def skip_form_field?(field)
     field.reload # Handle a field changing visibility/disabled state from previous form field manipulations
 

data/test/support/effective_test_bot_form_helper.rb

@@ -4,7 +4,7 @@ module EffectiveTestBotFormHelper
   # Intelligently fills a form with Faker based randomish input
   # Delegates the form fill logic to effective_test_bot_form_filler
   def fill_form(fills = {})
-    bootstrap_tabs = all("a[data-toggle='tab']")
+    bootstrap_tabs = all("a[data-toggle='tab']", wait: false)
 
     form_fills = HashWithIndifferentAccess.new((EffectiveTestBot.form_fills || {}).merge(fills || {}))
 
@@ -69,16 +69,19 @@ module EffectiveTestBotFormHelper
   end
 
   def clear_form
-    all('input,select,textarea').each do |field|
-      if field.tag_name == 'select' && field['class'].to_s.include?('select2') # effective_select
+    all('input,select,textarea', wait: false).each do |field|
+      if effective_select_input?(field)
         clear_effective_select(field)
+      elsif effective_date_input?(field)
+        field.set('')
+        close_effective_date_time_picker(field)
+      elsif file_input?(field)
+        # Nothing
+      else
+        field.set('')
       end
 
-      begin
-        field.set('')
-        close_effective_date_time_picker(field) if field['class'].to_s.include?('effective_date')
-        save_test_bot_screenshot if EffectiveTestBot.tour_mode_extreme?
-      rescue => e; end
+      save_test_bot_screenshot if EffectiveTestBot.tour_mode_extreme?
     end
 
     true

data/test/support/effective_test_bot_minitest_helper.rb

@@ -7,20 +7,15 @@ module EffectiveTestBotMinitestHelper
   def before_teardown
     super
 
-    if EffectiveTestBot.gifs? && (@test_bot_screenshot_id || 0) > 0
-      if !passed? && EffectiveTestBot.autosave_animated_gif_on_failure?
-        save_test_bot_screenshot
-        save_test_bot_failure_gif
-      end
-
-      if passed? && EffectiveTestBot.tour_mode?
-        save_test_bot_tour_gif
-      end
+    if passed?
+      EffectiveTestBot.save_passed_test(current_test_name)
+      save_test_bot_tour_gif if EffectiveTestBot.tour_mode?
     end
 
-    if passed? && !EffectiveTestBot.passed_tests[current_test_name]
-      EffectiveTestBot.save_passed_test(current_test_name)
+    if !passed?
+      save_test_bot_failure_gif if EffectiveTestBot.autosave_animated_gif_on_failure?
     end
+
   end
 
   protected

data/test/support/effective_test_bot_screenshots_helper.rb

@@ -9,13 +9,17 @@ module EffectiveTestBotScreenshotsHelper
   def save_test_bot_screenshot
     return unless EffectiveTestBot.screenshots?
     return unless page.current_path.present?
+    
     page.save_screenshot("#{current_test_temp_path}/#{current_test_screenshot_id}.png")
+    true
   end
 
   def save_test_bot_failure_gif
     return unless EffectiveTestBot.screenshots?
     return unless EffectiveTestBot.gifs?
 
+    return unless save_test_bot_screenshot
+
     Dir.mkdir(current_test_failure_path) unless File.exist?(current_test_failure_path)
     full_path = (current_test_failure_path + '/' + current_test_failure_filename)
 
@@ -26,12 +30,13 @@ module EffectiveTestBotScreenshotsHelper
   def save_test_bot_tour_gif
     return unless EffectiveTestBot.screenshots?
     return unless EffectiveTestBot.gifs?
+    return unless (@test_bot_screenshot_id || 0) > 0
 
     Dir.mkdir(current_test_tour_path) unless File.exist?(current_test_tour_path)
     full_path = (current_test_tour_path + '/' + current_test_tour_filename)
 
     save_test_bot_gif(full_path)
-    puts_green("    Tour .gif: #{full_path}") if EffectiveTestBot.tour_mode_verbose?
+    puts_green("    Tour .gif: #{full_path}")
   end
 
   def without_screenshots(&block)

data/test/support/effective_test_bot_test_helper.rb

@@ -102,4 +102,12 @@ module EffectiveTestBotTestHelper
     }
   end
 
+  def tsputs(message)
+    @last_message ||= Time.zone.now
+    now = Time.zone.now
+
+    puts "[+ #{now - @last_message}] #{message}"
+    @last_message = now
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: effective_test_bot
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.1.3
 platform: ruby
 authors:
 - Code and Effect
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-11 00:00:00.000000000 Z
+date: 2019-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails